Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/2216798/?format=api
{ "id": 2216798, "url": "http://patchwork.ozlabs.org/api/patches/2216798/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20260327072332.130320-2-aleksandr.loktionov@intel.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20260327072332.130320-2-aleksandr.loktionov@intel.com>", "list_archive_url": null, "date": "2026-03-27T07:23:25", "name": "[net] ice: fix locking around wait_event_interruptible_locked_irq", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "35ddb4d104cef083a0605de9f1ddc49f0a3428de", "submitter": { "id": 75597, "url": "http://patchwork.ozlabs.org/api/people/75597/?format=api", "name": "Loktionov, Aleksandr", "email": "aleksandr.loktionov@intel.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20260327072332.130320-2-aleksandr.loktionov@intel.com/mbox/", "series": [ { "id": 497707, "url": "http://patchwork.ozlabs.org/api/series/497707/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/list/?series=497707", "date": "2026-03-27T07:23:25", "name": "[net] ice: fix locking around wait_event_interruptible_locked_irq", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/497707/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2216798/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2216798/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@legolas.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=osuosl.org header.i=@osuosl.org header.a=rsa-sha256\n header.s=default header.b=95CtsAcd;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=osuosl.org\n (client-ip=2605:bc80:3010::138; helo=smtp1.osuosl.org;\n envelope-from=intel-wired-lan-bounces@osuosl.org;\n receiver=patchwork.ozlabs.org)" ], "Received": [ "from smtp1.osuosl.org (smtp1.osuosl.org [IPv6:2605:bc80:3010::138])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fhsZQ5TNcz1xy1\n\tfor <incoming@patchwork.ozlabs.org>; Fri, 27 Mar 2026 18:23:42 +1100 (AEDT)", "from localhost (localhost [127.0.0.1])\n\tby smtp1.osuosl.org (Postfix) with ESMTP id 6AC2983C30;\n\tFri, 27 Mar 2026 07:23:41 +0000 (UTC)", "from smtp1.osuosl.org ([127.0.0.1])\n by localhost (smtp1.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP\n id 9QYUW0jElpgK; Fri, 27 Mar 2026 07:23:40 +0000 (UTC)", "from lists1.osuosl.org (lists1.osuosl.org [140.211.166.142])\n\tby smtp1.osuosl.org (Postfix) with ESMTP id 953D983C29;\n\tFri, 27 Mar 2026 07:23:40 +0000 (UTC)", "from smtp4.osuosl.org (smtp4.osuosl.org [IPv6:2605:bc80:3010::137])\n by lists1.osuosl.org (Postfix) with ESMTP id C2D31249\n for <intel-wired-lan@lists.osuosl.org>; Fri, 27 Mar 2026 07:23:38 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n by smtp4.osuosl.org (Postfix) with ESMTP id A94D7415FA\n for <intel-wired-lan@lists.osuosl.org>; Fri, 27 Mar 2026 07:23:38 +0000 (UTC)", "from smtp4.osuosl.org ([127.0.0.1])\n by localhost (smtp4.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP\n id u6-YSZ6-2hIm for <intel-wired-lan@lists.osuosl.org>;\n Fri, 27 Mar 2026 07:23:37 +0000 (UTC)", "from mgamail.intel.com (mgamail.intel.com [192.198.163.14])\n by smtp4.osuosl.org (Postfix) with ESMTPS id 3DDF741574\n for <intel-wired-lan@lists.osuosl.org>; Fri, 27 Mar 2026 07:23:37 +0000 (UTC)", "from orviesa002.jf.intel.com ([10.64.159.142])\n by fmvoesa108.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 27 Mar 2026 00:23:37 -0700", "from amlin-019-225.igk.intel.com ([10.102.19.225])\n by orviesa002.jf.intel.com with ESMTP; 27 Mar 2026 00:23:35 -0700" ], "X-Virus-Scanned": [ "amavis at osuosl.org", "amavis at osuosl.org" ], "X-Comment": "SPF check N/A for local connections - client-ip=140.211.166.142;\n helo=lists1.osuosl.org; envelope-from=intel-wired-lan-bounces@osuosl.org;\n receiver=<UNKNOWN> ", "DKIM-Filter": [ "OpenDKIM Filter v2.11.0 smtp1.osuosl.org 953D983C29", "OpenDKIM Filter v2.11.0 smtp4.osuosl.org 3DDF741574" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=osuosl.org;\n\ts=default; t=1774596220;\n\tbh=dIDOqpXEPqmJGLQ19N/DQYPNtM7J8tYYvNPr/uNDIew=;\n\th=From:To:Cc:Date:In-Reply-To:References:Subject:List-Id:\n\t List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe:\n\t From;\n\tb=95CtsAcdqnwaxl1U23ra6map/dVErsH1cIGQZOHM6YsEhPoOXpNsq6S7j8q5PqePR\n\t K1JJccUlVyp+h9Vzx6PGXsYSiqvYutG2GBdVW/3Rl/o47y+xbTeaKRfptelJ09H2lD\n\t OjoKf2B6qwAv2jMFteiy3VzwjW6KtoGR0ND1Z1d1J7J5NGJUj4MQc0aFQV2aIsKjjp\n\t NtGUqPo9ZA+ONNcvryAK6lv+7XfP9jYONMvT3lYlzzdE2Q4sVUn9iAlJcOKPNCL8lK\n\t iaHDZ1Gnb4YA8SsNLJPseQQI4rjFkeis4E8YEFvu811wtBI8PY37U14lBpUWgvHqoc\n\t ZgnQX6meuOn+w==", "Received-SPF": "Pass (mailfrom) identity=mailfrom; client-ip=192.198.163.14;\n helo=mgamail.intel.com; envelope-from=aleksandr.loktionov@intel.com;\n receiver=<UNKNOWN>", "DMARC-Filter": "OpenDMARC Filter v1.4.2 smtp4.osuosl.org 3DDF741574", "X-CSE-ConnectionGUID": [ "NPTirQ/hTFqLmfhejqCT1w==", "cjU8uxqrTNeqQpG2ePj2qw==" ], "X-CSE-MsgGUID": [ "KL4axRYsRi+kRQ1KYGPrYw==", "GGk17MhwRLCO9K21fSn5aA==" ], "X-IronPort-AV": [ "E=McAfee;i=\"6800,10657,11741\"; a=\"75733965\"", "E=Sophos;i=\"6.23,143,1770624000\"; d=\"scan'208\";a=\"75733965\"", "E=Sophos;i=\"6.23,143,1770624000\"; d=\"scan'208\";a=\"255739086\"" ], "X-ExtLoop1": "1", "From": "Aleksandr Loktionov <aleksandr.loktionov@intel.com>", "To": "intel-wired-lan@lists.osuosl.org, anthony.l.nguyen@intel.com,\n aleksandr.loktionov@intel.com", "Cc": "netdev@vger.kernel.org, Jacob Keller <jacob.e.keller@intel.com>,\n Jakub Kicinski <kuba@kernel.org>", "Date": "Fri, 27 Mar 2026 08:23:25 +0100", "Message-ID": "<20260327072332.130320-2-aleksandr.loktionov@intel.com>", "X-Mailer": "git-send-email 2.52.0", "In-Reply-To": "<20260327072332.130320-1-aleksandr.loktionov@intel.com>", "References": "<20260327072332.130320-1-aleksandr.loktionov@intel.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-Mailman-Original-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple;\n d=intel.com; i=@intel.com; q=dns/txt; s=Intel;\n t=1774596217; x=1806132217;\n h=from:to:cc:subject:date:message-id:in-reply-to:\n references:mime-version:content-transfer-encoding;\n bh=+FmYWfOtYLDqvPwMlsKA5+9rkYFC7p/MdLIOyUR/QUs=;\n b=ACVp49yAy6Lyg5Aa556Oen6NoakcU0hVSTgHztvdesebc8138E/eOkGM\n awiLZqkcCvbJ45BFjgZUAoF69mmR10BGF91bRYBsWKpq1ocB8x79zS++O\n 8y6qOcoCWALjpcdy7UtI863E1+3a5nLeHXkkT5UlVP1NtbGqVbieUfoZH\n wej0YcXBmx40qbsEidBYCFNcGHKKnFjWB9jvgLMmihQ7amAONB85oplFo\n cCRDLRuuXoG/2+iJz7FABHkWlYHabgmvZk8TBrn0jQ/yxKlNzsCyB+21b\n INmfFnYsufWIxmFXCfOvdTMsqEJhPgJs+1c2olTmZlAKVci5A6M7NwxPX\n g==;", "X-Mailman-Original-Authentication-Results": [ "smtp4.osuosl.org;\n dmarc=pass (p=none dis=none)\n header.from=intel.com", "smtp4.osuosl.org;\n dkim=pass (2048-bit key,\n unprotected) header.d=intel.com header.i=@intel.com header.a=rsa-sha256\n header.s=Intel header.b=ACVp49yA" ], "Subject": "[Intel-wired-lan] [PATCH net] ice: fix locking around\n wait_event_interruptible_locked_irq", "X-BeenThere": "intel-wired-lan@osuosl.org", "X-Mailman-Version": "2.1.30", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n <intel-wired-lan.osuosl.org>", "List-Unsubscribe": "<https://lists.osuosl.org/mailman/options/intel-wired-lan>,\n <mailto:intel-wired-lan-request@osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@osuosl.org?subject=help>", "List-Subscribe": "<https://lists.osuosl.org/mailman/listinfo/intel-wired-lan>,\n <mailto:intel-wired-lan-request@osuosl.org?subject=subscribe>", "Errors-To": "intel-wired-lan-bounces@osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@osuosl.org>" }, "content": "From: Jacob Keller <jacob.e.keller@intel.com>\n\nCommit 50327223a8bb (\"ice: add lock to protect low latency interface\")\nintroduced a wait queue used to protect the low latency timer interface.\nThe queue is used with the wait_event_interruptible_locked_irq macro, which\nunlocks the wait queue lock while sleeping. The irq variant uses\nspin_lock_irq and spin_unlock_irq to manage this. The wait queue lock was\npreviously locked using spin_lock_irqsave. This difference in lock variants\ncould lead to issues, since wait_event would unlock the wait queue and\nrestore interrupts while sleeping.\n\nThe ice_read_phy_tstamp_ll_e810() function is ultimately called through\nice_read_phy_tstamp, which is called from ice_ptp_process_tx_tstamp or\nice_ptp_clear_unexpected_tx_ready. The former is called through the\nmiscellaneous IRQ thread function, while the latter is called from the\nservice task work queue thread. Neither of these functions has interrupts\ndisabled, so use spin_lock_irq instead of spin_lock_irqsave.\n\nFixes: 50327223a8bb (\"ice: add lock to protect low latency interface\")\nCc: stable@vger.kernel.org\nReported-by: Jakub Kicinski <kuba@kernel.org>\nCloses: https://lore.kernel.org/netdev/20250109181823.77f44c69@kernel.org/\nSigned-off-by: Jacob Keller <jacob.e.keller@intel.com>\nSigned-off-by: Aleksandr Loktionov <aleksandr.loktionov@intel.com>\n---\n\n drivers/net/ethernet/intel/ice/ice_ptp_hw.c | 9 ++++-----\n 1 file changed, 4 insertions(+), 5 deletions(-)", "diff": "diff --git a/drivers/net/ethernet/intel/ice/ice_ptp_hw.c b/drivers/net/ethernet/intel/ice/ice_ptp_hw.c\nindex 61c0a0d..1f73d72 100644\n--- a/drivers/net/ethernet/intel/ice/ice_ptp_hw.c\n+++ b/drivers/net/ethernet/intel/ice/ice_ptp_hw.c\n@@ -4323,18 +4323,17 @@ static int\n ice_read_phy_tstamp_ll_e810(struct ice_hw *hw, u8 idx, u8 *hi, u32 *lo)\n {\n \tstruct ice_e810_params *params = &hw->ptp.phy.e810;\n-\tunsigned long flags;\n \tu32 val;\n \tint err;\n \n-\tspin_lock_irqsave(¶ms->atqbal_wq.lock, flags);\n+\tspin_lock_irq(¶ms->atqbal_wq.lock);\n \n \t/* Wait for any pending in-progress low latency interrupt */\n \terr = wait_event_interruptible_locked_irq(params->atqbal_wq,\n \t\t\t\t\t\t !(params->atqbal_flags &\n \t\t\t\t\t\t ATQBAL_FLAGS_INTR_IN_PROGRESS));\n \tif (err) {\n-\t\tspin_unlock_irqrestore(¶ms->atqbal_wq.lock, flags);\n+\t\tspin_unlock_irq(¶ms->atqbal_wq.lock);\n \t\treturn err;\n \t}\n \n@@ -4349,7 +4348,7 @@ ice_read_phy_tstamp_ll_e810(struct ice_hw *hw, u8 idx, u8 *hi, u32 *lo)\n \t\t\t\t REG_LL_PROXY_H);\n \tif (err) {\n \t\tice_debug(hw, ICE_DBG_PTP, \"Failed to read PTP timestamp using low latency read\\n\");\n-\t\tspin_unlock_irqrestore(¶ms->atqbal_wq.lock, flags);\n+\t\tspin_unlock_irq(¶ms->atqbal_wq.lock);\n \t\treturn err;\n \t}\n \n@@ -4359,7 +4358,7 @@ ice_read_phy_tstamp_ll_e810(struct ice_hw *hw, u8 idx, u8 *hi, u32 *lo)\n \t/* Read the low 32 bit value and set the TS valid bit */\n \t*lo = rd32(hw, REG_LL_PROXY_L) | TS_VALID;\n \n-\tspin_unlock_irqrestore(¶ms->atqbal_wq.lock, flags);\n+\tspin_unlock_irq(¶ms->atqbal_wq.lock);\n \n \treturn 0;\n }\n", "prefixes": [ "net" ] }