Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/2216797/?format=api
{ "id": 2216797, "url": "http://patchwork.ozlabs.org/api/patches/2216797/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20260327072332.130320-1-aleksandr.loktionov@intel.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20260327072332.130320-1-aleksandr.loktionov@intel.com>", "list_archive_url": null, "date": "2026-03-27T07:23:24", "name": "[net] ice: fix null-ptr dereference on false-positive tx timeout", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "98df8c87da8eac2300d3bd602f11a467798873c5", "submitter": { "id": 75597, "url": "http://patchwork.ozlabs.org/api/people/75597/?format=api", "name": "Loktionov, Aleksandr", "email": "aleksandr.loktionov@intel.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20260327072332.130320-1-aleksandr.loktionov@intel.com/mbox/", "series": [ { "id": 497706, "url": "http://patchwork.ozlabs.org/api/series/497706/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/list/?series=497706", "date": "2026-03-27T07:23:24", "name": "[net] ice: fix null-ptr dereference on false-positive tx timeout", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/497706/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2216797/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2216797/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@legolas.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=osuosl.org header.i=@osuosl.org header.a=rsa-sha256\n header.s=default header.b=95whfT1F;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=osuosl.org\n (client-ip=2605:bc80:3010::138; helo=smtp1.osuosl.org;\n envelope-from=intel-wired-lan-bounces@osuosl.org;\n receiver=patchwork.ozlabs.org)" ], "Received": [ "from smtp1.osuosl.org (smtp1.osuosl.org [IPv6:2605:bc80:3010::138])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fhsZN1Bctz1xy1\n\tfor <incoming@patchwork.ozlabs.org>; Fri, 27 Mar 2026 18:23:40 +1100 (AEDT)", "from localhost (localhost [127.0.0.1])\n\tby smtp1.osuosl.org (Postfix) with ESMTP id CB38183C23;\n\tFri, 27 Mar 2026 07:23:38 +0000 (UTC)", "from smtp1.osuosl.org ([127.0.0.1])\n by localhost (smtp1.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP\n id GOu-Ui3NZEnu; Fri, 27 Mar 2026 07:23:38 +0000 (UTC)", "from lists1.osuosl.org (lists1.osuosl.org [140.211.166.142])\n\tby smtp1.osuosl.org (Postfix) with ESMTP id 054AF827A0;\n\tFri, 27 Mar 2026 07:23:38 +0000 (UTC)", "from smtp4.osuosl.org (smtp4.osuosl.org [IPv6:2605:bc80:3010::137])\n by lists1.osuosl.org (Postfix) with ESMTP id 925EA249\n for <intel-wired-lan@lists.osuosl.org>; Fri, 27 Mar 2026 07:23:36 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n by smtp4.osuosl.org (Postfix) with ESMTP id 842FD415FA\n for <intel-wired-lan@lists.osuosl.org>; Fri, 27 Mar 2026 07:23:36 +0000 (UTC)", "from smtp4.osuosl.org ([127.0.0.1])\n by localhost (smtp4.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP\n id yXxG757MI_CG for <intel-wired-lan@lists.osuosl.org>;\n Fri, 27 Mar 2026 07:23:36 +0000 (UTC)", "from mgamail.intel.com (mgamail.intel.com [192.198.163.14])\n by smtp4.osuosl.org (Postfix) with ESMTPS id E540B41574\n for <intel-wired-lan@lists.osuosl.org>; Fri, 27 Mar 2026 07:23:35 +0000 (UTC)", "from orviesa002.jf.intel.com ([10.64.159.142])\n by fmvoesa108.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 27 Mar 2026 00:23:35 -0700", "from amlin-019-225.igk.intel.com ([10.102.19.225])\n by orviesa002.jf.intel.com with ESMTP; 27 Mar 2026 00:23:34 -0700" ], "X-Virus-Scanned": [ "amavis at osuosl.org", "amavis at osuosl.org" ], "X-Comment": "SPF check N/A for local connections - client-ip=140.211.166.142;\n helo=lists1.osuosl.org; envelope-from=intel-wired-lan-bounces@osuosl.org;\n receiver=<UNKNOWN> ", "DKIM-Filter": [ "OpenDKIM Filter v2.11.0 smtp1.osuosl.org 054AF827A0", "OpenDKIM Filter v2.11.0 smtp4.osuosl.org E540B41574" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=osuosl.org;\n\ts=default; t=1774596218;\n\tbh=7P8hGlecmQr20nAtPit5lbQW4/g9MdVvcqPsoku4ZYI=;\n\th=From:To:Cc:Date:Subject:List-Id:List-Unsubscribe:List-Archive:\n\t List-Post:List-Help:List-Subscribe:From;\n\tb=95whfT1F7pVZMHTz1gkXQdzANWa2l8rRIDJbO7wCPNq9lWoqHbmbA4Pi6M4upzRjc\n\t /VuqhrJhxU8b0xi3o3ecQC2M+7O4iCV0gN8tN36u7DOXPlnjjevVOhwQ1DvZZeLbTN\n\t lIH9681BQSKRI3eDuxUKEDWJjMoW97H0HOGiWAbuU2WCNjyWBxtuXLSYBxGufuxv8s\n\t hGtZ+EQF1KTZJyfrHYAgvkyZHtAVP9U5E3eUu1LXBzt3ab4mgimPfhk9fsoql50Lx1\n\t DQeMDf8p8g9G8w/OrxoLTROhkj7QGrmVTe3faIhs5VyIrpcHK33xaT3ppHHAY1RRzT\n\t wgfVmIv27xCpw==", "Received-SPF": "Pass (mailfrom) identity=mailfrom; client-ip=192.198.163.14;\n helo=mgamail.intel.com; envelope-from=aleksandr.loktionov@intel.com;\n receiver=<UNKNOWN>", "DMARC-Filter": "OpenDMARC Filter v1.4.2 smtp4.osuosl.org E540B41574", "X-CSE-ConnectionGUID": [ "b9osulzsRG6od6ceqqzUjA==", "XY/SgQUmTIyPDG7gpUf/Xw==" ], "X-CSE-MsgGUID": [ "WFfKnDeqSZyhjnXGRoDTkQ==", "Ll3cd2eDSzuEUk/PQinWSg==" ], "X-IronPort-AV": [ "E=McAfee;i=\"6800,10657,11741\"; a=\"75733963\"", "E=Sophos;i=\"6.23,143,1770624000\"; d=\"scan'208\";a=\"75733963\"", "E=Sophos;i=\"6.23,143,1770624000\"; d=\"scan'208\";a=\"255739078\"" ], "X-ExtLoop1": "1", "From": "Aleksandr Loktionov <aleksandr.loktionov@intel.com>", "To": "intel-wired-lan@lists.osuosl.org, anthony.l.nguyen@intel.com,\n aleksandr.loktionov@intel.com", "Cc": "netdev@vger.kernel.org", "Date": "Fri, 27 Mar 2026 08:23:24 +0100", "Message-ID": "<20260327072332.130320-1-aleksandr.loktionov@intel.com>", "X-Mailer": "git-send-email 2.52.0", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-Mailman-Original-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple;\n d=intel.com; i=@intel.com; q=dns/txt; s=Intel;\n t=1774596216; x=1806132216;\n h=from:to:cc:subject:date:message-id:mime-version:\n content-transfer-encoding;\n bh=r+G9qCQlC2UPALPlilVAYlqAgt+L21Z8ORPZYuoYQ5Y=;\n b=d2HzcHjB3vw74nH48CpfsD4PVAtlY0OzC3DO86o237gdbbs/QiETsxf7\n v4bPP0Yxv15ncWI1pXIl7EGsLqzfpPDP55+kSHTEJhJQ3GmepgBebOvtE\n FA5SvHJWra+wuI6DjXwwNgOc4gJYnoP7PmlyojK1yc5iyqvPiR4GBIWoO\n NrEjNbs8QXScfMEwAttFqHK6vF4SWdj/EcoZ5QIzIexSYJjYNXDZCXKSJ\n qT0nwed8UegIWt1H9a7leF7evTc5a9w4gGjuI/3jjzjaqbWlFxu8qv+BY\n 5oACE/B7D5ptSr2L1MHMpTUkHHbQsXO8ycCoYFZlcoohGhH/57GINTvrF\n g==;", "X-Mailman-Original-Authentication-Results": [ "smtp4.osuosl.org;\n dmarc=pass (p=none dis=none)\n header.from=intel.com", "smtp4.osuosl.org;\n dkim=pass (2048-bit key,\n unprotected) header.d=intel.com header.i=@intel.com header.a=rsa-sha256\n header.s=Intel header.b=d2HzcHjB" ], "Subject": "[Intel-wired-lan] [PATCH net] ice: fix null-ptr dereference on\n false-positive tx timeout", "X-BeenThere": "intel-wired-lan@osuosl.org", "X-Mailman-Version": "2.1.30", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n <intel-wired-lan.osuosl.org>", "List-Unsubscribe": "<https://lists.osuosl.org/mailman/options/intel-wired-lan>,\n <mailto:intel-wired-lan-request@osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@osuosl.org?subject=help>", "List-Subscribe": "<https://lists.osuosl.org/mailman/listinfo/intel-wired-lan>,\n <mailto:intel-wired-lan-request@osuosl.org?subject=subscribe>", "Errors-To": "intel-wired-lan-bounces@osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@osuosl.org>" }, "content": "From: Michal Kubiak <michal.kubiak@intel.com>\n\nDue to some kernel bugs the Tx timeout event may be false-positive.\nFor example, the kernel commit 95ecba62e2fd (\"net: fix races in\nnetdev_tx_sent_queue()/dev_watchdog()\") fixes race conditions that can\nalso occur during the ice driver initialization.\n\nIn case of such false-positive Tx timeouts there can be no real Tx\ntransaction started, so the SKB pointer can be NULL. Therefore, the call\ndevlink_fmsg_dump_skb() can crash because of NULL-ptr dereference.\n\nFix that by checking the SKB pointer before dereferencing it.\n\nFixes: 2a82874a3b7b (\"ice: add Tx hang devlink health reporter\")\nCc: stable@vger.kernel.org\nSigned-off-by: Michal Kubiak <michal.kubiak@intel.com>\nSigned-off-by: Aleksandr Loktionov <aleksandr.loktionov@intel.com>\n---\n\n drivers/net/ethernet/intel/ice/devlink/health.c | 3 ++-\n 1 file changed, 2 insertions(+), 1 deletion(-)", "diff": "diff --git a/drivers/net/ethernet/intel/ice/devlink/health.c b/drivers/net/ethernet/intel/ice/devlink/health.c\nindex 8e9a8a8..4275329 100644\n--- a/drivers/net/ethernet/intel/ice/devlink/health.c\n+++ b/drivers/net/ethernet/intel/ice/devlink/health.c\n@@ -409,7 +409,8 @@ static int ice_tx_hang_reporter_dump(struct devlink_health_reporter *reporter,\n \tice_fmsg_put_ptr(fmsg, \"skb-ptr\", skb);\n \tdevlink_fmsg_binary_pair_put(fmsg, \"desc\", event->tx_ring->desc,\n \t\t\t\t event->tx_ring->count * sizeof(struct ice_tx_desc));\n-\tdevlink_fmsg_dump_skb(fmsg, skb);\n+\tif (skb)\n+\t\tdevlink_fmsg_dump_skb(fmsg, skb);\n \tdevlink_fmsg_obj_nest_end(fmsg);\n \n \treturn 0;\n", "prefixes": [ "net" ] }