Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/2216773/?format=api
{ "id": 2216773, "url": "http://patchwork.ozlabs.org/api/patches/2216773/?format=api", "web_url": "http://patchwork.ozlabs.org/project/sparclinux/patch/20260327061704.3707577-26-hch@lst.de/", "project": { "id": 10, "url": "http://patchwork.ozlabs.org/api/projects/10/?format=api", "name": "Linux SPARC Development ", "link_name": "sparclinux", "list_id": "sparclinux.vger.kernel.org", "list_email": "sparclinux@vger.kernel.org", "web_url": null, "scm_url": null, "webscm_url": null, "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20260327061704.3707577-26-hch@lst.de>", "list_archive_url": null, "date": "2026-03-27T06:16:57", "name": "[25/28] btrfs: use xor_gen", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "6a7da7015bb771c23127835ad729afb109f5fdbc", "submitter": { "id": 82, "url": "http://patchwork.ozlabs.org/api/people/82/?format=api", "name": "Christoph Hellwig", "email": "hch@lst.de" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/sparclinux/patch/20260327061704.3707577-26-hch@lst.de/mbox/", "series": [ { "id": 497694, "url": "http://patchwork.ozlabs.org/api/series/497694/?format=api", "web_url": "http://patchwork.ozlabs.org/project/sparclinux/list/?series=497694", "date": "2026-03-27T06:16:33", "name": "[01/28] xor: assert that xor_blocks is not call from interrupt context", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/497694/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2216773/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2216773/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "\n <SRS0=LhXE=B3=vger.kernel.org=sparclinux+bounces-6600-patchwork-incoming=ozlabs.org@ozlabs.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "sparclinux@vger.kernel.org" ], "Delivered-To": [ "patchwork-incoming@legolas.ozlabs.org", "patchwork-incoming@ozlabs.org" ], "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n secure) header.d=infradead.org header.i=@infradead.org header.a=rsa-sha256\n header.s=bombadil.20210309 header.b=dDerKLQ1;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=ozlabs.org\n (client-ip=150.107.74.76; helo=mail.ozlabs.org;\n envelope-from=srs0=lhxe=b3=vger.kernel.org=sparclinux+bounces-6600-patchwork-incoming=ozlabs.org@ozlabs.org;\n receiver=patchwork.ozlabs.org)", "gandalf.ozlabs.org;\n arc=pass smtp.remote-ip=\"2600:3c04:e001:36c::12fc:5321\"\n arc.chain=subspace.kernel.org", "gandalf.ozlabs.org;\n dmarc=fail (p=none dis=none) header.from=lst.de", "gandalf.ozlabs.org;\n\tdkim=pass (2048-bit key;\n secure) header.d=infradead.org header.i=@infradead.org header.a=rsa-sha256\n header.s=bombadil.20210309 header.b=dDerKLQ1;\n\tdkim-atps=neutral", "gandalf.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=2600:3c04:e001:36c::12fc:5321; helo=tor.lore.kernel.org;\n envelope-from=sparclinux+bounces-6600-patchwork-incoming=ozlabs.org@vger.kernel.org;\n receiver=ozlabs.org)", "smtp.subspace.kernel.org;\n\tdkim=pass (2048-bit key) header.d=infradead.org header.i=@infradead.org\n header.b=\"dDerKLQ1\"", "smtp.subspace.kernel.org;\n arc=none smtp.client-ip=198.137.202.133", "smtp.subspace.kernel.org;\n dmarc=fail (p=none dis=none) header.from=lst.de", "smtp.subspace.kernel.org;\n spf=none smtp.mailfrom=bombadil.srs.infradead.org" ], "Received": [ "from mail.ozlabs.org (gandalf.ozlabs.org [150.107.74.76])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fhrgn6Ppxz1y1x\n\tfor <incoming@patchwork.ozlabs.org>; Fri, 27 Mar 2026 17:43:17 +1100 (AEDT)", "from mail.ozlabs.org (mail.ozlabs.org [IPv6:2404:9400:2221:ea00::3])\n\tby gandalf.ozlabs.org (Postfix) with ESMTP id 4fhrgn5KXhz4wSW\n\tfor <incoming@patchwork.ozlabs.org>; Fri, 27 Mar 2026 17:43:17 +1100 (AEDT)", "by gandalf.ozlabs.org (Postfix)\n\tid 4fhrgn5Fnjz4wCX; Fri, 27 Mar 2026 17:43:17 +1100 (AEDT)", "from tor.lore.kernel.org (tor.lore.kernel.org\n [IPv6:2600:3c04:e001:36c::12fc:5321])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby gandalf.ozlabs.org (Postfix) with ESMTPS id 4fhrgk1BQHz4wSW\n\tfor <patchwork-incoming@ozlabs.org>; Fri, 27 Mar 2026 17:43:14 +1100 (AEDT)", "from smtp.subspace.kernel.org (conduit.subspace.kernel.org\n [100.90.174.1])\n\tby tor.lore.kernel.org (Postfix) with ESMTP id D229F31DEFA2\n\tfor <patchwork-incoming@ozlabs.org>; Fri, 27 Mar 2026 06:28:30 +0000 (UTC)", "from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id 56E6639021F;\n\tFri, 27 Mar 2026 06:23:19 +0000 (UTC)", "from bombadil.infradead.org (bombadil.infradead.org\n [198.137.202.133])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby smtp.subspace.kernel.org (Postfix) with ESMTPS id 097F737A4B9;\n\tFri, 27 Mar 2026 06:23:18 +0000 (UTC)", "from\n 2a02-8389-2341-5b80-d601-7564-c2e0-491c.cable.dynamic.v6.surfer.at\n ([2a02:8389:2341:5b80:d601:7564:c2e0:491c] helo=localhost)\n\tby bombadil.infradead.org with esmtpsa (Exim 4.98.2 #2 (Red Hat Linux))\n\tid 1w60b3-00000006nwZ-2BNW;\n\tFri, 27 Mar 2026 06:23:05 +0000" ], "ARC-Seal": [ "i=2; a=rsa-sha256; d=ozlabs.org; s=201707; t=1774593797; cv=pass;\n\tb=YxlZYZMPtsPpo9ZzHD2AaaD/RtvP+meIs8pp8gCEd+ZoFlRrghC8Ex34jBy8p6YmebpS+omxPFK4FacM886YyLhqPwV5asuITDhw6zBuMja16Roo7zTu5iFZBseeDVtss0ZdFQKSRuQ/Va+p8aNkq4yV0gMNIm5+nRwg95Rb5prNWQeikGr1Lgdlvq/F8/ORjSPCaKzhDeBYx+mQTl4IeuKmtPxiN+Ctg30xvrNtOLBaN7kAFjbUqeIDiwDnCxyT9GHyZQZtwCXmHVj/CXCsYztzSD7BXluJ+tUHzz/iQEiMykIh3IWGev7DCggpJryNfUXiQAEv4E/mDD93LXHqmw==", "i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;\n\tt=1774592599; cv=none;\n b=Cx/9Mevswe7pNxqHicnSW8GGNOq5OOVDh4KpzAQORKJqhTP32VYs0iVMgyv7zRGn/zS+R6nmzig9EznEa4/pMYxZPLp7NnurYK52F27WE9LITZH4S9Gb0nigSPxistdFd65z5O2/K2DkTfeXtb9NhegxoufBp3zH2IjwshUSNsA=" ], "ARC-Message-Signature": [ "i=2; a=rsa-sha256; d=ozlabs.org; s=201707;\n\tt=1774593797; c=relaxed/relaxed;\n\tbh=QjlTDO4991l2Jq5L4100pIA+eekfjivGwuTXYuHUt8k=;\n\th=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References:\n\t MIME-Version;\n b=QI5LLGoZmELzLwF04hhAtc54PDNi2+cx3/NPCbSjX1gsIKj1ghni8zuCG7Q/oYAcWPYOUz01O0rl++QMEDYlFReYpWWstU5inRrcF68/r2pUXVGnJ8ujrEwKHe4Au6LHCPwOOP/0EU2sUrIJ6JDP5PsSdynGWLLqm4SvA0Fb0jL7lQk0o9RqahyGSi7tABYU2fIpHWLqfJWU8n0gdmjkbxv3g0KxphIO5TnMYpez/NuvF76v6+qMC/zoRQNqyFw8myot+/oZXB80SIaeZ6FIhbOhk8rDaX25d7J13rnYi1WslR9U/IHSDF/DYiAM7szepb08LJA5j5jyPt187LyIzw==", "i=1; a=rsa-sha256; d=subspace.kernel.org;\n\ts=arc-20240116; t=1774592599; c=relaxed/simple;\n\tbh=MK+8Iw/tZlfeqjAYZN3DfhSu1o8d3eIERNgNH+wls0k=;\n\th=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References:\n\t MIME-Version;\n b=a/Rp6N4CKlMe+S722/KYDzHl11rV2Dvjne1mTQTChXp8/Y/Q3OHxwTKJxPr6QKqREIAOd1APW1hWi10cXH2XXTFZVYfl5JFi69+KRDt1yS/quh7GxVYPEN6J/X2MvdNW/oNrAKGTEUrqbydDAAoleH8blZJnbX6x7DB7o15cuAc=" ], "ARC-Authentication-Results": [ "i=2; gandalf.ozlabs.org;\n dmarc=fail (p=none dis=none) header.from=lst.de; dkim=pass (2048-bit key;\n secure) header.d=infradead.org header.i=@infradead.org header.a=rsa-sha256\n header.s=bombadil.20210309 header.b=dDerKLQ1; dkim-atps=neutral;\n spf=pass (client-ip=2600:3c04:e001:36c::12fc:5321; helo=tor.lore.kernel.org;\n envelope-from=sparclinux+bounces-6600-patchwork-incoming=ozlabs.org@vger.kernel.org;\n receiver=ozlabs.org) smtp.mailfrom=vger.kernel.org", "i=1; smtp.subspace.kernel.org;\n dmarc=fail (p=none dis=none) header.from=lst.de;\n spf=none smtp.mailfrom=bombadil.srs.infradead.org;\n dkim=pass (2048-bit key) header.d=infradead.org header.i=@infradead.org\n header.b=dDerKLQ1; arc=none smtp.client-ip=198.137.202.133" ], "DKIM-Signature": "v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;\n\td=infradead.org; s=bombadil.20210309; h=Content-Transfer-Encoding:\n\tMIME-Version:References:In-Reply-To:Message-ID:Date:Subject:Cc:To:From:Sender\n\t:Reply-To:Content-Type:Content-ID:Content-Description;\n\tbh=QjlTDO4991l2Jq5L4100pIA+eekfjivGwuTXYuHUt8k=; b=dDerKLQ1lHWrPC05m5ZiRRIe0B\n\tUOltIo5Hbc2kYmt6fRvkV+U+AADTU6g0g7IXxF9L6DULdct3/fhQQD0lIGtrW21UogaUnjUioeqnJ\n\t5cE8k8iVk81eX4t/a9lYZX7noCyDBiDOQ/64fDswRuFs6HHYCcMTMCxwiT08HrkL9SZYLlUTpq/y1\n\ts+/iCkl2BsZ2noSlTO0aI0UHgYfUTEmJAmLE2bXjm71irxYO8n5TsdbxikNMobiIMD0omzGq59pz1\n\tQWJ6x5mE+NL1sPaj/U7GtyoVlVqFUne3SZNWWQXFjl3q5RbDKT/aYEjoFZS7wzPDK2mye+zMzC9P5\n\twgwDMQdw==;", "From": "Christoph Hellwig <hch@lst.de>", "To": "Andrew Morton <akpm@linux-foundation.org>", "Cc": "Richard Henderson <richard.henderson@linaro.org>,\n\tMatt Turner <mattst88@gmail.com>,\n\tMagnus Lindholm <linmag7@gmail.com>,\n\tRussell King <linux@armlinux.org.uk>,\n\tCatalin Marinas <catalin.marinas@arm.com>,\n\tWill Deacon <will@kernel.org>,\n\tArd Biesheuvel <ardb@kernel.org>,\n\tHuacai Chen <chenhuacai@kernel.org>,\n\tWANG Xuerui <kernel@xen0n.name>,\n\tMadhavan Srinivasan <maddy@linux.ibm.com>,\n\tMichael Ellerman <mpe@ellerman.id.au>,\n\tNicholas Piggin <npiggin@gmail.com>,\n\t\"Christophe Leroy (CS GROUP)\" <chleroy@kernel.org>,\n\tPaul Walmsley <pjw@kernel.org>,\n\tPalmer Dabbelt <palmer@dabbelt.com>,\n\tAlbert Ou <aou@eecs.berkeley.edu>,\n\tAlexandre Ghiti <alex@ghiti.fr>,\n\tHeiko Carstens <hca@linux.ibm.com>,\n\tVasily Gorbik <gor@linux.ibm.com>,\n\tAlexander Gordeev <agordeev@linux.ibm.com>,\n\tChristian Borntraeger <borntraeger@linux.ibm.com>,\n\tSven Schnelle <svens@linux.ibm.com>,\n\t\"David S. Miller\" <davem@davemloft.net>,\n\tAndreas Larsson <andreas@gaisler.com>,\n\tRichard Weinberger <richard@nod.at>,\n\tAnton Ivanov <anton.ivanov@cambridgegreys.com>,\n\tJohannes Berg <johannes@sipsolutions.net>,\n\tThomas Gleixner <tglx@kernel.org>,\n\tIngo Molnar <mingo@redhat.com>,\n\tBorislav Petkov <bp@alien8.de>,\n\tDave Hansen <dave.hansen@linux.intel.com>,\n\tx86@kernel.org,\n\t\"H. Peter Anvin\" <hpa@zytor.com>,\n\tHerbert Xu <herbert@gondor.apana.org.au>,\n\tDan Williams <dan.j.williams@intel.com>,\n\tChris Mason <clm@fb.com>,\n\tDavid Sterba <dsterba@suse.com>,\n\tArnd Bergmann <arnd@arndb.de>,\n\tSong Liu <song@kernel.org>,\n\tYu Kuai <yukuai@fnnas.com>,\n\tLi Nan <linan122@huawei.com>,\n\t\"Theodore Ts'o\" <tytso@mit.edu>,\n\t\"Jason A. Donenfeld\" <Jason@zx2c4.com>,\n\tlinux-alpha@vger.kernel.org,\n\tlinux-kernel@vger.kernel.org,\n\tlinux-arm-kernel@lists.infradead.org,\n\tloongarch@lists.linux.dev,\n\tlinuxppc-dev@lists.ozlabs.org,\n\tlinux-riscv@lists.infradead.org,\n\tlinux-s390@vger.kernel.org,\n\tsparclinux@vger.kernel.org,\n\tlinux-um@lists.infradead.org,\n\tlinux-crypto@vger.kernel.org,\n\tlinux-btrfs@vger.kernel.org,\n\tlinux-arch@vger.kernel.org,\n\tlinux-raid@vger.kernel.org", "Subject": "[PATCH 25/28] btrfs: use xor_gen", "Date": "Fri, 27 Mar 2026 07:16:57 +0100", "Message-ID": "<20260327061704.3707577-26-hch@lst.de>", "X-Mailer": "git-send-email 2.47.3", "In-Reply-To": "<20260327061704.3707577-1-hch@lst.de>", "References": "<20260327061704.3707577-1-hch@lst.de>", "Precedence": "bulk", "X-Mailing-List": "sparclinux@vger.kernel.org", "List-Id": "<sparclinux.vger.kernel.org>", "List-Subscribe": "<mailto:sparclinux+subscribe@vger.kernel.org>", "List-Unsubscribe": "<mailto:sparclinux+unsubscribe@vger.kernel.org>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-SRS-Rewrite": "SMTP reverse-path rewritten from <hch@infradead.org> by\n bombadil.infradead.org. See http://www.infradead.org/rpr.html", "X-Spam-Status": "No, score=-0.2 required=5.0 tests=ARC_SIGNED,ARC_VALID,\n\tDKIM_SIGNED,DKIM_VALID,DMARC_NONE,HEADER_FROM_DIFFERENT_DOMAINS,\n\tMAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=disabled\n\tversion=4.0.1", "X-Spam-Checker-Version": "SpamAssassin 4.0.1 (2024-03-25) on gandalf.ozlabs.org" }, "content": "Use the new xor_gen helper instead of open coding the loop around\nxor_blocks. This helper is very similar to the existing run_xor helper\nin btrfs, except that the destination buffer is passed explicitly.\n\nSigned-off-by: Christoph Hellwig <hch@lst.de>\nAcked-by: David Sterba <dsterba@suse.com>\n---\n fs/btrfs/raid56.c | 27 ++++-----------------------\n 1 file changed, 4 insertions(+), 23 deletions(-)", "diff": "diff --git a/fs/btrfs/raid56.c b/fs/btrfs/raid56.c\nindex 02105d68accb..ad091c56ce77 100644\n--- a/fs/btrfs/raid56.c\n+++ b/fs/btrfs/raid56.c\n@@ -617,26 +617,6 @@ static void cache_rbio(struct btrfs_raid_bio *rbio)\n \tspin_unlock(&table->cache_lock);\n }\n \n-/*\n- * helper function to run the xor_blocks api. It is only\n- * able to do MAX_XOR_BLOCKS at a time, so we need to\n- * loop through.\n- */\n-static void run_xor(void **pages, int src_cnt, ssize_t len)\n-{\n-\tint src_off = 0;\n-\tint xor_src_cnt = 0;\n-\tvoid *dest = pages[src_cnt];\n-\n-\twhile(src_cnt > 0) {\n-\t\txor_src_cnt = min(src_cnt, MAX_XOR_BLOCKS);\n-\t\txor_blocks(xor_src_cnt, len, dest, pages + src_off);\n-\n-\t\tsrc_cnt -= xor_src_cnt;\n-\t\tsrc_off += xor_src_cnt;\n-\t}\n-}\n-\n /*\n * Returns true if the bio list inside this rbio covers an entire stripe (no\n * rmw required).\n@@ -1434,7 +1414,8 @@ static void generate_pq_vertical_step(struct btrfs_raid_bio *rbio, unsigned int\n \t} else {\n \t\t/* raid5 */\n \t\tmemcpy(pointers[rbio->nr_data], pointers[0], step);\n-\t\trun_xor(pointers + 1, rbio->nr_data - 1, step);\n+\t\txor_gen(pointers[rbio->nr_data], pointers + 1, rbio->nr_data - 1,\n+\t\t\t\tstep);\n \t}\n \tfor (stripe = stripe - 1; stripe >= 0; stripe--)\n \t\tkunmap_local(pointers[stripe]);\n@@ -2034,7 +2015,7 @@ static void recover_vertical_step(struct btrfs_raid_bio *rbio,\n \t\tpointers[rbio->nr_data - 1] = p;\n \n \t\t/* Xor in the rest */\n-\t\trun_xor(pointers, rbio->nr_data - 1, step);\n+\t\txor_gen(p, pointers, rbio->nr_data - 1, step);\n \t}\n \n cleanup:\n@@ -2672,7 +2653,7 @@ static bool verify_one_parity_step(struct btrfs_raid_bio *rbio,\n \t} else {\n \t\t/* RAID5. */\n \t\tmemcpy(pointers[nr_data], pointers[0], step);\n-\t\trun_xor(pointers + 1, nr_data - 1, step);\n+\t\txor_gen(pointers[nr_data], pointers + 1, nr_data - 1, step);\n \t}\n \n \t/* Check scrubbing parity and repair it. */\n", "prefixes": [ "25/28" ] }