Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/2216747/?format=api
{ "id": 2216747, "url": "http://patchwork.ozlabs.org/api/patches/2216747/?format=api", "web_url": "http://patchwork.ozlabs.org/project/linuxppc-dev/patch/20260327061704.3707577-28-hch@lst.de/", "project": { "id": 2, "url": "http://patchwork.ozlabs.org/api/projects/2/?format=api", "name": "Linux PPC development", "link_name": "linuxppc-dev", "list_id": "linuxppc-dev.lists.ozlabs.org", "list_email": "linuxppc-dev@lists.ozlabs.org", "web_url": "https://github.com/linuxppc/wiki/wiki", "scm_url": "https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git", "webscm_url": "https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git/", "list_archive_url": "https://lore.kernel.org/linuxppc-dev/", "list_archive_url_format": "https://lore.kernel.org/linuxppc-dev/{}/", "commit_url_format": "https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git/commit/?id={}" }, "msgid": "<20260327061704.3707577-28-hch@lst.de>", "list_archive_url": "https://lore.kernel.org/linuxppc-dev/20260327061704.3707577-28-hch@lst.de/", "date": "2026-03-27T06:16:59", "name": "[27/28] xor: use static_call for xor_gen", "commit_ref": null, "pull_url": null, "state": "handled-elsewhere", "archived": false, "hash": "3f098b9d4365b82313d7403fe74aee451381d537", "submitter": { "id": 82, "url": "http://patchwork.ozlabs.org/api/people/82/?format=api", "name": "Christoph Hellwig", "email": "hch@lst.de" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/linuxppc-dev/patch/20260327061704.3707577-28-hch@lst.de/mbox/", "series": [ { "id": 497693, "url": "http://patchwork.ozlabs.org/api/series/497693/?format=api", "web_url": "http://patchwork.ozlabs.org/project/linuxppc-dev/list/?series=497693", "date": "2026-03-27T06:16:33", "name": "[01/28] xor: assert that xor_blocks is not call from interrupt context", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/497693/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2216747/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2216747/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "\n <linuxppc-dev+bounces-18897-incoming=patchwork.ozlabs.org@lists.ozlabs.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "linuxppc-dev@lists.ozlabs.org" ], "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n secure) header.d=infradead.org header.i=@infradead.org header.a=rsa-sha256\n header.s=bombadil.20210309 header.b=B79nu8vZ;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.ozlabs.org\n (client-ip=2404:9400:21b9:f100::1; helo=lists.ozlabs.org;\n envelope-from=linuxppc-dev+bounces-18897-incoming=patchwork.ozlabs.org@lists.ozlabs.org;\n receiver=patchwork.ozlabs.org)", "lists.ozlabs.org;\n arc=none smtp.remote-ip=\"2607:7c80:54:3::133\"", "lists.ozlabs.org;\n dmarc=fail (p=none dis=none) header.from=lst.de", "lists.ozlabs.org;\n\tdkim=pass (2048-bit key;\n secure) header.d=infradead.org header.i=@infradead.org header.a=rsa-sha256\n header.s=bombadil.20210309 header.b=B79nu8vZ;\n\tdkim-atps=neutral", "lists.ozlabs.org;\n spf=none (no SPF record) smtp.mailfrom=bombadil.srs.infradead.org\n (client-ip=2607:7c80:54:3::133; helo=bombadil.infradead.org;\n envelope-from=batv+7b1de7ca9b09bfe890a7+8251+infradead.org+hch@bombadil.srs.infradead.org;\n receiver=lists.ozlabs.org)" ], "Received": [ "from lists.ozlabs.org (lists.ozlabs.org\n [IPv6:2404:9400:21b9:f100::1])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fhrFF6HLMz1xy1\n\tfor <incoming@patchwork.ozlabs.org>; Fri, 27 Mar 2026 17:23:45 +1100 (AEDT)", "from boromir.ozlabs.org (localhost [127.0.0.1])\n\tby lists.ozlabs.org (Postfix) with ESMTP id 4fhrFF5HVRz3f1y;\n\tFri, 27 Mar 2026 17:23:45 +1100 (AEDT)", "from bombadil.infradead.org (bombadil.infradead.org\n [IPv6:2607:7c80:54:3::133])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n\t(No client certificate requested)\n\tby lists.ozlabs.org (Postfix) with ESMTPS id 4fhrFF109tz3f1t\n\tfor <linuxppc-dev@lists.ozlabs.org>; Fri, 27 Mar 2026 17:23:45 +1100 (AEDT)", "from\n 2a02-8389-2341-5b80-d601-7564-c2e0-491c.cable.dynamic.v6.surfer.at\n ([2a02:8389:2341:5b80:d601:7564:c2e0:491c] helo=localhost)\n\tby bombadil.infradead.org with esmtpsa (Exim 4.98.2 #2 (Red Hat Linux))\n\tid 1w60bS-00000006oEd-09fn;\n\tFri, 27 Mar 2026 06:23:30 +0000" ], "ARC-Seal": "i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707; t=1774592625;\n\tcv=none;\n b=YNS2zJcpUy2cjVgYDL1st8mmPVbMcqDX4prUlaJXiX00BidQd3cFEUhC+hZad4HcQN+7bgunle4tF7Z51nzIvGLWRxIRXWrhefHRqiGJ4qjNairp92wUDhOgD/MHu3PGAD+Y8GIMsF/pLF6qszW9x2QNG2dI78QkJHsF+K8R0etaxIxADcEu+6S82agNP08ID2T59jxPOUlkU16LrFhIgEhc+1qO4daqRSnudp8Z6+x4K3Uq+TmkCVef8P6L1QXSMOI9gyC8358rso7FiVF6ptkeLOuExIzgPB7gSG8i0QHXyS5Wyb1XygIcQ0Le8VNmJFDcR4cBdfv/23pePL1rQw==", "ARC-Message-Signature": "i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707;\n\tt=1774592625; c=relaxed/relaxed;\n\tbh=/eIr9wIIm6iGlYV1kRtLFx5UsBKOxZ4VNuwt7IPsmcE=;\n\th=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References:\n\t MIME-Version;\n b=g8O+rM+DC21LW8axVcymv8T6HQWPSO27TATiKJu2i+b+2NLJDY74X08MkRKkANQaL34E2RSmPB+nilUbNOwxWszBlhANubj5O6CsMvhhzjjnlNzgMbpWgJ4QpT1NNM7pnpoNUNvkIKsSjy/ZYQdoPgJPxJleTIzcxX9Dv6KK8J/ATITT6aY5NvUbcX27m0e8F+o6vajoJk0Sx069mvwSTAYQnqw08G0TxbBowGDmsdwo/INCca+e94fvdFue359JBPQz818TeWTEPDTTHoxsGP0n13su2rG4gqEV2aLDBzrXPEur1Tta5aDkkK/1G/uVvt6Knb/uBR/xHqtI52xHDQ==", "ARC-Authentication-Results": "i=1; lists.ozlabs.org;\n dmarc=fail (p=none dis=none) header.from=lst.de; dkim=pass (2048-bit key;\n secure) header.d=infradead.org header.i=@infradead.org header.a=rsa-sha256\n header.s=bombadil.20210309 header.b=B79nu8vZ; dkim-atps=neutral;\n spf=none (client-ip=2607:7c80:54:3::133; helo=bombadil.infradead.org;\n envelope-from=batv+7b1de7ca9b09bfe890a7+8251+infradead.org+hch@bombadil.srs.infradead.org;\n receiver=lists.ozlabs.org) smtp.mailfrom=bombadil.srs.infradead.org", "DKIM-Signature": "v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;\n\td=infradead.org; s=bombadil.20210309; h=Content-Transfer-Encoding:\n\tMIME-Version:References:In-Reply-To:Message-ID:Date:Subject:Cc:To:From:Sender\n\t:Reply-To:Content-Type:Content-ID:Content-Description;\n\tbh=/eIr9wIIm6iGlYV1kRtLFx5UsBKOxZ4VNuwt7IPsmcE=; b=B79nu8vZV/CSonC7sqH0z/OKAl\n\t/edR6ukNRR9e2OXsqxy0hAnd5awCq7NvJwVK47ZKrEiivroyi32XYu/5O7DE3UVV+WHCNSS21upsn\n\tEIXvxSssYk7zka1I4NceFAoBnl09Knq/JdUYOBMvS5imNReaFZVqF+mv5nV5Ire0iaK4aU/FoGjBS\n\tgQSw3TnFArvcWd/YcTPub9h8vqlqP3T9T9lLgNPj6HzbaS4/yGeqaATp/M0uxw1Lj/MkY8Am7Xwcf\n\txRlX2Ud6W+b75r2z7YD9t8zysNMUf9FFMQRTNUgMpGapVKo9FFHAg0we3BXkJFwBw2HyU89gxIW3g\n\tn4l5zDjg==;", "From": "Christoph Hellwig <hch@lst.de>", "To": "Andrew Morton <akpm@linux-foundation.org>", "Cc": "Richard Henderson <richard.henderson@linaro.org>,\n\tMatt Turner <mattst88@gmail.com>,\n\tMagnus Lindholm <linmag7@gmail.com>,\n\tRussell King <linux@armlinux.org.uk>,\n\tCatalin Marinas <catalin.marinas@arm.com>,\n\tWill Deacon <will@kernel.org>,\n\tArd Biesheuvel <ardb@kernel.org>,\n\tHuacai Chen <chenhuacai@kernel.org>,\n\tWANG Xuerui <kernel@xen0n.name>,\n\tMadhavan Srinivasan <maddy@linux.ibm.com>,\n\tMichael Ellerman <mpe@ellerman.id.au>,\n\tNicholas Piggin <npiggin@gmail.com>,\n\t\"Christophe Leroy (CS GROUP)\" <chleroy@kernel.org>,\n\tPaul Walmsley <pjw@kernel.org>,\n\tPalmer Dabbelt <palmer@dabbelt.com>,\n\tAlbert Ou <aou@eecs.berkeley.edu>,\n\tAlexandre Ghiti <alex@ghiti.fr>,\n\tHeiko Carstens <hca@linux.ibm.com>,\n\tVasily Gorbik <gor@linux.ibm.com>,\n\tAlexander Gordeev <agordeev@linux.ibm.com>,\n\tChristian Borntraeger <borntraeger@linux.ibm.com>,\n\tSven Schnelle <svens@linux.ibm.com>,\n\t\"David S. Miller\" <davem@davemloft.net>,\n\tAndreas Larsson <andreas@gaisler.com>,\n\tRichard Weinberger <richard@nod.at>,\n\tAnton Ivanov <anton.ivanov@cambridgegreys.com>,\n\tJohannes Berg <johannes@sipsolutions.net>,\n\tThomas Gleixner <tglx@kernel.org>,\n\tIngo Molnar <mingo@redhat.com>,\n\tBorislav Petkov <bp@alien8.de>,\n\tDave Hansen <dave.hansen@linux.intel.com>,\n\tx86@kernel.org,\n\t\"H. Peter Anvin\" <hpa@zytor.com>,\n\tHerbert Xu <herbert@gondor.apana.org.au>,\n\tDan Williams <dan.j.williams@intel.com>,\n\tChris Mason <clm@fb.com>,\n\tDavid Sterba <dsterba@suse.com>,\n\tArnd Bergmann <arnd@arndb.de>,\n\tSong Liu <song@kernel.org>,\n\tYu Kuai <yukuai@fnnas.com>,\n\tLi Nan <linan122@huawei.com>,\n\t\"Theodore Ts'o\" <tytso@mit.edu>,\n\t\"Jason A. Donenfeld\" <Jason@zx2c4.com>,\n\tlinux-alpha@vger.kernel.org,\n\tlinux-kernel@vger.kernel.org,\n\tlinux-arm-kernel@lists.infradead.org,\n\tloongarch@lists.linux.dev,\n\tlinuxppc-dev@lists.ozlabs.org,\n\tlinux-riscv@lists.infradead.org,\n\tlinux-s390@vger.kernel.org,\n\tsparclinux@vger.kernel.org,\n\tlinux-um@lists.infradead.org,\n\tlinux-crypto@vger.kernel.org,\n\tlinux-btrfs@vger.kernel.org,\n\tlinux-arch@vger.kernel.org,\n\tlinux-raid@vger.kernel.org", "Subject": "[PATCH 27/28] xor: use static_call for xor_gen", "Date": "Fri, 27 Mar 2026 07:16:59 +0100", "Message-ID": "<20260327061704.3707577-28-hch@lst.de>", "X-Mailer": "git-send-email 2.47.3", "In-Reply-To": "<20260327061704.3707577-1-hch@lst.de>", "References": "<20260327061704.3707577-1-hch@lst.de>", "X-Mailing-List": "linuxppc-dev@lists.ozlabs.org", "List-Id": "<linuxppc-dev.lists.ozlabs.org>", "List-Help": "<mailto:linuxppc-dev+help@lists.ozlabs.org>", "List-Owner": "<mailto:linuxppc-dev+owner@lists.ozlabs.org>", "List-Post": "<mailto:linuxppc-dev@lists.ozlabs.org>", "List-Archive": "<https://lore.kernel.org/linuxppc-dev/>,\n <https://lists.ozlabs.org/pipermail/linuxppc-dev/>", "List-Subscribe": "<mailto:linuxppc-dev+subscribe@lists.ozlabs.org>,\n <mailto:linuxppc-dev+subscribe-digest@lists.ozlabs.org>,\n <mailto:linuxppc-dev+subscribe-nomail@lists.ozlabs.org>", "List-Unsubscribe": "<mailto:linuxppc-dev+unsubscribe@lists.ozlabs.org>", "Precedence": "list", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-SRS-Rewrite": "SMTP reverse-path rewritten from <hch@infradead.org> by\n bombadil.infradead.org. See http://www.infradead.org/rpr.html", "X-Spam-Status": "No, score=0.0 required=3.0 tests=DKIM_SIGNED,DKIM_VALID,\n\tHEADER_FROM_DIFFERENT_DOMAINS,SPF_HELO_NONE,SPF_NONE\n\tautolearn=disabled version=4.0.1 OzLabs 8", "X-Spam-Checker-Version": "SpamAssassin 4.0.1 (2024-03-25) on lists.ozlabs.org" }, "content": "Avoid the indirect call for xor_generation by using a static_call.\n\nSigned-off-by: Christoph Hellwig <hch@lst.de>\n---\n lib/raid/xor/xor-core.c | 22 +++++++++++-----------\n 1 file changed, 11 insertions(+), 11 deletions(-)", "diff": "diff --git a/lib/raid/xor/xor-core.c b/lib/raid/xor/xor-core.c\nindex 9e043d8c3a7a..bd4e6e434418 100644\n--- a/lib/raid/xor/xor-core.c\n+++ b/lib/raid/xor/xor-core.c\n@@ -11,10 +11,10 @@\n #include <linux/raid/xor.h>\n #include <linux/jiffies.h>\n #include <linux/preempt.h>\n+#include <linux/static_call.h>\n #include \"xor_impl.h\"\n \n-/* The xor routine to use. */\n-static struct xor_block_template *active_template;\n+DEFINE_STATIC_CALL_NULL(xor_gen_impl, *xor_block_8regs.xor_gen);\n \n /**\n * xor_gen - generate RAID-style XOR information\n@@ -37,13 +37,13 @@ void xor_gen(void *dest, void **srcs, unsigned int src_cnt, unsigned int bytes)\n \tWARN_ON_ONCE(bytes == 0);\n \tWARN_ON_ONCE(bytes & 511);\n \n-\tactive_template->xor_gen(dest, srcs, src_cnt, bytes);\n+\tstatic_call(xor_gen_impl)(dest, srcs, src_cnt, bytes);\n }\n EXPORT_SYMBOL(xor_gen);\n \n /* Set of all registered templates. */\n static struct xor_block_template *__initdata template_list;\n-static bool __initdata xor_forced = false;\n+static struct xor_block_template *forced_template;\n \n /**\n * xor_register - register a XOR template\n@@ -69,7 +69,7 @@ void __init xor_register(struct xor_block_template *tmpl)\n */\n void __init xor_force(struct xor_block_template *tmpl)\n {\n-\tactive_template = tmpl;\n+\tforced_template = tmpl;\n }\n \n #define BENCH_SIZE\t4096\n@@ -111,7 +111,7 @@ static int __init calibrate_xor_blocks(void)\n \tvoid *b1, *b2;\n \tstruct xor_block_template *f, *fastest;\n \n-\tif (xor_forced)\n+\tif (forced_template)\n \t\treturn 0;\n \n \tb1 = (void *) __get_free_pages(GFP_KERNEL, 2);\n@@ -128,7 +128,7 @@ static int __init calibrate_xor_blocks(void)\n \t\tif (f->speed > fastest->speed)\n \t\t\tfastest = f;\n \t}\n-\tactive_template = fastest;\n+\tstatic_call_update(xor_gen_impl, fastest->xor_gen);\n \tpr_info(\"xor: using function: %s (%d MB/sec)\\n\",\n \t fastest->name, fastest->speed);\n \n@@ -156,10 +156,10 @@ static int __init xor_init(void)\n \t * If this arch/cpu has a short-circuited selection, don't loop through\n \t * all the possible functions, just use the best one.\n \t */\n-\tif (active_template) {\n+\tif (forced_template) {\n \t\tpr_info(\"xor: automatically using best checksumming function %-10s\\n\",\n-\t\t\tactive_template->name);\n-\t\txor_forced = true;\n+\t\t\tforced_template->name);\n+\t\tstatic_call_update(xor_gen_impl, forced_template->xor_gen);\n \t\treturn 0;\n \t}\n \n@@ -170,7 +170,7 @@ static int __init xor_init(void)\n \t * Pick the first template as the temporary default until calibration\n \t * happens.\n \t */\n-\tactive_template = template_list;\n+\tstatic_call_update(xor_gen_impl, template_list->xor_gen);\n \treturn 0;\n #endif\n }\n", "prefixes": [ "27/28" ] }