Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/2216742/?format=api
{ "id": 2216742, "url": "http://patchwork.ozlabs.org/api/patches/2216742/?format=api", "web_url": "http://patchwork.ozlabs.org/project/linuxppc-dev/patch/20260327061704.3707577-26-hch@lst.de/", "project": { "id": 2, "url": "http://patchwork.ozlabs.org/api/projects/2/?format=api", "name": "Linux PPC development", "link_name": "linuxppc-dev", "list_id": "linuxppc-dev.lists.ozlabs.org", "list_email": "linuxppc-dev@lists.ozlabs.org", "web_url": "https://github.com/linuxppc/wiki/wiki", "scm_url": "https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git", "webscm_url": "https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git/", "list_archive_url": "https://lore.kernel.org/linuxppc-dev/", "list_archive_url_format": "https://lore.kernel.org/linuxppc-dev/{}/", "commit_url_format": "https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git/commit/?id={}" }, "msgid": "<20260327061704.3707577-26-hch@lst.de>", "list_archive_url": "https://lore.kernel.org/linuxppc-dev/20260327061704.3707577-26-hch@lst.de/", "date": "2026-03-27T06:16:57", "name": "[25/28] btrfs: use xor_gen", "commit_ref": null, "pull_url": null, "state": "handled-elsewhere", "archived": false, "hash": "6a7da7015bb771c23127835ad729afb109f5fdbc", "submitter": { "id": 82, "url": "http://patchwork.ozlabs.org/api/people/82/?format=api", "name": "Christoph Hellwig", "email": "hch@lst.de" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/linuxppc-dev/patch/20260327061704.3707577-26-hch@lst.de/mbox/", "series": [ { "id": 497693, "url": "http://patchwork.ozlabs.org/api/series/497693/?format=api", "web_url": "http://patchwork.ozlabs.org/project/linuxppc-dev/list/?series=497693", "date": "2026-03-27T06:16:33", "name": "[01/28] xor: assert that xor_blocks is not call from interrupt context", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/497693/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2216742/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2216742/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "\n <linuxppc-dev+bounces-18895-incoming=patchwork.ozlabs.org@lists.ozlabs.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "linuxppc-dev@lists.ozlabs.org" ], "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n secure) header.d=infradead.org header.i=@infradead.org header.a=rsa-sha256\n header.s=bombadil.20210309 header.b=dDerKLQ1;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.ozlabs.org\n (client-ip=2404:9400:21b9:f100::1; helo=lists.ozlabs.org;\n envelope-from=linuxppc-dev+bounces-18895-incoming=patchwork.ozlabs.org@lists.ozlabs.org;\n receiver=patchwork.ozlabs.org)", "lists.ozlabs.org;\n arc=none smtp.remote-ip=\"2607:7c80:54:3::133\"", "lists.ozlabs.org;\n dmarc=fail (p=none dis=none) header.from=lst.de", "lists.ozlabs.org;\n\tdkim=pass (2048-bit key;\n secure) header.d=infradead.org header.i=@infradead.org header.a=rsa-sha256\n header.s=bombadil.20210309 header.b=dDerKLQ1;\n\tdkim-atps=neutral", "lists.ozlabs.org;\n spf=none (no SPF record) smtp.mailfrom=bombadil.srs.infradead.org\n (client-ip=2607:7c80:54:3::133; helo=bombadil.infradead.org;\n envelope-from=batv+7b1de7ca9b09bfe890a7+8251+infradead.org+hch@bombadil.srs.infradead.org;\n receiver=lists.ozlabs.org)" ], "Received": [ "from lists.ozlabs.org (lists.ozlabs.org\n [IPv6:2404:9400:21b9:f100::1])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fhrDm3BKxz1xy1\n\tfor <incoming@patchwork.ozlabs.org>; Fri, 27 Mar 2026 17:23:20 +1100 (AEDT)", "from boromir.ozlabs.org (localhost [127.0.0.1])\n\tby lists.ozlabs.org (Postfix) with ESMTP id 4fhrDm28Bnz2xMY;\n\tFri, 27 Mar 2026 17:23:20 +1100 (AEDT)", "from bombadil.infradead.org (bombadil.infradead.org\n [IPv6:2607:7c80:54:3::133])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n\t(No client certificate requested)\n\tby lists.ozlabs.org (Postfix) with ESMTPS id 4fhrDl4dm6z3dy9\n\tfor <linuxppc-dev@lists.ozlabs.org>; Fri, 27 Mar 2026 17:23:19 +1100 (AEDT)", "from\n 2a02-8389-2341-5b80-d601-7564-c2e0-491c.cable.dynamic.v6.surfer.at\n ([2a02:8389:2341:5b80:d601:7564:c2e0:491c] helo=localhost)\n\tby bombadil.infradead.org with esmtpsa (Exim 4.98.2 #2 (Red Hat Linux))\n\tid 1w60b3-00000006nwZ-2BNW;\n\tFri, 27 Mar 2026 06:23:05 +0000" ], "ARC-Seal": "i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707; t=1774592600;\n\tcv=none;\n b=AJswUtxU1R5lAR6ioyvwrtMHsPuug2H5ypxiWpWFumqkfd6f5cnPVTb1s/M33WFfY1aq60vlg9+32Ki+lJ3coZKLv+v+fqCAVwDCvOM06Wdz0KOd+NTzw+qfzqXXbuUOyS0/Txo4tlcCOFg+0j9K7d96R9DAJnwjZkfN7Od8vOkrH7BGme+UXB5KGkw3EfXdYDcwS68VeR4DymBYNwQqD4YXPhnV4liSWbcYkj+7j5vNzOirzXcw9k2/ODFu5XQfeaq+Kq0NKihk0sVNoOye5wWP/yJLAuEhcRfbSjPzKi7NZwkASifqPMUdZ4WnyPEbCgXN5vIR7KDu24OTHfwaXw==", "ARC-Message-Signature": "i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707;\n\tt=1774592600; c=relaxed/relaxed;\n\tbh=QjlTDO4991l2Jq5L4100pIA+eekfjivGwuTXYuHUt8k=;\n\th=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References:\n\t MIME-Version;\n b=NasZmOlEtWchQkEVoF4NX2K4GrtOAOnRncCr5zxHWceHI9squ9Vai/lIYxQNgYDa4CV61eALkpIi3J4Ym158RMReaqIs0aPugWkrq+N3Mc7yB4rbZfHnbT80nLaYjRtWR/tzfVuCoNi4LQO+KHOgY1I39joN+22x7gBMB/qs/NBUQHSYa0Qn0que+P32ZTsEwgK8lXDa4soMuE5v7BL5aJjc1VbU7eArch0O4ib4fl2zFGA0o3pBmmg04Z+whl1mrnSQC5ZlQVq8Lb8cboluCHqgAFD6e62bKYtSIAfuQqr38ki/5MFPhKNPJZ+0c0nwyOv0PGddG9nKgdMiG5Zbcw==", "ARC-Authentication-Results": "i=1; lists.ozlabs.org;\n dmarc=fail (p=none dis=none) header.from=lst.de; dkim=pass (2048-bit key;\n secure) header.d=infradead.org header.i=@infradead.org header.a=rsa-sha256\n header.s=bombadil.20210309 header.b=dDerKLQ1; dkim-atps=neutral;\n spf=none (client-ip=2607:7c80:54:3::133; helo=bombadil.infradead.org;\n envelope-from=batv+7b1de7ca9b09bfe890a7+8251+infradead.org+hch@bombadil.srs.infradead.org;\n receiver=lists.ozlabs.org) smtp.mailfrom=bombadil.srs.infradead.org", "DKIM-Signature": "v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;\n\td=infradead.org; s=bombadil.20210309; h=Content-Transfer-Encoding:\n\tMIME-Version:References:In-Reply-To:Message-ID:Date:Subject:Cc:To:From:Sender\n\t:Reply-To:Content-Type:Content-ID:Content-Description;\n\tbh=QjlTDO4991l2Jq5L4100pIA+eekfjivGwuTXYuHUt8k=; b=dDerKLQ1lHWrPC05m5ZiRRIe0B\n\tUOltIo5Hbc2kYmt6fRvkV+U+AADTU6g0g7IXxF9L6DULdct3/fhQQD0lIGtrW21UogaUnjUioeqnJ\n\t5cE8k8iVk81eX4t/a9lYZX7noCyDBiDOQ/64fDswRuFs6HHYCcMTMCxwiT08HrkL9SZYLlUTpq/y1\n\ts+/iCkl2BsZ2noSlTO0aI0UHgYfUTEmJAmLE2bXjm71irxYO8n5TsdbxikNMobiIMD0omzGq59pz1\n\tQWJ6x5mE+NL1sPaj/U7GtyoVlVqFUne3SZNWWQXFjl3q5RbDKT/aYEjoFZS7wzPDK2mye+zMzC9P5\n\twgwDMQdw==;", "From": "Christoph Hellwig <hch@lst.de>", "To": "Andrew Morton <akpm@linux-foundation.org>", "Cc": "Richard Henderson <richard.henderson@linaro.org>,\n\tMatt Turner <mattst88@gmail.com>,\n\tMagnus Lindholm <linmag7@gmail.com>,\n\tRussell King <linux@armlinux.org.uk>,\n\tCatalin Marinas <catalin.marinas@arm.com>,\n\tWill Deacon <will@kernel.org>,\n\tArd Biesheuvel <ardb@kernel.org>,\n\tHuacai Chen <chenhuacai@kernel.org>,\n\tWANG Xuerui <kernel@xen0n.name>,\n\tMadhavan Srinivasan <maddy@linux.ibm.com>,\n\tMichael Ellerman <mpe@ellerman.id.au>,\n\tNicholas Piggin <npiggin@gmail.com>,\n\t\"Christophe Leroy (CS GROUP)\" <chleroy@kernel.org>,\n\tPaul Walmsley <pjw@kernel.org>,\n\tPalmer Dabbelt <palmer@dabbelt.com>,\n\tAlbert Ou <aou@eecs.berkeley.edu>,\n\tAlexandre Ghiti <alex@ghiti.fr>,\n\tHeiko Carstens <hca@linux.ibm.com>,\n\tVasily Gorbik <gor@linux.ibm.com>,\n\tAlexander Gordeev <agordeev@linux.ibm.com>,\n\tChristian Borntraeger <borntraeger@linux.ibm.com>,\n\tSven Schnelle <svens@linux.ibm.com>,\n\t\"David S. Miller\" <davem@davemloft.net>,\n\tAndreas Larsson <andreas@gaisler.com>,\n\tRichard Weinberger <richard@nod.at>,\n\tAnton Ivanov <anton.ivanov@cambridgegreys.com>,\n\tJohannes Berg <johannes@sipsolutions.net>,\n\tThomas Gleixner <tglx@kernel.org>,\n\tIngo Molnar <mingo@redhat.com>,\n\tBorislav Petkov <bp@alien8.de>,\n\tDave Hansen <dave.hansen@linux.intel.com>,\n\tx86@kernel.org,\n\t\"H. Peter Anvin\" <hpa@zytor.com>,\n\tHerbert Xu <herbert@gondor.apana.org.au>,\n\tDan Williams <dan.j.williams@intel.com>,\n\tChris Mason <clm@fb.com>,\n\tDavid Sterba <dsterba@suse.com>,\n\tArnd Bergmann <arnd@arndb.de>,\n\tSong Liu <song@kernel.org>,\n\tYu Kuai <yukuai@fnnas.com>,\n\tLi Nan <linan122@huawei.com>,\n\t\"Theodore Ts'o\" <tytso@mit.edu>,\n\t\"Jason A. Donenfeld\" <Jason@zx2c4.com>,\n\tlinux-alpha@vger.kernel.org,\n\tlinux-kernel@vger.kernel.org,\n\tlinux-arm-kernel@lists.infradead.org,\n\tloongarch@lists.linux.dev,\n\tlinuxppc-dev@lists.ozlabs.org,\n\tlinux-riscv@lists.infradead.org,\n\tlinux-s390@vger.kernel.org,\n\tsparclinux@vger.kernel.org,\n\tlinux-um@lists.infradead.org,\n\tlinux-crypto@vger.kernel.org,\n\tlinux-btrfs@vger.kernel.org,\n\tlinux-arch@vger.kernel.org,\n\tlinux-raid@vger.kernel.org", "Subject": "[PATCH 25/28] btrfs: use xor_gen", "Date": "Fri, 27 Mar 2026 07:16:57 +0100", "Message-ID": "<20260327061704.3707577-26-hch@lst.de>", "X-Mailer": "git-send-email 2.47.3", "In-Reply-To": "<20260327061704.3707577-1-hch@lst.de>", "References": "<20260327061704.3707577-1-hch@lst.de>", "X-Mailing-List": "linuxppc-dev@lists.ozlabs.org", "List-Id": "<linuxppc-dev.lists.ozlabs.org>", "List-Help": "<mailto:linuxppc-dev+help@lists.ozlabs.org>", "List-Owner": "<mailto:linuxppc-dev+owner@lists.ozlabs.org>", "List-Post": "<mailto:linuxppc-dev@lists.ozlabs.org>", "List-Archive": "<https://lore.kernel.org/linuxppc-dev/>,\n <https://lists.ozlabs.org/pipermail/linuxppc-dev/>", "List-Subscribe": "<mailto:linuxppc-dev+subscribe@lists.ozlabs.org>,\n <mailto:linuxppc-dev+subscribe-digest@lists.ozlabs.org>,\n <mailto:linuxppc-dev+subscribe-nomail@lists.ozlabs.org>", "List-Unsubscribe": "<mailto:linuxppc-dev+unsubscribe@lists.ozlabs.org>", "Precedence": "list", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-SRS-Rewrite": "SMTP reverse-path rewritten from <hch@infradead.org> by\n bombadil.infradead.org. See http://www.infradead.org/rpr.html", "X-Spam-Status": "No, score=0.0 required=3.0 tests=DKIM_SIGNED,DKIM_VALID,\n\tHEADER_FROM_DIFFERENT_DOMAINS,SPF_HELO_NONE,SPF_NONE\n\tautolearn=disabled version=4.0.1 OzLabs 8", "X-Spam-Checker-Version": "SpamAssassin 4.0.1 (2024-03-25) on lists.ozlabs.org" }, "content": "Use the new xor_gen helper instead of open coding the loop around\nxor_blocks. This helper is very similar to the existing run_xor helper\nin btrfs, except that the destination buffer is passed explicitly.\n\nSigned-off-by: Christoph Hellwig <hch@lst.de>\nAcked-by: David Sterba <dsterba@suse.com>\n---\n fs/btrfs/raid56.c | 27 ++++-----------------------\n 1 file changed, 4 insertions(+), 23 deletions(-)", "diff": "diff --git a/fs/btrfs/raid56.c b/fs/btrfs/raid56.c\nindex 02105d68accb..ad091c56ce77 100644\n--- a/fs/btrfs/raid56.c\n+++ b/fs/btrfs/raid56.c\n@@ -617,26 +617,6 @@ static void cache_rbio(struct btrfs_raid_bio *rbio)\n \tspin_unlock(&table->cache_lock);\n }\n \n-/*\n- * helper function to run the xor_blocks api. It is only\n- * able to do MAX_XOR_BLOCKS at a time, so we need to\n- * loop through.\n- */\n-static void run_xor(void **pages, int src_cnt, ssize_t len)\n-{\n-\tint src_off = 0;\n-\tint xor_src_cnt = 0;\n-\tvoid *dest = pages[src_cnt];\n-\n-\twhile(src_cnt > 0) {\n-\t\txor_src_cnt = min(src_cnt, MAX_XOR_BLOCKS);\n-\t\txor_blocks(xor_src_cnt, len, dest, pages + src_off);\n-\n-\t\tsrc_cnt -= xor_src_cnt;\n-\t\tsrc_off += xor_src_cnt;\n-\t}\n-}\n-\n /*\n * Returns true if the bio list inside this rbio covers an entire stripe (no\n * rmw required).\n@@ -1434,7 +1414,8 @@ static void generate_pq_vertical_step(struct btrfs_raid_bio *rbio, unsigned int\n \t} else {\n \t\t/* raid5 */\n \t\tmemcpy(pointers[rbio->nr_data], pointers[0], step);\n-\t\trun_xor(pointers + 1, rbio->nr_data - 1, step);\n+\t\txor_gen(pointers[rbio->nr_data], pointers + 1, rbio->nr_data - 1,\n+\t\t\t\tstep);\n \t}\n \tfor (stripe = stripe - 1; stripe >= 0; stripe--)\n \t\tkunmap_local(pointers[stripe]);\n@@ -2034,7 +2015,7 @@ static void recover_vertical_step(struct btrfs_raid_bio *rbio,\n \t\tpointers[rbio->nr_data - 1] = p;\n \n \t\t/* Xor in the rest */\n-\t\trun_xor(pointers, rbio->nr_data - 1, step);\n+\t\txor_gen(p, pointers, rbio->nr_data - 1, step);\n \t}\n \n cleanup:\n@@ -2672,7 +2653,7 @@ static bool verify_one_parity_step(struct btrfs_raid_bio *rbio,\n \t} else {\n \t\t/* RAID5. */\n \t\tmemcpy(pointers[nr_data], pointers[0], step);\n-\t\trun_xor(pointers + 1, nr_data - 1, step);\n+\t\txor_gen(pointers[nr_data], pointers + 1, nr_data - 1, step);\n \t}\n \n \t/* Check scrubbing parity and repair it. */\n", "prefixes": [ "25/28" ] }