Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/2216741/?format=api
{ "id": 2216741, "url": "http://patchwork.ozlabs.org/api/patches/2216741/?format=api", "web_url": "http://patchwork.ozlabs.org/project/linux-um/patch/20260327061704.3707577-26-hch@lst.de/", "project": { "id": 60, "url": "http://patchwork.ozlabs.org/api/projects/60/?format=api", "name": "User-mode Linux Development", "link_name": "linux-um", "list_id": "linux-um.lists.infradead.org", "list_email": "linux-um@lists.infradead.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20260327061704.3707577-26-hch@lst.de>", "list_archive_url": null, "date": "2026-03-27T06:16:57", "name": "[25/28] btrfs: use xor_gen", "commit_ref": null, "pull_url": null, "state": "not-applicable", "archived": false, "hash": "6a7da7015bb771c23127835ad729afb109f5fdbc", "submitter": { "id": 82, "url": "http://patchwork.ozlabs.org/api/people/82/?format=api", "name": "Christoph Hellwig", "email": "hch@lst.de" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/linux-um/patch/20260327061704.3707577-26-hch@lst.de/mbox/", "series": [ { "id": 497692, "url": "http://patchwork.ozlabs.org/api/series/497692/?format=api", "web_url": "http://patchwork.ozlabs.org/project/linux-um/list/?series=497692", "date": "2026-03-27T06:16:33", "name": "[01/28] xor: assert that xor_blocks is not call from interrupt context", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/497692/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2216741/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2216741/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "\n <linux-um-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n secure) header.d=lists.infradead.org header.i=@lists.infradead.org\n header.a=rsa-sha256 header.s=bombadil.20210309 header.b=bvfDJiox;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=none (no SPF record) smtp.mailfrom=lists.infradead.org\n (client-ip=2607:7c80:54:3::133; helo=bombadil.infradead.org;\n envelope-from=linux-um-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org;\n receiver=patchwork.ozlabs.org)" ], "Received": [ "from bombadil.infradead.org (bombadil.infradead.org\n [IPv6:2607:7c80:54:3::133])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fhrDZ10kkz1xy1\n\tfor <incoming@patchwork.ozlabs.org>; Fri, 27 Mar 2026 17:23:10 +1100 (AEDT)", "from localhost ([::1] helo=bombadil.infradead.org)\n\tby bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux))\n\tid 1w60b6-00000006o7R-2U40;\n\tFri, 27 Mar 2026 06:23:08 +0000", "from\n 2a02-8389-2341-5b80-d601-7564-c2e0-491c.cable.dynamic.v6.surfer.at\n ([2a02:8389:2341:5b80:d601:7564:c2e0:491c] helo=localhost)\n\tby bombadil.infradead.org with esmtpsa (Exim 4.98.2 #2 (Red Hat Linux))\n\tid 1w60b3-00000006nwZ-2BNW;\n\tFri, 27 Mar 2026 06:23:05 +0000" ], "DKIM-Signature": "v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;\n\td=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help\n\t:List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding:\n\tMIME-Version:References:In-Reply-To:Message-ID:Date:Subject:Cc:To:From:\n\tReply-To:Content-Type:Content-ID:Content-Description:Resent-Date:Resent-From:\n\tResent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner;\n\tbh=QjlTDO4991l2Jq5L4100pIA+eekfjivGwuTXYuHUt8k=; b=bvfDJiox8tBEXgoHipfBYS5opF\n\t+TdIHinS9EB8KdEAnyrBOzrHRiZgS83Ua4EJLW8h/pxoxe3gdWrjfjq8v084JPNzYbXF3smEwRa7R\n\trnDHOZJpzZbryzxZsZHckQhStUeMiSwPEft5SC5l7FjUTK1mWC7r4OXHSBo+1gJw3JAw97gIwJkYQ\n\tWqkslxVHGy5miVc1bZ6PMWgT3diPy2jhZI7JNVnz9oH/QfzPLrLXmh0Ah+AqokBpopolGZJB5qz22\n\tvrMtUghp8eQcuqbsuIM25wB7AZScpTZnUlWcwRJmVQEmdqNIKJ2OU0QKUFA2/kZzVp0s5Yab4E6cb\n\t3vQBB8yw==;", "From": "Christoph Hellwig <hch@lst.de>", "To": "Andrew Morton <akpm@linux-foundation.org>", "Cc": "Richard Henderson <richard.henderson@linaro.org>,\n\tMatt Turner <mattst88@gmail.com>,\n\tMagnus Lindholm <linmag7@gmail.com>,\n\tRussell King <linux@armlinux.org.uk>,\n\tCatalin Marinas <catalin.marinas@arm.com>,\n\tWill Deacon <will@kernel.org>,\n\tArd Biesheuvel <ardb@kernel.org>,\n\tHuacai Chen <chenhuacai@kernel.org>,\n\tWANG Xuerui <kernel@xen0n.name>,\n\tMadhavan Srinivasan <maddy@linux.ibm.com>,\n\tMichael Ellerman <mpe@ellerman.id.au>,\n\tNicholas Piggin <npiggin@gmail.com>,\n\t\"Christophe Leroy (CS GROUP)\" <chleroy@kernel.org>,\n\tPaul Walmsley <pjw@kernel.org>,\n\tPalmer Dabbelt <palmer@dabbelt.com>,\n\tAlbert Ou <aou@eecs.berkeley.edu>,\n\tAlexandre Ghiti <alex@ghiti.fr>,\n\tHeiko Carstens <hca@linux.ibm.com>,\n\tVasily Gorbik <gor@linux.ibm.com>,\n\tAlexander Gordeev <agordeev@linux.ibm.com>,\n\tChristian Borntraeger <borntraeger@linux.ibm.com>,\n\tSven Schnelle <svens@linux.ibm.com>,\n\t\"David S. Miller\" <davem@davemloft.net>,\n\tAndreas Larsson <andreas@gaisler.com>,\n\tRichard Weinberger <richard@nod.at>,\n\tAnton Ivanov <anton.ivanov@cambridgegreys.com>,\n\tJohannes Berg <johannes@sipsolutions.net>,\n\tThomas Gleixner <tglx@kernel.org>,\n\tIngo Molnar <mingo@redhat.com>,\n\tBorislav Petkov <bp@alien8.de>,\n\tDave Hansen <dave.hansen@linux.intel.com>,\n\tx86@kernel.org,\n\t\"H. Peter Anvin\" <hpa@zytor.com>,\n\tHerbert Xu <herbert@gondor.apana.org.au>,\n\tDan Williams <dan.j.williams@intel.com>,\n\tChris Mason <clm@fb.com>,\n\tDavid Sterba <dsterba@suse.com>,\n\tArnd Bergmann <arnd@arndb.de>,\n\tSong Liu <song@kernel.org>,\n\tYu Kuai <yukuai@fnnas.com>,\n\tLi Nan <linan122@huawei.com>,\n\t\"Theodore Ts'o\" <tytso@mit.edu>,\n\t\"Jason A. Donenfeld\" <Jason@zx2c4.com>,\n\tlinux-alpha@vger.kernel.org,\n\tlinux-kernel@vger.kernel.org,\n\tlinux-arm-kernel@lists.infradead.org,\n\tloongarch@lists.linux.dev,\n\tlinuxppc-dev@lists.ozlabs.org,\n\tlinux-riscv@lists.infradead.org,\n\tlinux-s390@vger.kernel.org,\n\tsparclinux@vger.kernel.org,\n\tlinux-um@lists.infradead.org,\n\tlinux-crypto@vger.kernel.org,\n\tlinux-btrfs@vger.kernel.org,\n\tlinux-arch@vger.kernel.org,\n\tlinux-raid@vger.kernel.org", "Subject": "[PATCH 25/28] btrfs: use xor_gen", "Date": "Fri, 27 Mar 2026 07:16:57 +0100", "Message-ID": "<20260327061704.3707577-26-hch@lst.de>", "X-Mailer": "git-send-email 2.47.3", "In-Reply-To": "<20260327061704.3707577-1-hch@lst.de>", "References": "<20260327061704.3707577-1-hch@lst.de>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "linux-um@lists.infradead.org", "X-Mailman-Version": "2.1.34", "Precedence": "list", "List-Id": "<linux-um.lists.infradead.org>", "List-Unsubscribe": "<http://lists.infradead.org/mailman/options/linux-um>,\n <mailto:linux-um-request@lists.infradead.org?subject=unsubscribe>", "List-Archive": "<http://lists.infradead.org/pipermail/linux-um/>", "List-Post": "<mailto:linux-um@lists.infradead.org>", "List-Help": "<mailto:linux-um-request@lists.infradead.org?subject=help>", "List-Subscribe": "<http://lists.infradead.org/mailman/listinfo/linux-um>,\n <mailto:linux-um-request@lists.infradead.org?subject=subscribe>", "Sender": "\"linux-um\" <linux-um-bounces@lists.infradead.org>", "Errors-To": "linux-um-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org" }, "content": "Use the new xor_gen helper instead of open coding the loop around\nxor_blocks. This helper is very similar to the existing run_xor helper\nin btrfs, except that the destination buffer is passed explicitly.\n\nSigned-off-by: Christoph Hellwig <hch@lst.de>\nAcked-by: David Sterba <dsterba@suse.com>\n---\n fs/btrfs/raid56.c | 27 ++++-----------------------\n 1 file changed, 4 insertions(+), 23 deletions(-)", "diff": "diff --git a/fs/btrfs/raid56.c b/fs/btrfs/raid56.c\nindex 02105d68accb..ad091c56ce77 100644\n--- a/fs/btrfs/raid56.c\n+++ b/fs/btrfs/raid56.c\n@@ -617,26 +617,6 @@ static void cache_rbio(struct btrfs_raid_bio *rbio)\n \tspin_unlock(&table->cache_lock);\n }\n \n-/*\n- * helper function to run the xor_blocks api. It is only\n- * able to do MAX_XOR_BLOCKS at a time, so we need to\n- * loop through.\n- */\n-static void run_xor(void **pages, int src_cnt, ssize_t len)\n-{\n-\tint src_off = 0;\n-\tint xor_src_cnt = 0;\n-\tvoid *dest = pages[src_cnt];\n-\n-\twhile(src_cnt > 0) {\n-\t\txor_src_cnt = min(src_cnt, MAX_XOR_BLOCKS);\n-\t\txor_blocks(xor_src_cnt, len, dest, pages + src_off);\n-\n-\t\tsrc_cnt -= xor_src_cnt;\n-\t\tsrc_off += xor_src_cnt;\n-\t}\n-}\n-\n /*\n * Returns true if the bio list inside this rbio covers an entire stripe (no\n * rmw required).\n@@ -1434,7 +1414,8 @@ static void generate_pq_vertical_step(struct btrfs_raid_bio *rbio, unsigned int\n \t} else {\n \t\t/* raid5 */\n \t\tmemcpy(pointers[rbio->nr_data], pointers[0], step);\n-\t\trun_xor(pointers + 1, rbio->nr_data - 1, step);\n+\t\txor_gen(pointers[rbio->nr_data], pointers + 1, rbio->nr_data - 1,\n+\t\t\t\tstep);\n \t}\n \tfor (stripe = stripe - 1; stripe >= 0; stripe--)\n \t\tkunmap_local(pointers[stripe]);\n@@ -2034,7 +2015,7 @@ static void recover_vertical_step(struct btrfs_raid_bio *rbio,\n \t\tpointers[rbio->nr_data - 1] = p;\n \n \t\t/* Xor in the rest */\n-\t\trun_xor(pointers, rbio->nr_data - 1, step);\n+\t\txor_gen(p, pointers, rbio->nr_data - 1, step);\n \t}\n \n cleanup:\n@@ -2672,7 +2653,7 @@ static bool verify_one_parity_step(struct btrfs_raid_bio *rbio,\n \t} else {\n \t\t/* RAID5. */\n \t\tmemcpy(pointers[nr_data], pointers[0], step);\n-\t\trun_xor(pointers + 1, nr_data - 1, step);\n+\t\txor_gen(pointers[nr_data], pointers + 1, nr_data - 1, step);\n \t}\n \n \t/* Check scrubbing parity and repair it. */\n", "prefixes": [ "25/28" ] }