Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/2216721/?format=api
{ "id": 2216721, "url": "http://patchwork.ozlabs.org/api/patches/2216721/?format=api", "web_url": "http://patchwork.ozlabs.org/project/linux-um/patch/20260327061704.3707577-17-hch@lst.de/", "project": { "id": 60, "url": "http://patchwork.ozlabs.org/api/projects/60/?format=api", "name": "User-mode Linux Development", "link_name": "linux-um", "list_id": "linux-um.lists.infradead.org", "list_email": "linux-um@lists.infradead.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20260327061704.3707577-17-hch@lst.de>", "list_archive_url": null, "date": "2026-03-27T06:16:48", "name": "[16/28] riscv: move the XOR code to lib/raid/", "commit_ref": null, "pull_url": null, "state": "not-applicable", "archived": false, "hash": "b26a8d13ca8e4983ab59bcf5498f9981211c0258", "submitter": { "id": 82, "url": "http://patchwork.ozlabs.org/api/people/82/?format=api", "name": "Christoph Hellwig", "email": "hch@lst.de" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/linux-um/patch/20260327061704.3707577-17-hch@lst.de/mbox/", "series": [ { "id": 497692, "url": "http://patchwork.ozlabs.org/api/series/497692/?format=api", "web_url": "http://patchwork.ozlabs.org/project/linux-um/list/?series=497692", "date": "2026-03-27T06:16:33", "name": "[01/28] xor: assert that xor_blocks is not call from interrupt context", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/497692/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2216721/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2216721/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "\n <linux-um-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n secure) header.d=lists.infradead.org header.i=@lists.infradead.org\n header.a=rsa-sha256 header.s=bombadil.20210309 header.b=XhfNuN1q;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=none (no SPF record) smtp.mailfrom=lists.infradead.org\n (client-ip=2607:7c80:54:3::133; helo=bombadil.infradead.org;\n envelope-from=linux-um-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org;\n receiver=patchwork.ozlabs.org)" ], "Received": [ "from bombadil.infradead.org (bombadil.infradead.org\n [IPv6:2607:7c80:54:3::133])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fhrBS2PbZz1xy1\n\tfor <incoming@patchwork.ozlabs.org>; Fri, 27 Mar 2026 17:21:20 +1100 (AEDT)", "from localhost ([::1] helo=bombadil.infradead.org)\n\tby bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux))\n\tid 1w60ZK-00000006mpK-2MN9;\n\tFri, 27 Mar 2026 06:21:18 +0000", "from\n 2a02-8389-2341-5b80-d601-7564-c2e0-491c.cable.dynamic.v6.surfer.at\n ([2a02:8389:2341:5b80:d601:7564:c2e0:491c] helo=localhost)\n\tby bombadil.infradead.org with esmtpsa (Exim 4.98.2 #2 (Red Hat Linux))\n\tid 1w60ZG-00000006mcg-2DiH;\n\tFri, 27 Mar 2026 06:21:15 +0000" ], "DKIM-Signature": "v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;\n\td=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help\n\t:List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding:\n\tMIME-Version:References:In-Reply-To:Message-ID:Date:Subject:Cc:To:From:\n\tReply-To:Content-Type:Content-ID:Content-Description:Resent-Date:Resent-From:\n\tResent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner;\n\tbh=07vOovAtUwNz4Cgfu6Afqnyvj7rNswjLnNiipxDT/U4=; b=XhfNuN1qHOJrRK5mopFcxAv8gY\n\tbquKIdualy7ChVgUUqLMSEHbH4GEuEwi7zndwWSkeK2C1gFMphFogFr7YDeG2wSa/HBR9gkOxHBnW\n\tdMQ2EGMlbMNSsR/q01AlYyM+4TrH9h3JqGrfUvDyMeG2WgJjREEIU8RJAiaa1DDu2pCDHKu7x766z\n\t2U8Zz87pTIzYPVvQio5I5vZN+2Xa7u+WBa1CT8N/p5F3GtyNR2hZnN4MdoebGO09bLN3M/V0SmdZo\n\t8UUebtOtLDaUSZsyHMth6Yi0CA3QQ54QrIqqA8+O/v2B21TSJE2Yw/mLJmTr4l468jASBHyWHeBRy\n\tBjnyrNmA==;", "From": "Christoph Hellwig <hch@lst.de>", "To": "Andrew Morton <akpm@linux-foundation.org>", "Cc": "Richard Henderson <richard.henderson@linaro.org>,\n\tMatt Turner <mattst88@gmail.com>,\n\tMagnus Lindholm <linmag7@gmail.com>,\n\tRussell King <linux@armlinux.org.uk>,\n\tCatalin Marinas <catalin.marinas@arm.com>,\n\tWill Deacon <will@kernel.org>,\n\tArd Biesheuvel <ardb@kernel.org>,\n\tHuacai Chen <chenhuacai@kernel.org>,\n\tWANG Xuerui <kernel@xen0n.name>,\n\tMadhavan Srinivasan <maddy@linux.ibm.com>,\n\tMichael Ellerman <mpe@ellerman.id.au>,\n\tNicholas Piggin <npiggin@gmail.com>,\n\t\"Christophe Leroy (CS GROUP)\" <chleroy@kernel.org>,\n\tPaul Walmsley <pjw@kernel.org>,\n\tPalmer Dabbelt <palmer@dabbelt.com>,\n\tAlbert Ou <aou@eecs.berkeley.edu>,\n\tAlexandre Ghiti <alex@ghiti.fr>,\n\tHeiko Carstens <hca@linux.ibm.com>,\n\tVasily Gorbik <gor@linux.ibm.com>,\n\tAlexander Gordeev <agordeev@linux.ibm.com>,\n\tChristian Borntraeger <borntraeger@linux.ibm.com>,\n\tSven Schnelle <svens@linux.ibm.com>,\n\t\"David S. Miller\" <davem@davemloft.net>,\n\tAndreas Larsson <andreas@gaisler.com>,\n\tRichard Weinberger <richard@nod.at>,\n\tAnton Ivanov <anton.ivanov@cambridgegreys.com>,\n\tJohannes Berg <johannes@sipsolutions.net>,\n\tThomas Gleixner <tglx@kernel.org>,\n\tIngo Molnar <mingo@redhat.com>,\n\tBorislav Petkov <bp@alien8.de>,\n\tDave Hansen <dave.hansen@linux.intel.com>,\n\tx86@kernel.org,\n\t\"H. Peter Anvin\" <hpa@zytor.com>,\n\tHerbert Xu <herbert@gondor.apana.org.au>,\n\tDan Williams <dan.j.williams@intel.com>,\n\tChris Mason <clm@fb.com>,\n\tDavid Sterba <dsterba@suse.com>,\n\tArnd Bergmann <arnd@arndb.de>,\n\tSong Liu <song@kernel.org>,\n\tYu Kuai <yukuai@fnnas.com>,\n\tLi Nan <linan122@huawei.com>,\n\t\"Theodore Ts'o\" <tytso@mit.edu>,\n\t\"Jason A. Donenfeld\" <Jason@zx2c4.com>,\n\tlinux-alpha@vger.kernel.org,\n\tlinux-kernel@vger.kernel.org,\n\tlinux-arm-kernel@lists.infradead.org,\n\tloongarch@lists.linux.dev,\n\tlinuxppc-dev@lists.ozlabs.org,\n\tlinux-riscv@lists.infradead.org,\n\tlinux-s390@vger.kernel.org,\n\tsparclinux@vger.kernel.org,\n\tlinux-um@lists.infradead.org,\n\tlinux-crypto@vger.kernel.org,\n\tlinux-btrfs@vger.kernel.org,\n\tlinux-arch@vger.kernel.org,\n\tlinux-raid@vger.kernel.org", "Subject": "[PATCH 16/28] riscv: move the XOR code to lib/raid/", "Date": "Fri, 27 Mar 2026 07:16:48 +0100", "Message-ID": "<20260327061704.3707577-17-hch@lst.de>", "X-Mailer": "git-send-email 2.47.3", "In-Reply-To": "<20260327061704.3707577-1-hch@lst.de>", "References": "<20260327061704.3707577-1-hch@lst.de>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "linux-um@lists.infradead.org", "X-Mailman-Version": "2.1.34", "Precedence": "list", "List-Id": "<linux-um.lists.infradead.org>", "List-Unsubscribe": "<http://lists.infradead.org/mailman/options/linux-um>,\n <mailto:linux-um-request@lists.infradead.org?subject=unsubscribe>", "List-Archive": "<http://lists.infradead.org/pipermail/linux-um/>", "List-Post": "<mailto:linux-um@lists.infradead.org>", "List-Help": "<mailto:linux-um-request@lists.infradead.org?subject=help>", "List-Subscribe": "<http://lists.infradead.org/mailman/listinfo/linux-um>,\n <mailto:linux-um-request@lists.infradead.org?subject=subscribe>", "Sender": "\"linux-um\" <linux-um-bounces@lists.infradead.org>", "Errors-To": "linux-um-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org" }, "content": "Move the optimized XOR into lib/raid and include it it in xor.ko\ninstead of always building it into the main kernel image.\n\nSigned-off-by: Christoph Hellwig <hch@lst.de>\n---\n arch/riscv/include/asm/xor.h | 54 +------------------\n arch/riscv/lib/Makefile | 1 -\n lib/raid/xor/Makefile | 1 +\n lib/raid/xor/riscv/xor-glue.c | 56 ++++++++++++++++++++\n {arch/riscv/lib => lib/raid/xor/riscv}/xor.S | 4 --\n 5 files changed, 59 insertions(+), 57 deletions(-)\n create mode 100644 lib/raid/xor/riscv/xor-glue.c\n rename {arch/riscv/lib => lib/raid/xor/riscv}/xor.S (92%)", "diff": "diff --git a/arch/riscv/include/asm/xor.h b/arch/riscv/include/asm/xor.h\nindex ed5f27903efc..614d9209d078 100644\n--- a/arch/riscv/include/asm/xor.h\n+++ b/arch/riscv/include/asm/xor.h\n@@ -2,60 +2,10 @@\n /*\n * Copyright (C) 2021 SiFive\n */\n-\n-#include <linux/hardirq.h>\n-#include <asm-generic/xor.h>\n-#ifdef CONFIG_RISCV_ISA_V\n #include <asm/vector.h>\n-#include <asm/switch_to.h>\n-#include <asm/asm-prototypes.h>\n-\n-static void xor_vector_2(unsigned long bytes, unsigned long *__restrict p1,\n-\t\t\t const unsigned long *__restrict p2)\n-{\n-\tkernel_vector_begin();\n-\txor_regs_2_(bytes, p1, p2);\n-\tkernel_vector_end();\n-}\n-\n-static void xor_vector_3(unsigned long bytes, unsigned long *__restrict p1,\n-\t\t\t const unsigned long *__restrict p2,\n-\t\t\t const unsigned long *__restrict p3)\n-{\n-\tkernel_vector_begin();\n-\txor_regs_3_(bytes, p1, p2, p3);\n-\tkernel_vector_end();\n-}\n-\n-static void xor_vector_4(unsigned long bytes, unsigned long *__restrict p1,\n-\t\t\t const unsigned long *__restrict p2,\n-\t\t\t const unsigned long *__restrict p3,\n-\t\t\t const unsigned long *__restrict p4)\n-{\n-\tkernel_vector_begin();\n-\txor_regs_4_(bytes, p1, p2, p3, p4);\n-\tkernel_vector_end();\n-}\n-\n-static void xor_vector_5(unsigned long bytes, unsigned long *__restrict p1,\n-\t\t\t const unsigned long *__restrict p2,\n-\t\t\t const unsigned long *__restrict p3,\n-\t\t\t const unsigned long *__restrict p4,\n-\t\t\t const unsigned long *__restrict p5)\n-{\n-\tkernel_vector_begin();\n-\txor_regs_5_(bytes, p1, p2, p3, p4, p5);\n-\tkernel_vector_end();\n-}\n+#include <asm-generic/xor.h>\n \n-static struct xor_block_template xor_block_rvv = {\n-\t.name = \"rvv\",\n-\t.do_2 = xor_vector_2,\n-\t.do_3 = xor_vector_3,\n-\t.do_4 = xor_vector_4,\n-\t.do_5 = xor_vector_5\n-};\n-#endif /* CONFIG_RISCV_ISA_V */\n+extern struct xor_block_template xor_block_rvv;\n \n #define arch_xor_init arch_xor_init\n static __always_inline void __init arch_xor_init(void)\ndiff --git a/arch/riscv/lib/Makefile b/arch/riscv/lib/Makefile\nindex bbc031124974..e220c35764eb 100644\n--- a/arch/riscv/lib/Makefile\n+++ b/arch/riscv/lib/Makefile\n@@ -16,5 +16,4 @@ lib-$(CONFIG_MMU)\t+= uaccess.o\n lib-$(CONFIG_64BIT)\t+= tishift.o\n lib-$(CONFIG_RISCV_ISA_ZICBOZ)\t+= clear_page.o\n obj-$(CONFIG_FUNCTION_ERROR_INJECTION) += error-inject.o\n-lib-$(CONFIG_RISCV_ISA_V)\t+= xor.o\n lib-$(CONFIG_RISCV_ISA_V)\t+= riscv_v_helpers.o\ndiff --git a/lib/raid/xor/Makefile b/lib/raid/xor/Makefile\nindex 006b44ce46bf..9e729b50e775 100644\n--- a/lib/raid/xor/Makefile\n+++ b/lib/raid/xor/Makefile\n@@ -17,6 +17,7 @@ xor-$(CONFIG_ARM64)\t\t+= arm64/xor-neon.o arm64/xor-neon-glue.o\n xor-$(CONFIG_CPU_HAS_LSX)\t+= loongarch/xor_simd.o\n xor-$(CONFIG_CPU_HAS_LSX)\t+= loongarch/xor_simd_glue.o\n xor-$(CONFIG_ALTIVEC)\t\t+= powerpc/xor_vmx.o powerpc/xor_vmx_glue.o\n+xor-$(CONFIG_RISCV_ISA_V)\t+= riscv/xor.o riscv/xor-glue.o\n \n \n CFLAGS_arm/xor-neon.o\t\t+= $(CC_FLAGS_FPU)\ndiff --git a/lib/raid/xor/riscv/xor-glue.c b/lib/raid/xor/riscv/xor-glue.c\nnew file mode 100644\nindex 000000000000..11666a4b6b68\n--- /dev/null\n+++ b/lib/raid/xor/riscv/xor-glue.c\n@@ -0,0 +1,56 @@\n+// SPDX-License-Identifier: GPL-2.0-or-later\n+/*\n+ * Copyright (C) 2021 SiFive\n+ */\n+\n+#include <linux/raid/xor_impl.h>\n+#include <asm/vector.h>\n+#include <asm/switch_to.h>\n+#include <asm/asm-prototypes.h>\n+#include <asm/xor.h>\n+\n+static void xor_vector_2(unsigned long bytes, unsigned long *__restrict p1,\n+\t\t\t const unsigned long *__restrict p2)\n+{\n+\tkernel_vector_begin();\n+\txor_regs_2_(bytes, p1, p2);\n+\tkernel_vector_end();\n+}\n+\n+static void xor_vector_3(unsigned long bytes, unsigned long *__restrict p1,\n+\t\t\t const unsigned long *__restrict p2,\n+\t\t\t const unsigned long *__restrict p3)\n+{\n+\tkernel_vector_begin();\n+\txor_regs_3_(bytes, p1, p2, p3);\n+\tkernel_vector_end();\n+}\n+\n+static void xor_vector_4(unsigned long bytes, unsigned long *__restrict p1,\n+\t\t\t const unsigned long *__restrict p2,\n+\t\t\t const unsigned long *__restrict p3,\n+\t\t\t const unsigned long *__restrict p4)\n+{\n+\tkernel_vector_begin();\n+\txor_regs_4_(bytes, p1, p2, p3, p4);\n+\tkernel_vector_end();\n+}\n+\n+static void xor_vector_5(unsigned long bytes, unsigned long *__restrict p1,\n+\t\t\t const unsigned long *__restrict p2,\n+\t\t\t const unsigned long *__restrict p3,\n+\t\t\t const unsigned long *__restrict p4,\n+\t\t\t const unsigned long *__restrict p5)\n+{\n+\tkernel_vector_begin();\n+\txor_regs_5_(bytes, p1, p2, p3, p4, p5);\n+\tkernel_vector_end();\n+}\n+\n+struct xor_block_template xor_block_rvv = {\n+\t.name = \"rvv\",\n+\t.do_2 = xor_vector_2,\n+\t.do_3 = xor_vector_3,\n+\t.do_4 = xor_vector_4,\n+\t.do_5 = xor_vector_5\n+};\ndiff --git a/arch/riscv/lib/xor.S b/lib/raid/xor/riscv/xor.S\nsimilarity index 92%\nrename from arch/riscv/lib/xor.S\nrename to lib/raid/xor/riscv/xor.S\nindex b28f2430e52f..56fb7fc1e2cd 100644\n--- a/arch/riscv/lib/xor.S\n+++ b/lib/raid/xor/riscv/xor.S\n@@ -18,7 +18,6 @@ SYM_FUNC_START(xor_regs_2_)\n \tbnez a0, xor_regs_2_\n \tret\n SYM_FUNC_END(xor_regs_2_)\n-EXPORT_SYMBOL(xor_regs_2_)\n \n SYM_FUNC_START(xor_regs_3_)\n \tvsetvli a4, a0, e8, m8, ta, ma\n@@ -35,7 +34,6 @@ SYM_FUNC_START(xor_regs_3_)\n \tbnez a0, xor_regs_3_\n \tret\n SYM_FUNC_END(xor_regs_3_)\n-EXPORT_SYMBOL(xor_regs_3_)\n \n SYM_FUNC_START(xor_regs_4_)\n \tvsetvli a5, a0, e8, m8, ta, ma\n@@ -55,7 +53,6 @@ SYM_FUNC_START(xor_regs_4_)\n \tbnez a0, xor_regs_4_\n \tret\n SYM_FUNC_END(xor_regs_4_)\n-EXPORT_SYMBOL(xor_regs_4_)\n \n SYM_FUNC_START(xor_regs_5_)\n \tvsetvli a6, a0, e8, m8, ta, ma\n@@ -78,4 +75,3 @@ SYM_FUNC_START(xor_regs_5_)\n \tbnez a0, xor_regs_5_\n \tret\n SYM_FUNC_END(xor_regs_5_)\n-EXPORT_SYMBOL(xor_regs_5_)\n", "prefixes": [ "16/28" ] }