Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/2216717/?format=api
{ "id": 2216717, "url": "http://patchwork.ozlabs.org/api/patches/2216717/?format=api", "web_url": "http://patchwork.ozlabs.org/project/linux-um/patch/20260327061704.3707577-16-hch@lst.de/", "project": { "id": 60, "url": "http://patchwork.ozlabs.org/api/projects/60/?format=api", "name": "User-mode Linux Development", "link_name": "linux-um", "list_id": "linux-um.lists.infradead.org", "list_email": "linux-um@lists.infradead.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20260327061704.3707577-16-hch@lst.de>", "list_archive_url": null, "date": "2026-03-27T06:16:47", "name": "[15/28] powerpc: move the XOR code to lib/raid/", "commit_ref": null, "pull_url": null, "state": "not-applicable", "archived": false, "hash": "b61516c4e9422a2ff1b60df6d0a434a852b0579a", "submitter": { "id": 82, "url": "http://patchwork.ozlabs.org/api/people/82/?format=api", "name": "Christoph Hellwig", "email": "hch@lst.de" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/linux-um/patch/20260327061704.3707577-16-hch@lst.de/mbox/", "series": [ { "id": 497692, "url": "http://patchwork.ozlabs.org/api/series/497692/?format=api", "web_url": "http://patchwork.ozlabs.org/project/linux-um/list/?series=497692", "date": "2026-03-27T06:16:33", "name": "[01/28] xor: assert that xor_blocks is not call from interrupt context", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/497692/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2216717/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2216717/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "\n <linux-um-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n secure) header.d=lists.infradead.org header.i=@lists.infradead.org\n header.a=rsa-sha256 header.s=bombadil.20210309 header.b=gk/eLZj0;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=none (no SPF record) smtp.mailfrom=lists.infradead.org\n (client-ip=2607:7c80:54:3::133; helo=bombadil.infradead.org;\n envelope-from=linux-um-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org;\n receiver=patchwork.ozlabs.org)" ], "Received": [ "from bombadil.infradead.org (bombadil.infradead.org\n [IPv6:2607:7c80:54:3::133])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fhrB96cvHz1xy1\n\tfor <incoming@patchwork.ozlabs.org>; Fri, 27 Mar 2026 17:21:05 +1100 (AEDT)", "from localhost ([::1] helo=bombadil.infradead.org)\n\tby bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux))\n\tid 1w60Z6-00000006me5-0tpn;\n\tFri, 27 Mar 2026 06:21:04 +0000", "from\n 2a02-8389-2341-5b80-d601-7564-c2e0-491c.cable.dynamic.v6.surfer.at\n ([2a02:8389:2341:5b80:d601:7564:c2e0:491c] helo=localhost)\n\tby bombadil.infradead.org with esmtpsa (Exim 4.98.2 #2 (Red Hat Linux))\n\tid 1w60Z3-00000006mQy-1JhN;\n\tFri, 27 Mar 2026 06:21:01 +0000" ], "DKIM-Signature": "v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;\n\td=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help\n\t:List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding:\n\tMIME-Version:References:In-Reply-To:Message-ID:Date:Subject:Cc:To:From:\n\tReply-To:Content-Type:Content-ID:Content-Description:Resent-Date:Resent-From:\n\tResent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner;\n\tbh=VU1JeGqI6k2uvXecj1efLpuQZv7vmGIDPw6I2na0LZU=; b=gk/eLZj02yxlNgUSNNM/ClOt7K\n\tmQWYAO7TsED2Gx4ghIZ7UmDt9mJ5nWzgq+QkFX85eF3IGl8h0KSFowwnL4OTGt6nYPnlccHJjkq41\n\tzwvBHx5O5+IuSaW2mSHTpnVtrOvqa6zMHYLtvAcJjmSE7DlqM98cTIWlB2GCQsrmiKZobzXBtxqUm\n\tS3Uy7yTygTIyOlFTsboc3RDI+bSZAOmypst2kCAOC8Kz3fX+OmfncrEbzohp0x4+yCAtlDyv0IiMR\n\txW4NlGDLTFLmpI16fQw0M6ZRBZx8OWnUuJ1nnjChqm3DtcDHqvJPCH0uLrhzv7ChyKPv0KZ6QyAhv\n\tU0GqnAiw==;", "From": "Christoph Hellwig <hch@lst.de>", "To": "Andrew Morton <akpm@linux-foundation.org>", "Cc": "Richard Henderson <richard.henderson@linaro.org>,\n\tMatt Turner <mattst88@gmail.com>,\n\tMagnus Lindholm <linmag7@gmail.com>,\n\tRussell King <linux@armlinux.org.uk>,\n\tCatalin Marinas <catalin.marinas@arm.com>,\n\tWill Deacon <will@kernel.org>,\n\tArd Biesheuvel <ardb@kernel.org>,\n\tHuacai Chen <chenhuacai@kernel.org>,\n\tWANG Xuerui <kernel@xen0n.name>,\n\tMadhavan Srinivasan <maddy@linux.ibm.com>,\n\tMichael Ellerman <mpe@ellerman.id.au>,\n\tNicholas Piggin <npiggin@gmail.com>,\n\t\"Christophe Leroy (CS GROUP)\" <chleroy@kernel.org>,\n\tPaul Walmsley <pjw@kernel.org>,\n\tPalmer Dabbelt <palmer@dabbelt.com>,\n\tAlbert Ou <aou@eecs.berkeley.edu>,\n\tAlexandre Ghiti <alex@ghiti.fr>,\n\tHeiko Carstens <hca@linux.ibm.com>,\n\tVasily Gorbik <gor@linux.ibm.com>,\n\tAlexander Gordeev <agordeev@linux.ibm.com>,\n\tChristian Borntraeger <borntraeger@linux.ibm.com>,\n\tSven Schnelle <svens@linux.ibm.com>,\n\t\"David S. Miller\" <davem@davemloft.net>,\n\tAndreas Larsson <andreas@gaisler.com>,\n\tRichard Weinberger <richard@nod.at>,\n\tAnton Ivanov <anton.ivanov@cambridgegreys.com>,\n\tJohannes Berg <johannes@sipsolutions.net>,\n\tThomas Gleixner <tglx@kernel.org>,\n\tIngo Molnar <mingo@redhat.com>,\n\tBorislav Petkov <bp@alien8.de>,\n\tDave Hansen <dave.hansen@linux.intel.com>,\n\tx86@kernel.org,\n\t\"H. Peter Anvin\" <hpa@zytor.com>,\n\tHerbert Xu <herbert@gondor.apana.org.au>,\n\tDan Williams <dan.j.williams@intel.com>,\n\tChris Mason <clm@fb.com>,\n\tDavid Sterba <dsterba@suse.com>,\n\tArnd Bergmann <arnd@arndb.de>,\n\tSong Liu <song@kernel.org>,\n\tYu Kuai <yukuai@fnnas.com>,\n\tLi Nan <linan122@huawei.com>,\n\t\"Theodore Ts'o\" <tytso@mit.edu>,\n\t\"Jason A. Donenfeld\" <Jason@zx2c4.com>,\n\tlinux-alpha@vger.kernel.org,\n\tlinux-kernel@vger.kernel.org,\n\tlinux-arm-kernel@lists.infradead.org,\n\tloongarch@lists.linux.dev,\n\tlinuxppc-dev@lists.ozlabs.org,\n\tlinux-riscv@lists.infradead.org,\n\tlinux-s390@vger.kernel.org,\n\tsparclinux@vger.kernel.org,\n\tlinux-um@lists.infradead.org,\n\tlinux-crypto@vger.kernel.org,\n\tlinux-btrfs@vger.kernel.org,\n\tlinux-arch@vger.kernel.org,\n\tlinux-raid@vger.kernel.org", "Subject": "[PATCH 15/28] powerpc: move the XOR code to lib/raid/", "Date": "Fri, 27 Mar 2026 07:16:47 +0100", "Message-ID": "<20260327061704.3707577-16-hch@lst.de>", "X-Mailer": "git-send-email 2.47.3", "In-Reply-To": "<20260327061704.3707577-1-hch@lst.de>", "References": "<20260327061704.3707577-1-hch@lst.de>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "linux-um@lists.infradead.org", "X-Mailman-Version": "2.1.34", "Precedence": "list", "List-Id": "<linux-um.lists.infradead.org>", "List-Unsubscribe": "<http://lists.infradead.org/mailman/options/linux-um>,\n <mailto:linux-um-request@lists.infradead.org?subject=unsubscribe>", "List-Archive": "<http://lists.infradead.org/pipermail/linux-um/>", "List-Post": "<mailto:linux-um@lists.infradead.org>", "List-Help": "<mailto:linux-um-request@lists.infradead.org?subject=help>", "List-Subscribe": "<http://lists.infradead.org/mailman/listinfo/linux-um>,\n <mailto:linux-um-request@lists.infradead.org?subject=subscribe>", "Sender": "\"linux-um\" <linux-um-bounces@lists.infradead.org>", "Errors-To": "linux-um-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org" }, "content": "Move the optimized XOR into lib/raid and include it it in xor.ko\ninstead of always building it into the main kernel image.\n\nSigned-off-by: Christoph Hellwig <hch@lst.de>\n---\n arch/powerpc/include/asm/xor.h | 17 +----\n arch/powerpc/include/asm/xor_altivec.h | 22 ------\n arch/powerpc/lib/Makefile | 5 --\n arch/powerpc/lib/xor_vmx_glue.c | 63 -----------------\n lib/raid/xor/Makefile | 5 ++\n .../lib => lib/raid/xor/powerpc}/xor_vmx.c | 0\n .../lib => lib/raid/xor/powerpc}/xor_vmx.h | 0\n lib/raid/xor/powerpc/xor_vmx_glue.c | 67 +++++++++++++++++++\n 8 files changed, 74 insertions(+), 105 deletions(-)\n delete mode 100644 arch/powerpc/include/asm/xor_altivec.h\n delete mode 100644 arch/powerpc/lib/xor_vmx_glue.c\n rename {arch/powerpc/lib => lib/raid/xor/powerpc}/xor_vmx.c (100%)\n rename {arch/powerpc/lib => lib/raid/xor/powerpc}/xor_vmx.h (100%)\n create mode 100644 lib/raid/xor/powerpc/xor_vmx_glue.c", "diff": "diff --git a/arch/powerpc/include/asm/xor.h b/arch/powerpc/include/asm/xor.h\nindex 30224c5279c4..3293ac87181c 100644\n--- a/arch/powerpc/include/asm/xor.h\n+++ b/arch/powerpc/include/asm/xor.h\n@@ -8,24 +8,11 @@\n #ifndef _ASM_POWERPC_XOR_H\n #define _ASM_POWERPC_XOR_H\n \n-#ifdef CONFIG_ALTIVEC\n-\n-#include <asm/cputable.h>\n #include <asm/cpu_has_feature.h>\n-#include <asm/xor_altivec.h>\n-\n-static struct xor_block_template xor_block_altivec = {\n-\t.name = \"altivec\",\n-\t.do_2 = xor_altivec_2,\n-\t.do_3 = xor_altivec_3,\n-\t.do_4 = xor_altivec_4,\n-\t.do_5 = xor_altivec_5,\n-};\n-#endif /* CONFIG_ALTIVEC */\n-\n-/* Also try the generic routines. */\n #include <asm-generic/xor.h>\n \n+extern struct xor_block_template xor_block_altivec;\n+\n #define arch_xor_init arch_xor_init\n static __always_inline void __init arch_xor_init(void)\n {\ndiff --git a/arch/powerpc/include/asm/xor_altivec.h b/arch/powerpc/include/asm/xor_altivec.h\ndeleted file mode 100644\nindex 294620a25f80..000000000000\n--- a/arch/powerpc/include/asm/xor_altivec.h\n+++ /dev/null\n@@ -1,22 +0,0 @@\n-/* SPDX-License-Identifier: GPL-2.0 */\n-#ifndef _ASM_POWERPC_XOR_ALTIVEC_H\n-#define _ASM_POWERPC_XOR_ALTIVEC_H\n-\n-#ifdef CONFIG_ALTIVEC\n-void xor_altivec_2(unsigned long bytes, unsigned long * __restrict p1,\n-\t\t const unsigned long * __restrict p2);\n-void xor_altivec_3(unsigned long bytes, unsigned long * __restrict p1,\n-\t\t const unsigned long * __restrict p2,\n-\t\t const unsigned long * __restrict p3);\n-void xor_altivec_4(unsigned long bytes, unsigned long * __restrict p1,\n-\t\t const unsigned long * __restrict p2,\n-\t\t const unsigned long * __restrict p3,\n-\t\t const unsigned long * __restrict p4);\n-void xor_altivec_5(unsigned long bytes, unsigned long * __restrict p1,\n-\t\t const unsigned long * __restrict p2,\n-\t\t const unsigned long * __restrict p3,\n-\t\t const unsigned long * __restrict p4,\n-\t\t const unsigned long * __restrict p5);\n-\n-#endif\n-#endif /* _ASM_POWERPC_XOR_ALTIVEC_H */\ndiff --git a/arch/powerpc/lib/Makefile b/arch/powerpc/lib/Makefile\nindex f14ecab674a3..002edc3f01d5 100644\n--- a/arch/powerpc/lib/Makefile\n+++ b/arch/powerpc/lib/Makefile\n@@ -73,9 +73,4 @@ obj-$(CONFIG_PPC_LIB_RHEAP) += rheap.o\n \n obj-$(CONFIG_FTR_FIXUP_SELFTEST) += feature-fixups-test.o\n \n-obj-$(CONFIG_ALTIVEC)\t+= xor_vmx.o xor_vmx_glue.o\n-CFLAGS_xor_vmx.o += -mhard-float -maltivec $(call cc-option,-mabi=altivec)\n-# Enable <altivec.h>\n-CFLAGS_xor_vmx.o += -isystem $(shell $(CC) -print-file-name=include)\n-\n obj-$(CONFIG_PPC64) += $(obj64-y)\ndiff --git a/arch/powerpc/lib/xor_vmx_glue.c b/arch/powerpc/lib/xor_vmx_glue.c\ndeleted file mode 100644\nindex 35d917ece4d1..000000000000\n--- a/arch/powerpc/lib/xor_vmx_glue.c\n+++ /dev/null\n@@ -1,63 +0,0 @@\n-// SPDX-License-Identifier: GPL-2.0-or-later\n-/*\n- * Altivec XOR operations\n- *\n- * Copyright 2017 IBM Corp.\n- */\n-\n-#include <linux/preempt.h>\n-#include <linux/export.h>\n-#include <linux/sched.h>\n-#include <asm/switch_to.h>\n-#include <asm/xor_altivec.h>\n-#include \"xor_vmx.h\"\n-\n-void xor_altivec_2(unsigned long bytes, unsigned long * __restrict p1,\n-\t\t const unsigned long * __restrict p2)\n-{\n-\tpreempt_disable();\n-\tenable_kernel_altivec();\n-\t__xor_altivec_2(bytes, p1, p2);\n-\tdisable_kernel_altivec();\n-\tpreempt_enable();\n-}\n-EXPORT_SYMBOL(xor_altivec_2);\n-\n-void xor_altivec_3(unsigned long bytes, unsigned long * __restrict p1,\n-\t\t const unsigned long * __restrict p2,\n-\t\t const unsigned long * __restrict p3)\n-{\n-\tpreempt_disable();\n-\tenable_kernel_altivec();\n-\t__xor_altivec_3(bytes, p1, p2, p3);\n-\tdisable_kernel_altivec();\n-\tpreempt_enable();\n-}\n-EXPORT_SYMBOL(xor_altivec_3);\n-\n-void xor_altivec_4(unsigned long bytes, unsigned long * __restrict p1,\n-\t\t const unsigned long * __restrict p2,\n-\t\t const unsigned long * __restrict p3,\n-\t\t const unsigned long * __restrict p4)\n-{\n-\tpreempt_disable();\n-\tenable_kernel_altivec();\n-\t__xor_altivec_4(bytes, p1, p2, p3, p4);\n-\tdisable_kernel_altivec();\n-\tpreempt_enable();\n-}\n-EXPORT_SYMBOL(xor_altivec_4);\n-\n-void xor_altivec_5(unsigned long bytes, unsigned long * __restrict p1,\n-\t\t const unsigned long * __restrict p2,\n-\t\t const unsigned long * __restrict p3,\n-\t\t const unsigned long * __restrict p4,\n-\t\t const unsigned long * __restrict p5)\n-{\n-\tpreempt_disable();\n-\tenable_kernel_altivec();\n-\t__xor_altivec_5(bytes, p1, p2, p3, p4, p5);\n-\tdisable_kernel_altivec();\n-\tpreempt_enable();\n-}\n-EXPORT_SYMBOL(xor_altivec_5);\ndiff --git a/lib/raid/xor/Makefile b/lib/raid/xor/Makefile\nindex e8868f5fc396..006b44ce46bf 100644\n--- a/lib/raid/xor/Makefile\n+++ b/lib/raid/xor/Makefile\n@@ -16,6 +16,7 @@ endif\n xor-$(CONFIG_ARM64)\t\t+= arm64/xor-neon.o arm64/xor-neon-glue.o\n xor-$(CONFIG_CPU_HAS_LSX)\t+= loongarch/xor_simd.o\n xor-$(CONFIG_CPU_HAS_LSX)\t+= loongarch/xor_simd_glue.o\n+xor-$(CONFIG_ALTIVEC)\t\t+= powerpc/xor_vmx.o powerpc/xor_vmx_glue.o\n \n \n CFLAGS_arm/xor-neon.o\t\t+= $(CC_FLAGS_FPU)\n@@ -23,3 +24,7 @@ CFLAGS_REMOVE_arm/xor-neon.o\t+= $(CC_FLAGS_NO_FPU)\n \n CFLAGS_arm64/xor-neon.o\t\t+= $(CC_FLAGS_FPU)\n CFLAGS_REMOVE_arm64/xor-neon.o\t+= $(CC_FLAGS_NO_FPU)\n+\n+CFLAGS_powerpc/xor_vmx.o\t+= -mhard-float -maltivec \\\n+\t\t\t\t $(call cc-option,-mabi=altivec) \\\n+\t\t\t\t -isystem $(shell $(CC) -print-file-name=include)\ndiff --git a/arch/powerpc/lib/xor_vmx.c b/lib/raid/xor/powerpc/xor_vmx.c\nsimilarity index 100%\nrename from arch/powerpc/lib/xor_vmx.c\nrename to lib/raid/xor/powerpc/xor_vmx.c\ndiff --git a/arch/powerpc/lib/xor_vmx.h b/lib/raid/xor/powerpc/xor_vmx.h\nsimilarity index 100%\nrename from arch/powerpc/lib/xor_vmx.h\nrename to lib/raid/xor/powerpc/xor_vmx.h\ndiff --git a/lib/raid/xor/powerpc/xor_vmx_glue.c b/lib/raid/xor/powerpc/xor_vmx_glue.c\nnew file mode 100644\nindex 000000000000..c41e38340700\n--- /dev/null\n+++ b/lib/raid/xor/powerpc/xor_vmx_glue.c\n@@ -0,0 +1,67 @@\n+// SPDX-License-Identifier: GPL-2.0-or-later\n+/*\n+ * Altivec XOR operations\n+ *\n+ * Copyright 2017 IBM Corp.\n+ */\n+\n+#include <linux/preempt.h>\n+#include <linux/sched.h>\n+#include <linux/raid/xor_impl.h>\n+#include <asm/switch_to.h>\n+#include <asm/xor.h>\n+#include \"xor_vmx.h\"\n+\n+static void xor_altivec_2(unsigned long bytes, unsigned long * __restrict p1,\n+\t\tconst unsigned long * __restrict p2)\n+{\n+\tpreempt_disable();\n+\tenable_kernel_altivec();\n+\t__xor_altivec_2(bytes, p1, p2);\n+\tdisable_kernel_altivec();\n+\tpreempt_enable();\n+}\n+\n+static void xor_altivec_3(unsigned long bytes, unsigned long * __restrict p1,\n+\t\tconst unsigned long * __restrict p2,\n+\t\tconst unsigned long * __restrict p3)\n+{\n+\tpreempt_disable();\n+\tenable_kernel_altivec();\n+\t__xor_altivec_3(bytes, p1, p2, p3);\n+\tdisable_kernel_altivec();\n+\tpreempt_enable();\n+}\n+\n+static void xor_altivec_4(unsigned long bytes, unsigned long * __restrict p1,\n+\t\tconst unsigned long * __restrict p2,\n+\t\tconst unsigned long * __restrict p3,\n+\t\tconst unsigned long * __restrict p4)\n+{\n+\tpreempt_disable();\n+\tenable_kernel_altivec();\n+\t__xor_altivec_4(bytes, p1, p2, p3, p4);\n+\tdisable_kernel_altivec();\n+\tpreempt_enable();\n+}\n+\n+static void xor_altivec_5(unsigned long bytes, unsigned long * __restrict p1,\n+\t\tconst unsigned long * __restrict p2,\n+\t\tconst unsigned long * __restrict p3,\n+\t\tconst unsigned long * __restrict p4,\n+\t\tconst unsigned long * __restrict p5)\n+{\n+\tpreempt_disable();\n+\tenable_kernel_altivec();\n+\t__xor_altivec_5(bytes, p1, p2, p3, p4, p5);\n+\tdisable_kernel_altivec();\n+\tpreempt_enable();\n+}\n+\n+struct xor_block_template xor_block_altivec = {\n+\t.name = \"altivec\",\n+\t.do_2 = xor_altivec_2,\n+\t.do_3 = xor_altivec_3,\n+\t.do_4 = xor_altivec_4,\n+\t.do_5 = xor_altivec_5,\n+};\n", "prefixes": [ "15/28" ] }