Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/2216716/?format=api
{ "id": 2216716, "url": "http://patchwork.ozlabs.org/api/patches/2216716/?format=api", "web_url": "http://patchwork.ozlabs.org/project/linux-um/patch/20260327061704.3707577-15-hch@lst.de/", "project": { "id": 60, "url": "http://patchwork.ozlabs.org/api/projects/60/?format=api", "name": "User-mode Linux Development", "link_name": "linux-um", "list_id": "linux-um.lists.infradead.org", "list_email": "linux-um@lists.infradead.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20260327061704.3707577-15-hch@lst.de>", "list_archive_url": null, "date": "2026-03-27T06:16:46", "name": "[14/28] loongarch: move the XOR code to lib/raid/", "commit_ref": null, "pull_url": null, "state": "not-applicable", "archived": false, "hash": "58d4b2f05a8623a2627cd58293ff5d387154acc0", "submitter": { "id": 82, "url": "http://patchwork.ozlabs.org/api/people/82/?format=api", "name": "Christoph Hellwig", "email": "hch@lst.de" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/linux-um/patch/20260327061704.3707577-15-hch@lst.de/mbox/", "series": [ { "id": 497692, "url": "http://patchwork.ozlabs.org/api/series/497692/?format=api", "web_url": "http://patchwork.ozlabs.org/project/linux-um/list/?series=497692", "date": "2026-03-27T06:16:33", "name": "[01/28] xor: assert that xor_blocks is not call from interrupt context", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/497692/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2216716/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2216716/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "\n <linux-um-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n secure) header.d=lists.infradead.org header.i=@lists.infradead.org\n header.a=rsa-sha256 header.s=bombadil.20210309 header.b=CO6BYP+I;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=none (no SPF record) smtp.mailfrom=lists.infradead.org\n (client-ip=2607:7c80:54:3::133; helo=bombadil.infradead.org;\n envelope-from=linux-um-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org;\n receiver=patchwork.ozlabs.org)" ], "Received": [ "from bombadil.infradead.org (bombadil.infradead.org\n [IPv6:2607:7c80:54:3::133])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fhr9x21RZz1xy1\n\tfor <incoming@patchwork.ozlabs.org>; Fri, 27 Mar 2026 17:20:53 +1100 (AEDT)", "from localhost ([::1] helo=bombadil.infradead.org)\n\tby bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux))\n\tid 1w60Yt-00000006mTC-2ucE;\n\tFri, 27 Mar 2026 06:20:51 +0000", "from\n 2a02-8389-2341-5b80-d601-7564-c2e0-491c.cable.dynamic.v6.surfer.at\n ([2a02:8389:2341:5b80:d601:7564:c2e0:491c] helo=localhost)\n\tby bombadil.infradead.org with esmtpsa (Exim 4.98.2 #2 (Red Hat Linux))\n\tid 1w60Yq-00000006mFy-0sTM;\n\tFri, 27 Mar 2026 06:20:48 +0000" ], "DKIM-Signature": "v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;\n\td=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help\n\t:List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding:\n\tMIME-Version:References:In-Reply-To:Message-ID:Date:Subject:Cc:To:From:\n\tReply-To:Content-Type:Content-ID:Content-Description:Resent-Date:Resent-From:\n\tResent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner;\n\tbh=gjX5FBygeWMjPukwqXaKShwz3C1U1AWYRymWZAxycrE=; b=CO6BYP+ITIsNu6XIJf5I/QKuq5\n\tsaJx5VFx+NOptWBOJaCp3Sgy1aPWjEBZNKt0nRZiZAUN9NtM7gaLifKll3ykjRvBQ7FTH4Au24ex2\n\twE/MzA79vuWvnXWmtAaH7TV7LO8uVWrxIZgjqacZq8m58fqYOAQwYfg8r8jkG64/47c2MaBMVbzbB\n\tndtrUjnYAzKwk2pQfz+Rz0S6i3TznFZqevVrEKk3kMF89u6kilplPw1HINYw2qlWPMTlsnCCOxP06\n\tSMblgLzZW2Cp4QHlVMF7EbaErBlI8LU0PMkRccbo8VUdQcyUBYhgZ/JsPlmi4Gu0r2K6lXB6wm1Us\n\thlm06wNA==;", "From": "Christoph Hellwig <hch@lst.de>", "To": "Andrew Morton <akpm@linux-foundation.org>", "Cc": "Richard Henderson <richard.henderson@linaro.org>,\n\tMatt Turner <mattst88@gmail.com>,\n\tMagnus Lindholm <linmag7@gmail.com>,\n\tRussell King <linux@armlinux.org.uk>,\n\tCatalin Marinas <catalin.marinas@arm.com>,\n\tWill Deacon <will@kernel.org>,\n\tArd Biesheuvel <ardb@kernel.org>,\n\tHuacai Chen <chenhuacai@kernel.org>,\n\tWANG Xuerui <kernel@xen0n.name>,\n\tMadhavan Srinivasan <maddy@linux.ibm.com>,\n\tMichael Ellerman <mpe@ellerman.id.au>,\n\tNicholas Piggin <npiggin@gmail.com>,\n\t\"Christophe Leroy (CS GROUP)\" <chleroy@kernel.org>,\n\tPaul Walmsley <pjw@kernel.org>,\n\tPalmer Dabbelt <palmer@dabbelt.com>,\n\tAlbert Ou <aou@eecs.berkeley.edu>,\n\tAlexandre Ghiti <alex@ghiti.fr>,\n\tHeiko Carstens <hca@linux.ibm.com>,\n\tVasily Gorbik <gor@linux.ibm.com>,\n\tAlexander Gordeev <agordeev@linux.ibm.com>,\n\tChristian Borntraeger <borntraeger@linux.ibm.com>,\n\tSven Schnelle <svens@linux.ibm.com>,\n\t\"David S. Miller\" <davem@davemloft.net>,\n\tAndreas Larsson <andreas@gaisler.com>,\n\tRichard Weinberger <richard@nod.at>,\n\tAnton Ivanov <anton.ivanov@cambridgegreys.com>,\n\tJohannes Berg <johannes@sipsolutions.net>,\n\tThomas Gleixner <tglx@kernel.org>,\n\tIngo Molnar <mingo@redhat.com>,\n\tBorislav Petkov <bp@alien8.de>,\n\tDave Hansen <dave.hansen@linux.intel.com>,\n\tx86@kernel.org,\n\t\"H. Peter Anvin\" <hpa@zytor.com>,\n\tHerbert Xu <herbert@gondor.apana.org.au>,\n\tDan Williams <dan.j.williams@intel.com>,\n\tChris Mason <clm@fb.com>,\n\tDavid Sterba <dsterba@suse.com>,\n\tArnd Bergmann <arnd@arndb.de>,\n\tSong Liu <song@kernel.org>,\n\tYu Kuai <yukuai@fnnas.com>,\n\tLi Nan <linan122@huawei.com>,\n\t\"Theodore Ts'o\" <tytso@mit.edu>,\n\t\"Jason A. Donenfeld\" <Jason@zx2c4.com>,\n\tlinux-alpha@vger.kernel.org,\n\tlinux-kernel@vger.kernel.org,\n\tlinux-arm-kernel@lists.infradead.org,\n\tloongarch@lists.linux.dev,\n\tlinuxppc-dev@lists.ozlabs.org,\n\tlinux-riscv@lists.infradead.org,\n\tlinux-s390@vger.kernel.org,\n\tsparclinux@vger.kernel.org,\n\tlinux-um@lists.infradead.org,\n\tlinux-crypto@vger.kernel.org,\n\tlinux-btrfs@vger.kernel.org,\n\tlinux-arch@vger.kernel.org,\n\tlinux-raid@vger.kernel.org", "Subject": "[PATCH 14/28] loongarch: move the XOR code to lib/raid/", "Date": "Fri, 27 Mar 2026 07:16:46 +0100", "Message-ID": "<20260327061704.3707577-15-hch@lst.de>", "X-Mailer": "git-send-email 2.47.3", "In-Reply-To": "<20260327061704.3707577-1-hch@lst.de>", "References": "<20260327061704.3707577-1-hch@lst.de>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "linux-um@lists.infradead.org", "X-Mailman-Version": "2.1.34", "Precedence": "list", "List-Id": "<linux-um.lists.infradead.org>", "List-Unsubscribe": "<http://lists.infradead.org/mailman/options/linux-um>,\n <mailto:linux-um-request@lists.infradead.org?subject=unsubscribe>", "List-Archive": "<http://lists.infradead.org/pipermail/linux-um/>", "List-Post": "<mailto:linux-um@lists.infradead.org>", "List-Help": "<mailto:linux-um-request@lists.infradead.org?subject=help>", "List-Subscribe": "<http://lists.infradead.org/mailman/listinfo/linux-um>,\n <mailto:linux-um-request@lists.infradead.org?subject=subscribe>", "Sender": "\"linux-um\" <linux-um-bounces@lists.infradead.org>", "Errors-To": "linux-um-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org" }, "content": "Move the optimized XOR into lib/raid and include it it in xor.ko\ninstead of always building it into the main kernel image.\n\nSigned-off-by: Christoph Hellwig <hch@lst.de>\n---\n arch/loongarch/include/asm/xor.h | 24 ++----------\n arch/loongarch/include/asm/xor_simd.h | 34 ----------------\n arch/loongarch/lib/Makefile | 2 -\n lib/raid/xor/Makefile | 2 +\n .../lib => lib/raid/xor/loongarch}/xor_simd.c | 0\n .../lib => lib/raid/xor/loongarch}/xor_simd.h | 0\n .../raid/xor/loongarch}/xor_simd_glue.c | 39 +++++++++++--------\n .../raid/xor/loongarch}/xor_template.c | 0\n 8 files changed, 27 insertions(+), 74 deletions(-)\n delete mode 100644 arch/loongarch/include/asm/xor_simd.h\n rename {arch/loongarch/lib => lib/raid/xor/loongarch}/xor_simd.c (100%)\n rename {arch/loongarch/lib => lib/raid/xor/loongarch}/xor_simd.h (100%)\n rename {arch/loongarch/lib => lib/raid/xor/loongarch}/xor_simd_glue.c (64%)\n rename {arch/loongarch/lib => lib/raid/xor/loongarch}/xor_template.c (100%)", "diff": "diff --git a/arch/loongarch/include/asm/xor.h b/arch/loongarch/include/asm/xor.h\nindex d17c0e3b047f..7e32f72f8b03 100644\n--- a/arch/loongarch/include/asm/xor.h\n+++ b/arch/loongarch/include/asm/xor.h\n@@ -6,27 +6,6 @@\n #define _ASM_LOONGARCH_XOR_H\n \n #include <asm/cpu-features.h>\n-#include <asm/xor_simd.h>\n-\n-#ifdef CONFIG_CPU_HAS_LSX\n-static struct xor_block_template xor_block_lsx = {\n-\t.name = \"lsx\",\n-\t.do_2 = xor_lsx_2,\n-\t.do_3 = xor_lsx_3,\n-\t.do_4 = xor_lsx_4,\n-\t.do_5 = xor_lsx_5,\n-};\n-#endif /* CONFIG_CPU_HAS_LSX */\n-\n-#ifdef CONFIG_CPU_HAS_LASX\n-static struct xor_block_template xor_block_lasx = {\n-\t.name = \"lasx\",\n-\t.do_2 = xor_lasx_2,\n-\t.do_3 = xor_lasx_3,\n-\t.do_4 = xor_lasx_4,\n-\t.do_5 = xor_lasx_5,\n-};\n-#endif /* CONFIG_CPU_HAS_LASX */\n \n /*\n * For grins, also test the generic routines.\n@@ -38,6 +17,9 @@ static struct xor_block_template xor_block_lasx = {\n */\n #include <asm-generic/xor.h>\n \n+extern struct xor_block_template xor_block_lsx;\n+extern struct xor_block_template xor_block_lasx;\n+\n #define arch_xor_init arch_xor_init\n static __always_inline void __init arch_xor_init(void)\n {\ndiff --git a/arch/loongarch/include/asm/xor_simd.h b/arch/loongarch/include/asm/xor_simd.h\ndeleted file mode 100644\nindex 471b96332f38..000000000000\n--- a/arch/loongarch/include/asm/xor_simd.h\n+++ /dev/null\n@@ -1,34 +0,0 @@\n-/* SPDX-License-Identifier: GPL-2.0-or-later */\n-/*\n- * Copyright (C) 2023 WANG Xuerui <git@xen0n.name>\n- */\n-#ifndef _ASM_LOONGARCH_XOR_SIMD_H\n-#define _ASM_LOONGARCH_XOR_SIMD_H\n-\n-#ifdef CONFIG_CPU_HAS_LSX\n-void xor_lsx_2(unsigned long bytes, unsigned long * __restrict p1,\n-\t const unsigned long * __restrict p2);\n-void xor_lsx_3(unsigned long bytes, unsigned long * __restrict p1,\n-\t const unsigned long * __restrict p2, const unsigned long * __restrict p3);\n-void xor_lsx_4(unsigned long bytes, unsigned long * __restrict p1,\n-\t const unsigned long * __restrict p2, const unsigned long * __restrict p3,\n-\t const unsigned long * __restrict p4);\n-void xor_lsx_5(unsigned long bytes, unsigned long * __restrict p1,\n-\t const unsigned long * __restrict p2, const unsigned long * __restrict p3,\n-\t const unsigned long * __restrict p4, const unsigned long * __restrict p5);\n-#endif /* CONFIG_CPU_HAS_LSX */\n-\n-#ifdef CONFIG_CPU_HAS_LASX\n-void xor_lasx_2(unsigned long bytes, unsigned long * __restrict p1,\n-\t const unsigned long * __restrict p2);\n-void xor_lasx_3(unsigned long bytes, unsigned long * __restrict p1,\n-\t const unsigned long * __restrict p2, const unsigned long * __restrict p3);\n-void xor_lasx_4(unsigned long bytes, unsigned long * __restrict p1,\n-\t const unsigned long * __restrict p2, const unsigned long * __restrict p3,\n-\t const unsigned long * __restrict p4);\n-void xor_lasx_5(unsigned long bytes, unsigned long * __restrict p1,\n-\t const unsigned long * __restrict p2, const unsigned long * __restrict p3,\n-\t const unsigned long * __restrict p4, const unsigned long * __restrict p5);\n-#endif /* CONFIG_CPU_HAS_LASX */\n-\n-#endif /* _ASM_LOONGARCH_XOR_SIMD_H */\ndiff --git a/arch/loongarch/lib/Makefile b/arch/loongarch/lib/Makefile\nindex ccea3bbd4353..827a88529a42 100644\n--- a/arch/loongarch/lib/Makefile\n+++ b/arch/loongarch/lib/Makefile\n@@ -8,6 +8,4 @@ lib-y\t+= delay.o memset.o memcpy.o memmove.o \\\n \n obj-$(CONFIG_ARCH_SUPPORTS_INT128) += tishift.o\n \n-obj-$(CONFIG_CPU_HAS_LSX) += xor_simd.o xor_simd_glue.o\n-\n obj-$(CONFIG_FUNCTION_ERROR_INJECTION) += error-inject.o\ndiff --git a/lib/raid/xor/Makefile b/lib/raid/xor/Makefile\nindex 4ab0e7411ff7..e8868f5fc396 100644\n--- a/lib/raid/xor/Makefile\n+++ b/lib/raid/xor/Makefile\n@@ -14,6 +14,8 @@ ifeq ($(CONFIG_ARM),y)\n xor-$(CONFIG_KERNEL_MODE_NEON)\t+= arm/xor-neon.o arm/xor-neon-glue.o\n endif\n xor-$(CONFIG_ARM64)\t\t+= arm64/xor-neon.o arm64/xor-neon-glue.o\n+xor-$(CONFIG_CPU_HAS_LSX)\t+= loongarch/xor_simd.o\n+xor-$(CONFIG_CPU_HAS_LSX)\t+= loongarch/xor_simd_glue.o\n \n \n CFLAGS_arm/xor-neon.o\t\t+= $(CC_FLAGS_FPU)\ndiff --git a/arch/loongarch/lib/xor_simd.c b/lib/raid/xor/loongarch/xor_simd.c\nsimilarity index 100%\nrename from arch/loongarch/lib/xor_simd.c\nrename to lib/raid/xor/loongarch/xor_simd.c\ndiff --git a/arch/loongarch/lib/xor_simd.h b/lib/raid/xor/loongarch/xor_simd.h\nsimilarity index 100%\nrename from arch/loongarch/lib/xor_simd.h\nrename to lib/raid/xor/loongarch/xor_simd.h\ndiff --git a/arch/loongarch/lib/xor_simd_glue.c b/lib/raid/xor/loongarch/xor_simd_glue.c\nsimilarity index 64%\nrename from arch/loongarch/lib/xor_simd_glue.c\nrename to lib/raid/xor/loongarch/xor_simd_glue.c\nindex 393f689dbcf6..11fa3b47ba83 100644\n--- a/arch/loongarch/lib/xor_simd_glue.c\n+++ b/lib/raid/xor/loongarch/xor_simd_glue.c\n@@ -5,24 +5,23 @@\n * Copyright (C) 2023 WANG Xuerui <git@xen0n.name>\n */\n \n-#include <linux/export.h>\n #include <linux/sched.h>\n+#include <linux/raid/xor_impl.h>\n #include <asm/fpu.h>\n-#include <asm/xor_simd.h>\n+#include <asm/xor.h>\n #include \"xor_simd.h\"\n \n #define MAKE_XOR_GLUE_2(flavor)\t\t\t\t\t\t\t\\\n-void xor_##flavor##_2(unsigned long bytes, unsigned long * __restrict p1,\t\\\n+static void xor_##flavor##_2(unsigned long bytes, unsigned long * __restrict p1,\\\n \t\t const unsigned long * __restrict p2)\t\t\t\\\n {\t\t\t\t\t\t\t\t\t\t\\\n \tkernel_fpu_begin();\t\t\t\t\t\t\t\\\n \t__xor_##flavor##_2(bytes, p1, p2);\t\t\t\t\t\\\n \tkernel_fpu_end();\t\t\t\t\t\t\t\\\n }\t\t\t\t\t\t\t\t\t\t\\\n-EXPORT_SYMBOL_GPL(xor_##flavor##_2)\n \n #define MAKE_XOR_GLUE_3(flavor)\t\t\t\t\t\t\t\\\n-void xor_##flavor##_3(unsigned long bytes, unsigned long * __restrict p1,\t\\\n+static void xor_##flavor##_3(unsigned long bytes, unsigned long * __restrict p1,\\\n \t\t const unsigned long * __restrict p2,\t\t\t\\\n \t\t const unsigned long * __restrict p3)\t\t\t\\\n {\t\t\t\t\t\t\t\t\t\t\\\n@@ -30,10 +29,9 @@ void xor_##flavor##_3(unsigned long bytes, unsigned long * __restrict p1,\t\\\n \t__xor_##flavor##_3(bytes, p1, p2, p3);\t\t\t\t\t\\\n \tkernel_fpu_end();\t\t\t\t\t\t\t\\\n }\t\t\t\t\t\t\t\t\t\t\\\n-EXPORT_SYMBOL_GPL(xor_##flavor##_3)\n \n #define MAKE_XOR_GLUE_4(flavor)\t\t\t\t\t\t\t\\\n-void xor_##flavor##_4(unsigned long bytes, unsigned long * __restrict p1,\t\\\n+static void xor_##flavor##_4(unsigned long bytes, unsigned long * __restrict p1,\\\n \t\t const unsigned long * __restrict p2,\t\t\t\\\n \t\t const unsigned long * __restrict p3,\t\t\t\\\n \t\t const unsigned long * __restrict p4)\t\t\t\\\n@@ -42,10 +40,9 @@ void xor_##flavor##_4(unsigned long bytes, unsigned long * __restrict p1,\t\\\n \t__xor_##flavor##_4(bytes, p1, p2, p3, p4);\t\t\t\t\\\n \tkernel_fpu_end();\t\t\t\t\t\t\t\\\n }\t\t\t\t\t\t\t\t\t\t\\\n-EXPORT_SYMBOL_GPL(xor_##flavor##_4)\n \n #define MAKE_XOR_GLUE_5(flavor)\t\t\t\t\t\t\t\\\n-void xor_##flavor##_5(unsigned long bytes, unsigned long * __restrict p1,\t\\\n+static void xor_##flavor##_5(unsigned long bytes, unsigned long * __restrict p1,\\\n \t\t const unsigned long * __restrict p2,\t\t\t\\\n \t\t const unsigned long * __restrict p3,\t\t\t\\\n \t\t const unsigned long * __restrict p4,\t\t\t\\\n@@ -55,18 +52,26 @@ void xor_##flavor##_5(unsigned long bytes, unsigned long * __restrict p1,\t\\\n \t__xor_##flavor##_5(bytes, p1, p2, p3, p4, p5);\t\t\t\t\\\n \tkernel_fpu_end();\t\t\t\t\t\t\t\\\n }\t\t\t\t\t\t\t\t\t\t\\\n-EXPORT_SYMBOL_GPL(xor_##flavor##_5)\n \n-#define MAKE_XOR_GLUES(flavor)\t\t\\\n-\tMAKE_XOR_GLUE_2(flavor);\t\\\n-\tMAKE_XOR_GLUE_3(flavor);\t\\\n-\tMAKE_XOR_GLUE_4(flavor);\t\\\n-\tMAKE_XOR_GLUE_5(flavor)\n+#define MAKE_XOR_GLUES(flavor)\t\t\t\t\\\n+\tMAKE_XOR_GLUE_2(flavor);\t\t\t\\\n+\tMAKE_XOR_GLUE_3(flavor);\t\t\t\\\n+\tMAKE_XOR_GLUE_4(flavor);\t\t\t\\\n+\tMAKE_XOR_GLUE_5(flavor);\t\t\t\\\n+\t\t\t\t\t\t\t\\\n+struct xor_block_template xor_block_##flavor = {\t\\\n+\t.name = __stringify(flavor),\t\t\t\\\n+\t.do_2 = xor_##flavor##_2,\t\t\t\\\n+\t.do_3 = xor_##flavor##_3,\t\t\t\\\n+\t.do_4 = xor_##flavor##_4,\t\t\t\\\n+\t.do_5 = xor_##flavor##_5,\t\t\t\\\n+}\n+\n \n #ifdef CONFIG_CPU_HAS_LSX\n MAKE_XOR_GLUES(lsx);\n-#endif\n+#endif /* CONFIG_CPU_HAS_LSX */\n \n #ifdef CONFIG_CPU_HAS_LASX\n MAKE_XOR_GLUES(lasx);\n-#endif\n+#endif /* CONFIG_CPU_HAS_LASX */\ndiff --git a/arch/loongarch/lib/xor_template.c b/lib/raid/xor/loongarch/xor_template.c\nsimilarity index 100%\nrename from arch/loongarch/lib/xor_template.c\nrename to lib/raid/xor/loongarch/xor_template.c\n", "prefixes": [ "14/28" ] }