Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/2216589/?format=api
{ "id": 2216589, "url": "http://patchwork.ozlabs.org/api/patches/2216589/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20260326210532.379027-11-peterx@redhat.com/", "project": { "id": 14, "url": "http://patchwork.ozlabs.org/api/projects/14/?format=api", "name": "QEMU Development", "link_name": "qemu-devel", "list_id": "qemu-devel.nongnu.org", "list_email": "qemu-devel@nongnu.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20260326210532.379027-11-peterx@redhat.com>", "list_archive_url": null, "date": "2026-03-26T21:05:31", "name": "[RFC,v2,10/11] vmstate: Stop checking size for nullptr compression", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "3c6eceeb1e8522ffc1a1673f455983c2a951d057", "submitter": { "id": 67717, "url": "http://patchwork.ozlabs.org/api/people/67717/?format=api", "name": "Peter Xu", "email": "peterx@redhat.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20260326210532.379027-11-peterx@redhat.com/mbox/", "series": [ { "id": 497651, "url": "http://patchwork.ozlabs.org/api/series/497651/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/list/?series=497651", "date": "2026-03-26T21:05:22", "name": "vmstate: Implement VMS_ARRAY_OF_POINTER_AUTO_ALLOC", "version": 2, "mbox": "http://patchwork.ozlabs.org/series/497651/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2216589/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2216589/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=mimecast20190719 header.b=Dsv0NW9V;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=google header.b=RLknSWMG;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)" ], "Received": [ "from lists.gnu.org (lists.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fhbvQ5vkCz1y1j\n\tfor <incoming@patchwork.ozlabs.org>; Fri, 27 Mar 2026 08:07:30 +1100 (AEDT)", "from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from <qemu-devel-bounces@nongnu.org>)\n\tid 1w5rtt-0004Ap-JA; Thu, 26 Mar 2026 17:05:57 -0400", "from eggs.gnu.org ([2001:470:142:3::10])\n by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <peterx@redhat.com>) id 1w5rto-00049J-Bi\n for qemu-devel@nongnu.org; Thu, 26 Mar 2026 17:05:52 -0400", "from us-smtp-delivery-124.mimecast.com ([170.10.133.124])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <peterx@redhat.com>) id 1w5rtn-00038N-0k\n for qemu-devel@nongnu.org; Thu, 26 Mar 2026 17:05:52 -0400", "from mail-qk1-f199.google.com (mail-qk1-f199.google.com\n [209.85.222.199]) by relay.mimecast.com with ESMTP with STARTTLS\n (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id\n us-mta-630-5L501rjRPY-PKxq6YZvyHg-1; Thu, 26 Mar 2026 17:05:49 -0400", "by mail-qk1-f199.google.com with SMTP id\n af79cd13be357-8cb706313beso250159285a.3\n for <qemu-devel@nongnu.org>; Thu, 26 Mar 2026 14:05:49 -0700 (PDT)", "from x1.com ([142.189.10.167]) by smtp.gmail.com with ESMTPSA id\n af79cd13be357-8d00e4fa7d9sm353479785a.32.2026.03.26.14.05.46\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Thu, 26 Mar 2026 14:05:47 -0700 (PDT)" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n s=mimecast20190719; t=1774559150;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:cc:mime-version:mime-version:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=Xl4BeA9TjT4adRjjwuVr5ck8x18mt6Jrccqdq1Pqh9U=;\n b=Dsv0NW9VMPdkxo9LcUYol7hlaBUiBN+UJfoO8QgMe/tjVqymEueu2HFLiI+TxY5wPqGiqn\n 0krT6JhFs1i0XZPJ2G/S4AAwdZMV3t0rBsIRLKV2FJpib9jxYxuANQ17DgduOSsR28Nz/X\n y6+eNVOvxSCcptJglzikAGtUQLX+2fI=", "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=redhat.com; s=google; t=1774559148; x=1775163948; darn=nongnu.org;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:from:to:cc:subject:date\n :message-id:reply-to;\n bh=Xl4BeA9TjT4adRjjwuVr5ck8x18mt6Jrccqdq1Pqh9U=;\n b=RLknSWMGyC/CqluCmFJ2jn/cghqwN4Cxtl7UNIo3tKqt+KlYcOqL+1Y7J/ywFUpEPT\n NrYx72f17Qq+N5bBkPlZGagmZ/dJaKqdwGSYq5FTjWnqz5EwTguDTvE8xWxvO7Cr/KQO\n hhnR2P06Lxt9SeIKstgVAU3Lm6GUBmh6JuNgUYBZrwzxpkrJMN64OubAOVwniTQEPVF7\n WnVleLDyuFVAGqf3OpX6U9r2Ox4ZEX8sUL6HKw+1LxnXMfeJkJqjBReSZun2fQQ6c6To\n jEAuNqVjmVNXG1lYGJyyzrwPClQANV42+DxCCD6/MuOL6HOgwXKbNrXna3j28zlSjwP3\n fK0g==" ], "X-MC-Unique": "5L501rjRPY-PKxq6YZvyHg-1", "X-Mimecast-MFC-AGG-ID": "5L501rjRPY-PKxq6YZvyHg_1774559149", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1774559148; x=1775163948;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from\n :to:cc:subject:date:message-id:reply-to;\n bh=Xl4BeA9TjT4adRjjwuVr5ck8x18mt6Jrccqdq1Pqh9U=;\n b=L1hBtHDQD82VKVanfdQsLdVUtQOzHHrGtOa/7a9APe/S7xOtmifUtlRkWnFvEa3jsc\n EiIu2pLv7nr9L3mjmYoASY2l6dlMx0WuurcO1lgM1ZmDwTloFel5o0EqPA1W/rB8xHyr\n 29VP26MIkSNJm6Bt03pJGh5h8ampL68yDalSeuqwg7bfwu3jyfU+mNmRsCkO2Didt17g\n pUdAwhU2/v0XksjzQ+jf2jleQMupUV3x6jkJmGifaYlxmiu6BbLDxt56IL/Gof2t+qtD\n AzMsJyKY/2BMld7nVMDHdpGdS1HZRxZ0EiMWSY7c0+2Z/qyUYJhKTLokYkFW2Ivi6zgK\n /McQ==", "X-Gm-Message-State": "AOJu0YzQwKdYM2DASQROQYJFfpbxdkZfnngIouvqEF12+feU59cXqxCC\n 6HV5DaOY9JgVf5hlp6ErGaohYhrUec6y784UqB7XQUpQ92H+RXipqwEDO/4Wl4hoEZt2NtT+gjx\n Rdo3Z3O6eJe0BoEtathdu0EfCDOrBO5wqdHtjw343HAjqsz03Scrf2Ykaxg3HCZGSbuY6W6bucs\n SFZgMZPtFUFSIKZYdv/GxaPvJU9hFRlbztIMQ/5A==", "X-Gm-Gg": "ATEYQzzvJGi1BqOYL0P7DU30QyZaVzKEwjejNq/N/Fr9Zm9fnLl2vFXJkAWZYKYMGNC\n EVwUNEPvBdWAU5VevRKVRev/95kxm0QrFLzSfall6pDCj8RtwyV3O0qH+IifiTZVjONwuoL8vxF\n aLboWfunh0/J/kqifuQj1irZ85FGDGZ/uo3djWQ507boU2C8NVJd3k5FawX7YX+wYFhR/CFGQbe\n eV+2ujBCY2smm9yNUo8dN6i38q+m8z/qLTElKUKfeSg2djH3vgazI+ELYmA3xVOOoKbGYCNAAy/\n TmZwO3Ei9YnvIaps4mvWvxf7BVs4NRYJFejEZlb66ZpRsfl+8ndY6qkwtGvYyhlro+n5f/GkxJm\n oPfKRA9k+IwQ=", "X-Received": [ "by 2002:a05:620a:400b:b0:8cd:b61f:2f48 with SMTP id\n af79cd13be357-8d00100bc68mr1252415785a.42.1774559148325;\n Thu, 26 Mar 2026 14:05:48 -0700 (PDT)", "by 2002:a05:620a:400b:b0:8cd:b61f:2f48 with SMTP id\n af79cd13be357-8d00100bc68mr1252410185a.42.1774559147640;\n Thu, 26 Mar 2026 14:05:47 -0700 (PDT)" ], "From": "Peter Xu <peterx@redhat.com>", "To": "qemu-devel@nongnu.org", "Cc": "Alexander Mikhalitsyn <alexander@mihalicyn.com>, peterx@redhat.com,\n Fabiano Rosas <farosas@suse.de>, Juraj Marcin <jmarcin@redhat.com>", "Subject": "[PATCH RFC v2 10/11] vmstate: Stop checking size for nullptr\n compression", "Date": "Thu, 26 Mar 2026 17:05:31 -0400", "Message-ID": "<20260326210532.379027-11-peterx@redhat.com>", "X-Mailer": "git-send-email 2.50.1", "In-Reply-To": "<20260326210532.379027-1-peterx@redhat.com>", "References": "<20260326210532.379027-1-peterx@redhat.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Received-SPF": "pass client-ip=170.10.133.124; envelope-from=peterx@redhat.com;\n helo=us-smtp-delivery-124.mimecast.com", "X-Spam_score_int": "-20", "X-Spam_score": "-2.1", "X-Spam_bar": "--", "X-Spam_report": "(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001,\n DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=0.001,\n RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001,\n SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no", "X-Spam_action": "no action", "X-BeenThere": "qemu-devel@nongnu.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "qemu development <qemu-devel.nongnu.org>", "List-Unsubscribe": "<https://lists.nongnu.org/mailman/options/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>", "List-Archive": "<https://lists.nongnu.org/archive/html/qemu-devel>", "List-Post": "<mailto:qemu-devel@nongnu.org>", "List-Help": "<mailto:qemu-devel-request@nongnu.org?subject=help>", "List-Subscribe": "<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=subscribe>", "Errors-To": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org", "Sender": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org" }, "content": "From: Fabiano Rosas <farosas@suse.de>\n\nThe NULL pointer marker code applies only to VMS_ARRAY_OF_POINTER,\nwhere the size is never NULL. Move the setting of is_null under\nVMS_ARRAY_OF_POINTER, so we can stop checking the size.\n\nSigned-off-by: Fabiano Rosas <farosas@suse.de>\nSigned-off-by: Peter Xu <peterx@redhat.com>\n---\n migration/vmstate.c | 6 +++---\n 1 file changed, 3 insertions(+), 3 deletions(-)", "diff": "diff --git a/migration/vmstate.c b/migration/vmstate.c\nindex 9cd0a88ce9..1923602f3b 100644\n--- a/migration/vmstate.c\n+++ b/migration/vmstate.c\n@@ -673,14 +673,14 @@ static bool vmstate_save_vmsd_v(QEMUFile *f, const VMStateDescription *vmsd,\n const VMStateField *inner_field;\n /* maximum number of elements to compress in the JSON blob */\n int max_elems = vmsd_can_compress(field) ? (n_elems - i) : 1;\n- bool use_marker_field, is_null;\n+ bool use_marker_field, is_null = false;\n \n if (field->flags & VMS_ARRAY_OF_POINTER) {\n assert(curr_elem);\n curr_elem = *(void **)curr_elem;\n+ is_null = !curr_elem;\n }\n \n- is_null = !curr_elem && size;\n use_marker_field = use_dynamic_array || is_null;\n \n if (use_marker_field) {\n@@ -708,7 +708,7 @@ static bool vmstate_save_vmsd_v(QEMUFile *f, const VMStateDescription *vmsd,\n \n for (int j = i + 1; j < n_elems; j++) {\n void *elem = *(void **)(first_elem + size * j);\n- bool elem_is_null = !elem && size;\n+ bool elem_is_null = !elem;\n \n if (is_null != elem_is_null) {\n max_elems = j - i;\n", "prefixes": [ "RFC", "v2", "10/11" ] }