Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/2216585/?format=api
{ "id": 2216585, "url": "http://patchwork.ozlabs.org/api/patches/2216585/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20260326210532.379027-12-peterx@redhat.com/", "project": { "id": 14, "url": "http://patchwork.ozlabs.org/api/projects/14/?format=api", "name": "QEMU Development", "link_name": "qemu-devel", "list_id": "qemu-devel.nongnu.org", "list_email": "qemu-devel@nongnu.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20260326210532.379027-12-peterx@redhat.com>", "list_archive_url": null, "date": "2026-03-26T21:05:32", "name": "[RFC,v2,11/11] tests/unit/test-vmstate: add tests for VMS_ARRAY_OF_POINTER_AUTO_ALLOC", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "89bcfc78366e09990fcb9c2e4850a62762436102", "submitter": { "id": 67717, "url": "http://patchwork.ozlabs.org/api/people/67717/?format=api", "name": "Peter Xu", "email": "peterx@redhat.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20260326210532.379027-12-peterx@redhat.com/mbox/", "series": [ { "id": 497651, "url": "http://patchwork.ozlabs.org/api/series/497651/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/list/?series=497651", "date": "2026-03-26T21:05:22", "name": "vmstate: Implement VMS_ARRAY_OF_POINTER_AUTO_ALLOC", "version": 2, "mbox": "http://patchwork.ozlabs.org/series/497651/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2216585/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2216585/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=mimecast20190719 header.b=EBmXSVH3;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=google header.b=ATCQ2GNE;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)" ], "Received": [ "from lists.gnu.org (lists.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fhbvD42xlz1yFr\n\tfor <incoming@patchwork.ozlabs.org>; Fri, 27 Mar 2026 08:07:20 +1100 (AEDT)", "from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from <qemu-devel-bounces@nongnu.org>)\n\tid 1w5rtt-0004B5-TF; Thu, 26 Mar 2026 17:05:57 -0400", "from eggs.gnu.org ([2001:470:142:3::10])\n by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <peterx@redhat.com>) id 1w5rtq-0004A0-SL\n for qemu-devel@nongnu.org; Thu, 26 Mar 2026 17:05:55 -0400", "from us-smtp-delivery-124.mimecast.com ([170.10.129.124])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <peterx@redhat.com>) id 1w5rtp-00039Y-6K\n for qemu-devel@nongnu.org; Thu, 26 Mar 2026 17:05:54 -0400", "from mail-qv1-f72.google.com (mail-qv1-f72.google.com\n [209.85.219.72]) by relay.mimecast.com with ESMTP with STARTTLS\n (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id\n us-mta-187-Aiqq05axPSWobj6hgbuy8A-1; Thu, 26 Mar 2026 17:05:50 -0400", "by mail-qv1-f72.google.com with SMTP id\n 6a1803df08f44-89c4ec516e5so62601016d6.0\n for <qemu-devel@nongnu.org>; Thu, 26 Mar 2026 14:05:50 -0700 (PDT)", "from x1.com ([142.189.10.167]) by smtp.gmail.com with ESMTPSA id\n af79cd13be357-8d00e4fa7d9sm353479785a.32.2026.03.26.14.05.47\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Thu, 26 Mar 2026 14:05:48 -0700 (PDT)" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n s=mimecast20190719; t=1774559152;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:cc:mime-version:mime-version:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=BTcRRki4RVI+IH0q3dAynZQWyxZQTTE18znN3ItjLD4=;\n b=EBmXSVH3I9o/i6OYM80KziZ+6GuoCR3ItrDzblS2vIHBMhgdDhNfhszFUhMcMl7twxVFa6\n aEhdm1fyfJPC2ZRTaLM9ep0Yjm8RT59sS/zs7zxpAkhl7p1kRp98azti1Iub+QGen4wnPV\n s/pFmz5Ia7HRtIOBJftebREyrg75tqM=", "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=redhat.com; s=google; t=1774559150; x=1775163950; darn=nongnu.org;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:from:to:cc:subject:date\n :message-id:reply-to;\n bh=BTcRRki4RVI+IH0q3dAynZQWyxZQTTE18znN3ItjLD4=;\n b=ATCQ2GNE5zCX9ltgtp8JrzwulO2Nmq5wvAbnqD2F2GMEkTA89M6j8+lFWFOFJW8HTV\n TyiBhjhwjzFoy9VMNwKm62vYww8D2ukuTjHsloumiONBfnbHrfOQMj6U0qna6CYaZvSz\n F/VHw97bn9/eRDI0ns0OA/lCh8pt/IOWHT/mezskwEeQBB0/LRZLq7AfUKiwdQG0jf7R\n 9LMGWXq9MZitf31yU190kq+e++KqYHrOXZBckbQ0nb0YqI1vwz5Iuq9JZpRURDRI88zF\n YwTVWVfEKaClKNE54zNEXEdMiOlfi3PSI/yB7Y4YPxORihf2ktSIGSxmmsXmzaMdZttr\n oORA==" ], "X-MC-Unique": "Aiqq05axPSWobj6hgbuy8A-1", "X-Mimecast-MFC-AGG-ID": "Aiqq05axPSWobj6hgbuy8A_1774559150", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1774559150; x=1775163950;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from\n :to:cc:subject:date:message-id:reply-to;\n bh=BTcRRki4RVI+IH0q3dAynZQWyxZQTTE18znN3ItjLD4=;\n b=rjZSp81mc8L3AraJ7oTv1Shp//7kpVZotI0UA8aXQ9an8Di1ZJxpFd/sxvk4CFXMuf\n dKlb9VBl1IQpaWxMQkOE3FnNNUXD2EXiBBAJKJNOVuOzEAwpr0LIr+GOh+VjkxmXJI1K\n qY3F5izN0ayFuNhw+vfYo0DUWo+WtC3+ntG58M5dqB45WQuyc2qrmEgMFORQzz8oS7zc\n xn2+aTTbahHCYhXOGLJdkVApBTInhrlX76tmFhE4ZoTYvMREZg910NPX2BRCwz5VWCbO\n clL3WXBT9rD9J2uevlAw0Ey3EFsEVjZCyBMHYZzxToE67heR283cxc+HUvOBhiipCqL4\n muMg==", "X-Gm-Message-State": "AOJu0Yx2ZLww8YYcEeE4uAzYDqWfa6ZyGqmydvScuc0PEPoz610poNEP\n zqePeYFptNLIC92gB9P+h++zEdOUeIp/vjafgaAjQO0gE5p6tzjVT0lObY935F329TGbz23RPyQ\n QBY1uWjs/SaHUQEeYxneZKPfq1GLr3vagplxii7Pso8HHD5QjjWwP+9uhUkL4g5AIFlNVoa7ZPr\n Rev8CapoRFqp5pCF6tCjn6F0h3+Kp5rbkQL2pKmA==", "X-Gm-Gg": "ATEYQzyqAxwNQzx1zMIaLzF/gbC4ydSn7tk0LTauxIFjV0yMzYCGf3ojkk/Gx89254a\n 0VFXnUbGK83MPUvUJNQL4DQcoZK8ysSf0g4r+Hm22BcwYOQoNGmsemMxF1ggVvMpUp8g9QVzJp3\n NwfIihR4u+lofgQ5rrYLv06QUgW2mY6yVOqsiAZXjmAZGY4ue/OwS1jcJDwQMdOzbXPMQ6YL/iu\n BPKdJO9DH00fXkgsjTxBq+oV+d1qAXqDqQgjWf9LtDc8DLAzSCaRrcM3OJob0UixRD+djpNBt93\n ywSA32xLXNYETWtnd+CS3PNdcgdmPXK7l84HJVwMNkWVnhQs1wl0ogpSlxmUMs76/BpxwYvrScC\n OjrOBkcXfCP4=", "X-Received": [ "by 2002:a05:620a:4449:b0:8cf:d469:8456 with SMTP id\n af79cd13be357-8d000f85e87mr1224703785a.4.1774559149547;\n Thu, 26 Mar 2026 14:05:49 -0700 (PDT)", "by 2002:a05:620a:4449:b0:8cf:d469:8456 with SMTP id\n af79cd13be357-8d000f85e87mr1224696785a.4.1774559148749;\n Thu, 26 Mar 2026 14:05:48 -0700 (PDT)" ], "From": "Peter Xu <peterx@redhat.com>", "To": "qemu-devel@nongnu.org", "Cc": "Alexander Mikhalitsyn <alexander@mihalicyn.com>, peterx@redhat.com,\n Fabiano Rosas <farosas@suse.de>, Juraj Marcin <jmarcin@redhat.com>,\n Alexander Mikhalitsyn <aleksandr.mikhalitsyn@futurfusion.io>", "Subject": "[PATCH RFC v2 11/11] tests/unit/test-vmstate: add tests for\n VMS_ARRAY_OF_POINTER_AUTO_ALLOC", "Date": "Thu, 26 Mar 2026 17:05:32 -0400", "Message-ID": "<20260326210532.379027-12-peterx@redhat.com>", "X-Mailer": "git-send-email 2.50.1", "In-Reply-To": "<20260326210532.379027-1-peterx@redhat.com>", "References": "<20260326210532.379027-1-peterx@redhat.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Received-SPF": "pass client-ip=170.10.129.124; envelope-from=peterx@redhat.com;\n helo=us-smtp-delivery-124.mimecast.com", "X-Spam_score_int": "-20", "X-Spam_score": "-2.1", "X-Spam_bar": "--", "X-Spam_report": "(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001,\n DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=0.001,\n RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001,\n SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no", "X-Spam_action": "no action", "X-BeenThere": "qemu-devel@nongnu.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "qemu development <qemu-devel.nongnu.org>", "List-Unsubscribe": "<https://lists.nongnu.org/mailman/options/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>", "List-Archive": "<https://lists.nongnu.org/archive/html/qemu-devel>", "List-Post": "<mailto:qemu-devel@nongnu.org>", "List-Help": "<mailto:qemu-devel-request@nongnu.org?subject=help>", "List-Subscribe": "<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=subscribe>", "Errors-To": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org", "Sender": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org" }, "content": "From: Alexander Mikhalitsyn <aleksandr.mikhalitsyn@futurfusion.io>\n\nAdd tests for VMSTATE_VARRAY_OF_POINTER_TO_STRUCT_UINT32_ALLOC.\n\nSigned-off-by: Alexander Mikhalitsyn <aleksandr.mikhalitsyn@futurfusion.io>\n[peterx: Removed two tests due to macro not used, rebase, fix warning]\nSigned-off-by: Peter Xu <peterx@redhat.com>\n---\n tests/unit/test-vmstate.c | 86 +++++++++++++++++++++++++++++++++++++++\n 1 file changed, 86 insertions(+)", "diff": "diff --git a/tests/unit/test-vmstate.c b/tests/unit/test-vmstate.c\nindex dae15786aa..df1fb4c778 100644\n--- a/tests/unit/test-vmstate.c\n+++ b/tests/unit/test-vmstate.c\n@@ -702,6 +702,88 @@ static void test_arr_ptr_prim_0_load(void)\n }\n }\n \n+static uint8_t wire_arr_ptr_with_nulls[] = {\n+ VMS_MARKER_PTR_VALID,\n+ 0x00, 0x00, 0x00, 0x00,\n+ VMS_MARKER_PTR_NULL,\n+ VMS_MARKER_PTR_VALID,\n+ 0x00, 0x00, 0x00, 0x02,\n+ VMS_MARKER_PTR_VALID,\n+ 0x00, 0x00, 0x00, 0x03,\n+ QEMU_VM_EOF\n+};\n+\n+typedef struct {\n+ uint32_t ar_items_num;\n+ TestStructTriv **ar;\n+} TestVArrayOfPtrToStuctWithNULLs;\n+\n+const VMStateDescription vmsd_arps_with_nulls = {\n+ .name = \"test/arps_with_nulls\",\n+ .version_id = 1,\n+ .minimum_version_id = 1,\n+ .fields = (const VMStateField[]) {\n+ VMSTATE_VARRAY_OF_POINTER_TO_STRUCT_UINT32_ALLOC(\n+ ar, TestVArrayOfPtrToStuctWithNULLs, ar_items_num,\n+ 0, vmsd_tst, TestStructTriv),\n+ VMSTATE_END_OF_LIST()\n+ }\n+};\n+\n+static void test_arr_ptr_nulls_str_save(void)\n+{\n+ TestStructTriv ar[AR_SIZE] = { {.i = 0}, {.i = 1}, {.i = 2}, {.i = 3} };\n+ TestVArrayOfPtrToStuctWithNULLs sample = {};\n+ int idx;\n+\n+ sample.ar_items_num = AR_SIZE;\n+ sample.ar = g_new0(TestStructTriv*, sample.ar_items_num);\n+ sample.ar[0] = g_new0(TestStructTriv, 1);\n+ *sample.ar[0] = ar[0];\n+ /* note, sample.ar[1] remains NULL */\n+ sample.ar[2] = g_new0(TestStructTriv, 1);\n+ *sample.ar[2] = ar[2];\n+ sample.ar[3] = g_new0(TestStructTriv, 1);\n+ *sample.ar[3] = ar[3];\n+\n+ save_vmstate(&vmsd_arps_with_nulls, &sample);\n+ compare_vmstate(wire_arr_ptr_with_nulls, sizeof(wire_arr_ptr_with_nulls));\n+\n+ for (idx = 0; idx < AR_SIZE; ++idx) {\n+ g_free(sample.ar[idx]);\n+ }\n+ g_free(sample.ar);\n+}\n+\n+static void test_arr_ptr_nulls_str_load(void)\n+{\n+ TestStructTriv ar_gt[AR_SIZE] = {{.i = 0}, {.i = 0}, {.i = 2}, {.i = 3} };\n+ TestVArrayOfPtrToStuctWithNULLs obj = {};\n+ int idx;\n+\n+ obj.ar_items_num = AR_SIZE;\n+ obj.ar = g_new0(TestStructTriv*, obj.ar_items_num);\n+\n+ save_buffer(wire_arr_ptr_with_nulls, sizeof(wire_arr_ptr_with_nulls));\n+ SUCCESS(load_vmstate_one(\n+ &vmsd_arps_with_nulls, &obj, 1,\n+ wire_arr_ptr_with_nulls, sizeof(wire_arr_ptr_with_nulls)));\n+\n+ for (idx = 0; idx < AR_SIZE; ++idx) {\n+ if (idx == 1) {\n+ g_assert_cmpint((uintptr_t)(obj.ar[idx]), ==, 0);\n+ } else {\n+ /* compare the target array ar with the ground truth array ar_gt */\n+ g_assert_cmpint(ar_gt[idx].i, ==, obj.ar[idx]->i);\n+ }\n+ }\n+\n+ for (idx = 0; idx < AR_SIZE; ++idx) {\n+ g_free(obj.ar[idx]);\n+ }\n+ g_free(obj.ar);\n+}\n+\n /* test QTAILQ migration */\n typedef struct TestQtailqElement TestQtailqElement;\n \n@@ -1568,6 +1650,10 @@ int main(int argc, char **argv)\n test_arr_ptr_prim_0_save);\n g_test_add_func(\"/vmstate/array/ptr/prim/0/load\",\n test_arr_ptr_prim_0_load);\n+ g_test_add_func(\"/vmstate/array/ptr-nulls/str/save\",\n+ test_arr_ptr_nulls_str_save);\n+ g_test_add_func(\"/vmstate/array/ptr-nulls/str/load\",\n+ test_arr_ptr_nulls_str_load);\n g_test_add_func(\"/vmstate/qtailq/save/saveq\", test_save_q);\n g_test_add_func(\"/vmstate/qtailq/load/loadq\", test_load_q);\n g_test_add_func(\"/vmstate/gtree/save/savedomain\", test_gtree_save_domain);\n", "prefixes": [ "RFC", "v2", "11/11" ] }