Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/2216583/?format=api
{ "id": 2216583, "url": "http://patchwork.ozlabs.org/api/patches/2216583/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20260326210532.379027-7-peterx@redhat.com/", "project": { "id": 14, "url": "http://patchwork.ozlabs.org/api/projects/14/?format=api", "name": "QEMU Development", "link_name": "qemu-devel", "list_id": "qemu-devel.nongnu.org", "list_email": "qemu-devel@nongnu.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20260326210532.379027-7-peterx@redhat.com>", "list_archive_url": null, "date": "2026-03-26T21:05:27", "name": "[RFC,v2,06/11] vmstate: Introduce vmstate_save_field_with_vmdesc()", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "7a6c5061a88ed85561e9309ab42c43b5243267ac", "submitter": { "id": 67717, "url": "http://patchwork.ozlabs.org/api/people/67717/?format=api", "name": "Peter Xu", "email": "peterx@redhat.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20260326210532.379027-7-peterx@redhat.com/mbox/", "series": [ { "id": 497651, "url": "http://patchwork.ozlabs.org/api/series/497651/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/list/?series=497651", "date": "2026-03-26T21:05:22", "name": "vmstate: Implement VMS_ARRAY_OF_POINTER_AUTO_ALLOC", "version": 2, "mbox": "http://patchwork.ozlabs.org/series/497651/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2216583/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2216583/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=mimecast20190719 header.b=RgPdVtFL;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=google header.b=dtLMV5R7;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)" ], "Received": [ "from lists.gnu.org (lists.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fhbv1335qz1y1j\n\tfor <incoming@patchwork.ozlabs.org>; Fri, 27 Mar 2026 08:07:09 +1100 (AEDT)", "from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from <qemu-devel-bounces@nongnu.org>)\n\tid 1w5rto-00049d-LW; Thu, 26 Mar 2026 17:05:52 -0400", "from eggs.gnu.org ([2001:470:142:3::10])\n by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <peterx@redhat.com>) id 1w5rtl-00048P-Dp\n for qemu-devel@nongnu.org; Thu, 26 Mar 2026 17:05:49 -0400", "from us-smtp-delivery-124.mimecast.com ([170.10.129.124])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <peterx@redhat.com>) id 1w5rtj-00036m-Kw\n for qemu-devel@nongnu.org; Thu, 26 Mar 2026 17:05:49 -0400", "from mail-qk1-f199.google.com (mail-qk1-f199.google.com\n [209.85.222.199]) by relay.mimecast.com with ESMTP with STARTTLS\n (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id\n us-mta-693-WffzlzDkOZiRrVMkbTbjsA-1; Thu, 26 Mar 2026 17:05:45 -0400", "by mail-qk1-f199.google.com with SMTP id\n af79cd13be357-8cfcebeb1f3so121921485a.0\n for <qemu-devel@nongnu.org>; Thu, 26 Mar 2026 14:05:45 -0700 (PDT)", "from x1.com ([142.189.10.167]) by smtp.gmail.com with ESMTPSA id\n af79cd13be357-8d00e4fa7d9sm353479785a.32.2026.03.26.14.05.43\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Thu, 26 Mar 2026 14:05:43 -0700 (PDT)" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n s=mimecast20190719; t=1774559146;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:cc:mime-version:mime-version:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=5OGxsDPDL98ip8EJwQP/tMCYj51Rwd5fV8vt/33jK2E=;\n b=RgPdVtFLTEa9C/mH4eo7ExHHYUWeETnQRwSm921degXGhB2FF+meTQTxetL1Bi2T5Xt4SX\n r8HKgSE/lboNWQoK7uH4zYYXpyVM18si0pLxazcg/dG9/G8QtxZUyLYlDmiceyv6ZxkUqF\n vhCKCd71ZBc2ZIFju0pXXnAfWfE0vzw=", "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=redhat.com; s=google; t=1774559145; x=1775163945; darn=nongnu.org;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:from:to:cc:subject:date\n :message-id:reply-to;\n bh=5OGxsDPDL98ip8EJwQP/tMCYj51Rwd5fV8vt/33jK2E=;\n b=dtLMV5R73wqbA7LIAIyKEs6DoLVUbsAwVaFe1V1VohNrTY/bzH8pTbehHV4DDH/YIZ\n LP+B3GKkZ75VXEsaf7G3Ov2/2w6Iz+UGkKNySU8jwa3+oOeK8U4hMY8uuoXFqj1lq/Ow\n YvlPhVU0/6k0Mdp2nr12DVbuvduRiXAbHAT24U4BccXRSy+hnxJj+3fBVb1jbtGkNAO3\n yzFzdj5fMcjODpVUqmJYGoi9vAG+cqFJisrEPFshl1TGY4hAGwusDzdSf8CYg1csQpRa\n H01noR7dZ6w2CP/3BzX/sUDRY+X+tSQO9zZE2mGLRWKXLqIg9la0og+GvW6q0826i3WS\n uUjA==" ], "X-MC-Unique": "WffzlzDkOZiRrVMkbTbjsA-1", "X-Mimecast-MFC-AGG-ID": "WffzlzDkOZiRrVMkbTbjsA_1774559145", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1774559145; x=1775163945;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from\n :to:cc:subject:date:message-id:reply-to;\n bh=5OGxsDPDL98ip8EJwQP/tMCYj51Rwd5fV8vt/33jK2E=;\n b=aojBiP3jVwqVCh9HpRJrdW66ubdZ8Rl4dHiCiwz9uZPlBKuPF74wCuQwcCK55pa62u\n TOUFwpkgiOcJKXpW7/x+T6Pe85RzyBqhzaR1DZwfdsevy8C0TSsbNvEFnraesU72iClk\n 0jQeTSBcFVN5DReUcffFek8XInA1llwgiIbWlAaRVWsmmGpqiFBLeDWXlNTDjfADgLlN\n zvbSv6Mza8YScDt7XBX565pHlqYuXoOqFjg9XyrEXYMJ7IDLi/lYZEaYp45YrxrVnK1W\n kpbqmvz1E0CCwwlC9dXQrkhAyvkb+EbSzCNs4uclHJZiV61D24Ja/n6ibHJAkwT49o6u\n Rc3Q==", "X-Gm-Message-State": "AOJu0YxDsZ3zqB5rTijPxOChG0AwZ8QQW5g53IYt4q7h72q7R6PN9YQc\n Rj3CHoiaryG8cy5cjVq+XL0LAEa1oWmHTGpusSWciFNNw3slv2zzyQBbrv+vqVC4SbqNhdq2QLX\n TTMacH9YmgbEbZVIrjaOrBs/5UrTIplnGm5y/wKzJsrBOIV2ADpd7yJb6YsMOV8pYp9XjT7b11N\n BxeLrGV/1QhOMVoeckV6yGJJPOZ6fpxB/Q0BDteA==", "X-Gm-Gg": "ATEYQzwCcO5I4NAkeWoPRRPo657U36qIaVvSY+dOyQYM4LdU81YIWW2mUNkzGPCIE6X\n KVPbtzGqDfPAj2oSIUkUeRIuFza7HJcsiUg8ssevM8OQpKYvbizzCMG48R2h1r4ccv0A/DIxno8\n cqcTG8w4Ov8HgpvKYymbkKDhFamY6I9HIR+IlQuKWO+970A7m5djbRx0tAoyMy9sLyUMq0pcqKk\n zRHO52PBjMNnL8NeJ+0ya/6Xml9GwhlJGidyEZ/b/4kQaPvridc8YWuvGjqs9USUJXAWKkRtgWX\n E4sMaFiE1gvotJ1Q64AJN4aRL5/3kOXLT8obVx2feYJy3PNnc2/+GA6/qXC+1ALrIqhm5+yKmcF\n imqijNJoOncE=", "X-Received": [ "by 2002:a05:620a:1a25:b0:8cd:8eb7:2c02 with SMTP id\n af79cd13be357-8d00107e6d6mr1258732385a.58.1774559144565;\n Thu, 26 Mar 2026 14:05:44 -0700 (PDT)", "by 2002:a05:620a:1a25:b0:8cd:8eb7:2c02 with SMTP id\n af79cd13be357-8d00107e6d6mr1258726285a.58.1774559143895;\n Thu, 26 Mar 2026 14:05:43 -0700 (PDT)" ], "From": "Peter Xu <peterx@redhat.com>", "To": "qemu-devel@nongnu.org", "Cc": "Alexander Mikhalitsyn <alexander@mihalicyn.com>, peterx@redhat.com,\n Fabiano Rosas <farosas@suse.de>, Juraj Marcin <jmarcin@redhat.com>,\n Alexander Mikhalitsyn <aleksandr.mikhalitsyn@futurfusion.io>", "Subject": "[PATCH RFC v2 06/11] vmstate: Introduce\n vmstate_save_field_with_vmdesc()", "Date": "Thu, 26 Mar 2026 17:05:27 -0400", "Message-ID": "<20260326210532.379027-7-peterx@redhat.com>", "X-Mailer": "git-send-email 2.50.1", "In-Reply-To": "<20260326210532.379027-1-peterx@redhat.com>", "References": "<20260326210532.379027-1-peterx@redhat.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Received-SPF": "pass client-ip=170.10.129.124; envelope-from=peterx@redhat.com;\n helo=us-smtp-delivery-124.mimecast.com", "X-Spam_score_int": "-20", "X-Spam_score": "-2.1", "X-Spam_bar": "--", "X-Spam_report": "(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001,\n DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=0.001,\n RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001,\n SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no", "X-Spam_action": "no action", "X-BeenThere": "qemu-devel@nongnu.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "qemu development <qemu-devel.nongnu.org>", "List-Unsubscribe": "<https://lists.nongnu.org/mailman/options/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>", "List-Archive": "<https://lists.nongnu.org/archive/html/qemu-devel>", "List-Post": "<mailto:qemu-devel@nongnu.org>", "List-Help": "<mailto:qemu-devel-request@nongnu.org?subject=help>", "List-Subscribe": "<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=subscribe>", "Errors-To": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org", "Sender": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org" }, "content": "Introduce a helper to do both the JSON blob generations and save vmstate.\nThis further shrinks the function a bit. More importantly, we'll need to\nsave two fields in one loop very soon in the future with the JSON blob.\n\nReviewed-by: Alexander Mikhalitsyn <aleksandr.mikhalitsyn@futurfusion.io>\nSigned-off-by: Peter Xu <peterx@redhat.com>\n---\n migration/vmstate.c | 45 ++++++++++++++++++++++++++++++++-------------\n 1 file changed, 32 insertions(+), 13 deletions(-)", "diff": "diff --git a/migration/vmstate.c b/migration/vmstate.c\nindex 05badef42f..b274204e66 100644\n--- a/migration/vmstate.c\n+++ b/migration/vmstate.c\n@@ -514,6 +514,35 @@ static bool vmstate_save_field(QEMUFile *f, void *pv, size_t size,\n return true;\n }\n \n+/*\n+ * Save a whole VMSD field, including its JSON blob separately when @vmdesc\n+ * is specified.\n+ */\n+static inline bool\n+vmstate_save_field_with_vmdesc(QEMUFile *f, void *pv, size_t size,\n+ const VMStateDescription *vmsd,\n+ const VMStateField *field, JSONWriter *vmdesc,\n+ int i, int max, Error **errp)\n+{\n+ uint64_t old_offset, written_bytes;\n+ bool ok;\n+\n+ vmsd_desc_field_start(vmsd, vmdesc, field, i, max);\n+\n+ old_offset = qemu_file_transferred(f);\n+ ok = vmstate_save_field(f, pv, size, field, vmdesc, errp);\n+ written_bytes = qemu_file_transferred(f) - old_offset;\n+\n+ vmsd_desc_field_end(vmsd, vmdesc, field, written_bytes);\n+\n+ if (!ok) {\n+ error_prepend(errp, \"Save of field %s/%s failed: \",\n+ vmsd->name, field->name);\n+ }\n+\n+ return ok;\n+}\n+\n static bool vmstate_save_vmsd_v(QEMUFile *f, const VMStateDescription *vmsd,\n void *opaque, JSONWriter *vmdesc,\n int version_id, Error **errp)\n@@ -542,7 +571,6 @@ static bool vmstate_save_vmsd_v(QEMUFile *f, const VMStateDescription *vmsd,\n void *first_elem = opaque + field->offset;\n int i, n_elems = vmstate_n_elems(opaque, field);\n int size = vmstate_size(opaque, field);\n- uint64_t old_offset, written_bytes;\n JSONWriter *vmdesc_loop = vmdesc;\n bool is_prev_null = false;\n \n@@ -559,7 +587,6 @@ static bool vmstate_save_vmsd_v(QEMUFile *f, const VMStateDescription *vmsd,\n /* maximum number of elements to compress in the JSON blob */\n int max_elems = vmsd_can_compress(field) ? (n_elems - i) : 1;\n \n- old_offset = qemu_file_transferred(f);\n if (field->flags & VMS_ARRAY_OF_POINTER) {\n assert(curr_elem);\n curr_elem = *(void **)curr_elem;\n@@ -606,15 +633,9 @@ static bool vmstate_save_vmsd_v(QEMUFile *f, const VMStateDescription *vmsd,\n }\n }\n \n- vmsd_desc_field_start(vmsd, vmdesc_loop, inner_field,\n- i, max_elems);\n-\n- ok = vmstate_save_field(f, curr_elem, size, inner_field,\n- vmdesc_loop, errp);\n-\n- written_bytes = qemu_file_transferred(f) - old_offset;\n- vmsd_desc_field_end(vmsd, vmdesc_loop, inner_field,\n- written_bytes);\n+ ok = vmstate_save_field_with_vmdesc(f, curr_elem, size, vmsd,\n+ inner_field, vmdesc_loop,\n+ i, max_elems, errp);\n \n /* If we used a fake temp field.. free it now */\n if (is_null) {\n@@ -622,8 +643,6 @@ static bool vmstate_save_vmsd_v(QEMUFile *f, const VMStateDescription *vmsd,\n }\n \n if (!ok) {\n- error_prepend(errp, \"Save of field %s/%s failed: \",\n- vmsd->name, field->name);\n goto out;\n }\n \n", "prefixes": [ "RFC", "v2", "06/11" ] }