Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/2216582/?format=api
{ "id": 2216582, "url": "http://patchwork.ozlabs.org/api/patches/2216582/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20260326210532.379027-3-peterx@redhat.com/", "project": { "id": 14, "url": "http://patchwork.ozlabs.org/api/projects/14/?format=api", "name": "QEMU Development", "link_name": "qemu-devel", "list_id": "qemu-devel.nongnu.org", "list_email": "qemu-devel@nongnu.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20260326210532.379027-3-peterx@redhat.com>", "list_archive_url": null, "date": "2026-03-26T21:05:23", "name": "[RFC,v2,02/11] vmstate: Pass in struct itself for VMSTATE_VARRAY_OF_POINTER_UINT32", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "95119052536cbe8038b1b7ba8be2eb200aff1cf9", "submitter": { "id": 67717, "url": "http://patchwork.ozlabs.org/api/people/67717/?format=api", "name": "Peter Xu", "email": "peterx@redhat.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20260326210532.379027-3-peterx@redhat.com/mbox/", "series": [ { "id": 497651, "url": "http://patchwork.ozlabs.org/api/series/497651/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/list/?series=497651", "date": "2026-03-26T21:05:22", "name": "vmstate: Implement VMS_ARRAY_OF_POINTER_AUTO_ALLOC", "version": 2, "mbox": "http://patchwork.ozlabs.org/series/497651/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2216582/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2216582/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=mimecast20190719 header.b=PnR5viag;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=google header.b=BFBtj1gB;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)" ], "Received": [ "from lists.gnu.org (lists.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fhbtz6vRVz1y1j\n\tfor <incoming@patchwork.ozlabs.org>; Fri, 27 Mar 2026 08:07:07 +1100 (AEDT)", "from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from <qemu-devel-bounces@nongnu.org>)\n\tid 1w5rtl-00048H-6I; Thu, 26 Mar 2026 17:05:49 -0400", "from eggs.gnu.org ([2001:470:142:3::10])\n by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <peterx@redhat.com>) id 1w5rtj-00047e-Ve\n for qemu-devel@nongnu.org; Thu, 26 Mar 2026 17:05:47 -0400", "from us-smtp-delivery-124.mimecast.com ([170.10.133.124])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <peterx@redhat.com>) id 1w5rti-00036I-Hr\n for qemu-devel@nongnu.org; Thu, 26 Mar 2026 17:05:47 -0400", "from mail-qk1-f200.google.com (mail-qk1-f200.google.com\n [209.85.222.200]) by relay.mimecast.com with ESMTP with STARTTLS\n (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id\n us-mta-658-i4Sc2zJeOca-m3b6YFoF8g-1; Thu, 26 Mar 2026 17:05:40 -0400", "by mail-qk1-f200.google.com with SMTP id\n af79cd13be357-8cfdc479f5bso350116985a.2\n for <qemu-devel@nongnu.org>; Thu, 26 Mar 2026 14:05:40 -0700 (PDT)", "from x1.com ([142.189.10.167]) by smtp.gmail.com with ESMTPSA id\n af79cd13be357-8d00e4fa7d9sm353479785a.32.2026.03.26.14.05.37\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Thu, 26 Mar 2026 14:05:37 -0700 (PDT)" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n s=mimecast20190719; t=1774559146;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:cc:mime-version:mime-version:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=yAsrRY7tNnPZNv7QX95Jwwlg0RE4QfNAnLAWQ9HKoeI=;\n b=PnR5viagpp76e/w2kFcESHagAJ3K0ZfXVU1NFrPLhwhre3B9AFO5BXhPR4c46G3dSM0FRk\n tw4cWJgbQ/DBg4ki/Et6mrozc24zGqSj032kAldgXGVW/kgNHk7LswnxcFLtdam6eZKnEB\n PBMrhPad4J0npzDNRXA4XhUNsqSc2Lc=", "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=redhat.com; s=google; t=1774559139; x=1775163939; darn=nongnu.org;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:from:to:cc:subject:date\n :message-id:reply-to;\n bh=yAsrRY7tNnPZNv7QX95Jwwlg0RE4QfNAnLAWQ9HKoeI=;\n b=BFBtj1gBOBsmK/HUhmWQQnvN2qZsrC9LZhol/4vJ5JCYxVQQ2NZr5UT0ri15RWzOHK\n r5pzPmqNTzvYsTtJjR+NRt4eQgI/73TAwpbkoSmL6xgWRBQ1IdeabbVvH3L+b0nW06ov\n UpCNCTTuwpQIeYU/05ZGoLfcdVFL72AxtYNjnqkoTww+y1y7m23s4Pbg51g0vgHcp+yG\n oas79yAcN2sHtu1dQ3S3OWkICYmf1HDA8Uu80LJfKu4Ln7yUyJWQ+zTPLtgz12Cxc1I4\n ol73yLxno8Olee9PBSNA75Nvkuj07qq9Wjl2EWxKxWSTSKOIfTy4FSrDBh4UH+jRwmus\n 8lSQ==" ], "X-MC-Unique": "i4Sc2zJeOca-m3b6YFoF8g-1", "X-Mimecast-MFC-AGG-ID": "i4Sc2zJeOca-m3b6YFoF8g_1774559140", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1774559139; x=1775163939;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from\n :to:cc:subject:date:message-id:reply-to;\n bh=yAsrRY7tNnPZNv7QX95Jwwlg0RE4QfNAnLAWQ9HKoeI=;\n b=IAsl3qxlcFPciomj/gwNwtz394a7kvZrH7bcVuKog682tvI1cmx2T3Kp+z3XZZg12R\n k/7RccJkqY3s/TJO5CTfALsWP9iBPUPZ29IO2GTrcK9jbONsC78L/2xheIMSDNMJ810V\n 82ex4vzC6X7oXpnG1y/WLo5HAutoTrJ2ytcsFVfEBCa3xeziyXb2hs5fQc89o5XT855x\n G+dWPALb8NJCYE7SJ1C8g5qc+k3u43RJhxTH2vN8zzfNx8KsM3y1DNM5E6+j5NReeg9k\n yXrvqGJSUtQ7zs4/iDyJskVTIEGBQtNO57NT9IsbybdxDUXIxEcdqHH6L/fP6rYYB+ap\n FmrA==", "X-Gm-Message-State": "AOJu0YwiSLw6pFGBFn6QNzBgJQXRhDt6slFJiXEsDrf5Ffk8A02bOlSI\n nQFtYlpwSXbuInMxNk9Ys33xvo2qInaUSzfyWwxcl3liS0xYbN6zzW2P/I9j+Y95JtE6QbRDZm5\n mqsK4WLeirD0ALvqkBBPDo9lY7YfpG/2uYloHU5/Dm0fuMRKB+u8eeen/TLn0E+vzWVfPAeFoCK\n f/qPWICEW1JkZaTddFYtCuWDMavJJJNVdR4Ww4Cg==", "X-Gm-Gg": "ATEYQzy93RmZgHtWJbVo8/p7/4DqvcA1USbfc2BZZNgGRqAk70v7zKN5393uGBgSOQS\n Gpxg3CqOFXXDCFCLc07bjtg3kDGrQclVcvkYy09t0ockREa8bCaXwLxe6DNamn3elWIXrVAJGCt\n gpSQJiBQIn+eGPkBldxBylNomcV2Y1fiT+yXetpA4adtOFKhHFTpE3YD7iE6iCDu4k7s6R/mOKB\n MXaDfukVWcpIDrb4qltwAbMlW+mC8Cr6PdzUd86iP7+9QdAtZ6cfVg/MTCVA7/UhHponqhUl8aY\n jWjFNebL/NjXMiTXGKtPg+PjnwU33OOScqCibpE54XXKquYTRizO66rMp7K7IxlGO1imbu18IKS\n Pai3ovn/QvBQ=", "X-Received": [ "by 2002:a05:620a:2805:b0:8cf:e946:b2d4 with SMTP id\n af79cd13be357-8d00105203fmr1191627685a.69.1774559139188;\n Thu, 26 Mar 2026 14:05:39 -0700 (PDT)", "by 2002:a05:620a:2805:b0:8cf:e946:b2d4 with SMTP id\n af79cd13be357-8d00105203fmr1191620185a.69.1774559138515;\n Thu, 26 Mar 2026 14:05:38 -0700 (PDT)" ], "From": "Peter Xu <peterx@redhat.com>", "To": "qemu-devel@nongnu.org", "Cc": "Alexander Mikhalitsyn <alexander@mihalicyn.com>, peterx@redhat.com,\n Fabiano Rosas <farosas@suse.de>, Juraj Marcin <jmarcin@redhat.com>,\n Alexander Mikhalitsyn <aleksandr.mikhalitsyn@futurfusion.io>", "Subject": "[PATCH RFC v2 02/11] vmstate: Pass in struct itself for\n VMSTATE_VARRAY_OF_POINTER_UINT32", "Date": "Thu, 26 Mar 2026 17:05:23 -0400", "Message-ID": "<20260326210532.379027-3-peterx@redhat.com>", "X-Mailer": "git-send-email 2.50.1", "In-Reply-To": "<20260326210532.379027-1-peterx@redhat.com>", "References": "<20260326210532.379027-1-peterx@redhat.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Received-SPF": "pass client-ip=170.10.133.124; envelope-from=peterx@redhat.com;\n helo=us-smtp-delivery-124.mimecast.com", "X-Spam_score_int": "-20", "X-Spam_score": "-2.1", "X-Spam_bar": "--", "X-Spam_report": "(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001,\n DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=0.001,\n RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001,\n SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no", "X-Spam_action": "no action", "X-BeenThere": "qemu-devel@nongnu.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "qemu development <qemu-devel.nongnu.org>", "List-Unsubscribe": "<https://lists.nongnu.org/mailman/options/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>", "List-Archive": "<https://lists.nongnu.org/archive/html/qemu-devel>", "List-Post": "<mailto:qemu-devel@nongnu.org>", "List-Help": "<mailto:qemu-devel-request@nongnu.org?subject=help>", "List-Subscribe": "<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=subscribe>", "Errors-To": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org", "Sender": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org" }, "content": "Passing in a pointer almost never helps. Convert it to pass in struct for\nfurther refactoring on VMS_ARRAY_OF_POINTER.\n\nSigned-off-by: Peter Xu <peterx@redhat.com>\nReviewed-by: Alexander Mikhalitsyn <aleksandr.mikhalitsyn@futurfusion.io>\n---\n include/hw/intc/riscv_aclint.h | 6 +++---\n include/migration/vmstate.h | 4 ++--\n 2 files changed, 5 insertions(+), 5 deletions(-)", "diff": "diff --git a/include/hw/intc/riscv_aclint.h b/include/hw/intc/riscv_aclint.h\nindex 5310615cbf..0e0b98acb0 100644\n--- a/include/hw/intc/riscv_aclint.h\n+++ b/include/hw/intc/riscv_aclint.h\n@@ -80,8 +80,8 @@ enum {\n RISCV_ACLINT_SWI_SIZE = 0x4000\n };\n \n-#define VMSTATE_TIMER_PTR_VARRAY(_f, _s, _f_n) \\\n-VMSTATE_VARRAY_OF_POINTER_UINT32(_f, _s, _f_n, 0, vmstate_info_timer, \\\n- QEMUTimer *)\n+#define VMSTATE_TIMER_PTR_VARRAY(_f, _s, _f_n) \\\n+ VMSTATE_VARRAY_OF_POINTER_UINT32(_f, _s, _f_n, 0, vmstate_info_timer, \\\n+ QEMUTimer)\n \n #endif\ndiff --git a/include/migration/vmstate.h b/include/migration/vmstate.h\nindex 8992fba57d..68fd954411 100644\n--- a/include/migration/vmstate.h\n+++ b/include/migration/vmstate.h\n@@ -567,9 +567,9 @@ extern const VMStateInfo vmstate_info_qlist;\n .version_id = (_version), \\\n .num_offset = vmstate_offset_value(_state, _field_num, uint32_t), \\\n .info = &(_info), \\\n- .size = sizeof(_type), \\\n+ .size = sizeof(_type *), \\\n .flags = VMS_VARRAY_UINT32 | VMS_ARRAY_OF_POINTER | VMS_POINTER, \\\n- .offset = vmstate_offset_pointer(_state, _field, _type), \\\n+ .offset = vmstate_offset_pointer(_state, _field, _type *), \\\n }\n \n #define VMSTATE_STRUCT_SUB_ARRAY(_field, _state, _start, _num, _version, _vmsd, _type) { \\\n", "prefixes": [ "RFC", "v2", "02/11" ] }