Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/2216578/?format=api
{ "id": 2216578, "url": "http://patchwork.ozlabs.org/api/patches/2216578/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20260326210532.379027-2-peterx@redhat.com/", "project": { "id": 14, "url": "http://patchwork.ozlabs.org/api/projects/14/?format=api", "name": "QEMU Development", "link_name": "qemu-devel", "list_id": "qemu-devel.nongnu.org", "list_email": "qemu-devel@nongnu.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20260326210532.379027-2-peterx@redhat.com>", "list_archive_url": null, "date": "2026-03-26T21:05:22", "name": "[RFC,v2,01/11] vmstate: Pass in struct itself for VMSTATE_ARRAY_OF_POINTER", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "eca0b6cdfa4501017073c7582717c751f624bb6e", "submitter": { "id": 67717, "url": "http://patchwork.ozlabs.org/api/people/67717/?format=api", "name": "Peter Xu", "email": "peterx@redhat.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20260326210532.379027-2-peterx@redhat.com/mbox/", "series": [ { "id": 497651, "url": "http://patchwork.ozlabs.org/api/series/497651/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/list/?series=497651", "date": "2026-03-26T21:05:22", "name": "vmstate: Implement VMS_ARRAY_OF_POINTER_AUTO_ALLOC", "version": 2, "mbox": "http://patchwork.ozlabs.org/series/497651/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2216578/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2216578/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=mimecast20190719 header.b=Ehrwonwb;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=google header.b=sXwO0MWQ;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)" ], "Received": [ "from lists.gnu.org (lists.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fhbt63PYmz1y1j\n\tfor <incoming@patchwork.ozlabs.org>; Fri, 27 Mar 2026 08:06:20 +1100 (AEDT)", "from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from <qemu-devel-bounces@nongnu.org>)\n\tid 1w5rtg-00046f-7m; Thu, 26 Mar 2026 17:05:44 -0400", "from eggs.gnu.org ([2001:470:142:3::10])\n by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <peterx@redhat.com>) id 1w5rte-00046H-K2\n for qemu-devel@nongnu.org; Thu, 26 Mar 2026 17:05:42 -0400", "from us-smtp-delivery-124.mimecast.com ([170.10.129.124])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <peterx@redhat.com>) id 1w5rtd-00035E-3A\n for qemu-devel@nongnu.org; Thu, 26 Mar 2026 17:05:42 -0400", "from mail-qk1-f199.google.com (mail-qk1-f199.google.com\n [209.85.222.199]) by relay.mimecast.com with ESMTP with STARTTLS\n (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id\n us-mta-657-ZQXLhpZzPtGgt_zmGGRwYA-1; Thu, 26 Mar 2026 17:05:38 -0400", "by mail-qk1-f199.google.com with SMTP id\n af79cd13be357-8cd77e5e187so394853385a.1\n for <qemu-devel@nongnu.org>; Thu, 26 Mar 2026 14:05:38 -0700 (PDT)", "from x1.com ([142.189.10.167]) by smtp.gmail.com with ESMTPSA id\n af79cd13be357-8d00e4fa7d9sm353479785a.32.2026.03.26.14.05.35\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Thu, 26 Mar 2026 14:05:35 -0700 (PDT)" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n s=mimecast20190719; t=1774559140;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:cc:mime-version:mime-version:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=erx+743xHQZ4m+Ex6FitH4YpobL1zwjNzywosqKc3PM=;\n b=EhrwonwbIv6kHn/oUI+vPPJJTl5fB8vPlEpk7XsoS2UbCQ+UBhPGbPSVVJYH7atyzl7nPI\n QMTVia6rTR9tAnKHgpJ4q56pP9cAEoEXNK7/O7ZYB38OmJ5xbdJ33lnOATsppS8mcd8rVe\n pyW5pr3JS14nlNfeDF38UZmlUKwgliA=", "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=redhat.com; s=google; t=1774559138; x=1775163938; darn=nongnu.org;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:from:to:cc:subject:date\n :message-id:reply-to;\n bh=erx+743xHQZ4m+Ex6FitH4YpobL1zwjNzywosqKc3PM=;\n b=sXwO0MWQKYPooa0ztTsQNMoLa3d6JodeNuI+Wtq1tVd6YuUrmYLQ5nTmQd5p6oaJCx\n BLK0swO0XAOeLfnbmc3wGK/q25Zs8rI0ksggnFAhwbsNBggBUVl2eEtZqaEcYyUIWJnC\n vojfine+4yIVA1NZcCI/ZPofu+VgqjagdD43RrW8HF8o06StztfhIc2lpwu1Ao7P9BPC\n Np6PkS6a7rS97NjFCboo7O2FfrKmSOy9mASfcjXK23oh5G/4oEYZ1rjsDt03soNDvz/E\n KbMbvZe3oGQpcP4ZckCVoD0OKh0F/QJ7I1RMZavGFfYEO1mZI18ax4YXtaTPp+nbRS7H\n 1ohw==" ], "X-MC-Unique": "ZQXLhpZzPtGgt_zmGGRwYA-1", "X-Mimecast-MFC-AGG-ID": "ZQXLhpZzPtGgt_zmGGRwYA_1774559138", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1774559138; x=1775163938;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from\n :to:cc:subject:date:message-id:reply-to;\n bh=erx+743xHQZ4m+Ex6FitH4YpobL1zwjNzywosqKc3PM=;\n b=j7ZISRzRE1Im+mrNMZjuBKZQnRZqMxMTI/rduQFgQI3cSCip39EH9sGq0PrRcr6/Sl\n ylMjDwRz8YiGeVXcizprbktgUlDU2SrqOQffr8nTGyLGv5UwWmtNYXFtp4YXxHcc1pX+\n UBlFrRRKKCkfs8nXejfrd+9SFy5wOG0jVLfcabnQUOCFxtSI8o/C0mpiLABDFuYrErD8\n mASqpk0FWt6fJAJo4UbdLiN3oiO+k+WkyEQ1ffp04TcWNOhooDYroEFGr6T9+Jb+MOu5\n dTZYmQDshc004Gpaz18Sviy+VhcKvleuZToLCnHxNFgtt4hmuoUjQzi+BizxWBe3XdR7\n Rxqw==", "X-Gm-Message-State": "AOJu0YwVbFyTW4ecmMsbikQkqyvb+FQA1MElymZ+PKxl/XEZQTz54H7E\n B1thCf645bdZFcc4l+q/Sm1lKQEp0vWF+qNk/2c7wAM/hkq0RfbnndYYi1CJKGT2juQtsvjvDJY\n pBWUkXZNqLzzTo+KAbf32aGRoxA5pm1YpJW9N0IGqbvSgefK4PmGXOzLV2bxiC4Kn60uMT+cWWC\n FFZ2firdeUpCjM5viQlFY8UVKMjhfanLc/HVnazQ==", "X-Gm-Gg": "ATEYQzwF9OgFNZQzUNZfI8+SSvaCqz1fLBU5IJ278DHlPc8Pi4HHRSOdDZfJZyyh9vt\n IgI4YAADZUaiPb9vOc+vIJxn3GSNvmfpIliBdK7D1EsUxN7lkbLOiPmxEiJ7jMCiR7xbNi4mInZ\n pAn2Pgw3GKS69R8kS3zVD6dhrTGqB9aZeC8tPNK3RcmQEEkHC1JJ5Rca/TLMoFnfjzO/N+fR8Ul\n u6kyhXghV/fviIFYoAlBDuutilTM8NXjsaQd76PADPpAgFcCFQ525wdzOUHBi71rXqZfO+qt/iU\n 3W1n4kcsry5I7Fr5mOj3DGxh+616GXb0ZNiE9zfk5dCEivcOFsMuNMucsN7oVq5nGJp4DyFz0lM\n aicdAQVnfxSg=", "X-Received": [ "by 2002:a05:620a:c4a:b0:8ca:123e:819c with SMTP id\n af79cd13be357-8d00100420cmr1207553585a.35.1774559137584;\n Thu, 26 Mar 2026 14:05:37 -0700 (PDT)", "by 2002:a05:620a:c4a:b0:8ca:123e:819c with SMTP id\n af79cd13be357-8d00100420cmr1207547985a.35.1774559136993;\n Thu, 26 Mar 2026 14:05:36 -0700 (PDT)" ], "From": "Peter Xu <peterx@redhat.com>", "To": "qemu-devel@nongnu.org", "Cc": "Alexander Mikhalitsyn <alexander@mihalicyn.com>, peterx@redhat.com,\n Fabiano Rosas <farosas@suse.de>, Juraj Marcin <jmarcin@redhat.com>,\n Alexander Mikhalitsyn <aleksandr.mikhalitsyn@futurfusion.io>", "Subject": "[PATCH RFC v2 01/11] vmstate: Pass in struct itself for\n VMSTATE_ARRAY_OF_POINTER", "Date": "Thu, 26 Mar 2026 17:05:22 -0400", "Message-ID": "<20260326210532.379027-2-peterx@redhat.com>", "X-Mailer": "git-send-email 2.50.1", "In-Reply-To": "<20260326210532.379027-1-peterx@redhat.com>", "References": "<20260326210532.379027-1-peterx@redhat.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Received-SPF": "pass client-ip=170.10.129.124; envelope-from=peterx@redhat.com;\n helo=us-smtp-delivery-124.mimecast.com", "X-Spam_score_int": "-20", "X-Spam_score": "-2.1", "X-Spam_bar": "--", "X-Spam_report": "(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001,\n DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=0.001,\n RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001,\n SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no", "X-Spam_action": "no action", "X-BeenThere": "qemu-devel@nongnu.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "qemu development <qemu-devel.nongnu.org>", "List-Unsubscribe": "<https://lists.nongnu.org/mailman/options/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>", "List-Archive": "<https://lists.nongnu.org/archive/html/qemu-devel>", "List-Post": "<mailto:qemu-devel@nongnu.org>", "List-Help": "<mailto:qemu-devel-request@nongnu.org?subject=help>", "List-Subscribe": "<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=subscribe>", "Errors-To": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org", "Sender": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org" }, "content": "Passing in a pointer almost never helps. Convert it to pass in struct for\nfurther refactoring on VMS_ARRAY_OF_POINTER.\n\nSigned-off-by: Peter Xu <peterx@redhat.com>\nReviewed-by: Alexander Mikhalitsyn <aleksandr.mikhalitsyn@futurfusion.io>\n---\n include/migration/vmstate.h | 6 +++---\n tests/unit/test-vmstate.c | 2 +-\n 2 files changed, 4 insertions(+), 4 deletions(-)", "diff": "diff --git a/include/migration/vmstate.h b/include/migration/vmstate.h\nindex d4a39aa794..8992fba57d 100644\n--- a/include/migration/vmstate.h\n+++ b/include/migration/vmstate.h\n@@ -547,9 +547,9 @@ extern const VMStateInfo vmstate_info_qlist;\n .version_id = (_version), \\\n .num = (_num), \\\n .info = &(_info), \\\n- .size = sizeof(_type), \\\n+ .size = sizeof(_type *), \\\n .flags = VMS_ARRAY|VMS_ARRAY_OF_POINTER, \\\n- .offset = vmstate_offset_array(_state, _field, _type, _num), \\\n+ .offset = vmstate_offset_array(_state, _field, _type*, _num), \\\n }\n \n #define VMSTATE_ARRAY_OF_POINTER_TO_STRUCT(_f, _s, _n, _v, _vmsd, _type) { \\\n@@ -1093,7 +1093,7 @@ extern const VMStateInfo vmstate_info_qlist;\n VMSTATE_TIMER_PTR_V(_f, _s, 0)\n \n #define VMSTATE_TIMER_PTR_ARRAY(_f, _s, _n) \\\n- VMSTATE_ARRAY_OF_POINTER(_f, _s, _n, 0, vmstate_info_timer, QEMUTimer *)\n+ VMSTATE_ARRAY_OF_POINTER(_f, _s, _n, 0, vmstate_info_timer, QEMUTimer)\n \n #define VMSTATE_TIMER_TEST(_f, _s, _test) \\\n VMSTATE_SINGLE_TEST(_f, _s, _test, 0, vmstate_info_timer, QEMUTimer)\ndiff --git a/tests/unit/test-vmstate.c b/tests/unit/test-vmstate.c\nindex cadbab3c5e..6a42cc1a4e 100644\n--- a/tests/unit/test-vmstate.c\n+++ b/tests/unit/test-vmstate.c\n@@ -668,7 +668,7 @@ const VMStateDescription vmsd_arpp = {\n .minimum_version_id = 1,\n .fields = (const VMStateField[]) {\n VMSTATE_ARRAY_OF_POINTER(ar, TestArrayOfPtrToInt,\n- AR_SIZE, 0, vmstate_info_int32, int32_t*),\n+ AR_SIZE, 0, vmstate_info_int32, int32_t),\n VMSTATE_END_OF_LIST()\n }\n };\n", "prefixes": [ "RFC", "v2", "01/11" ] }