Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/2216576/?format=api
{ "id": 2216576, "url": "http://patchwork.ozlabs.org/api/patches/2216576/?format=api", "web_url": "http://patchwork.ozlabs.org/project/uboot/patch/20260326-cmd-scsi-drop-reset-v1-1-01956d061acc@baylibre.com/", "project": { "id": 18, "url": "http://patchwork.ozlabs.org/api/projects/18/?format=api", "name": "U-Boot", "link_name": "uboot", "list_id": "u-boot.lists.denx.de", "list_email": "u-boot@lists.denx.de", "web_url": null, "scm_url": null, "webscm_url": null, "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20260326-cmd-scsi-drop-reset-v1-1-01956d061acc@baylibre.com>", "list_archive_url": null, "date": "2026-03-26T20:39:52", "name": "cmd/scsi: drop scsi reset command", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "e9b00be643690d90bbf613f870c886f333408dd4", "submitter": { "id": 87228, "url": "http://patchwork.ozlabs.org/api/people/87228/?format=api", "name": "David Lechner", "email": "dlechner@baylibre.com" }, "delegate": { "id": 3651, "url": "http://patchwork.ozlabs.org/api/users/3651/?format=api", "username": "trini", "first_name": "Tom", "last_name": "Rini", "email": "trini@ti.com" }, "mbox": "http://patchwork.ozlabs.org/project/uboot/patch/20260326-cmd-scsi-drop-reset-v1-1-01956d061acc@baylibre.com/mbox/", "series": [ { "id": 497649, "url": "http://patchwork.ozlabs.org/api/series/497649/?format=api", "web_url": "http://patchwork.ozlabs.org/project/uboot/list/?series=497649", "date": "2026-03-26T20:39:52", "name": "cmd/scsi: drop scsi reset command", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/497649/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2216576/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2216576/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<u-boot-bounces@lists.denx.de>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=baylibre-com.20230601.gappssmtp.com\n header.i=@baylibre-com.20230601.gappssmtp.com header.a=rsa-sha256\n header.s=20230601 header.b=TCs1r1+M;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de\n (client-ip=2a01:238:438b:c500:173d:9f52:ddab:ee01; helo=phobos.denx.de;\n envelope-from=u-boot-bounces@lists.denx.de; receiver=patchwork.ozlabs.org)", "phobos.denx.de;\n dmarc=none (p=none dis=none) header.from=baylibre.com", "phobos.denx.de;\n spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de", "phobos.denx.de;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=baylibre-com.20230601.gappssmtp.com\n header.i=@baylibre-com.20230601.gappssmtp.com header.b=\"TCs1r1+M\";\n\tdkim-atps=neutral", "phobos.denx.de;\n dmarc=none (p=none dis=none) header.from=baylibre.com", "phobos.denx.de;\n spf=pass smtp.mailfrom=dlechner@baylibre.com" ], "Received": [ "from phobos.denx.de (phobos.denx.de\n [IPv6:2a01:238:438b:c500:173d:9f52:ddab:ee01])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fhbJ13wNBz1xy1\n\tfor <incoming@patchwork.ozlabs.org>; Fri, 27 Mar 2026 07:40:17 +1100 (AEDT)", "from h2850616.stratoserver.net (localhost [IPv6:::1])\n\tby phobos.denx.de (Postfix) with ESMTP id BEE5681E18;\n\tThu, 26 Mar 2026 21:40:07 +0100 (CET)", "by phobos.denx.de (Postfix, from userid 109)\n id 5CBFC838BB; Thu, 26 Mar 2026 21:40:07 +0100 (CET)", "from mail-oo1-xc2b.google.com (mail-oo1-xc2b.google.com\n [IPv6:2607:f8b0:4864:20::c2b])\n (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits))\n (No client certificate requested)\n by phobos.denx.de (Postfix) with ESMTPS id 1424080517\n for <u-boot@lists.denx.de>; Thu, 26 Mar 2026 21:40:05 +0100 (CET)", "by mail-oo1-xc2b.google.com with SMTP id\n 006d021491bc7-673ee2a98b1so816372eaf.0\n for <u-boot@lists.denx.de>; Thu, 26 Mar 2026 13:40:04 -0700 (PDT)", "from [127.0.1.1] ([2600:8803:e7e4:500:5200:5612:f63e:1681])\n by smtp.gmail.com with ESMTPSA id\n 006d021491bc7-67e0aaf8185sm2539014eaf.11.2026.03.26.13.40.00\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Thu, 26 Mar 2026 13:40:01 -0700 (PDT)" ], "X-Spam-Checker-Version": "SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de", "X-Spam-Level": "", "X-Spam-Status": "No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,\n DKIM_VALID,RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_PASS autolearn=ham\n autolearn_force=no version=3.4.2", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1774557602;\n x=1775162402;\n darn=lists.denx.de;\n h=cc:to:message-id:content-transfer-encoding:mime-version:subject\n :date:from:from:to:cc:subject:date:message-id:reply-to;\n bh=Oqk6CsKtaPl0De8iZAYsRePyHANYoDGV/OKyqT0+R7Q=;\n b=TCs1r1+MTJV8u3okfUHfB7pgjs2yfOCXHvMZCpREX/9f01uUcxl3tWH1RbE8GSehho\n +VId61qYdlPBhiJ5q5P3IW0LCYf1NPYCCff4JfQ54bXtT4bm6Z/nkJbOfIHJAuc837ze\n Y8L1Wn0T+mVSZyDJ2mb5I6QK3CjtB/6oCFoLN2WHW2mc7DBvkxG42oQLJ62NdvVFJGMl\n aIgECcr2AmzczFOUazx3AtJjqeYrDuTtQ+9vbCd3NINSHzx4/E955umHFgIbZFWL3zUq\n fmKqtn5sSTQIPtbaYfxdXjl0iVdzmrMQ2H4eTtGXIW8vTi93MHeBoulomAtnVcFUH4cZ\n tzIA==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1774557602; x=1775162402;\n h=cc:to:message-id:content-transfer-encoding:mime-version:subject\n :date:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date\n :message-id:reply-to;\n bh=Oqk6CsKtaPl0De8iZAYsRePyHANYoDGV/OKyqT0+R7Q=;\n b=l45Nwc3L+8jEMD8kBRY2RAtDirSWF+V5yYJTIuFu5z61mDm9LbooU6RjEV5JGTqnvz\n G72o4n/EXN4wQhdgNs82dOJ3jjZNH4mQtZmBkPBmGjJVm1qCekeEv6jKXH5r2sx7FubA\n +DI4gQ/qxizBwr1ORlU2FErPULa1cHL/Z1tUt9VaGbJjV2dCTYINeWIctLXR3iXpypsr\n Jo7UNNhLGun/LAxO08rbNCJyW9bmN5Ci6a1VQC1bBgKtq6ghF7becF5uD1MyJtEqcY/s\n G57YSLhD8SSfBzDZz5rLBNuQFGZNHeA3Vbv127y3Q+HRZzPPMhtJXoon/DJQyvDYn9qM\n h/9A==", "X-Forwarded-Encrypted": "i=1;\n AJvYcCXYVEMz4UwGF3ypFOV4YBSceU9AqOQPUcDKp/Dnez4IHkirmdXjlvf/SotYSTrxQCET+cLGrvY=@lists.denx.de", "X-Gm-Message-State": "AOJu0Ywzzghnjg1EdW++FyNsPyyflOuBhDeVUkrDRbsnmi/25mlg5J/4\n A+TrEVjmq7z9o42bN1LapGNQG2hFgswgsrDWzDQP45AMKVTwih8YyfzpS8NejbnOPrpWKB3cHIg\n Ocn9F", "X-Gm-Gg": "ATEYQzwbeullOxKJ0gcgN5+0L7AjfKsAyity80zv3e3BGthf6yVXp3V2ULuYw0Klywp\n NL6F9Ux/iqIC7nifsqr1Niy7NCGDM8qLvVHoKA8BJU+QU7xGMW1XjySmBKXE41BAEZyCaEBgrtL\n d0uTD/PL8aA6lTPpMyU6Hk8I6qgawSQe7dRucOLvGI3K+UYRZy4Vvb+eUDbERQUPiuvY1LISJeW\n f9HiBQCKRJ+nlcp6vV1AyCz84gDM86ThhxxmcOVUm1ZmlxVNuMnWtn/7Z5oksTD7+C5ZnyBE0a8\n CTW9sXZbe8adgrx85BMU6Dj7MX0Ab0cAVVdSeTmmQ3R7UrLfa1uXcSTY3XDMX2H8Bq/PzypKN+2\n 6v5P90pxBrKHgMmY/6U85/UMFtY2PjRiUPlVPul2zoFTE4ZXsZZ4RfmhosZoy3LlvU3Tmz6xpka\n WFA2dc+paUIumEmQfB1OxNptt/0byS", "X-Received": "by 2002:a05:6820:1344:b0:67d:f88f:d853 with SMTP id\n 006d021491bc7-67e185f6571mr56199eaf.6.1774557602108;\n Thu, 26 Mar 2026 13:40:02 -0700 (PDT)", "From": "David Lechner <dlechner@baylibre.com>", "Date": "Thu, 26 Mar 2026 15:39:52 -0500", "Subject": "[PATCH] cmd/scsi: drop scsi reset command", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"utf-8\"", "Content-Transfer-Encoding": "7bit", "Message-Id": "<20260326-cmd-scsi-drop-reset-v1-1-01956d061acc@baylibre.com>", "X-B4-Tracking": "v=1; b=H4sIAAAAAAAC/yXMQQqDQAxA0atI1g3oiCP2KqWLTiZqhKokWgTx7\n k51+Rb/72CswgbPbAfln5hMY0LxyID6z9gxSkwGlzufl84jfSMamWDUaUZl4wULX1eh8jW52EA\n qZ+VWtuv6et+2NQxMy38Fx3ECXqSBxncAAAA=", "X-Change-ID": "20260326-cmd-scsi-drop-reset-1675b567c2d9", "To": "Tom Rini <trini@konsulko.com>", "Cc": "Julien Stephan <jstephan@baylibre.com>, u-boot@lists.denx.de,\n David Lechner <dlechner@baylibre.com>", "X-Mailer": "b4 0.16-dev", "X-Developer-Signature": "v=1; a=openpgp-sha256; l=2631; i=dlechner@baylibre.com;\n h=from:subject:message-id;\n bh=qlIgHBDBALp8rpnEprF6sqVWx8IDfU0MCTX83ff5q9Y=;\n b=owEBhAF7/pANAwAKAcLMIAH/AY/AAcsmYgBpxZma1P1tEBsk3Sb1KQfFIF+ry8WCd+1pn3ltK\n AOH4vQeCRaJAUoEAAEKADQWIQTsGNmeYg6D1pzYaJjCzCAB/wGPwAUCacWZmhYcZGxlY2huZXJA\n YmF5bGlicmUuY29tAAoJEMLMIAH/AY/A1CEH/0NCqU95B/6+Ym6oHeFdPyks/rWUq5kyxIkET7f\n 5KkHKjzEqy+IymSZSVXZTvrJJ4A12y/sXDBrMND22XgUwhR++equfxXBgaDUFvI+MaSX3je5isJ\n Sr5aIZeY5sGGnKcquns3LejUj0gM1HwN6csmIK3xCu2HjJeVkRbbJU0srCMmZGwoMs7pI3E3LlC\n UfpiAYOuZiaStH9h7NbEf6Np6ExF83dJLJrhdOI1yaiZuloobmirezsrDhNgdwRF6WCd/xXnNQQ\n NLG6HRIswhmm7S3EJinEF7mMmU0MdMczFRV3W3QE2WuE4T0HWif89XNPC0Rlhoef9Mo0Lo9JcK+\n aNQQ=", "X-Developer-Key": "i=dlechner@baylibre.com; a=openpgp;\n fpr=8A73D82A6A1F509907F373881F8AF88C82F77C03", "X-BeenThere": "u-boot@lists.denx.de", "X-Mailman-Version": "2.1.39", "Precedence": "list", "List-Id": "U-Boot discussion <u-boot.lists.denx.de>", "List-Unsubscribe": "<https://lists.denx.de/options/u-boot>,\n <mailto:u-boot-request@lists.denx.de?subject=unsubscribe>", "List-Archive": "<https://lists.denx.de/pipermail/u-boot/>", "List-Post": "<mailto:u-boot@lists.denx.de>", "List-Help": "<mailto:u-boot-request@lists.denx.de?subject=help>", "List-Subscribe": "<https://lists.denx.de/listinfo/u-boot>,\n <mailto:u-boot-request@lists.denx.de?subject=subscribe>", "Errors-To": "u-boot-bounces@lists.denx.de", "Sender": "\"U-Boot\" <u-boot-bounces@lists.denx.de>", "X-Virus-Scanned": "clamav-milter 0.103.8 at phobos.denx.de", "X-Virus-Status": "Clean" }, "content": "Since commit b630f8b3aefc (\"scsi: Forceably finish migration to DM_SCSI\")\nthe \"scsi reset\" command has no possibility of actually resetting any\nSCSI controller. Drop the command to avoid confusion that the command is\nactually resetting the SCSI controller.\n\nSigned-off-by: David Lechner <dlechner@baylibre.com>\n---\nThis is just something I noticed while inspecting the code. Since it\nhas done nothing for a couple of years, it seems likely that no one is\nusing it, so hopefully can just be removed. And if anyone actually is \nusing it, removing it should actually make them aware there is a problem\nvs. currently silently not doing what was intended. In that case,\nsomeone who actually uses it can re-implement it properly.\n---\n cmd/scsi.c | 8 --------\n test/py/tests/test_scsi.py | 10 ----------\n 2 files changed, 18 deletions(-)\n\n\n---\nbase-commit: 80a4c49a4ab2ad06fa84a8b7bdf6e33b3b5101bf\nchange-id: 20260326-cmd-scsi-drop-reset-1675b567c2d9\n\nBest regards,\n-- \nDavid Lechner <dlechner@baylibre.com>", "diff": "diff --git a/cmd/scsi.c b/cmd/scsi.c\nindex 9f7613424e5..ad7d8a4b664 100644\n--- a/cmd/scsi.c\n+++ b/cmd/scsi.c\n@@ -31,13 +31,6 @@ static int do_scsi(struct cmd_tbl *cmdtp, int flag, int argc,\n \tint ret;\n \n \tif (argc == 2) {\n-\t\tif (strncmp(argv[1], \"res\", 3) == 0) {\n-\t\t\tprintf(\"\\nReset SCSI\\n\");\n-\t\t\tret = scsi_scan(true);\n-\t\t\tif (ret)\n-\t\t\t\treturn CMD_RET_FAILURE;\n-\t\t\treturn ret;\n-\t\t}\n \t\tif (strncmp(argv[1], \"scan\", 4) == 0) {\n \t\t\tret = scsi_scan(true);\n \t\t\tif (ret)\n@@ -52,7 +45,6 @@ static int do_scsi(struct cmd_tbl *cmdtp, int flag, int argc,\n U_BOOT_CMD(\n \tscsi, 5, 1, do_scsi,\n \t\"SCSI sub-system\",\n-\t\"reset - reset SCSI controller\\n\"\n \t\"scsi info - show available SCSI devices\\n\"\n \t\"scsi scan - (re-)scan SCSI bus\\n\"\n \t\"scsi device [dev] - show or set current device\\n\"\ndiff --git a/test/py/tests/test_scsi.py b/test/py/tests/test_scsi.py\nindex 2a35e47e558..4390ff65845 100644\n--- a/test/py/tests/test_scsi.py\n+++ b/test/py/tests/test_scsi.py\n@@ -38,16 +38,6 @@ def scsi_setup(ubman):\n \n return dev_num, dev_type, dev_size\n \n-@pytest.mark.buildconfigspec('cmd_scsi')\n-def test_scsi_reset(ubman):\n- dev_num, dev_type, dev_size = scsi_setup(ubman)\n- output = ubman.run_command('scsi reset')\n- assert f'Device {dev_num}:' in output\n- assert f'Type: {dev_type}' in output\n- assert f'Capacity: {dev_size}' in output\n- output = ubman.run_command('echo $?')\n- assert output.endswith('0')\n-\n @pytest.mark.buildconfigspec('cmd_scsi')\n def test_scsi_info(ubman):\n dev_num, dev_type, dev_size = scsi_setup(ubman)\n", "prefixes": [] }