Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/2216575/?format=api
{ "id": 2216575, "url": "http://patchwork.ozlabs.org/api/patches/2216575/?format=api", "web_url": "http://patchwork.ozlabs.org/project/sparclinux/patch/20260326203341.60393-1-ebiggers@kernel.org/", "project": { "id": 10, "url": "http://patchwork.ozlabs.org/api/projects/10/?format=api", "name": "Linux SPARC Development ", "link_name": "sparclinux", "list_id": "sparclinux.vger.kernel.org", "list_email": "sparclinux@vger.kernel.org", "web_url": null, "scm_url": null, "webscm_url": null, "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20260326203341.60393-1-ebiggers@kernel.org>", "list_archive_url": null, "date": "2026-03-26T20:33:41", "name": "lib/crypto: sparc: Drop optimized MD5 code", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "182a2a25f647d08f3410bc7dc60c5ff09d495d93", "submitter": { "id": 74690, "url": "http://patchwork.ozlabs.org/api/people/74690/?format=api", "name": "Eric Biggers", "email": "ebiggers@kernel.org" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/sparclinux/patch/20260326203341.60393-1-ebiggers@kernel.org/mbox/", "series": [ { "id": 497648, "url": "http://patchwork.ozlabs.org/api/series/497648/?format=api", "web_url": "http://patchwork.ozlabs.org/project/sparclinux/list/?series=497648", "date": "2026-03-26T20:33:41", "name": "lib/crypto: sparc: Drop optimized MD5 code", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/497648/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2216575/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2216575/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "\n <SRS0=EBNr=B2=vger.kernel.org=sparclinux+bounces-6571-patchwork-incoming=ozlabs.org@ozlabs.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "sparclinux@vger.kernel.org" ], "Delivered-To": [ "patchwork-incoming@legolas.ozlabs.org", "patchwork-incoming@ozlabs.org" ], "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256\n header.s=k20201202 header.b=VY/ezY9B;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=ozlabs.org\n (client-ip=2404:9400:2221:ea00::3; helo=mail.ozlabs.org;\n envelope-from=srs0=ebnr=b2=vger.kernel.org=sparclinux+bounces-6571-patchwork-incoming=ozlabs.org@ozlabs.org;\n receiver=patchwork.ozlabs.org)", "gandalf.ozlabs.org;\n arc=pass smtp.remote-ip=172.105.105.114 arc.chain=subspace.kernel.org", "gandalf.ozlabs.org;\n dmarc=pass (p=quarantine dis=none) header.from=kernel.org", "gandalf.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256\n header.s=k20201202 header.b=VY/ezY9B;\n\tdkim-atps=neutral", "gandalf.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=172.105.105.114; helo=tor.lore.kernel.org;\n envelope-from=sparclinux+bounces-6571-patchwork-incoming=ozlabs.org@vger.kernel.org;\n receiver=ozlabs.org)", "smtp.subspace.kernel.org;\n\tdkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org\n header.b=\"VY/ezY9B\"", "smtp.subspace.kernel.org;\n arc=none smtp.client-ip=10.30.226.201" ], "Received": [ "from mail.ozlabs.org (mail.ozlabs.org [IPv6:2404:9400:2221:ea00::3])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fhb8m3MzPz1yFp\n\tfor <incoming@patchwork.ozlabs.org>; Fri, 27 Mar 2026 07:34:00 +1100 (AEDT)", "from mail.ozlabs.org (mail.ozlabs.org [IPv6:2404:9400:2221:ea00::3])\n\tby gandalf.ozlabs.org (Postfix) with ESMTP id 4fhb8m2HCfz4wM6\n\tfor <incoming@patchwork.ozlabs.org>; Fri, 27 Mar 2026 07:34:00 +1100 (AEDT)", "by gandalf.ozlabs.org (Postfix)\n\tid 4fhb8m23R0z4wSQ; Fri, 27 Mar 2026 07:34:00 +1100 (AEDT)", "from tor.lore.kernel.org (tor.lore.kernel.org [172.105.105.114])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby gandalf.ozlabs.org (Postfix) with ESMTPS id 4fhb8h2DR1z4wM6\n\tfor <patchwork-incoming@ozlabs.org>; Fri, 27 Mar 2026 07:33:56 +1100 (AEDT)", "from smtp.subspace.kernel.org (conduit.subspace.kernel.org\n [100.90.174.1])\n\tby tor.lore.kernel.org (Postfix) with ESMTP id ADCBD303793C\n\tfor <patchwork-incoming@ozlabs.org>; Thu, 26 Mar 2026 20:33:53 +0000 (UTC)", "from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id 16CBB39A7F6;\n\tThu, 26 Mar 2026 20:33:52 +0000 (UTC)", "from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org\n [10.30.226.201])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby smtp.subspace.kernel.org (Postfix) with ESMTPS id E6D0734A3D8;\n\tThu, 26 Mar 2026 20:33:51 +0000 (UTC)", "by smtp.kernel.org (Postfix) with ESMTPSA id 5D82CC116C6;\n\tThu, 26 Mar 2026 20:33:51 +0000 (UTC)" ], "ARC-Seal": [ "i=2; a=rsa-sha256; d=ozlabs.org; s=201707; t=1774557240; cv=pass;\n\tb=uaKuXG2f3sFhXkgxPKATJNSj7Dpn3aNVqZ3c2ocwsgFNnkL01MO0YoOtyaOF6eHWx3vzgrnXby3vDxONxlSoeuNrxbFslmfqkmrjGhQ0tvvMjokTp4L032nve3/9cVV8yX3EQQeXIajFL5EGT82yUJ/4wks/wpq3C+0K+KSAYzbbDMQIrMP06vn0SXR2W21tPjbcOpZZX2zJC49q+Sj3kmgYHhezrinzoXI2DyKCNMzKjzOO8ARhZN5MTKnmGzwn34zw5/bJhFu6bjY1//NrDki47VvzvpNggCTjnDgYqtyP/qqZx02eIzvV+2xehNUFjB7l+UuNPzVBuWA8vvi4yg==", "i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;\n\tt=1774557232; cv=none;\n b=POHqgABDa/LSDX/5c4t1qyFssCSvlI5fli7SZiieJdTRUZOQLOmCFl9IXp7bNACw+RIG/a6n5Esj9T42sMZjF3V4n6mkA+L78jcZl8T0OXb+g4Di0AsX5R4qkT4AzlDgU+2rdtX8ZmzCo6tl9iTua5CBhQE/kblPtprW5X8JAtA=" ], "ARC-Message-Signature": [ "i=2; a=rsa-sha256; d=ozlabs.org; s=201707;\n\tt=1774557240; c=relaxed/relaxed;\n\tbh=5xWjCYZsnY5FHUDKnQM59YqqAdvLHKRlih748gehtPA=;\n\th=From:To:Cc:Subject:Date:Message-ID:MIME-Version;\n b=eFZFbtw6CI1AsiCk9TyT+stVtp0Yll1SjDq2WEQ1qW1HxQKLYjfi2fWtyH2A3UiU2yzHTfQxXhigYS/z0d+zkn8cWHkwXgzEAhhg7FvGEe5qBeZ7YFcynL0IJ4s4C1DAH3Ncx6pjzsEUd6F0nX+6JIZ3X8XiCZfeZrw1qW0ed+SsRZogEcYrc5Zwj9F22ax66yi0r/jrbM2zHAGDZANk8sLvc9BGlbTVlDx01zRX/JDDOs66yOg+JZ38efwsS8kB89IR5iWzwaFvRhUFQOVqeWj8zh+oGK+i/r7tTkGHPqRwl+e+ELQ7gl/aCo4KM7i9OfdNI7QTO5JctxNyNrBtKw==", "i=1; a=rsa-sha256; d=subspace.kernel.org;\n\ts=arc-20240116; t=1774557232; c=relaxed/simple;\n\tbh=Pr5ogmVS/nQaXDB7AZFHq8parU19obu368R2tSsYo1k=;\n\th=From:To:Cc:Subject:Date:Message-ID:MIME-Version;\n b=s8yG/YcEWqlqUNBTz+DZC1ByUj9ibg6j++w3xFGw3ut/FMl1Trcyr7W1AwxamMQ9wZkoJLg43YzEb92bf9u4W2a0xc0x0Lg4StYuXp2HaAWkGw6x+zj3I5xa46vbyGuWHFT/DXYXMObJUW3yXPRZu8gJaxo8aWOraaSoDNIFSog=" ], "ARC-Authentication-Results": [ "i=2; gandalf.ozlabs.org;\n dmarc=pass (p=quarantine dis=none) header.from=kernel.org;\n dkim=pass (2048-bit key;\n unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256\n header.s=k20201202 header.b=VY/ezY9B; dkim-atps=neutral;\n spf=pass (client-ip=172.105.105.114; helo=tor.lore.kernel.org;\n envelope-from=sparclinux+bounces-6571-patchwork-incoming=ozlabs.org@vger.kernel.org;\n receiver=ozlabs.org) smtp.mailfrom=vger.kernel.org", "i=1; smtp.subspace.kernel.org;\n dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org\n header.b=VY/ezY9B; arc=none smtp.client-ip=10.30.226.201" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;\n\ts=k20201202; t=1774557231;\n\tbh=Pr5ogmVS/nQaXDB7AZFHq8parU19obu368R2tSsYo1k=;\n\th=From:To:Cc:Subject:Date:From;\n\tb=VY/ezY9BYdwxMO3cq4H5E9Tag29nOyiFKNKTw7aMN2xdoJGPDP3uTCC+UvpND9Sg6\n\t q86Ee64Ajp5OVVYk9MsfDkt5IS86HawELnqVPBs0CyBKy6BBXxDKZzK5yeEh4YeHXC\n\t QENDMKGsazeVdH+S4ejV9dGup6HH0ujVhbTKd/PXmhuCJif4kElVr3DOjz1zbntLRX\n\t WdDxZT4MCLJmCqd2ccXYvtfD9vhG7mdrtQ7zgjkjsMtJQrksM6B7iAWvK23by8RfnR\n\t a09dOO7feT1blTjcN5SOVq+WA3CrdkHZqw4GpVLnRdc8IHz9BAAE6aTvw+IP4BNWZ6\n\t BTGyRgak9V1Zw==", "From": "Eric Biggers <ebiggers@kernel.org>", "To": "linux-crypto@vger.kernel.org", "Cc": "linux-kernel@vger.kernel.org,\n\tArd Biesheuvel <ardb@kernel.org>,\n\t\"Jason A . Donenfeld\" <Jason@zx2c4.com>,\n\tHerbert Xu <herbert@gondor.apana.org.au>,\n\tsparclinux@vger.kernel.org,\n\tEric Biggers <ebiggers@kernel.org>", "Subject": "[PATCH] lib/crypto: sparc: Drop optimized MD5 code", "Date": "Thu, 26 Mar 2026 13:33:41 -0700", "Message-ID": "<20260326203341.60393-1-ebiggers@kernel.org>", "X-Mailer": "git-send-email 2.53.0", "Precedence": "bulk", "X-Mailing-List": "sparclinux@vger.kernel.org", "List-Id": "<sparclinux.vger.kernel.org>", "List-Subscribe": "<mailto:sparclinux+subscribe@vger.kernel.org>", "List-Unsubscribe": "<mailto:sparclinux+unsubscribe@vger.kernel.org>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-Spam-Status": "No, score=-1.2 required=5.0 tests=ARC_SIGNED,ARC_VALID,\n\tDKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DMARC_PASS,\n\tMAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=disabled\n\tversion=4.0.1", "X-Spam-Checker-Version": "SpamAssassin 4.0.1 (2024-03-25) on gandalf.ozlabs.org" }, "content": "MD5 is obsolete. Continuing to maintain architecture-optimized\nimplementations of MD5 is unnecessary and risky. It diverts resources\nfrom the modern algorithms that are actually important.\n\nWhile there was demand for continuing to maintain the PowerPC optimized\nMD5 code to accommodate userspace programs that are misusing AF_ALG\n(https://lore.kernel.org/linux-crypto/c4191597-341d-4fd7-bc3d-13daf7666c41@csgroup.eu/),\nno such demand has been seen for the SPARC optimized MD5 code.\n\nThus, let's drop it and focus effort on the more modern SHA algorithms,\nwhich already have optimized code for SPARC.\n\nSigned-off-by: Eric Biggers <ebiggers@kernel.org>\n---\n\nThis patch is targeting libcrypto-next\n\n lib/crypto/Kconfig | 1 -\n lib/crypto/Makefile | 1 -\n lib/crypto/sparc/md5.h | 48 --------------------------\n lib/crypto/sparc/md5_asm.S | 70 --------------------------------------\n 4 files changed, 120 deletions(-)\n delete mode 100644 lib/crypto/sparc/md5.h\n delete mode 100644 lib/crypto/sparc/md5_asm.S\n\n\nbase-commit: 7ac21b4032e5b9b8a6a312b6f1d54f4ba24d1c16", "diff": "diff --git a/lib/crypto/Kconfig b/lib/crypto/Kconfig\nindex 4b6f593dc72f..a5246171a000 100644\n--- a/lib/crypto/Kconfig\n+++ b/lib/crypto/Kconfig\n@@ -134,11 +134,10 @@ config CRYPTO_LIB_MD5\n config CRYPTO_LIB_MD5_ARCH\n \tbool\n \tdepends on CRYPTO_LIB_MD5 && !UML\n \tdefault y if MIPS && CPU_CAVIUM_OCTEON\n \tdefault y if PPC\n-\tdefault y if SPARC64\n \n config CRYPTO_LIB_MLDSA\n \ttristate\n \tselect CRYPTO_LIB_SHA3\n \thelp\ndiff --git a/lib/crypto/Makefile b/lib/crypto/Makefile\nindex ec1747f51d07..4b47a2e5c67c 100644\n--- a/lib/crypto/Makefile\n+++ b/lib/crypto/Makefile\n@@ -186,11 +186,10 @@ clean-files += powerpc/ghashp8-ppc.S\n obj-$(CONFIG_CRYPTO_LIB_MD5) += libmd5.o\n libmd5-y := md5.o\n ifeq ($(CONFIG_CRYPTO_LIB_MD5_ARCH),y)\n CFLAGS_md5.o += -I$(src)/$(SRCARCH)\n libmd5-$(CONFIG_PPC) += powerpc/md5-asm.o\n-libmd5-$(CONFIG_SPARC) += sparc/md5_asm.o\n endif # CONFIG_CRYPTO_LIB_MD5_ARCH\n \n ################################################################################\n \n obj-$(CONFIG_CRYPTO_LIB_MLDSA) += libmldsa.o\ndiff --git a/lib/crypto/sparc/md5.h b/lib/crypto/sparc/md5.h\ndeleted file mode 100644\nindex 3995f3e075eb..000000000000\n--- a/lib/crypto/sparc/md5.h\n+++ /dev/null\n@@ -1,48 +0,0 @@\n-/* SPDX-License-Identifier: GPL-2.0-only */\n-/*\n- * MD5 accelerated using the sparc64 crypto opcodes\n- *\n- * Copyright (c) Alan Smithee.\n- * Copyright (c) Andrew McDonald <andrew@mcdonald.org.uk>\n- * Copyright (c) Jean-Francois Dive <jef@linuxbe.org>\n- * Copyright (c) Mathias Krause <minipli@googlemail.com>\n- * Copyright (c) Cryptoapi developers.\n- * Copyright (c) 2002 James Morris <jmorris@intercode.com.au>\n- */\n-\n-#include <asm/elf.h>\n-#include <asm/opcodes.h>\n-#include <asm/pstate.h>\n-\n-static __ro_after_init DEFINE_STATIC_KEY_FALSE(have_md5_opcodes);\n-\n-asmlinkage void md5_sparc64_transform(struct md5_block_state *state,\n-\t\t\t\t const u8 *data, size_t nblocks);\n-\n-static void md5_blocks(struct md5_block_state *state,\n-\t\t const u8 *data, size_t nblocks)\n-{\n-\tif (static_branch_likely(&have_md5_opcodes)) {\n-\t\tcpu_to_le32_array(state->h, ARRAY_SIZE(state->h));\n-\t\tmd5_sparc64_transform(state, data, nblocks);\n-\t\tle32_to_cpu_array(state->h, ARRAY_SIZE(state->h));\n-\t} else {\n-\t\tmd5_blocks_generic(state, data, nblocks);\n-\t}\n-}\n-\n-#define md5_mod_init_arch md5_mod_init_arch\n-static void md5_mod_init_arch(void)\n-{\n-\tunsigned long cfr;\n-\n-\tif (!(sparc64_elf_hwcap & HWCAP_SPARC_CRYPTO))\n-\t\treturn;\n-\n-\t__asm__ __volatile__(\"rd %%asr26, %0\" : \"=r\" (cfr));\n-\tif (!(cfr & CFR_MD5))\n-\t\treturn;\n-\n-\tstatic_branch_enable(&have_md5_opcodes);\n-\tpr_info(\"Using sparc64 md5 opcode optimized MD5 implementation\\n\");\n-}\ndiff --git a/lib/crypto/sparc/md5_asm.S b/lib/crypto/sparc/md5_asm.S\ndeleted file mode 100644\nindex 60b544e4d205..000000000000\n--- a/lib/crypto/sparc/md5_asm.S\n+++ /dev/null\n@@ -1,70 +0,0 @@\n-/* SPDX-License-Identifier: GPL-2.0 */\n-#include <linux/linkage.h>\n-#include <asm/opcodes.h>\n-#include <asm/visasm.h>\n-\n-ENTRY(md5_sparc64_transform)\n-\t/* %o0 = digest, %o1 = data, %o2 = rounds */\n-\tVISEntryHalf\n-\tld\t[%o0 + 0x00], %f0\n-\tld\t[%o0 + 0x04], %f1\n-\tandcc\t%o1, 0x7, %g0\n-\tld\t[%o0 + 0x08], %f2\n-\tbne,pn\t%xcc, 10f\n-\t ld\t[%o0 + 0x0c], %f3\n-\n-1:\n-\tldd\t[%o1 + 0x00], %f8\n-\tldd\t[%o1 + 0x08], %f10\n-\tldd\t[%o1 + 0x10], %f12\n-\tldd\t[%o1 + 0x18], %f14\n-\tldd\t[%o1 + 0x20], %f16\n-\tldd\t[%o1 + 0x28], %f18\n-\tldd\t[%o1 + 0x30], %f20\n-\tldd\t[%o1 + 0x38], %f22\n-\n-\tMD5\n-\n-\tsubcc\t%o2, 1, %o2\n-\tbne,pt\t%xcc, 1b\n-\t add\t%o1, 0x40, %o1\n-\n-5:\n-\tst\t%f0, [%o0 + 0x00]\n-\tst\t%f1, [%o0 + 0x04]\n-\tst\t%f2, [%o0 + 0x08]\n-\tst\t%f3, [%o0 + 0x0c]\n-\tretl\n-\t VISExitHalf\n-10:\n-\talignaddr %o1, %g0, %o1\n-\n-\tldd\t[%o1 + 0x00], %f10\n-1:\n-\tldd\t[%o1 + 0x08], %f12\n-\tldd\t[%o1 + 0x10], %f14\n-\tldd\t[%o1 + 0x18], %f16\n-\tldd\t[%o1 + 0x20], %f18\n-\tldd\t[%o1 + 0x28], %f20\n-\tldd\t[%o1 + 0x30], %f22\n-\tldd\t[%o1 + 0x38], %f24\n-\tldd\t[%o1 + 0x40], %f26\n-\n-\tfaligndata %f10, %f12, %f8\n-\tfaligndata %f12, %f14, %f10\n-\tfaligndata %f14, %f16, %f12\n-\tfaligndata %f16, %f18, %f14\n-\tfaligndata %f18, %f20, %f16\n-\tfaligndata %f20, %f22, %f18\n-\tfaligndata %f22, %f24, %f20\n-\tfaligndata %f24, %f26, %f22\n-\n-\tMD5\n-\n-\tsubcc\t%o2, 1, %o2\n-\tfsrc2\t%f26, %f10\n-\tbne,pt\t%xcc, 1b\n-\t add\t%o1, 0x40, %o1\n-\n-\tba,a,pt\t%xcc, 5b\n-ENDPROC(md5_sparc64_transform)\n", "prefixes": [] }