Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/2216559/?format=api
{ "id": 2216559, "url": "http://patchwork.ozlabs.org/api/patches/2216559/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20260326190438.734239-2-adityag@linux.ibm.com/", "project": { "id": 14, "url": "http://patchwork.ozlabs.org/api/projects/14/?format=api", "name": "QEMU Development", "link_name": "qemu-devel", "list_id": "qemu-devel.nongnu.org", "list_email": "qemu-devel@nongnu.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20260326190438.734239-2-adityag@linux.ibm.com>", "list_archive_url": null, "date": "2026-03-26T19:04:37", "name": "[1/2] ppc/pnv_phb3: Error out on invalid config access", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "4a9271477a8da774354286ac7929aa13dece85d0", "submitter": { "id": 86610, "url": "http://patchwork.ozlabs.org/api/people/86610/?format=api", "name": "Aditya Gupta", "email": "adityag@linux.ibm.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20260326190438.734239-2-adityag@linux.ibm.com/mbox/", "series": [ { "id": 497639, "url": "http://patchwork.ozlabs.org/api/series/497639/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/list/?series=497639", "date": "2026-03-26T19:04:36", "name": "Replace assert with bound checks in PnvPHB3", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/497639/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2216559/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2216559/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=ibm.com header.i=@ibm.com header.a=rsa-sha256\n header.s=pp1 header.b=sBlPAM05;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)" ], "Received": [ "from lists.gnu.org (lists.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fhYCt5k0Xz1yGD\n\tfor <incoming@patchwork.ozlabs.org>; Fri, 27 Mar 2026 06:06:34 +1100 (AEDT)", "from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from <qemu-devel-bounces@nongnu.org>)\n\tid 1w5q1u-0000G6-Ux; Thu, 26 Mar 2026 15:06:06 -0400", "from eggs.gnu.org ([2001:470:142:3::10])\n by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <adityag@linux.ibm.com>)\n id 1w5q1j-0000FP-J3; Thu, 26 Mar 2026 15:05:57 -0400", "from mx0a-001b2d01.pphosted.com ([148.163.156.1])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <adityag@linux.ibm.com>)\n id 1w5q1f-0006rB-Ri; Thu, 26 Mar 2026 15:05:54 -0400", "from pps.filterd (m0356517.ppops.net [127.0.0.1])\n by mx0a-001b2d01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id\n 62QF4H7L1516773; Thu, 26 Mar 2026 19:05:43 GMT", "from ppma22.wdc07v.mail.ibm.com\n (5c.69.3da9.ip4.static.sl-reverse.com [169.61.105.92])\n by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 4d1kwa6t6k-1\n (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT);\n Thu, 26 Mar 2026 19:05:42 +0000 (GMT)", "from pps.filterd (ppma22.wdc07v.mail.ibm.com [127.0.0.1])\n by ppma22.wdc07v.mail.ibm.com (8.18.1.2/8.18.1.2) with ESMTP id\n 62QIlIvw006009;\n Thu, 26 Mar 2026 19:05:41 GMT", "from smtprelay03.fra02v.mail.ibm.com ([9.218.2.224])\n by ppma22.wdc07v.mail.ibm.com (PPS) with ESMTPS id 4d261yvexp-1\n (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT);\n Thu, 26 Mar 2026 19:05:41 +0000", "from smtpav03.fra02v.mail.ibm.com (smtpav03.fra02v.mail.ibm.com\n [10.20.54.102])\n by smtprelay03.fra02v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id\n 62QJ5beB40436032\n (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK);\n Thu, 26 Mar 2026 19:05:37 GMT", "from smtpav03.fra02v.mail.ibm.com (unknown [127.0.0.1])\n by IMSVA (Postfix) with ESMTP id A564D2004B;\n Thu, 26 Mar 2026 19:05:37 +0000 (GMT)", "from smtpav03.fra02v.mail.ibm.com (unknown [127.0.0.1])\n by IMSVA (Postfix) with ESMTP id 07F4720043;\n Thu, 26 Mar 2026 19:05:34 +0000 (GMT)", "from li-3c92a0cc-27cf-11b2-a85c-b804d9ca68fa.ibm.com (unknown\n [9.124.221.9]) by smtpav03.fra02v.mail.ibm.com (Postfix) with ESMTP;\n Thu, 26 Mar 2026 19:05:33 +0000 (GMT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=cc\n :content-transfer-encoding:date:from:in-reply-to:message-id\n :mime-version:references:subject:to; s=pp1; bh=KjGRoqCMbHnrP2gt0\n m8HYDFhtQnVbz7bSENElLJnbqo=; b=sBlPAM05dVtfSogmQq3LT3J/1RhkVzuLR\n l2N2JyFqQgajR1lANuwzEvmz+10yZTLSbYIwfxxCKHfy1NWf/NrEk5vvwsJQEWim\n XGsHZwL4h6c/tHY06xP1DGGo3VlvTknBqQuIQhmcvR6xGlHhvcpYkvtvbu5/lzAj\n hzL4Ym6ac/GKy99SGf5Sen2NG5kuAcd7stXUCDo24YGDOfSRPllkfvRZ6OFMWBtj\n qezk/JZHuhxjDM1OezDRukjpVQa3QkBd4Fc/n7dwHf+BhkPc4BHjeKB3/HoEgKed\n NyzmIP9Myz4ekXrNSb0EUItwNGOzLpBJmq96ZV5D/usfzqGtaYiyg==", "From": "Aditya Gupta <adityag@linux.ibm.com>", "To": "<qemu-devel@nongnu.org>", "Cc": "<qemu-ppc@nongnu.org>, Harsh Prateek Bora <harshpb@linux.ibm.com>,\n Zexiang Zhang <chan9yan9@gmail.com>,\n Nicholas Piggin <npiggin@gmail.com>, Thomas Huth <thuth@redhat.com>,\n Miles Glenn <milesg@linux.ibm.com>, \"Michael S . Tsirkin\" <mst@redhat.com>,\n Marcel Apfelbaum <marcel.apfelbaum@gmail.com>", "Subject": "[PATCH 1/2] ppc/pnv_phb3: Error out on invalid config access", "Date": "Fri, 27 Mar 2026 00:34:37 +0530", "Message-ID": "<20260326190438.734239-2-adityag@linux.ibm.com>", "X-Mailer": "git-send-email 2.53.0", "In-Reply-To": "<20260326190438.734239-1-adityag@linux.ibm.com>", "References": "<20260326190438.734239-1-adityag@linux.ibm.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-TM-AS-GCONF": "00", "X-Proofpoint-Reinject": "loops=2 maxloops=12", "X-Proofpoint-ORIG-GUID": "pdhJ62bkmZ8g4ZycpfHrn-NLKcwYBDJp", "X-Proofpoint-Spam-Details-Enc": "AW1haW4tMjYwMzI2MDEzNSBTYWx0ZWRfX0XTT6+MrxmgW\n bo5DyPPJBLZMPS7RA0YQMrxSCU/i16IymnU0Ubp5GWcT9UvKl+0KtDeJ6DUuGanKwFD8QTTqNKK\n 41zGn4ljDaR8h6gQ6XVUw4sR2Wr8sLqExaLOBC4s3AmzTYBRDl0hVUs6Dl49HOWPa/C9NCTLKQg\n /NUufeVDSpvNDBASkgW3bFbbsP/6wPjKCE6jr4Vb6XquyFR74+ck5TbWum9CS57QAvdnf4sNZ7z\n 8jDL4sDF1gN2Q2sH7TkELNXYBRCre2lLux0SbLVz1R/h/LCmpVtwZ1pqQgpcQB/es+Y1Op/pAig\n NzzWb1VmuDW2xiTFIbH+19OFgxtkO4necucHI3kkY8KfMdYTvSqRUlNgOs81FhLQtmBdQcqp9zZ\n qjANs44tOiNlYtXiI29XJDoUEhgjiQNd+3L3D5lRG35jeaAwaYdFuBSVZsV1YH7unwVc8LKdAyg\n iy8Riyo98FbrK2rWKzQ==", "X-Proofpoint-GUID": "ii_VIQoQfjUuCBl2VYjjeNLVd4tO5ixJ", "X-Authority-Analysis": "v=2.4 cv=OsZCCi/t c=1 sm=1 tr=0 ts=69c58387 cx=c_pps\n a=5BHTudwdYE3Te8bg5FgnPg==:117 a=5BHTudwdYE3Te8bg5FgnPg==:17\n a=Yq5XynenixoA:10 a=sWKEhP36mHoA:10 a=VkNPw1HP01LnGYTKEx00:22\n a=RnoormkPH1_aCDwRdu11:22 a=U7nrCbtTmkRpXpFmAIza:22 a=p0WdMEafAAAA:8\n a=pGLkceISAAAA:8 a=VnNF1IyMAAAA:8 a=x9OATstFSDA1Japifd4A:9", "X-Proofpoint-Virus-Version": "vendor=baseguard\n engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49\n definitions=2026-03-26_03,2026-03-26_01,2025-10-01_01", "X-Proofpoint-Spam-Details": "rule=outbound_notspam policy=outbound score=0\n impostorscore=0 adultscore=0 clxscore=1015 phishscore=0 suspectscore=0\n lowpriorityscore=0 priorityscore=1501 bulkscore=0 spamscore=0 malwarescore=0\n classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0\n reason=mlx scancount=1 engine=8.22.0-2603050001 definitions=main-2603260135", "Received-SPF": "pass client-ip=148.163.156.1;\n envelope-from=adityag@linux.ibm.com;\n helo=mx0a-001b2d01.pphosted.com", "X-Spam_score_int": "-26", "X-Spam_score": "-2.7", "X-Spam_bar": "--", "X-Spam_report": "(-2.7 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7,\n RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001,\n RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001,\n SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no", "X-Spam_action": "no action", "X-BeenThere": "qemu-devel@nongnu.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "qemu development <qemu-devel.nongnu.org>", "List-Unsubscribe": "<https://lists.nongnu.org/mailman/options/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>", "List-Archive": "<https://lists.nongnu.org/archive/html/qemu-devel>", "List-Post": "<mailto:qemu-devel@nongnu.org>", "List-Help": "<mailto:qemu-devel-request@nongnu.org?subject=help>", "List-Subscribe": "<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=subscribe>", "Errors-To": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org", "Sender": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org" }, "content": "PHB in Power8 supports 8 byte registers, and hence the ops structure\nallows accessing of 8 bytes in 'pnv_phb3_reg_ops'\n\nBoth 'pnv_phb3_reg_read' & 'pnv_phb3_reg_write' pass the arguments as is\nto 'pnv_phb3_config_{read,write}', if offset is PHB_CONFIG_DATA.\n\nThis when called with size as 8, causes following assert failure in\n'pci_host_config_read_common' & 'pci_host_config_write_common':\n\n assert(len <= 4);\n\nValidate that size is <=4, before jumping to pci_host_config_{read,write}_common\n\nResolves: https://gitlab.com/qemu-project/qemu/-/work_items/3334\nReported-by: Zexiang Zhang <chan9yan9@gmail.com>\nFixes: 9ae1329ee2fe (\"ppc/pnv: Add models for POWER8 PHB3 PCIe Host bridge\")\nSigned-off-by: Aditya Gupta <adityag@linux.ibm.com>\n---\n hw/pci-host/pnv_phb3.c | 10 ++++++++++\n 1 file changed, 10 insertions(+)", "diff": "diff --git a/hw/pci-host/pnv_phb3.c b/hw/pci-host/pnv_phb3.c\nindex d6ab5153374f..4ffdb4ce31ae 100644\n--- a/hw/pci-host/pnv_phb3.c\n+++ b/hw/pci-host/pnv_phb3.c\n@@ -475,6 +475,11 @@ void pnv_phb3_reg_write(void *opaque, hwaddr off, uint64_t val, unsigned size)\n \n /* Special case configuration data */\n if ((off & 0xfffc) == PHB_CONFIG_DATA) {\n+ if (size > 4) {\n+ phb3_error(phb, \"Invalid config access, offset: 0x%\"PRIx64\" size: %d\",\n+ off, size);\n+ return;\n+ }\n pnv_phb3_config_write(phb, off & 0x3, size, val);\n return;\n }\n@@ -597,6 +602,11 @@ uint64_t pnv_phb3_reg_read(void *opaque, hwaddr off, unsigned size)\n uint64_t val;\n \n if ((off & 0xfffc) == PHB_CONFIG_DATA) {\n+ if (size > 4) {\n+ phb3_error(phb, \"Invalid config access, offset: 0x%\"PRIx64\" size: %d\",\n+ off, size);\n+ return ~0ull;\n+ }\n return pnv_phb3_config_read(phb, off & 0x3, size);\n }\n \n", "prefixes": [ "1/2" ] }