Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/2216558/?format=api
{ "id": 2216558, "url": "http://patchwork.ozlabs.org/api/patches/2216558/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-ppc/patch/20260326190438.734239-3-adityag@linux.ibm.com/", "project": { "id": 69, "url": "http://patchwork.ozlabs.org/api/projects/69/?format=api", "name": "QEMU powerpc development", "link_name": "qemu-ppc", "list_id": "qemu-ppc.nongnu.org", "list_email": "qemu-ppc@nongnu.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20260326190438.734239-3-adityag@linux.ibm.com>", "list_archive_url": null, "date": "2026-03-26T19:04:38", "name": "[2/2] hw/pci: Replace assert with bounds check and return", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "44f01c0a53575573c94cec271c08839bce48ae50", "submitter": { "id": 86610, "url": "http://patchwork.ozlabs.org/api/people/86610/?format=api", "name": "Aditya Gupta", "email": "adityag@linux.ibm.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/qemu-ppc/patch/20260326190438.734239-3-adityag@linux.ibm.com/mbox/", "series": [ { "id": 497638, "url": "http://patchwork.ozlabs.org/api/series/497638/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-ppc/list/?series=497638", "date": "2026-03-26T19:04:36", "name": "Replace assert with bound checks in PnvPHB3", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/497638/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2216558/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2216558/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<qemu-ppc-bounces+incoming=patchwork.ozlabs.org@nongnu.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=ibm.com header.i=@ibm.com header.a=rsa-sha256\n header.s=pp1 header.b=qnCt8KJz;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-ppc-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)" ], "Received": [ "from lists.gnu.org (lists.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fhYCs1Nt2z1yGD\n\tfor <incoming@patchwork.ozlabs.org>; Fri, 27 Mar 2026 06:06:33 +1100 (AEDT)", "from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from <qemu-ppc-bounces@nongnu.org>)\n\tid 1w5q1z-0000K4-Uc; Thu, 26 Mar 2026 15:06:11 -0400", "from eggs.gnu.org ([2001:470:142:3::10])\n by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <adityag@linux.ibm.com>)\n id 1w5q1s-0000G5-S4; Thu, 26 Mar 2026 15:06:06 -0400", "from mx0a-001b2d01.pphosted.com ([148.163.156.1])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <adityag@linux.ibm.com>)\n id 1w5q1f-0006rT-Ss; Thu, 26 Mar 2026 15:05:56 -0400", "from pps.filterd (m0360083.ppops.net [127.0.0.1])\n by mx0a-001b2d01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id\n 62QAnh5a3792418; Thu, 26 Mar 2026 19:05:49 GMT", "from ppma11.dal12v.mail.ibm.com\n (db.9e.1632.ip4.static.sl-reverse.com [50.22.158.219])\n by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 4d1kxqpukk-1\n (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT);\n Thu, 26 Mar 2026 19:05:49 +0000 (GMT)", "from pps.filterd (ppma11.dal12v.mail.ibm.com [127.0.0.1])\n by ppma11.dal12v.mail.ibm.com (8.18.1.2/8.18.1.2) with ESMTP id\n 62QGoF2A004392;\n Thu, 26 Mar 2026 19:05:48 GMT", "from smtprelay03.fra02v.mail.ibm.com ([9.218.2.224])\n by ppma11.dal12v.mail.ibm.com (PPS) with ESMTPS id 4d28c2c368-1\n (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT);\n Thu, 26 Mar 2026 19:05:48 +0000", "from smtpav03.fra02v.mail.ibm.com (smtpav03.fra02v.mail.ibm.com\n [10.20.54.102])\n by smtprelay03.fra02v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id\n 62QJ5iUW50987452\n (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK);\n Thu, 26 Mar 2026 19:05:44 GMT", "from smtpav03.fra02v.mail.ibm.com (unknown [127.0.0.1])\n by IMSVA (Postfix) with ESMTP id 914FF2004D;\n Thu, 26 Mar 2026 19:05:44 +0000 (GMT)", "from smtpav03.fra02v.mail.ibm.com (unknown [127.0.0.1])\n by IMSVA (Postfix) with ESMTP id 2CA6A20043;\n Thu, 26 Mar 2026 19:05:40 +0000 (GMT)", "from li-3c92a0cc-27cf-11b2-a85c-b804d9ca68fa.ibm.com (unknown\n [9.124.221.9]) by smtpav03.fra02v.mail.ibm.com (Postfix) with ESMTP;\n Thu, 26 Mar 2026 19:05:39 +0000 (GMT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=cc\n :content-transfer-encoding:date:from:in-reply-to:message-id\n :mime-version:references:subject:to; s=pp1; bh=TmM46Lo3kd1WIaZix\n fJwNiMON3swWRzxjwlFnBItCyY=; b=qnCt8KJzdNV/pXRSgdMyAMKthESb1yPqF\n AhVcKnSTeFTuVQb6HHzygD++viI3Tp0Ab8N+wQ7nKZWZwzgCM7xzR2K/Dr80Au/o\n P+4xwTp3bykoMbO8/gOeRDyPy4LbbPFm7BUJVQK27XJLQSmpYgt9aVdnyCpbGifn\n dCsdpuKl3KvCx7VL4oTjfYCkMDd3+4O8W6KQxAk+8wQ6Q15cNj32m7RcntjWzluA\n FBZOpNE+AmnnDnBBocMJ5WNjBgVHCxS0RNOnAiy6HT8zrgduWKSevhVEkbYI493t\n fC/A0adPVacOs5Skz8tAnLc35b6fQ5m/expnMPgaENxUsTyfBy4sw==", "From": "Aditya Gupta <adityag@linux.ibm.com>", "To": "<qemu-devel@nongnu.org>", "Cc": "<qemu-ppc@nongnu.org>, Harsh Prateek Bora <harshpb@linux.ibm.com>,\n Zexiang Zhang <chan9yan9@gmail.com>,\n Nicholas Piggin <npiggin@gmail.com>, Thomas Huth <thuth@redhat.com>,\n Miles Glenn <milesg@linux.ibm.com>, \"Michael S . Tsirkin\" <mst@redhat.com>,\n Marcel Apfelbaum <marcel.apfelbaum@gmail.com>", "Subject": "[PATCH 2/2] hw/pci: Replace assert with bounds check and return", "Date": "Fri, 27 Mar 2026 00:34:38 +0530", "Message-ID": "<20260326190438.734239-3-adityag@linux.ibm.com>", "X-Mailer": "git-send-email 2.53.0", "In-Reply-To": "<20260326190438.734239-1-adityag@linux.ibm.com>", "References": "<20260326190438.734239-1-adityag@linux.ibm.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-TM-AS-GCONF": "00", "X-Proofpoint-Reinject": "loops=2 maxloops=12", "X-Proofpoint-ORIG-GUID": "9zjOGUx1S_KgRM9w4eHfVZTnLEhuAQqx", "X-Proofpoint-Spam-Details-Enc": "AW1haW4tMjYwMzI2MDEzNSBTYWx0ZWRfX13NfFT4ma9Jn\n VJPUIHHxgRMm1VZD5kGJ4KfOcvht/YSp/txrQtqv5461nXZNgceLtqz1L9d1LzUEIlv3sjYYZKO\n wZSgNgjQhowe3MH9NTOlaa1okWunHBKA5oxINt/gaQtC8SiBC8nm/xLREeAC49uQuoF/404QxwK\n OHFt2nv3ETWTlJ6KczYlWt2eJdqZqa+mL60xqp1peyavWhTaFPO1LMU2ODjKx6y7paPiw+BpYVg\n Fb5lr1xcgWiUvLipstSqN9mnXxxlf74xoKZcgR1ZOn7E2UQh2Sd5vjg/3q9U1ypP7F+/gDtimhh\n pinUI71wNFKLE3ySaZ7V2gT/QytT0MzXPoGODifo6CyJpqllCc3ljsX2hEdEC7Ht+OHq6vsDhdz\n bMr5ZoXtXLMqRQTsqhaHrw3gy6IWOs2kRhGP2tF3qasXJWMOtdT9PyoYGT+I3P6+pCESNjepluC\n s81BIaNNJS/0I0OmZEA==", "X-Authority-Analysis": "v=2.4 cv=bLEb4f+Z c=1 sm=1 tr=0 ts=69c5838d cx=c_pps\n a=aDMHemPKRhS1OARIsFnwRA==:117 a=aDMHemPKRhS1OARIsFnwRA==:17\n a=Yq5XynenixoA:10 a=VkNPw1HP01LnGYTKEx00:22 a=RnoormkPH1_aCDwRdu11:22\n a=iQ6ETzBq9ecOQQE5vZCe:22 a=p0WdMEafAAAA:8 a=pGLkceISAAAA:8 a=VnNF1IyMAAAA:8\n a=S5HtyE1eDOxyD5dW7SoA:9", "X-Proofpoint-GUID": "tlL83mH6BSkgNrdfH6sWHEJhWYI07bfz", "X-Proofpoint-Virus-Version": "vendor=baseguard\n engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49\n definitions=2026-03-26_03,2026-03-26_01,2025-10-01_01", "X-Proofpoint-Spam-Details": "rule=outbound_notspam policy=outbound score=0\n spamscore=0 adultscore=0 clxscore=1015 phishscore=0 impostorscore=0\n malwarescore=0 lowpriorityscore=0 suspectscore=0 bulkscore=0\n priorityscore=1501 classifier=typeunknown authscore=0 authtc= authcc=\n route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2603050001\n definitions=main-2603260135", "Received-SPF": "pass client-ip=148.163.156.1;\n envelope-from=adityag@linux.ibm.com;\n helo=mx0a-001b2d01.pphosted.com", "X-Spam_score_int": "-26", "X-Spam_score": "-2.7", "X-Spam_bar": "--", "X-Spam_report": "(-2.7 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7,\n RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001,\n RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001,\n SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no", "X-Spam_action": "no action", "X-BeenThere": "qemu-ppc@nongnu.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<qemu-ppc.nongnu.org>", "List-Unsubscribe": "<https://lists.nongnu.org/mailman/options/qemu-ppc>,\n <mailto:qemu-ppc-request@nongnu.org?subject=unsubscribe>", "List-Archive": "<https://lists.nongnu.org/archive/html/qemu-ppc>", "List-Post": "<mailto:qemu-ppc@nongnu.org>", "List-Help": "<mailto:qemu-ppc-request@nongnu.org?subject=help>", "List-Subscribe": "<https://lists.nongnu.org/mailman/listinfo/qemu-ppc>,\n <mailto:qemu-ppc-request@nongnu.org?subject=subscribe>", "Errors-To": "qemu-ppc-bounces+incoming=patchwork.ozlabs.org@nongnu.org", "Sender": "qemu-ppc-bounces+incoming=patchwork.ozlabs.org@nongnu.org" }, "content": "As reported in https://gitlab.com/qemu-project/qemu/-/work_items/3334,\ncallers of 'pci_host_config_{read,write}_common' can pass length as 8,\ncausing an assert failure\n\nThe original issue with pnv_phb3 triggering the assert was fixed in a\nprevious commit\n\nInstead of asserting on invalid length, check if the length is valid\n(<=4), otherwise return (with the failure error code in read)\n\nReported-by: Zexiang Zhang <chan9yan9@gmail.com>\nSigned-off-by: Aditya Gupta <adityag@linux.ibm.com>\n---\n hw/pci/pci_host.c | 14 ++++++++++++--\n 1 file changed, 12 insertions(+), 2 deletions(-)", "diff": "diff --git a/hw/pci/pci_host.c b/hw/pci/pci_host.c\nindex 91e3885c7f62..2a7fdfa5636e 100644\n--- a/hw/pci/pci_host.c\n+++ b/hw/pci/pci_host.c\n@@ -81,7 +81,12 @@ void pci_host_config_write_common(PCIDevice *pci_dev, uint32_t addr,\n return;\n }\n \n- assert(len <= 4);\n+ if (len > 4) {\n+ PCI_DPRINTF(\"%s: invalid length access: addr \" HWADDR_FMT_plx \" \\\n+ len %d val %\"PRIx32\"\\n\", __func__, addr, len, val);\n+ return;\n+ }\n+\n /* non-zero functions are only exposed when function 0 is present,\n * allowing direct removal of unexposed functions.\n */\n@@ -106,7 +111,12 @@ uint32_t pci_host_config_read_common(PCIDevice *pci_dev, uint32_t addr,\n return ~0x0;\n }\n \n- assert(len <= 4);\n+ if (len > 4) {\n+ PCI_DPRINTF(\"%s: invalid length access: addr \" HWADDR_FMT_plx \" \\\n+ len %d val %\"PRIx32\"\\n\", __func__, addr, len, val);\n+ return ~0x0;\n+ }\n+\n /* non-zero functions are only exposed when function 0 is present,\n * allowing direct removal of unexposed functions.\n */\n", "prefixes": [ "2/2" ] }