Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/2216538/?format=api
{ "id": 2216538, "url": "http://patchwork.ozlabs.org/api/patches/2216538/?format=api", "web_url": "http://patchwork.ozlabs.org/project/ltp/patch/20260326170435.22566-3-pvorel@suse.cz/", "project": { "id": 59, "url": "http://patchwork.ozlabs.org/api/projects/59/?format=api", "name": "Linux Test Project development", "link_name": "ltp", "list_id": "ltp.lists.linux.it", "list_email": "ltp@lists.linux.it", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20260326170435.22566-3-pvorel@suse.cz>", "list_archive_url": null, "date": "2026-03-26T17:04:34", "name": "[v2,2/3] lib: Rename variable LTP_ENABLE_DEBUG => LTP_DEBUG", "commit_ref": null, "pull_url": null, "state": "changes-requested", "archived": false, "hash": "df601758b87cd855e795824ffbb4ad3472c1c574", "submitter": { "id": 70792, "url": "http://patchwork.ozlabs.org/api/people/70792/?format=api", "name": "Petr Vorel", "email": "pvorel@suse.cz" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/ltp/patch/20260326170435.22566-3-pvorel@suse.cz/mbox/", "series": [ { "id": 497627, "url": "http://patchwork.ozlabs.org/api/series/497627/?format=api", "web_url": "http://patchwork.ozlabs.org/project/ltp/list/?series=497627", "date": "2026-03-26T17:04:32", "name": "lib: LTP_DEBUG cleanup", "version": 2, "mbox": "http://patchwork.ozlabs.org/series/497627/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2216538/comments/", "check": "success", "checks": "http://patchwork.ozlabs.org/api/patches/2216538/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<ltp-bounces+incoming=patchwork.ozlabs.org@lists.linux.it>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "ltp@lists.linux.it" ], "Delivered-To": [ "patchwork-incoming@legolas.ozlabs.org", "ltp@picard.linux.it" ], "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n unprotected) header.d=suse.cz header.i=@suse.cz header.a=rsa-sha256\n header.s=susede2_rsa header.b=aDnIkNih;\n\tdkim=fail reason=\"signature verification failed\" header.d=suse.cz\n header.i=@suse.cz header.a=ed25519-sha256 header.s=susede2_ed25519\n header.b=FepNxrZY;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key)\n header.d=suse.cz header.i=@suse.cz header.a=rsa-sha256 header.s=susede2_rsa\n header.b=aDnIkNih;\n\tdkim=neutral header.d=suse.cz header.i=@suse.cz header.a=ed25519-sha256\n header.s=susede2_ed25519 header.b=FepNxrZY;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.linux.it\n (client-ip=2001:1418:10:5::2; helo=picard.linux.it;\n envelope-from=ltp-bounces+incoming=patchwork.ozlabs.org@lists.linux.it;\n receiver=patchwork.ozlabs.org)", "smtp-out2.suse.de;\n\tnone" ], "Received": [ "from picard.linux.it (picard.linux.it [IPv6:2001:1418:10:5::2])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fhVWc6dVcz1yGD\n\tfor <incoming@patchwork.ozlabs.org>; Fri, 27 Mar 2026 04:05:00 +1100 (AEDT)", "from picard.linux.it (localhost [IPv6:::1])\n\tby picard.linux.it (Postfix) with ESMTP id E5AEB3C0206\n\tfor <incoming@patchwork.ozlabs.org>; Thu, 26 Mar 2026 18:04:58 +0100 (CET)", "from in-6.smtp.seeweb.it (in-6.smtp.seeweb.it\n [IPv6:2001:4b78:1:20::6])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature ECDSA (secp384r1))\n (No client certificate requested)\n by picard.linux.it (Postfix) with ESMTPS id 92CF53D031F\n for <ltp@lists.linux.it>; Thu, 26 Mar 2026 18:04:39 +0100 (CET)", "from smtp-out2.suse.de (smtp-out2.suse.de [195.135.223.131])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n (No client certificate requested)\n by in-6.smtp.seeweb.it (Postfix) with ESMTPS id 90DE414013B7\n for <ltp@lists.linux.it>; Thu, 26 Mar 2026 18:04:38 +0100 (CET)", "from imap1.dmz-prg2.suse.org (unknown [10.150.64.97])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest\n SHA256)\n (No client certificate requested)\n by smtp-out2.suse.de (Postfix) with ESMTPS id E1D2F5BF59;\n Thu, 26 Mar 2026 17:04:37 +0000 (UTC)", "from imap1.dmz-prg2.suse.org (localhost [127.0.0.1])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest\n SHA256)\n (No client certificate requested)\n by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id B15814A0A7;\n Thu, 26 Mar 2026 17:04:37 +0000 (UTC)", "from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167])\n by imap1.dmz-prg2.suse.org with ESMTPSA id YNytKSVnxWnqTQAAD6G6ig\n (envelope-from <pvorel@suse.cz>); Thu, 26 Mar 2026 17:04:37 +0000" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz;\n s=susede2_rsa;\n t=1774544677;\n h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:\n mime-version:mime-version:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=/6bPb3oQn3GVUHXuqLlS3T3xS7VD8rPQ5LV4s8EREc8=;\n b=aDnIkNihC4D3UfJBhZgPaxBtZzt/OUJMXNo+u3IMkz9+moodTriltvWBXR6XUPv9ibAXHE\n CHBvvgUTGvXcPxj8aG7rACcWE2aN8WfCoAsnxA8TeCtF9D7LOKq6EB3H2B1To3PmqIETOV\n U5m8yN2R0yYMZ4K5TVAZ9MWLnKmtssM=", "v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz;\n s=susede2_ed25519; t=1774544677;\n h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:\n mime-version:mime-version:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=/6bPb3oQn3GVUHXuqLlS3T3xS7VD8rPQ5LV4s8EREc8=;\n b=FepNxrZYcZFvwVTTjxsx/vuM5q7uTsHe25s49/PUCh7UEyiCagBX8bpKEFSOMitbmcxFce\n Cxdz8vhNbWaXN4DQ==", "v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz;\n s=susede2_rsa;\n t=1774544677;\n h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:\n mime-version:mime-version:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=/6bPb3oQn3GVUHXuqLlS3T3xS7VD8rPQ5LV4s8EREc8=;\n b=aDnIkNihC4D3UfJBhZgPaxBtZzt/OUJMXNo+u3IMkz9+moodTriltvWBXR6XUPv9ibAXHE\n CHBvvgUTGvXcPxj8aG7rACcWE2aN8WfCoAsnxA8TeCtF9D7LOKq6EB3H2B1To3PmqIETOV\n U5m8yN2R0yYMZ4K5TVAZ9MWLnKmtssM=", "v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz;\n s=susede2_ed25519; t=1774544677;\n h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:\n mime-version:mime-version:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=/6bPb3oQn3GVUHXuqLlS3T3xS7VD8rPQ5LV4s8EREc8=;\n b=FepNxrZYcZFvwVTTjxsx/vuM5q7uTsHe25s49/PUCh7UEyiCagBX8bpKEFSOMitbmcxFce\n Cxdz8vhNbWaXN4DQ==" ], "From": "Petr Vorel <pvorel@suse.cz>", "To": "ltp@lists.linux.it", "Date": "Thu, 26 Mar 2026 18:04:34 +0100", "Message-ID": "<20260326170435.22566-3-pvorel@suse.cz>", "X-Mailer": "git-send-email 2.53.0", "In-Reply-To": "<20260326170435.22566-1-pvorel@suse.cz>", "References": "<20260326170435.22566-1-pvorel@suse.cz>", "MIME-Version": "1.0", "X-Spam-Score": "-2.80", "X-Spam-Level": "", "X-Spamd-Result": "default: False [-2.80 / 50.00]; BAYES_HAM(-3.00)[100.00%];\n NEURAL_HAM_LONG(-1.00)[-1.000]; MID_CONTAINS_FROM(1.00)[];\n R_MISSING_CHARSET(0.50)[]; NEURAL_HAM_SHORT(-0.20)[-0.989];\n MIME_GOOD(-0.10)[text/plain]; TO_MATCH_ENVRCPT_ALL(0.00)[];\n FROM_HAS_DN(0.00)[]; ARC_NA(0.00)[]; MIME_TRACE(0.00)[0:+];\n TO_DN_SOME(0.00)[];\n DBL_BLOCKED_OPENRESOLVER(0.00)[imap1.dmz-prg2.suse.org:helo,suse.cz:mid,suse.cz:email];\n RCVD_VIA_SMTP_AUTH(0.00)[]; FROM_EQ_ENVFROM(0.00)[];\n RCVD_COUNT_TWO(0.00)[2]; FUZZY_RATELIMITED(0.00)[rspamd.com];\n DKIM_SIGNED(0.00)[suse.cz:s=susede2_rsa,suse.cz:s=susede2_ed25519];\n RCPT_COUNT_FIVE(0.00)[5]; RCVD_TLS_ALL(0.00)[]", "X-Spam-Status": "No, score=0.1 required=7.0 tests=DKIM_SIGNED,DKIM_VALID,\n DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_PASS shortcircuit=no\n autolearn=disabled version=4.0.1", "X-Spam-Checker-Version": "SpamAssassin 4.0.1 (2024-03-25) on in-6.smtp.seeweb.it", "X-Virus-Scanned": "clamav-milter 1.0.9 at in-6.smtp.seeweb.it", "X-Virus-Status": "Clean", "Subject": "[LTP] [PATCH v2 2/3] lib: Rename variable LTP_ENABLE_DEBUG =>\n LTP_DEBUG", "X-BeenThere": "ltp@lists.linux.it", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "Linux Test Project <ltp.lists.linux.it>", "List-Unsubscribe": "<https://lists.linux.it/options/ltp>,\n <mailto:ltp-request@lists.linux.it?subject=unsubscribe>", "List-Archive": "<http://lists.linux.it/pipermail/ltp/>", "List-Post": "<mailto:ltp@lists.linux.it>", "List-Help": "<mailto:ltp-request@lists.linux.it?subject=help>", "List-Subscribe": "<https://lists.linux.it/listinfo/ltp>,\n <mailto:ltp-request@lists.linux.it?subject=subscribe>", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "ltp-bounces+incoming=patchwork.ozlabs.org@lists.linux.it", "Sender": "\"ltp\" <ltp-bounces+incoming=patchwork.ozlabs.org@lists.linux.it>" }, "content": "1) LTP_DEBUG is shorter to write.\n2) Enable is usually meant as boolean (on/off), that hides possible 2\nvalue even more.\n\nSigned-off-by: Petr Vorel <pvorel@suse.cz>\n---\n doc/developers/debugging.rst | 2 +-\n doc/old/C-Test-API.asciidoc | 2 +-\n doc/users/setup_tests.rst | 2 +-\n lib/newlib_tests/tst_res_flags.c | 2 +-\n lib/tst_test.c | 6 +++---\n 5 files changed, 7 insertions(+), 7 deletions(-)", "diff": "diff --git a/doc/developers/debugging.rst b/doc/developers/debugging.rst\nindex 52f881c5c8..36dda0d90f 100644\n--- a/doc/developers/debugging.rst\n+++ b/doc/developers/debugging.rst\n@@ -9,7 +9,7 @@ Debug messages\n --------------\n \n The LTP framework supports ``TDEBUG`` flag test debug messages. These\n-messages can be enabled using the ``-D[1,2]`` parameter or setting ``LTP_ENABLE_DEBUG=1,2``\n+messages can be enabled using the ``-D[1,2]`` parameter or setting ``LTP_DEBUG=1,2``\n environment variable (see :doc:`../users/setup_tests`).\n \n The ``-D`` parameter also supports the following verbosity levels:\ndiff --git a/doc/old/C-Test-API.asciidoc b/doc/old/C-Test-API.asciidoc\nindex 72fd2731d3..4207b28e92 100644\n--- a/doc/old/C-Test-API.asciidoc\n+++ b/doc/old/C-Test-API.asciidoc\n@@ -232,7 +232,7 @@ Printf-like function to report test result, it's mostly used with ttype:\n | 'TPASS' | Test has passed.\n | 'TFAIL' | Test has failed.\n | 'TINFO' | General message.\n-| 'TDEBUG' | Debug message (new C API only, printed with '-D' or via 'LTP_ENABLE_DEBUG=1' or 'y'\n+| 'TDEBUG' | Debug message (new C API only, printed with '-D' or via 'LTP_DEBUG=1' or 'y'\n environment variable), only for messages which would be too verbose for normal run.\n | 'TWARN' | Something went wrong but we decided to continue. Mostly used in cleanup functions.\n |==============================\ndiff --git a/doc/users/setup_tests.rst b/doc/users/setup_tests.rst\nindex 95d4d9e380..a42c397feb 100644\n--- a/doc/users/setup_tests.rst\n+++ b/doc/users/setup_tests.rst\n@@ -90,7 +90,7 @@ users.\n - Disable running test cleanup (defined in ``TST_CLEANUP``).\n Shell API only.\n \n- * - LTP_ENABLE_DEBUG\n+ * - LTP_DEBUG\n - Enable debug info (value ``1`` (``y``) or ``2`` for more verbose level).\n Equivalent of ``-D`` parameter.\n \ndiff --git a/lib/newlib_tests/tst_res_flags.c b/lib/newlib_tests/tst_res_flags.c\nindex 21637a472b..9993d0f87d 100644\n--- a/lib/newlib_tests/tst_res_flags.c\n+++ b/lib/newlib_tests/tst_res_flags.c\n@@ -21,7 +21,7 @@ static struct tcase {\n \t{FLAG(TCONF)},\n \t{FLAG(TWARN)},\n \t{FLAG(TINFO)},\n-\t{FLAG(TDEBUG), \" (printed only with -D[1,2] or LTP_ENABLE_DEBUG=1,2)\"},\n+\t{FLAG(TDEBUG), \" (printed only with -D[1,2] or LTP_DEBUG=1,2)\"},\n };\n \n static void do_cleanup(void)\ndiff --git a/lib/tst_test.c b/lib/tst_test.c\nindex 4a22f2e477..6b41c6e28f 100644\n--- a/lib/tst_test.c\n+++ b/lib/tst_test.c\n@@ -675,7 +675,7 @@ static void print_help(void)\n \tfprintf(stderr, \"LTP_COLORIZE_OUTPUT Force colorized output behaviour (y/1 always, n/0: never)\\n\");\n \tfprintf(stderr, \"LTP_DEV Path to the block device to be used (for .needs_device)\\n\");\n \tfprintf(stderr, \"LTP_DEV_FS_TYPE Filesystem used for testing (default: %s)\\n\", DEFAULT_FS_TYPE);\n-\tfprintf(stderr, \"LTP_ENABLE_DEBUG Print debug messages (set 1(y) or 2)\\n\");\n+\tfprintf(stderr, \"LTP_DEBUG Print debug messages (set 1(y) or 2)\\n\");\n \tfprintf(stderr, \"LTP_REPRODUCIBLE_OUTPUT Values 1 or y discard the actual content of the messages printed by the test\\n\");\n \tfprintf(stderr, \"LTP_QUIET Values 1 or y will suppress printing TCONF, TWARN, TINFO, and TDEBUG messages\\n\");\n \tfprintf(stderr, \"LTP_SINGLE_FS_TYPE Specifies filesystem instead all supported (for .all_filesystems)\\n\");\n@@ -1400,7 +1400,7 @@ bool tst_cmd_present(const char *cmd)\n \n static void do_setup(int argc, char *argv[])\n {\n-\tchar *tdebug_env = getenv(\"LTP_ENABLE_DEBUG\");\n+\tchar *tdebug_env = getenv(\"LTP_DEBUG\");\n \tchar *reproducible_env = getenv(\"LTP_REPRODUCIBLE_OUTPUT\");\n \tchar *quiet_env = getenv(\"LTP_QUIET\");\n \n@@ -1451,7 +1451,7 @@ static void do_setup(int argc, char *argv[])\n \t\telse if (!strcmp(tdebug_env, \"1\") || !strcmp(tdebug_env, \"y\"))\n \t\t\tcontext->tdebug = 1;\n \t\telse\n-\t\t\ttst_res(TWARN, \"Invalid LTP_ENABLE_DEBUG value: '%s'\", tdebug_env);\n+\t\t\ttst_res(TWARN, \"Invalid LTP_DEBUG value: '%s'\", tdebug_env);\n \n \t\tif (context->tdebug)\n \t\t\ttst_res(TINFO, \"Enabling debug info (level %d)\", context->tdebug);\n", "prefixes": [ "v2", "2/3" ] }