Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/2216525/?format=api
{ "id": 2216525, "url": "http://patchwork.ozlabs.org/api/patches/2216525/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20260326162832.3135857-8-grzegorz.nitka@intel.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20260326162832.3135857-8-grzegorz.nitka@intel.com>", "list_archive_url": null, "date": "2026-03-26T16:28:31", "name": "[v4,net-next,7/8] ice: add Tx reference clock index handling to AN restart command", "commit_ref": null, "pull_url": null, "state": "handled-elsewhere", "archived": false, "hash": "ca2d834ed4a9c8e03327a2a8bf77d7a041c45eba", "submitter": { "id": 82711, "url": "http://patchwork.ozlabs.org/api/people/82711/?format=api", "name": "Nitka, Grzegorz", "email": "grzegorz.nitka@intel.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20260326162832.3135857-8-grzegorz.nitka@intel.com/mbox/", "series": [ { "id": 497620, "url": "http://patchwork.ozlabs.org/api/series/497620/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/list/?series=497620", "date": "2026-03-26T16:28:24", "name": "dpll/ice: Add TXC DPLL type and full TX reference clock control for E825", "version": 4, "mbox": "http://patchwork.ozlabs.org/series/497620/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2216525/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2216525/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@legolas.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=osuosl.org header.i=@osuosl.org header.a=rsa-sha256\n header.s=default header.b=wMBc9w95;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=osuosl.org\n (client-ip=140.211.166.136; helo=smtp3.osuosl.org;\n envelope-from=intel-wired-lan-bounces@osuosl.org;\n receiver=patchwork.ozlabs.org)" ], "Received": [ "from smtp3.osuosl.org (smtp3.osuosl.org [140.211.166.136])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fhTq75ZsMz1yGD\n\tfor <incoming@patchwork.ozlabs.org>; Fri, 27 Mar 2026 03:33:23 +1100 (AEDT)", "from localhost (localhost [127.0.0.1])\n\tby smtp3.osuosl.org (Postfix) with ESMTP id CBDBF60AF5;\n\tThu, 26 Mar 2026 16:33:21 +0000 (UTC)", "from smtp3.osuosl.org ([127.0.0.1])\n by localhost (smtp3.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP\n id TnQb3vgwcEHj; Thu, 26 Mar 2026 16:33:20 +0000 (UTC)", "from lists1.osuosl.org (lists1.osuosl.org [140.211.166.142])\n\tby smtp3.osuosl.org (Postfix) with ESMTP id 3DB9860AD3;\n\tThu, 26 Mar 2026 16:33:20 +0000 (UTC)", "from smtp1.osuosl.org (smtp1.osuosl.org [140.211.166.138])\n by lists1.osuosl.org (Postfix) with ESMTP id B5F611D3\n for <intel-wired-lan@lists.osuosl.org>; Thu, 26 Mar 2026 16:33:18 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n by smtp1.osuosl.org (Postfix) with ESMTP id 9C2078129B\n for <intel-wired-lan@lists.osuosl.org>; Thu, 26 Mar 2026 16:33:18 +0000 (UTC)", "from smtp1.osuosl.org ([127.0.0.1])\n by localhost (smtp1.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP\n id EKvgdHx2GRsR for <intel-wired-lan@lists.osuosl.org>;\n Thu, 26 Mar 2026 16:33:16 +0000 (UTC)", "from mgamail.intel.com (mgamail.intel.com [192.198.163.19])\n by smtp1.osuosl.org (Postfix) with ESMTPS id 746878129A\n for <intel-wired-lan@lists.osuosl.org>; Thu, 26 Mar 2026 16:33:16 +0000 (UTC)", "from orviesa007.jf.intel.com ([10.64.159.147])\n by fmvoesa113.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 26 Mar 2026 09:33:16 -0700", "from gklab-003-001.igk.intel.com ([10.91.173.48])\n by orviesa007.jf.intel.com with ESMTP; 26 Mar 2026 09:33:12 -0700" ], "X-Virus-Scanned": [ "amavis at osuosl.org", "amavis at osuosl.org" ], "X-Comment": "SPF check N/A for local connections - client-ip=140.211.166.142;\n helo=lists1.osuosl.org; envelope-from=intel-wired-lan-bounces@osuosl.org;\n receiver=<UNKNOWN> ", "DKIM-Filter": [ "OpenDKIM Filter v2.11.0 smtp3.osuosl.org 3DB9860AD3", "OpenDKIM Filter v2.11.0 smtp1.osuosl.org 746878129A" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=osuosl.org;\n\ts=default; t=1774542800;\n\tbh=0fM3I6+OikB7+hj88oE9o72YJlLiLOrM9Di0KxaBgcA=;\n\th=From:To:Date:In-Reply-To:References:Subject:List-Id:\n\t List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe:\n\t Cc:From;\n\tb=wMBc9w95oJjb2ZZyLSyjwOvKaMeZUk1mXsnQmrgldSptU5qkM8dJBtBGK2mH7JrA+\n\t aUDkJaZK/xYg80duzoGNoItboTw3Zt4VULNS3n3Ry27pVemx5N7eIhFaYk1hAzesZ0\n\t HiGdXiLgnF6r4ATRMg07ZCECQLjEE2rq5BJJSQLVY+lO0jcgzx1gLbhRC6qQvwtY51\n\t ODEOBTUImafb/QAIvf+Xdv8DKCoe+Mmr/feZt2cbC3sdUuQE+TlFpX2sIxfWvMZRrx\n\t HMi1C+GZfxDjbtMofQhVPw6vHfgqnaavFsST5MhChLGu9vpMBec5XmmWZ53ZFpuUPq\n\t 6wAx9L80l9x6w==", "Received-SPF": "Pass (mailfrom) identity=mailfrom; client-ip=192.198.163.19;\n helo=mgamail.intel.com; envelope-from=grzegorz.nitka@intel.com;\n receiver=<UNKNOWN>", "DMARC-Filter": "OpenDMARC Filter v1.4.2 smtp1.osuosl.org 746878129A", "X-CSE-ConnectionGUID": [ "Dnk9xQtjSP+JRW8jymk5LA==", "eX5HKoH3SbyKGTplUSVCIg==" ], "X-CSE-MsgGUID": [ "FZRPVRUWRVqVvSywGQW9NA==", "nr2VscN5RQO67pCuqqFE5Q==" ], "X-IronPort-AV": [ "E=McAfee;i=\"6800,10657,11741\"; a=\"74636745\"", "E=Sophos;i=\"6.23,142,1770624000\"; d=\"scan'208\";a=\"74636745\"", "E=Sophos;i=\"6.23,142,1770624000\"; d=\"scan'208\";a=\"225311294\"" ], "X-ExtLoop1": "1", "From": "Grzegorz Nitka <grzegorz.nitka@intel.com>", "To": "netdev@vger.kernel.org", "Date": "Thu, 26 Mar 2026 17:28:31 +0100", "Message-Id": "<20260326162832.3135857-8-grzegorz.nitka@intel.com>", "X-Mailer": "git-send-email 2.39.3", "In-Reply-To": "<20260326162832.3135857-1-grzegorz.nitka@intel.com>", "References": "<20260326162832.3135857-1-grzegorz.nitka@intel.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-Mailman-Original-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple;\n d=intel.com; i=@intel.com; q=dns/txt; s=Intel;\n t=1774542796; x=1806078796;\n h=from:to:cc:subject:date:message-id:in-reply-to:\n references:mime-version:content-transfer-encoding;\n bh=2MZHnP/9cS14JCDWx6lZ3RRAkM3yTL2R5Dnn1mrIUqo=;\n b=W8W1+pSZ655/vCDWRIkMO1xs5Z5GDl/Q3ZTjY+uViIVkZS2qZejQAHUD\n o5eOELANF620YBk5jM1Y7HCK0umNxdsZFoH/SI5PSF5Qe/Q9Zi0WGEKyK\n nFA4aeX4IAMaguY9tFtY9R8/TGQy5FzUdjcFlU0PWq7wPKRHeCFCx9YFq\n XH7tUgv7CUf9vYebTASGp9j4r+m4cccAy7KgLC4qj6fHz6R/GeWDBdCx3\n Nn/OcTm9aHJkkwqYiY/ZQgJtAIzksnzSB6LuwnQuTrL3eddrV7gUGXZrT\n Ti5EBpE1o1NwedlI2Vylxsj1FecBB9PfvKs/Y/F3yWZNHd4ZEHRtLgdeI\n Q==;", "X-Mailman-Original-Authentication-Results": [ "smtp1.osuosl.org;\n dmarc=pass (p=none dis=none)\n header.from=intel.com", "smtp1.osuosl.org;\n dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com\n header.a=rsa-sha256 header.s=Intel header.b=W8W1+pSZ" ], "Subject": "[Intel-wired-lan] [PATCH v4 net-next 7/8] ice: add Tx reference\n clock index handling to AN restart command", "X-BeenThere": "intel-wired-lan@osuosl.org", "X-Mailman-Version": "2.1.30", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n <intel-wired-lan.osuosl.org>", "List-Unsubscribe": "<https://lists.osuosl.org/mailman/options/intel-wired-lan>,\n <mailto:intel-wired-lan-request@osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@osuosl.org?subject=help>", "List-Subscribe": "<https://lists.osuosl.org/mailman/listinfo/intel-wired-lan>,\n <mailto:intel-wired-lan-request@osuosl.org?subject=subscribe>", "Cc": "ivecera@redhat.com, vadim.fedorenko@linux.dev, kuba@kernel.org,\n jiri@resnulli.us, edumazet@google.com, przemyslaw.kitszel@intel.com,\n richardcochran@gmail.com, donald.hunter@gmail.com,\n linux-kernel@vger.kernel.org, arkadiusz.kubalewski@intel.com,\n andrew+netdev@lunn.ch, intel-wired-lan@lists.osuosl.org, horms@kernel.org,\n Prathosh.Satish@microchip.com, anthony.l.nguyen@intel.com, pabeni@redhat.com,\n davem@davemloft.net", "Errors-To": "intel-wired-lan-bounces@osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@osuosl.org>" }, "content": "Extend the Restart Auto-Negotiation (AN) AdminQ command with a new\nparameter allowing software to specify the Tx reference clock index to\nbe used during link restart.\n\nThis patch:\n - adds REFCLK field definitions to ice_aqc_restart_an\n - updates ice_aq_set_link_restart_an() to take a new refclk parameter\n and properly encode it into the command\n - keeps legacy behavior by passing REFCLK_NOCHANGE where appropriate\n\nThis prepares the driver for configurations requiring dynamic selection\nof the Tx reference clock as part of the AN flow.\n\nReviewed-by: Arkadiusz Kubalewski <arkadiusz.kubalewski@intel.com>\nSigned-off-by: Grzegorz Nitka <grzegorz.nitka@intel.com>\n---\n drivers/net/ethernet/intel/ice/ice_adminq_cmd.h | 2 ++\n drivers/net/ethernet/intel/ice/ice_common.c | 5 ++++-\n drivers/net/ethernet/intel/ice/ice_common.h | 2 +-\n drivers/net/ethernet/intel/ice/ice_lib.c | 3 ++-\n 4 files changed, 9 insertions(+), 3 deletions(-)", "diff": "diff --git a/drivers/net/ethernet/intel/ice/ice_adminq_cmd.h b/drivers/net/ethernet/intel/ice/ice_adminq_cmd.h\nindex 859e9c66f3e7..a24a0613d887 100644\n--- a/drivers/net/ethernet/intel/ice/ice_adminq_cmd.h\n+++ b/drivers/net/ethernet/intel/ice/ice_adminq_cmd.h\n@@ -1169,6 +1169,8 @@ struct ice_aqc_restart_an {\n \tu8 cmd_flags;\n #define ICE_AQC_RESTART_AN_LINK_RESTART\tBIT(1)\n #define ICE_AQC_RESTART_AN_LINK_ENABLE\tBIT(2)\n+#define ICE_AQC_RESTART_AN_REFCLK_M\tGENMASK(4, 3)\n+#define ICE_AQC_RESTART_AN_REFCLK_NOCHANGE 0\n \tu8 reserved2[13];\n };\n \ndiff --git a/drivers/net/ethernet/intel/ice/ice_common.c b/drivers/net/ethernet/intel/ice/ice_common.c\nindex ce11fea122d0..de88aec9137c 100644\n--- a/drivers/net/ethernet/intel/ice/ice_common.c\n+++ b/drivers/net/ethernet/intel/ice/ice_common.c\n@@ -4126,12 +4126,13 @@ int ice_get_link_status(struct ice_port_info *pi, bool *link_up)\n * @pi: pointer to the port information structure\n * @ena_link: if true: enable link, if false: disable link\n * @cd: pointer to command details structure or NULL\n+ * @refclk: the new TX reference clock, 0 if no change\n *\n * Sets up the link and restarts the Auto-Negotiation over the link.\n */\n int\n ice_aq_set_link_restart_an(struct ice_port_info *pi, bool ena_link,\n-\t\t\t struct ice_sq_cd *cd)\n+\t\t\t struct ice_sq_cd *cd, u8 refclk)\n {\n \tstruct ice_aqc_restart_an *cmd;\n \tstruct libie_aq_desc desc;\n@@ -4147,6 +4148,8 @@ ice_aq_set_link_restart_an(struct ice_port_info *pi, bool ena_link,\n \telse\n \t\tcmd->cmd_flags &= ~ICE_AQC_RESTART_AN_LINK_ENABLE;\n \n+\tcmd->cmd_flags |= FIELD_PREP(ICE_AQC_RESTART_AN_REFCLK_M, refclk);\n+\n \treturn ice_aq_send_cmd(pi->hw, &desc, NULL, 0, cd);\n }\n \ndiff --git a/drivers/net/ethernet/intel/ice/ice_common.h b/drivers/net/ethernet/intel/ice/ice_common.h\nindex e700ac0dc347..9f5344212195 100644\n--- a/drivers/net/ethernet/intel/ice/ice_common.h\n+++ b/drivers/net/ethernet/intel/ice/ice_common.h\n@@ -215,7 +215,7 @@ ice_cfg_phy_fec(struct ice_port_info *pi, struct ice_aqc_set_phy_cfg_data *cfg,\n \t\tenum ice_fec_mode fec);\n int\n ice_aq_set_link_restart_an(struct ice_port_info *pi, bool ena_link,\n-\t\t\t struct ice_sq_cd *cd);\n+\t\t\t struct ice_sq_cd *cd, u8 refclk);\n int\n ice_aq_set_mac_cfg(struct ice_hw *hw, u16 max_frame_size, struct ice_sq_cd *cd);\n int\ndiff --git a/drivers/net/ethernet/intel/ice/ice_lib.c b/drivers/net/ethernet/intel/ice/ice_lib.c\nindex 689c6025ea82..c2c7f186bcc7 100644\n--- a/drivers/net/ethernet/intel/ice/ice_lib.c\n+++ b/drivers/net/ethernet/intel/ice/ice_lib.c\n@@ -3769,7 +3769,8 @@ int ice_set_link(struct ice_vsi *vsi, bool ena)\n \tif (vsi->type != ICE_VSI_PF)\n \t\treturn -EINVAL;\n \n-\tstatus = ice_aq_set_link_restart_an(pi, ena, NULL);\n+\tstatus = ice_aq_set_link_restart_an(pi, ena, NULL,\n+\t\t\t\t\t ICE_AQC_RESTART_AN_REFCLK_NOCHANGE);\n \n \t/* if link is owned by manageability, FW will return LIBIE_AQ_RC_EMODE.\n \t * this is not a fatal error, so print a warning message and return\n", "prefixes": [ "v4", "net-next", "7/8" ] }