Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/2216508/?format=api
{ "id": 2216508, "url": "http://patchwork.ozlabs.org/api/patches/2216508/?format=api", "web_url": "http://patchwork.ozlabs.org/project/linux-mtd/patch/20260326-winbond-v6-18-rc1-cont-read-v2-5-643de97a68a3@bootlin.com/", "project": { "id": 3, "url": "http://patchwork.ozlabs.org/api/projects/3/?format=api", "name": "Linux MTD development", "link_name": "linux-mtd", "list_id": "linux-mtd.lists.infradead.org", "list_email": "linux-mtd@lists.infradead.org", "web_url": null, "scm_url": null, "webscm_url": null, "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20260326-winbond-v6-18-rc1-cont-read-v2-5-643de97a68a3@bootlin.com>", "list_archive_url": null, "date": "2026-03-26T16:25:52", "name": "[v2,05/11] spi: spi-mem: Create a secondary read operation", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "e7cb58836ae88e52bc5787208b0717008528c598", "submitter": { "id": 73368, "url": "http://patchwork.ozlabs.org/api/people/73368/?format=api", "name": "Miquel Raynal", "email": "miquel.raynal@bootlin.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/linux-mtd/patch/20260326-winbond-v6-18-rc1-cont-read-v2-5-643de97a68a3@bootlin.com/mbox/", "series": [ { "id": 497619, "url": "http://patchwork.ozlabs.org/api/series/497619/?format=api", "web_url": "http://patchwork.ozlabs.org/project/linux-mtd/list/?series=497619", "date": "2026-03-26T16:25:47", "name": "[v2,01/11] mtd: spinand: Drop a too strong limitation", "version": 2, "mbox": "http://patchwork.ozlabs.org/series/497619/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2216508/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2216508/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "\n <linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n secure) header.d=lists.infradead.org header.i=@lists.infradead.org\n header.a=rsa-sha256 header.s=bombadil.20210309 header.b=hr3gA2ME;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n unprotected) header.d=bootlin.com header.i=@bootlin.com header.a=rsa-sha256\n header.s=dkim header.b=I/QLYXw9;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=none (no SPF record) smtp.mailfrom=lists.infradead.org\n (client-ip=2607:7c80:54:3::133; helo=bombadil.infradead.org;\n envelope-from=linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org;\n receiver=patchwork.ozlabs.org)" ], "Received": [ "from bombadil.infradead.org (bombadil.infradead.org\n [IPv6:2607:7c80:54:3::133])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fhTgJ5xKsz20KZ\n\tfor <incoming@patchwork.ozlabs.org>; Fri, 27 Mar 2026 03:26:34 +1100 (AEDT)", "from localhost ([::1] helo=bombadil.infradead.org)\n\tby bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux))\n\tid 1w5nXJ-00000005qdR-35ez;\n\tThu, 26 Mar 2026 16:26:21 +0000", "from smtpout-03.galae.net ([185.246.85.4])\n\tby bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux))\n\tid 1w5nXD-00000005qZl-3y7Y\n\tfor linux-mtd@lists.infradead.org;\n\tThu, 26 Mar 2026 16:26:17 +0000", "from smtpout-01.galae.net (smtpout-01.galae.net [212.83.139.233])\n\tby smtpout-03.galae.net (Postfix) with ESMTPS id 3AF6D4E42811;\n\tThu, 26 Mar 2026 16:26:14 +0000 (UTC)", "from mail.galae.net (mail.galae.net [212.83.136.155])\n\tby smtpout-01.galae.net (Postfix) with ESMTPS id 10BD2601FA;\n\tThu, 26 Mar 2026 16:26:14 +0000 (UTC)", "from [127.0.0.1] (localhost [127.0.0.1]) by localhost (Mailerdaemon)\n with ESMTPSA id 6784310450C96;\n\tThu, 26 Mar 2026 17:26:12 +0100 (CET)" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;\n\td=lists.infradead.org; s=bombadil.20210309; h=Sender:\n\tContent-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post:\n\tList-Archive:List-Unsubscribe:List-Id:Cc:To:In-Reply-To:References:Message-Id\n\t:MIME-Version:Subject:Date:From:Reply-To:Content-ID:Content-Description:\n\tResent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:\n\tList-Owner; bh=lREmBHbVu6c/48KY76zF8HY9ubwCWSJ3hu3FtMZVfBk=; b=hr3gA2MErbVk2+\n\txvVoA8bVrpmeF56tCRQyEDmE2UvGMzGoz/WQbyeo/Y5dbyCN9bGZaVWkfm3ClxcRl8Zcxnt99xgSG\n\tWPtnkG+qoavvxwWQ28YXzs3WY8DUsLjbAyUpzvAh1FyuJEl6/q/Y5XiJ+d41W7Zl2T4+KjA+SiSi4\n\tGXKIqMVzh2uVSbJ8V/WJuAHK3Q1PK3uwqfndp1bihKRqLfcemTmynwrcpDmWOLmvL7W2uIHALbBtP\n\tyUKIALykn+nUsOZhwqumUl5GZikd+9you/2Zj97Bb14U+kBq6OrYGfASdRTPpBjH5X4951gOnBZ7o\n\tZZ4r9ad39BHNd0o/ixSg==;", "v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=dkim;\n\tt=1774542373; h=from:subject:date:message-id:to:cc:mime-version:content-type:\n\t content-transfer-encoding:in-reply-to:references;\n\tbh=AP5EDvNSDOA4mcH2wjjTrtd89tS9FG178G3LqqbkZ1Y=;\n\tb=I/QLYXw94NxpfiQ3i07ghpBYmjFR65mBcb2bSgGRkLT8NmTV4awILLREQcVwzt1PZVMrvV\n\tTZj3wCkZDcxfM8knSa2UFLliOx2/o6ZrUWutvLmuhCYXqNvqnz/6x64c1XqqxERRPfbCQB\n\tNWJOpus8tSl+l2eLgSo17ryVhAB2uk2BUN/Zx7NhXNjqxAVMxIayo8Lnn8x5IJVuFJPF0Z\n\tjvdHlB1Z95tZGwifXAeZ056R6XXtp3m/s4K+9QPgSglP2Qr5tAeUMx2J60aSPETUoT6oFY\n\tfb4ZFmbjYW/WqLCa/MjXPGtaAWaCrA6UQBAStC5plHZ0Fg/OpiqgZ2Ts+EOTzw==" ], "From": "Miquel Raynal <miquel.raynal@bootlin.com>", "Date": "Thu, 26 Mar 2026 17:25:52 +0100", "Subject": "[PATCH v2 05/11] spi: spi-mem: Create a secondary read operation", "MIME-Version": "1.0", "Message-Id": "\n <20260326-winbond-v6-18-rc1-cont-read-v2-5-643de97a68a3@bootlin.com>", "References": "\n <20260326-winbond-v6-18-rc1-cont-read-v2-0-643de97a68a3@bootlin.com>", "In-Reply-To": "\n <20260326-winbond-v6-18-rc1-cont-read-v2-0-643de97a68a3@bootlin.com>", "To": "Mark Brown <broonie@kernel.org>, Richard Weinberger <richard@nod.at>,\n Vignesh Raghavendra <vigneshr@ti.com>, Michael Walle <mwalle@kernel.org>,\n Miquel Raynal <miquel.raynal@bootlin.com>", "Cc": "Pratyush Yadav <pratyush@kernel.org>,\n Thomas Petazzoni <thomas.petazzoni@bootlin.com>,\n Steam Lin <STLin2@winbond.com>, Santhosh Kumar K <s-k6@ti.com>,\n linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org,\n linux-mtd@lists.infradead.org", "X-Mailer": "b4 0.14.3", "X-Last-TLS-Session-Version": "TLSv1.3", "X-CRM114-Version": "20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 ", "X-CRM114-CacheID": "sfid-20260326_092616_131161_8D886FF3 ", "X-CRM114-Status": "GOOD ( 19.84 )", "X-Spam-Score": "-2.1 (--)", "X-Spam-Report": "Spam detection software,\n running on the system \"bombadil.infradead.org\",\n has NOT identified this incoming email as spam. The original\n message has been attached to this so you can view it or label\n similar future email. If you have any questions, see\n the administrator of that system for details.\n Content preview: In some situations,\n direct mappings may need to use different\n operation templates. For instance, when enabling continuous reads, Winbond\n SPI NANDs no longer expect address cycles because they would be ignoring\n them otherwise. Hence, right after the command opcode, they start countin\n [...]\n Content analysis details: (-2.1 points, 5.0 required)\n pts rule name description\n ---- ----------------------\n --------------------------------------------------\n -0.0 SPF_HELO_PASS SPF: HELO matches SPF record\n -0.0 SPF_PASS SPF: sender matches SPF record\n -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from\n author's\n domain\n -0.1 DKIM_VALID Message has at least one valid DKIM or DK\n signature\n -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from\n envelope-from domain\n 0.1 DKIM_SIGNED Message has a DKIM or DK signature,\n not necessarily valid\n -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1%\n [score: 0.0000]\n 0.0 RCVD_IN_VALIDITY_CERTIFIED_BLOCKED RBL: ADMINISTRATOR NOTICE: The\n query to Validity was blocked. See\n https://knowledge.validity.com/hc/en-us/articles/20961730681243\n for more information.\n [185.246.85.4 listed in\n sa-trusted.bondedsender.org]\n 0.0 RCVD_IN_VALIDITY_SAFE_BLOCKED RBL: ADMINISTRATOR NOTICE: The query to\n Validity was blocked. See\n https://knowledge.validity.com/hc/en-us/articles/20961730681243\n for more information.\n [185.246.85.4 listed in sa-accredit.habeas.com]\n 0.0 RCVD_IN_VALIDITY_RPBL_BLOCKED RBL: ADMINISTRATOR NOTICE: The query to\n Validity was blocked. See\n https://knowledge.validity.com/hc/en-us/articles/20961730681243\n for more information.\n [185.246.85.4 listed in bl.score.senderscore.com]", "X-BeenThere": "linux-mtd@lists.infradead.org", "X-Mailman-Version": "2.1.34", "Precedence": "list", "List-Id": "Linux MTD discussion mailing list <linux-mtd.lists.infradead.org>", "List-Unsubscribe": "<http://lists.infradead.org/mailman/options/linux-mtd>,\n <mailto:linux-mtd-request@lists.infradead.org?subject=unsubscribe>", "List-Archive": "<http://lists.infradead.org/pipermail/linux-mtd/>", "List-Post": "<mailto:linux-mtd@lists.infradead.org>", "List-Help": "<mailto:linux-mtd-request@lists.infradead.org?subject=help>", "List-Subscribe": "<http://lists.infradead.org/mailman/listinfo/linux-mtd>,\n <mailto:linux-mtd-request@lists.infradead.org?subject=subscribe>", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Sender": "\"linux-mtd\" <linux-mtd-bounces@lists.infradead.org>", "Errors-To": "linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org" }, "content": "In some situations, direct mappings may need to use different\noperation templates.\n\nFor instance, when enabling continuous reads, Winbond SPI NANDs no\nlonger expect address cycles because they would be ignoring them\notherwise. Hence, right after the command opcode, they start counting\ndummy cycles, followed by the data cycles as usual.\n\nThis breaks the assumptions of \"reads from cache\" always being done\nidentically once the best variant has been picked up, across the\nlifetime of the system.\n\nIn order to support this feature, we must give direct mapping more than\na single operation template to use, in order to switch to using\nsecondary operations upon request by the upper layer.\n\nCreate the concept of optional secondary operation template, which may\nor may not be fulfilled by the SPI NAND and SPI NOR cores. If the\nunderlying SPI controller does not leverage any kind of direct mapping\nacceleration, the feature has no impact and can be freely\nused. Otherwise, the controller driver needs to opt-in for using this\nfeature, if supported.\n\nThe condition checked to know whether a secondary operation has been\nprovided or not is to look for a non zero opcode to limit the creation\nof extra variables. In practice, the opcode 0x00 exist, but is not\nrelated to any cache related operation.\n\nAcked-by: Mark Brown <broonie@kernel.org>\nSigned-off-by: Miquel Raynal <miquel.raynal@bootlin.com>\n---\nThe choice of defining two variables named primary and secondary instead\nof using an array of templates is on purpose, to simplify the reading. I\nfind less obvious the use of an array here but this is personal taste.\n---\n drivers/spi/spi-mem.c | 17 +++++++++++++++++\n include/linux/spi/spi-mem.h | 5 +++++\n 2 files changed, 22 insertions(+)", "diff": "diff --git a/drivers/spi/spi-mem.c b/drivers/spi/spi-mem.c\nindex e2eaa1ba4ff6..f64eda9bbd9f 100644\n--- a/drivers/spi/spi-mem.c\n+++ b/drivers/spi/spi-mem.c\n@@ -713,6 +713,23 @@ spi_mem_dirmap_create(struct spi_mem *mem,\n \tif (info->primary_op_tmpl.data.dir == SPI_MEM_NO_DATA)\n \t\treturn ERR_PTR(-EINVAL);\n \n+\t/* Apply similar constraints to the secondary template */\n+\tif (info->secondary_op_tmpl.cmd.opcode) {\n+\t\tif (!info->secondary_op_tmpl.addr.nbytes ||\n+\t\t info->secondary_op_tmpl.addr.nbytes > 8)\n+\t\t\treturn ERR_PTR(-EINVAL);\n+\n+\t\tif (info->secondary_op_tmpl.data.dir == SPI_MEM_NO_DATA)\n+\t\t\treturn ERR_PTR(-EINVAL);\n+\n+\t\tif (!spi_mem_supports_op(mem, &info->secondary_op_tmpl))\n+\t\t\treturn ERR_PTR(-EOPNOTSUPP);\n+\n+\t\tif (ctlr->mem_ops && ctlr->mem_ops->dirmap_create &&\n+\t\t !spi_mem_controller_is_capable(ctlr, secondary_op_tmpl))\n+\t\t\treturn ERR_PTR(-EOPNOTSUPP);\n+\t}\n+\n \tdesc = kzalloc_obj(*desc);\n \tif (!desc)\n \t\treturn ERR_PTR(-ENOMEM);\ndiff --git a/include/linux/spi/spi-mem.h b/include/linux/spi/spi-mem.h\nindex 3cba7fe4bed5..bd2a73d46980 100644\n--- a/include/linux/spi/spi-mem.h\n+++ b/include/linux/spi/spi-mem.h\n@@ -215,6 +215,8 @@ struct spi_mem_op {\n * struct spi_mem_dirmap_info - Direct mapping information\n * @op_tmpl: operation template that should be used by the direct mapping when\n *\t the memory device is accessed\n+ * @secondary_op_tmpl: secondary template, may be used as an alternative to the\n+ * primary template (decided by the upper layer)\n * @offset: absolute offset this direct mapping is pointing to\n * @length: length in byte of this direct mapping\n *\n@@ -227,6 +229,7 @@ struct spi_mem_op {\n struct spi_mem_dirmap_info {\n \tstruct spi_mem_op *op_tmpl;\n \tstruct spi_mem_op primary_op_tmpl;\n+\tstruct spi_mem_op secondary_op_tmpl;\n \tu64 offset;\n \tu64 length;\n };\n@@ -370,12 +373,14 @@ struct spi_controller_mem_ops {\n * @swap16: Supports swapping bytes on a 16 bit boundary when configured in\n *\t Octal DTR\n * @per_op_freq: Supports per operation frequency switching\n+ * @secondary_op_tmpl: Supports leveraging a secondary memory operation template\n */\n struct spi_controller_mem_caps {\n \tbool dtr;\n \tbool ecc;\n \tbool swap16;\n \tbool per_op_freq;\n+\tbool secondary_op_tmpl;\n };\n \n #define spi_mem_controller_is_capable(ctlr, cap)\t\\\n", "prefixes": [ "v2", "05/11" ] }