Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/2216478/?format=api
{ "id": 2216478, "url": "http://patchwork.ozlabs.org/api/patches/2216478/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20260326144835.67911-1-heinrich.schuchardt@canonical.com/", "project": { "id": 14, "url": "http://patchwork.ozlabs.org/api/projects/14/?format=api", "name": "QEMU Development", "link_name": "qemu-devel", "list_id": "qemu-devel.nongnu.org", "list_email": "qemu-devel@nongnu.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20260326144835.67911-1-heinrich.schuchardt@canonical.com>", "list_archive_url": null, "date": "2026-03-26T14:48:35", "name": "[v2] hw/acpi: correct field sequence in SPCR table", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "20986d41b0d0ccb489ec523bebb82c001ed20a03", "submitter": { "id": 82181, "url": "http://patchwork.ozlabs.org/api/people/82181/?format=api", "name": "Heinrich Schuchardt", "email": "heinrich.schuchardt@canonical.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20260326144835.67911-1-heinrich.schuchardt@canonical.com/mbox/", "series": [ { "id": 497605, "url": "http://patchwork.ozlabs.org/api/series/497605/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/list/?series=497605", "date": "2026-03-26T14:48:35", "name": "[v2] hw/acpi: correct field sequence in SPCR table", "version": 2, "mbox": "http://patchwork.ozlabs.org/series/497605/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2216478/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2216478/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (4096-bit key;\n unprotected) header.d=canonical.com header.i=@canonical.com\n header.a=rsa-sha256 header.s=20251003 header.b=Jr48gHQq;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)" ], "Received": [ "from lists.gnu.org (lists.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fhRWM0V59z1yGD\n\tfor <incoming@patchwork.ozlabs.org>; Fri, 27 Mar 2026 01:49:35 +1100 (AEDT)", "from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from <qemu-devel-bounces@nongnu.org>)\n\tid 1w5m0y-000141-Eg; Thu, 26 Mar 2026 10:48:52 -0400", "from eggs.gnu.org ([2001:470:142:3::10])\n by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <heinrich.schuchardt@canonical.com>)\n id 1w5m0w-00013h-J7\n for qemu-devel@nongnu.org; Thu, 26 Mar 2026 10:48:50 -0400", "from smtp-relay-internal-1.canonical.com ([185.125.188.123])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <heinrich.schuchardt@canonical.com>)\n id 1w5m0s-0004Nm-JM\n for qemu-devel@nongnu.org; Thu, 26 Mar 2026 10:48:49 -0400", "from mail-wm1-f71.google.com (mail-wm1-f71.google.com\n [209.85.128.71])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n (No client certificate requested)\n by smtp-relay-internal-1.canonical.com (Postfix) with ESMTPS id 1A44E3F624\n for <qemu-devel@nongnu.org>; Thu, 26 Mar 2026 14:48:42 +0000 (UTC)", "by mail-wm1-f71.google.com with SMTP id\n 5b1f17b1804b1-48722073bd2so5333595e9.0\n for <qemu-devel@nongnu.org>; Thu, 26 Mar 2026 07:48:42 -0700 (PDT)", "from workstation5 (ip-005-147-080-091.um06.pools.vodafone-ip.de.\n [5.147.80.91]) by smtp.gmail.com with ESMTPSA id\n ffacd0b85a97d-43b9192e533sm9845107f8f.2.2026.03.26.07.48.40\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Thu, 26 Mar 2026 07:48:40 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=canonical.com;\n s=20251003; t=1774536522;\n bh=9i07kbNbRKin4ccuX+XEktSQNxeOB3pk6a7DyZCJi1A=;\n h=From:To:Cc:Subject:Date:Message-ID:MIME-Version;\n b=Jr48gHQqmJvnad76ABLEH9cUpBsFe//vzd9KE4o8QyxwHBe5rS65S7QrCRXHoT7FY\n 42OK7olCrwy4kbYyMSwyTlKnjdebztwReQ+Sji4We0bE98/9sdPcBeSHqwhnqkwqD4\n p4iCi0Y+VCAQd2XnGg1lnbrgvu+dB5z9kCOdLWlNPivW8CK7bWFe1xP+vzWSOcQIkJ\n 9Sk5UsHjk3lj27+GldvbPmxZIzR5yaonVDze5vJD/FS9bg9I3Qt0ZgHuI5hlQdVqZ+\n oZ2sP22zKPuQEWjyrXZYVXG6gn/X57arOOTRAmDFB/mkp/rvLNqoeSpX01uf2MdlfV\n +nYE+gQdCllSz1azHLe3zI+3SKpoP3+VXvbG+k2nq3ZEw4w4AoZfIuQBexjeRS6Vxj\n G2MmrxPoROsvPP10MRe13z4GdZ+gxj/Ai/PHs3Pz+SC+nDgMAsihDLfmyArLdSmtgp\n IthuPn3MvyMvQf93OQ19H/jy77NcJ5FCwkJkwe4GtmvIm3ABZGIl8cvq7vp6XXlbtR\n tCyiuRpkF65ABEiBXCC2SJ7UTpAtYTeNU0jE0RRhXab5oHiao+4QoRyuFBp/uOM5RY\n YYuyjyAJUOBmkEhyJ8xcIzMRXvy9gTc0wTRM63FpO3JQfpZ74t/f9o9nEnXZxrtGge\n NCyMYvwLwZfrq/Q2IVilZG08=", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1774536522; x=1775141322;\n h=content-transfer-encoding:mime-version:message-id:date:subject:cc\n :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date\n :message-id:reply-to;\n bh=9i07kbNbRKin4ccuX+XEktSQNxeOB3pk6a7DyZCJi1A=;\n b=XSAHIZeXAgji49dmAuc1c6JZQs86c9qzTU4ddv8xkXGcsfZkNBx2d8SU1peMNjENms\n g8WE9OVT5yLc1z/04MOdGfU55UsUUMEUwM0NhJzunbwXtjGKGd7URE4l3Nt+8ovE6pMa\n +pkaWQeGDjQh+OL3SLtdueEx/lBPXx8CH9quiUFmlSS9twIhdP0Wc6Vk2XhDXXJGFM3K\n XVJQmQsPBLLCzIhm8a9dRqsGjxDjsvYU2HT/4jXXCiQgbGKUgrqWlx/b3vgV0XDCTEzO\n eV8tNV5xLLSvgpn/HHOE3bmcJgUcuISrm3IGD3Prq5/YBdxv9MUgnPN5+8fSdcNXqXo/\n zd0Q==", "X-Forwarded-Encrypted": "i=1;\n AJvYcCX4cna1f2N1KK0deO3Id4dnSv93YC4wFEVY1KsnmuffK4HHXolC6Ew7f/Aea7JXDx27iw18DsyAlDK/@nongnu.org", "X-Gm-Message-State": "AOJu0Yx/Qk9L8/LXIYN18gy69B4xeVt+QjHNID4Gs4T6jRsRMdy1BgUs\n jnIqO4qL0dj0pvQruoVBQ03NuC+X0te1f4m5IreOPzLst/RXxoLED6ZnwxHEw2MXWXH98cyfrLX\n HysqFxdSay0u2vatringlZl7isnWNu/e3np2mauuymm7oVQanuL74BMzsQkK/zsyn6qvaL1jm", "X-Gm-Gg": "ATEYQzypG1bHDnst0aABSgwZSaLW5swcqSOcCqIw9wg5cGxn9wp/ywyJMouD7DGMFdj\n xMAaLg0QHXOMfhyq6pfxPGiTa3ZHyVJvhO5A1BmyOBOaUpH0M5qr7k2GU7Wuh9p3qjbATfFJY1I\n eP5UBNe1+GZcsopc/xZsc52hgfK6VvBcvo00torTw8dnglKmwUBh3/S01oA6hlnUp81Aoa1y8yU\n H/DsAiAL4OUNVEBR6W5hbFUI/byQS/nCSUosPfO5Zz/IwVAWB214rcTljcJEhflSQcBn01lsVvw\n Whj1DvQKxsqpGUpmK9IwOA7kbfs1O0njCd1Gvx0Dv/xbXlXAjd9V/Tb09ZW/j5WrLwDdm3uhZwp\n q6eYuR5UHSOM4hcajo21Q4pKZFBhawToQ+6DqVwvCDTLSOFL8wLjrS98eKgBUBZ7dU7sZxozguO\n tSCxz5U/3z6hKHlS/wBZ29/ul/CE8pMxphSValF2nPMEUG", "X-Received": [ "by 2002:a05:600c:358f:b0:486:fcc7:6811 with SMTP id\n 5b1f17b1804b1-48722be4497mr37234525e9.10.1774536521600;\n Thu, 26 Mar 2026 07:48:41 -0700 (PDT)", "by 2002:a05:600c:358f:b0:486:fcc7:6811 with SMTP id\n 5b1f17b1804b1-48722be4497mr37234135e9.10.1774536521066;\n Thu, 26 Mar 2026 07:48:41 -0700 (PDT)" ], "From": "Heinrich Schuchardt <heinrich.schuchardt@canonical.com>", "To": "\"Michael S . Tsirkin\" <mst@redhat.com>,\n Igor Mammedov <imammedo@redhat.com>", "Cc": "Sia Jee Heng <jeeheng.sia@starfivetech.com>,\n Ani Sinha <anisinha@redhat.com>, qemu-devel@nongnu.org,\n Alistair Francis <alistair.francis@wdc.com>,\n Heinrich Schuchardt <heinrich.schuchardt@canonical.com>", "Subject": "[PATCH v2] hw/acpi: correct field sequence in SPCR table", "Date": "Thu, 26 Mar 2026 15:48:35 +0100", "Message-ID": "<20260326144835.67911-1-heinrich.schuchardt@canonical.com>", "X-Mailer": "git-send-email 2.53.0", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Received-SPF": "pass client-ip=185.125.188.123;\n envelope-from=heinrich.schuchardt@canonical.com;\n helo=smtp-relay-internal-1.canonical.com", "X-Spam_score_int": "-23", "X-Spam_score": "-2.4", "X-Spam_bar": "--", "X-Spam_report": "(-2.4 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001,\n DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001,\n RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001,\n URI_TRY_3LD=1.999 autolearn=ham autolearn_force=no", "X-Spam_action": "no action", "X-BeenThere": "qemu-devel@nongnu.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "qemu development <qemu-devel.nongnu.org>", "List-Unsubscribe": "<https://lists.nongnu.org/mailman/options/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>", "List-Archive": "<https://lists.nongnu.org/archive/html/qemu-devel>", "List-Post": "<mailto:qemu-devel@nongnu.org>", "List-Help": "<mailto:qemu-devel-request@nongnu.org?subject=help>", "List-Subscribe": "<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=subscribe>", "Errors-To": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org", "Sender": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org" }, "content": "On LoongArch and RISC-V invalid SPCR tables are created:\n\nTerrminal Type : 00\nLanguage : 03\n\nThe correct values are:\n\nTerrminal Type : 03\nLanguage : 00\n\nThis is due to commit 7dd0b070fa09 (\"hw/arm/virt-acpi-build.c: Migrate\nSPCR creation to common location\") that swapped the fields.\n\nSee the specification of the table in\nhttps://learn.microsoft.com/en-us/windows-hardware/drivers/bringup/serial-port-console-redirection-table\n\nThis page shows version 1.10. But the sequence of the fields was not changed\nsince version 1.0.\n\nOur LoongArch and ARM code uses version 1.07 of the specification.\nOur RISC-V code uses version 1.10 of the specification.\n\nFixes: 7dd0b070fa09 (\"hw/arm/virt-acpi-build.c: Migrate SPCR creation to common location\")\nSigned-off-by: Heinrich Schuchardt <heinrich.schuchardt@canonical.com>\nOrigin: https://lore.kernel.org/qemu-devel/20260326121947.51200-1-heinrich.schuchardt@canonical.com/T/#u\nBug-Ubuntu: https://bugs.launchpad.net/ubuntu/+source/qemu/+bug/2146419\n---\nv2:\n\tMention the different specification versions used by our code.\nv1:\n\thttps://lore.kernel.org/qemu-devel/20260326121947.51200-1-heinrich.schuchardt@canonical.com/T/#u\n---\n hw/acpi/aml-build.c | 4 ++--\n 1 file changed, 2 insertions(+), 2 deletions(-)", "diff": "diff --git a/hw/acpi/aml-build.c b/hw/acpi/aml-build.c\nindex 4b37405088..a999320e61 100644\n--- a/hw/acpi/aml-build.c\n+++ b/hw/acpi/aml-build.c\n@@ -2115,10 +2115,10 @@ void build_spcr(GArray *table_data, BIOSLinker *linker,\n build_append_int_noprefix(table_data, f->stop_bits, 1);\n /* Flow Control */\n build_append_int_noprefix(table_data, f->flow_control, 1);\n- /* Language */\n- build_append_int_noprefix(table_data, f->language, 1);\n /* Terminal Type */\n build_append_int_noprefix(table_data, f->terminal_type, 1);\n+ /* Language */\n+ build_append_int_noprefix(table_data, f->language, 1);\n /* PCI Device ID */\n build_append_int_noprefix(table_data, f->pci_device_id, 2);\n /* PCI Vendor ID */\n", "prefixes": [ "v2" ] }