Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/2216471/?format=api
{ "id": 2216471, "url": "http://patchwork.ozlabs.org/api/patches/2216471/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20260326141745.3804284-1-aleksandr.loktionov@intel.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20260326141745.3804284-1-aleksandr.loktionov@intel.com>", "list_archive_url": null, "date": "2026-03-26T14:17:45", "name": "[iwl-next,v3] ice: remove excessive memory allocation in ice_create_lag_recipe()", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "bc5e6564f498e7d9ee7a8f44eb41cf7bb0869ab2", "submitter": { "id": 75597, "url": "http://patchwork.ozlabs.org/api/people/75597/?format=api", "name": "Loktionov, Aleksandr", "email": "aleksandr.loktionov@intel.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20260326141745.3804284-1-aleksandr.loktionov@intel.com/mbox/", "series": [ { "id": 497598, "url": "http://patchwork.ozlabs.org/api/series/497598/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/list/?series=497598", "date": "2026-03-26T14:17:45", "name": "[iwl-next,v3] ice: remove excessive memory allocation in ice_create_lag_recipe()", "version": 3, "mbox": "http://patchwork.ozlabs.org/series/497598/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2216471/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2216471/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@legolas.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=osuosl.org header.i=@osuosl.org header.a=rsa-sha256\n header.s=default header.b=1rFUNZ78;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=osuosl.org\n (client-ip=140.211.166.137; helo=smtp4.osuosl.org;\n envelope-from=intel-wired-lan-bounces@osuosl.org;\n receiver=patchwork.ozlabs.org)" ], "Received": [ "from smtp4.osuosl.org (smtp4.osuosl.org [140.211.166.137])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fhQpq0vg9z1y1G\n\tfor <incoming@patchwork.ozlabs.org>; Fri, 27 Mar 2026 01:17:54 +1100 (AEDT)", "from localhost (localhost [127.0.0.1])\n\tby smtp4.osuosl.org (Postfix) with ESMTP id F35AC4085B;\n\tThu, 26 Mar 2026 14:17:52 +0000 (UTC)", "from smtp4.osuosl.org ([127.0.0.1])\n by localhost (smtp4.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP\n id n2-SIBqeSC6t; Thu, 26 Mar 2026 14:17:51 +0000 (UTC)", "from lists1.osuosl.org (lists1.osuosl.org [140.211.166.142])\n\tby smtp4.osuosl.org (Postfix) with ESMTP id 05E4440992;\n\tThu, 26 Mar 2026 14:17:51 +0000 (UTC)", "from smtp4.osuosl.org (smtp4.osuosl.org [IPv6:2605:bc80:3010::137])\n by lists1.osuosl.org (Postfix) with ESMTP id DB4F7F5\n for <intel-wired-lan@lists.osuosl.org>; Thu, 26 Mar 2026 14:17:49 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n by smtp4.osuosl.org (Postfix) with ESMTP id CD42040992\n for <intel-wired-lan@lists.osuosl.org>; Thu, 26 Mar 2026 14:17:49 +0000 (UTC)", "from smtp4.osuosl.org ([127.0.0.1])\n by localhost (smtp4.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP\n id ZDGcF1p6CzM2 for <intel-wired-lan@lists.osuosl.org>;\n Thu, 26 Mar 2026 14:17:49 +0000 (UTC)", "from mgamail.intel.com (mgamail.intel.com [198.175.65.9])\n by smtp4.osuosl.org (Postfix) with ESMTPS id CFB6D4085B\n for <intel-wired-lan@lists.osuosl.org>; Thu, 26 Mar 2026 14:17:48 +0000 (UTC)", "from orviesa005.jf.intel.com ([10.64.159.145])\n by orvoesa101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 26 Mar 2026 07:17:47 -0700", "from amlin-019-225.igk.intel.com ([10.102.19.225])\n by orviesa005.jf.intel.com with ESMTP; 26 Mar 2026 07:17:46 -0700" ], "X-Virus-Scanned": [ "amavis at osuosl.org", "amavis at osuosl.org" ], "X-Comment": "SPF check N/A for local connections - client-ip=140.211.166.142;\n helo=lists1.osuosl.org; envelope-from=intel-wired-lan-bounces@osuosl.org;\n receiver=<UNKNOWN> ", "DKIM-Filter": [ "OpenDKIM Filter v2.11.0 smtp4.osuosl.org 05E4440992", "OpenDKIM Filter v2.11.0 smtp4.osuosl.org CFB6D4085B" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=osuosl.org;\n\ts=default; t=1774534671;\n\tbh=XwGclFvzvtmw83tFGc3Z7bUMfypG6T/S2tSXYl9kqno=;\n\th=From:To:Cc:Date:Subject:List-Id:List-Unsubscribe:List-Archive:\n\t List-Post:List-Help:List-Subscribe:From;\n\tb=1rFUNZ787sgaakJ5ztWMwHyS96bcDLldXwwO2B8zW7/O0oh+zAmwcswDii1D3zC7q\n\t S9vwSXLcIYYbzgGsbYrJ7MUaBcN6sAPUDNEg69PkXrM5xQllCSvECWUaQeeN/CodIq\n\t iWWi3ZNli/u69KZR+nOKhU3BmAEDi2UvyW7je/NmaR5lhzu23lSrfUwy6c0xfhXsuc\n\t 9Yw363yHPE1gihiPQf72lHpGIfPC6zlgi5P/uEpwVgZsqPYED034EnL/whtGpmAx4u\n\t Ugybh6VXJ8AbZqUPZHhPiukg2/YaabBPwC0ia0nh4CBJXnkmUyT99pG9xVfhtdjuaH\n\t tqrrJoyQc4YUg==", "Received-SPF": "Pass (mailfrom) identity=mailfrom; client-ip=198.175.65.9;\n helo=mgamail.intel.com; envelope-from=aleksandr.loktionov@intel.com;\n receiver=<UNKNOWN>", "DMARC-Filter": "OpenDMARC Filter v1.4.2 smtp4.osuosl.org CFB6D4085B", "X-CSE-ConnectionGUID": [ "Gw7vzya/Qq+FdVnUr5IhtA==", "zlYbFasVTCCazD3zHtYOyA==" ], "X-CSE-MsgGUID": [ "UVJfhQ3PTAWWCdTqnonuxg==", "FuCbrUlrRh6ZBfeOE+Krvw==" ], "X-IronPort-AV": [ "E=McAfee;i=\"6800,10657,11741\"; a=\"98212693\"", "E=Sophos;i=\"6.23,142,1770624000\"; d=\"scan'208\";a=\"98212693\"", "E=Sophos;i=\"6.23,142,1770624000\"; d=\"scan'208\";a=\"229963510\"" ], "X-ExtLoop1": "1", "From": "Aleksandr Loktionov <aleksandr.loktionov@intel.com>", "To": "intel-wired-lan@lists.osuosl.org, anthony.l.nguyen@intel.com,\n aleksandr.loktionov@intel.com", "Cc": "netdev@vger.kernel.org,\n\tMarcin Szycik <marcin.szycik@intel.com>", "Date": "Thu, 26 Mar 2026 15:17:45 +0100", "Message-ID": "<20260326141745.3804284-1-aleksandr.loktionov@intel.com>", "X-Mailer": "git-send-email 2.52.0", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-Mailman-Original-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple;\n d=intel.com; i=@intel.com; q=dns/txt; s=Intel;\n t=1774534668; x=1806070668;\n h=from:to:cc:subject:date:message-id:mime-version:\n content-transfer-encoding;\n bh=19JNJgIC1w0C8iD0XBuDVA7+MnIqP+1uGvp0jR8zkts=;\n b=XlMIDE+m6QXDZ0OaS3mfBl6ol7PG+KSTplErc4YMyKthUnJgdvX6xYsN\n JbtisRJkP7AFe59k5gUsCT6dlv7DviPzmGSdLMy/pOnSNAXlQj7wG2FCu\n 6AuQo90JtA3uOFVpAHVnl31+Ln4fSDZd+bpavzGyCuil3WkYsPiQaOuFb\n 0JjaGn9uDR7hl+JiwjNbcyhxHDPdlxT7biOuUApkR10xL7ZHcETXeJVbK\n OlCeRn2Mzmw/BzAcrbVBi4/dA/Zc+CTz8ZiUvZ7rUwtpS7pQoJ/twQ0Rq\n ubbBmsADx1AAzcr7mOXARBdSGDtRFPLqDhS/J19FArQsi7Wo0dJfvVmNA\n g==;", "X-Mailman-Original-Authentication-Results": [ "smtp4.osuosl.org;\n dmarc=pass (p=none dis=none)\n header.from=intel.com", "smtp4.osuosl.org;\n dkim=pass (2048-bit key,\n unprotected) header.d=intel.com header.i=@intel.com header.a=rsa-sha256\n header.s=Intel header.b=XlMIDE+m" ], "Subject": "[Intel-wired-lan] [PATCH iwl-next v3] ice: remove excessive memory\n allocation in ice_create_lag_recipe()", "X-BeenThere": "intel-wired-lan@osuosl.org", "X-Mailman-Version": "2.1.30", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n <intel-wired-lan.osuosl.org>", "List-Unsubscribe": "<https://lists.osuosl.org/mailman/options/intel-wired-lan>,\n <mailto:intel-wired-lan-request@osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@osuosl.org?subject=help>", "List-Subscribe": "<https://lists.osuosl.org/mailman/listinfo/intel-wired-lan>,\n <mailto:intel-wired-lan-request@osuosl.org?subject=subscribe>", "Errors-To": "intel-wired-lan-bounces@osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@osuosl.org>" }, "content": "From: Marcin Szycik <marcin.szycik@intel.com>\n\nFor some reason ice_create_lag_recipe() allocates an array of 64\nstruct ice_aqc_recipe_data_elem elements, while it only needs one (1).\nFix it, while also using kzalloc_obj().\n\nSigned-off-by: Marcin Szycik <marcin.szycik@intel.com>\nSigned-off-by: Aleksandr Loktionov <aleksandr.loktionov@intel.com>\n---\nv2 -> v3 use sizeof(*new_rcp) in memcpy() to match the allocation (Jakub)\nv1 -> v2 remove 'Fixes' from commit message because it's not a critical bug\n---\n drivers/net/ethernet/intel/ice/ice_lag.c | 4 ++--\n 1 file changed, 2 insertions(+), 2 deletions(-)", "diff": "diff --git a/drivers/net/ethernet/intel/ice/ice_lag.c b/drivers/net/ethernet/intel/ice/ice_lag.c\nindex 310e8fe..9ad19c3 100644\n--- a/drivers/net/ethernet/intel/ice/ice_lag.c\n+++ b/drivers/net/ethernet/intel/ice/ice_lag.c\n@@ -2418,11 +2418,11 @@ static int ice_create_lag_recipe(struct ice_hw *hw, u16 *rid,\n \tif (err)\n \t\treturn err;\n \n-\tnew_rcp = kzalloc(ICE_RECIPE_LEN * ICE_MAX_NUM_RECIPES, GFP_KERNEL);\n+\tnew_rcp = kzalloc_obj(*new_rcp, GFP_KERNEL);\n \tif (!new_rcp)\n \t\treturn -ENOMEM;\n \n-\tmemcpy(new_rcp, base_recipe, ICE_RECIPE_LEN);\n+\tmemcpy(new_rcp, base_recipe, sizeof(*new_rcp));\n \tnew_rcp->content.act_ctrl_fwd_priority = prio;\n \tnew_rcp->content.rid = *rid | ICE_AQ_RECIPE_ID_IS_ROOT;\n \tnew_rcp->recipe_indx = *rid;\n", "prefixes": [ "iwl-next", "v3" ] }