Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/2216458/?format=api
{ "id": 2216458, "url": "http://patchwork.ozlabs.org/api/patches/2216458/?format=api", "web_url": "http://patchwork.ozlabs.org/project/gcc/patch/20260326140525.B877D4A0A3@imap1.dmz-prg2.suse.org/", "project": { "id": 17, "url": "http://patchwork.ozlabs.org/api/projects/17/?format=api", "name": "GNU Compiler Collection", "link_name": "gcc", "list_id": "gcc-patches.gcc.gnu.org", "list_email": "gcc-patches@gcc.gnu.org", "web_url": null, "scm_url": null, "webscm_url": null, "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20260326140525.B877D4A0A3@imap1.dmz-prg2.suse.org>", "list_archive_url": null, "date": "2026-03-26T14:05:17", "name": "[v2] middle-end/120839 - use unaligned incoming stack argument copy more", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "4975e71196dd98234995d3133ca422e4bb6d226e", "submitter": { "id": 4338, "url": "http://patchwork.ozlabs.org/api/people/4338/?format=api", "name": "Richard Biener", "email": "rguenther@suse.de" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/gcc/patch/20260326140525.B877D4A0A3@imap1.dmz-prg2.suse.org/mbox/", "series": [ { "id": 497594, "url": "http://patchwork.ozlabs.org/api/series/497594/?format=api", "web_url": "http://patchwork.ozlabs.org/project/gcc/list/?series=497594", "date": "2026-03-26T14:05:17", "name": "[v2] middle-end/120839 - use unaligned incoming stack argument copy more", "version": 2, "mbox": "http://patchwork.ozlabs.org/series/497594/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2216458/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2216458/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<gcc-patches-bounces~incoming=patchwork.ozlabs.org@gcc.gnu.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "gcc-patches@gcc.gnu.org" ], "Delivered-To": [ "patchwork-incoming@legolas.ozlabs.org", "gcc-patches@gcc.gnu.org" ], "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256\n header.s=susede2_rsa header.b=wda4NytT;\n\tdkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256\n header.s=susede2_ed25519 header.b=6IzAcvFf;\n\tdkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de\n header.a=rsa-sha256 header.s=susede2_rsa header.b=Ep3/23LX;\n\tdkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256\n header.s=susede2_ed25519 header.b=V6pbqhg2;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=gcc.gnu.org\n (client-ip=2620:52:6:3111::32; helo=vm01.sourceware.org;\n envelope-from=gcc-patches-bounces~incoming=patchwork.ozlabs.org@gcc.gnu.org;\n receiver=patchwork.ozlabs.org)", "sourceware.org;\n\tdkim=pass (1024-bit key,\n unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256\n header.s=susede2_rsa header.b=wda4NytT;\n\tdkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256\n header.s=susede2_ed25519 header.b=6IzAcvFf;\n\tdkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de\n header.a=rsa-sha256 header.s=susede2_rsa header.b=Ep3/23LX;\n\tdkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256\n header.s=susede2_ed25519 header.b=V6pbqhg2", "sourceware.org;\n dmarc=pass (p=none dis=none) header.from=suse.de", "sourceware.org; spf=pass smtp.mailfrom=suse.de", "server2.sourceware.org;\n arc=none smtp.remote-ip=195.135.223.130", "smtp-out1.suse.de;\n dkim=pass header.d=suse.de header.s=susede2_rsa header.b=\"Ep3/23LX\";\n dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=V6pbqhg2" ], "Received": [ "from vm01.sourceware.org (vm01.sourceware.org\n [IPv6:2620:52:6:3111::32])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fhQYm66YCz1yGD\n\tfor <incoming@patchwork.ozlabs.org>; Fri, 27 Mar 2026 01:06:36 +1100 (AEDT)", "from vm01.sourceware.org (localhost [127.0.0.1])\n\tby sourceware.org (Postfix) with ESMTP id AF1154BA23DF\n\tfor <incoming@patchwork.ozlabs.org>; Thu, 26 Mar 2026 14:06:34 +0000 (GMT)", "from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130])\n by sourceware.org (Postfix) with ESMTPS id AC21C4BAD15E\n for <gcc-patches@gcc.gnu.org>; Thu, 26 Mar 2026 14:05:32 +0000 (GMT)", "from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org\n [IPv6:2a07:de40:b281:104:10:150:64:97])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest\n SHA256)\n (No client certificate requested)\n by smtp-out1.suse.de (Postfix) with ESMTPS id D83364D2B5;\n Thu, 26 Mar 2026 14:05:25 +0000 (UTC)", "from imap1.dmz-prg2.suse.org (localhost [127.0.0.1])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest\n SHA256)\n (No client certificate requested)\n by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id B877D4A0A3;\n Thu, 26 Mar 2026 14:05:25 +0000 (UTC)", "from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167])\n by imap1.dmz-prg2.suse.org with ESMTPSA id KD1qKyU9xWnEDAAAD6G6ig\n (envelope-from <rguenther@suse.de>); Thu, 26 Mar 2026 14:05:25 +0000" ], "DKIM-Filter": [ "OpenDKIM Filter v2.11.0 sourceware.org AF1154BA23DF", "OpenDKIM Filter v2.11.0 sourceware.org AC21C4BAD15E" ], "DMARC-Filter": "OpenDMARC Filter v1.4.2 sourceware.org AC21C4BAD15E", "ARC-Filter": "OpenARC Filter v1.0.0 sourceware.org AC21C4BAD15E", "ARC-Seal": "i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1774533932; cv=none;\n b=n9t3fPQnk+knvOxqepJOcx8QS1HKLM5wLHNe3j+lIareFDyRmB/YEYF2wa+W2l6TWm85GiFIrRJAg3o3wjHT1X1Dg2Z4zcNAub7GXbv+WWjz4+k1DM88QLfhu9gXKFCD000WQlyFAhzcR4d+1AteDAqCsEaoimdNb0XjEdq5KN0=", "ARC-Message-Signature": "i=1; a=rsa-sha256; d=sourceware.org; s=key;\n t=1774533932; c=relaxed/simple;\n bh=wWIRu2k5PUS18vie17BOGnBiUXFs6Ak2InA2GUFyAqI=;\n h=DKIM-Signature:DKIM-Signature:DKIM-Signature:DKIM-Signature:Date:\n From:To:Subject:MIME-Version:Message-Id;\n b=g4brcnKwNtH7zvfwV68pr2Ai3oM0pC6r2MCGJsKpY8SKcynhodyC6MiM8lfGdylLPdAoA5H3mQ798b7CHtDzcTnAtjXjyoqhQCwZTZ6W3pRw+a+KZ4nCQ0TkE0t/ZldF0F+HBIm/YYzP3eTLgfeXnINPR/7n3P+OrYhbkI5z2hs=", "ARC-Authentication-Results": "i=1; server2.sourceware.org", "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de;\n s=susede2_rsa;\n t=1774533931;\n h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:\n mime-version:mime-version:content-type:content-type;\n bh=92My1QZREZA7cG/stQP584JGv8xlY7pGL7rYjbZoSHw=;\n b=wda4NytToR3CUyx1fOBFoB2fstqP/73bbEEdhPU1QaFVLu7y8Wdr7LSNqUF9R+rDIqgoE9\n AFY9LOmsPjaIQL1UNVhLiUpZZlNgoAY3Fnvrf7CC1vawmTaEIeBzmo9EAx+Cyh6XYBTf6G\n dAfyvwk8t5kt4Zz0RTGD0nqUp+PqxyE=", "v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de;\n s=susede2_ed25519; t=1774533931;\n h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:\n mime-version:mime-version:content-type:content-type;\n bh=92My1QZREZA7cG/stQP584JGv8xlY7pGL7rYjbZoSHw=;\n b=6IzAcvFfju5+9IeEgC6NqeZwLnGf+R6sUCsLhNVY8XWvS00ZQfKQqXG3e5jZTCdKGcCTyx\n jtwnco05+nmqKeDA==", "v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de;\n s=susede2_rsa;\n t=1774533926;\n h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:\n mime-version:mime-version:content-type:content-type;\n bh=92My1QZREZA7cG/stQP584JGv8xlY7pGL7rYjbZoSHw=;\n b=Ep3/23LXutqlrUT+pGRucHsuSf9Qrme0TG1n/DftcXSjtjPXJHpr0kITR+3d2aJxN8ZF6a\n QTSxCjZdsxzJ1e/KhDmk0dH++b+9gx+DmnD2oFskF98s7TELBtAgDHyhRjt1xP18MPIFbA\n ZMrgmZhBZpZNbEP2VIvL1feURhRhfAU=", "v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de;\n s=susede2_ed25519; t=1774533926;\n h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:\n mime-version:mime-version:content-type:content-type;\n bh=92My1QZREZA7cG/stQP584JGv8xlY7pGL7rYjbZoSHw=;\n b=V6pbqhg2FEXAFHQ9vKRp7EO4O2wCu5evWUleDjSVV4xhmBUwM2CEJfYg5D0Z1VKE9zifSt\n aHFtCEnO1hnSGJBA==" ], "Date": "Thu, 26 Mar 2026 15:05:17 +0100 (CET)", "From": "Richard Biener <rguenther@suse.de>", "To": "gcc-patches@gcc.gnu.org", "cc": "rdsandiford@googlemail.com", "Subject": "[PATCH][v2] middle-end/120839 - use unaligned incoming stack argument\n copy more", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=US-ASCII", "Message-Id": "<20260326140525.B877D4A0A3@imap1.dmz-prg2.suse.org>", "X-Spamd-Result": "default: False [-4.51 / 50.00]; BAYES_HAM(-3.00)[100.00%];\n NEURAL_HAM_LONG(-1.00)[-1.000];\n R_DKIM_ALLOW(-0.20)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519];\n NEURAL_HAM_SHORT(-0.20)[-1.000]; MIME_GOOD(-0.10)[text/plain];\n MX_GOOD(-0.01)[]; TO_MATCH_ENVRCPT_ALL(0.00)[];\n DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519];\n FREEMAIL_ENVRCPT(0.00)[googlemail.com];\n RBL_SPAMHAUS_BLOCKED_OPENRESOLVER(0.00)[2a07:de40:b281:104:10:150:64:97:from];\n MIME_TRACE(0.00)[0:+]; RCPT_COUNT_TWO(0.00)[2]; ARC_NA(0.00)[];\n FUZZY_RATELIMITED(0.00)[rspamd.com];\n FREEMAIL_CC(0.00)[googlemail.com]; RCVD_TLS_ALL(0.00)[];\n DKIM_TRACE(0.00)[suse.de:+]; RCVD_COUNT_TWO(0.00)[2];\n FROM_EQ_ENVFROM(0.00)[]; FROM_HAS_DN(0.00)[];\n SPAMHAUS_XBL(0.00)[2a07:de40:b281:104:10:150:64:97:from];\n TO_DN_NONE(0.00)[];\n RECEIVED_SPAMHAUS_BLOCKED_OPENRESOLVER(0.00)[2a07:de40:b281:106:10:150:64:167:received];\n DNSWL_BLOCKED(0.00)[2a07:de40:b281:106:10:150:64:167:received,2a07:de40:b281:104:10:150:64:97:from];\n MISSING_XM_UA(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[];\n DBL_BLOCKED_OPENRESOLVER(0.00)[suse.de:dkim, imap1.dmz-prg2.suse.org:rdns,\n imap1.dmz-prg2.suse.org:mid, imap1.dmz-prg2.suse.org:helo, function.cc:url]", "X-Rspamd-Action": "no action", "X-Rspamd-Server": "rspamd1.dmz-prg2.suse.org", "X-Rspamd-Queue-Id": "D83364D2B5", "X-BeenThere": "gcc-patches@gcc.gnu.org", "X-Mailman-Version": "2.1.30", "Precedence": "list", "List-Id": "Gcc-patches mailing list <gcc-patches.gcc.gnu.org>", "List-Unsubscribe": "<https://gcc.gnu.org/mailman/options/gcc-patches>,\n <mailto:gcc-patches-request@gcc.gnu.org?subject=unsubscribe>", "List-Archive": "<https://gcc.gnu.org/pipermail/gcc-patches/>", "List-Post": "<mailto:gcc-patches@gcc.gnu.org>", "List-Help": "<mailto:gcc-patches-request@gcc.gnu.org?subject=help>", "List-Subscribe": "<https://gcc.gnu.org/mailman/listinfo/gcc-patches>,\n <mailto:gcc-patches-request@gcc.gnu.org?subject=subscribe>", "Errors-To": "gcc-patches-bounces~incoming=patchwork.ozlabs.org@gcc.gnu.org" }, "content": "The following fixes a confusion seen in the x86 backend by\nassign_parm_adjust_stack_rtl failing to trigger a local stack copy\nfor an incoming stack parameter that is not aligned according to\nits type. The condition was introduced in r0-64961-gbfc45551d5ace4\nbut there is the MEM_ALIGN (stack_parm) < PREFERRED_STACK_BOUNDARY\ncondition not triggering for the case in question where both\nMEM_ALIGN and PREFERRED_STACK_BOUNDARY are 128. x86 supports\nstack-realignment so we can honor the declared alignment and this\nclears up the confusion. The following replaces the bound\nby MAX_SUPPORTED_STACK_ALIGNMENT if SUPPORTS_STACK_ALIGNMENT,\nonly affecting x86 and nvptx at this point.\n\nBootstrapped and tested on x86_64-unknown-linux-gnu.\n\nOK?\n\nBtw, for the testcase I see aarch64 producing\n\ne:\n.LFB0:\n .cfi_startproc\n stp x29, x30, [sp, -64]!\n .cfi_def_cfa_offset 64\n .cfi_offset 29, -64\n .cfi_offset 30, -56\n mov x29, sp\n add x0, sp, 47\n and x0, x0, -32\n stp q0, q1, [x0]\n bl __trunctfdf2\n adrp x0, .LANCHOR0\n str d0, [x0, #:lo12:.LANCHOR0]\n ldp x29, x30, [sp], 64\n .cfi_restore 30\n .cfi_restore 29\n .cfi_def_cfa_offset 0\n ret\n\nso it does seem to dynamically align the stack and we expand\n\n(insn 8 7 9 2 (set (mem/c:TF (reg/f:DI 108) [2 f+0 S16 A256]) \n (reg:TF 103)) \"t.c\":5:13 -1\n (nil))\n...\n(insn 15 14 16 2 (set (reg:TF 32 v0)\n (mem/c:TF (reg/f:DI 108) [1 f.a+0 S16 A256])) \"t.c\":5:20 -1\n (nil))\n\nbut the port doesn't define MAX_STACK_ALIGNMENTm has STACK_BOUNDARY\n128 and no PREFERRED_STACK_BOUNDARY. Doesn't that tell us there's\nsome generic code handling large stack allocations?\n\n\tPR middle-end/120839\n\t* function.cc (assign_parm_adjust_stack_rtl): Adjust\n\talignment check forcing a local copy for SUPPORTS_STACK_ALIGNMENT\n\ttargets if the argument is not aligned to its type and\n\tthe current alignment is less than MAX_SUPPORTED_STACK_ALIGNMENT.\n\n\t* gcc.dg/torture/pr120839.c: New testcase.\n---\n gcc/function.cc | 4 +++-\n gcc/testsuite/gcc.dg/torture/pr120839.c | 7 +++++++\n 2 files changed, 10 insertions(+), 1 deletion(-)\n create mode 100644 gcc/testsuite/gcc.dg/torture/pr120839.c", "diff": "diff --git a/gcc/function.cc b/gcc/function.cc\nindex bba05f3380d..5b3018f364e 100644\n--- a/gcc/function.cc\n+++ b/gcc/function.cc\n@@ -2840,7 +2840,9 @@ assign_parm_adjust_stack_rtl (struct assign_parm_data_one *data)\n \t\t\t\t\t\t MEM_ALIGN (stack_parm))))\n \t || (data->nominal_type\n \t && TYPE_ALIGN (data->nominal_type) > MEM_ALIGN (stack_parm)\n-\t && MEM_ALIGN (stack_parm) < PREFERRED_STACK_BOUNDARY)))\n+\t && MEM_ALIGN (stack_parm) < (SUPPORTS_STACK_ALIGNMENT\n+\t\t\t\t\t ? MAX_SUPPORTED_STACK_ALIGNMENT\n+\t\t\t\t\t : PREFERRED_STACK_BOUNDARY))))\n stack_parm = NULL;\n \n /* If parm was passed in memory, and we need to convert it on entry,\ndiff --git a/gcc/testsuite/gcc.dg/torture/pr120839.c b/gcc/testsuite/gcc.dg/torture/pr120839.c\nnew file mode 100644\nindex 00000000000..158e800649f\n--- /dev/null\n+++ b/gcc/testsuite/gcc.dg/torture/pr120839.c\n@@ -0,0 +1,7 @@\n+/* { dg-do compile } */\n+\n+typedef struct {\n+ long double a, b;\n+} c __attribute__((aligned(32)));\n+double d;\n+void e(c f) { d = f.a; }\n", "prefixes": [ "v2" ] }