Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/2216430/?format=api
{ "id": 2216430, "url": "http://patchwork.ozlabs.org/api/patches/2216430/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20260326121947.51200-1-heinrich.schuchardt@canonical.com/", "project": { "id": 14, "url": "http://patchwork.ozlabs.org/api/projects/14/?format=api", "name": "QEMU Development", "link_name": "qemu-devel", "list_id": "qemu-devel.nongnu.org", "list_email": "qemu-devel@nongnu.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20260326121947.51200-1-heinrich.schuchardt@canonical.com>", "list_archive_url": null, "date": "2026-03-26T12:19:47", "name": "hw/acpi: correct field sequence in SPCR table", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "20986d41b0d0ccb489ec523bebb82c001ed20a03", "submitter": { "id": 82181, "url": "http://patchwork.ozlabs.org/api/people/82181/?format=api", "name": "Heinrich Schuchardt", "email": "heinrich.schuchardt@canonical.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20260326121947.51200-1-heinrich.schuchardt@canonical.com/mbox/", "series": [ { "id": 497582, "url": "http://patchwork.ozlabs.org/api/series/497582/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/list/?series=497582", "date": "2026-03-26T12:19:47", "name": "hw/acpi: correct field sequence in SPCR table", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/497582/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2216430/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2216430/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (4096-bit key;\n unprotected) header.d=canonical.com header.i=@canonical.com\n header.a=rsa-sha256 header.s=20251003 header.b=pRrvARaG;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)" ], "Received": [ "from lists.gnu.org (lists.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fhNCm6nndz1y1G\n\tfor <incoming@patchwork.ozlabs.org>; Thu, 26 Mar 2026 23:20:52 +1100 (AEDT)", "from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from <qemu-devel-bounces@nongnu.org>)\n\tid 1w5jh7-0003Xh-1W; Thu, 26 Mar 2026 08:20:13 -0400", "from eggs.gnu.org ([2001:470:142:3::10])\n by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <heinrich.schuchardt@canonical.com>)\n id 1w5jgt-0003T4-DV\n for qemu-devel@nongnu.org; Thu, 26 Mar 2026 08:20:00 -0400", "from smtp-relay-internal-0.canonical.com ([185.125.188.122])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <heinrich.schuchardt@canonical.com>)\n id 1w5jgq-0003Sn-Sg\n for qemu-devel@nongnu.org; Thu, 26 Mar 2026 08:19:58 -0400", "from mail-wm1-f71.google.com (mail-wm1-f71.google.com\n [209.85.128.71])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n (No client certificate requested)\n by smtp-relay-internal-0.canonical.com (Postfix) with ESMTPS id 8973B3F452\n for <qemu-devel@nongnu.org>; Thu, 26 Mar 2026 12:19:53 +0000 (UTC)", "by mail-wm1-f71.google.com with SMTP id\n 5b1f17b1804b1-48553fdd03dso5793585e9.0\n for <qemu-devel@nongnu.org>; Thu, 26 Mar 2026 05:19:53 -0700 (PDT)", "from workstation5 (ip-005-147-080-091.um06.pools.vodafone-ip.de.\n [5.147.80.91]) by smtp.gmail.com with ESMTPSA id\n ffacd0b85a97d-43b919e7111sm7587721f8f.37.2026.03.26.05.19.51\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Thu, 26 Mar 2026 05:19:51 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=canonical.com;\n s=20251003; t=1774527593;\n bh=2a4uksXmDEhXbA8oCTGNFyxIUIo38RL710NsO82kbCA=;\n h=From:To:Cc:Subject:Date:Message-ID:MIME-Version;\n b=pRrvARaGECMJm+iwN1ERuEH2Q9rtmWrcNA3INIBTa4kOp80NKRmQckc2Hh7qLD/XP\n N+ezLONqAaqlFh7IdO+1QszrdxQDExFymS4PpqDo7Y7bIEXIiKOKwru2khsiCX/wtS\n /CPv4wiP+mFSi4xGcaG6ezVvUNKc985QlnzMosxAE/HL070/ZueMHwlPa2wi9u88HV\n l8/w6syv6dCNqr6Q+vMk4RmRCA7d1UgAf+4lUva3RRa7ZUUsZ8/7HRwLzwkaqwXmLx\n STChmJ2NG3j0MRQEbtHaTvuQyyZCypVW1Dp4oqfoLiDpKLVBE+snUTXOVUhImeKIvG\n L0vg+/U0qAxPhLhAGoubV4Pvs4Us18c1CZqyXh3P1NDUEueVBelkWFRKCKmxU79VWL\n neDfL/f8LTmi83wUQfXJg9E4uxHA2eA1XF/XXP9FrbRskWkBbpgZgHsERjryoE9Bfx\n Hw9AlXXN7AE6HsaK7qjcKMRjW+2ZD7waw3K/6Gye8DK5jpWqb5u5wi//2wPapR5VET\n c2Hi274FGgeYATq2WhZq290mDZVDuh+vnlxUI6hHbWHUtc3Z+PzvtptqOm7KpI0x6C\n ciKHU7dqe0w9YWFnQ24ul/qH3BNNKhkFdwUNbdG2vyhnprM6/axpmcZ1+ubFaMZkM1\n BzyOK8fs1S3NuWcopTx1B+Tc=", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1774527593; x=1775132393;\n h=content-transfer-encoding:mime-version:message-id:date:subject:cc\n :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date\n :message-id:reply-to;\n bh=2a4uksXmDEhXbA8oCTGNFyxIUIo38RL710NsO82kbCA=;\n b=GzhymnmNkT0RduGn24FWC3PxncsDnWZYimIUYOAf+zaLhspEkNRikT9rJhLPktdM+Y\n ALB5MHzOB2GaaZ99P0aChDcR1xHHT7d05RUXZUgh7Xbs0ht7MzTgMbuwqm+9d8FttVDK\n u0Yx/iB5Ig6JbFYzq3HPGe9BibFB7w+dpCuaXv+j4LCwFBWb2/G7/HKpCQ7bI4XfS+Km\n FIA2uig71DEN8zZrycATI5xEYgW9XSxWEJwsVd12aBfrPdAIU0WwZJJ1LdfiLOWSbvKT\n oQivr+fcfcZ/j0/j8umTtGfPE8IOaKn108BPKk+WhYfdx0QdkJdnS3pClZjE0lxt4v9i\n xoPA==", "X-Forwarded-Encrypted": "i=1;\n AJvYcCWxCuvnn0+vE2R1YXZeiqgWTWOYhLPsDJZbGUCbKmWHvScF4QQy1/jNNQR72quXKPHoFvvE6Ldxekbm@nongnu.org", "X-Gm-Message-State": "AOJu0YypXS+4ILnxUu2creR7i87RPSfQyNvB1rksXGrrqWnur8Vg7cRq\n H1XzMQ0foCYfm/zMPMOD9JbwQ7LtVNKzecmJJOguThHCe06TYYd8gO2qk0qj+IJ9QLRv/KVGMbD\n OoZozOIVZ5VjiKYiRTXcVxL0qDNadpZcmSyHL4kncQ/cwGtS1gJ5KNdnaLuP/DGUJMZlsYGa9", "X-Gm-Gg": "ATEYQzwRpm1Euutz97RuvXrTzHFbF4CgSzV6G9W1fnBlNmihpSxADUbbAQaVnKqyH5j\n J2zIHHGVmI7j+YVr7U6GVfA9ZbwUuMgdyIZ37LNqgjVRB22U8lj2h9bJOh4hov0ObkZAnaJ2kGW\n +gJqcpO7SaOjrP8K7IFRMbAtm05eBK3Xk2MpJ9P2rBj1D5utfJaMpqdqacjmSLRsZL/oFkCMuQR\n 9qLlZIVW6R72awCIRSTWj6glOsWixOctsMQXl+kmvONE6wvC/pPARp/+23Zh/VT+8zNAKU6qtpt\n 6Gd2NkbSBZ1dzcVJUlKM/8rz8OrhdKZlGAo+3yaektjCvcofE1+LaGfG50gAa0oBtPLVWwd/bNo\n Cs02W9Ix4B0s67vXImdlixbqmWznnUI+5VYK9PVdiS2LkZFpat19HDWMJg/oU4HL9AQ56fkuSSg\n VFYrEuSW3wNhscIy4DRDxqqquIo3yFBbkYcsf1lfyhBxHF", "X-Received": [ "by 2002:a05:600c:a010:b0:487:4cb:2fe4 with SMTP id\n 5b1f17b1804b1-487160bccf1mr112645955e9.33.1774527592940;\n Thu, 26 Mar 2026 05:19:52 -0700 (PDT)", "by 2002:a05:600c:a010:b0:487:4cb:2fe4 with SMTP id\n 5b1f17b1804b1-487160bccf1mr112645365e9.33.1774527592491;\n Thu, 26 Mar 2026 05:19:52 -0700 (PDT)" ], "From": "Heinrich Schuchardt <heinrich.schuchardt@canonical.com>", "To": "\"Michael S . Tsirkin\" <mst@redhat.com>,\n Igor Mammedov <imammedo@redhat.com>", "Cc": "Sia Jee Heng <jeeheng.sia@starfivetech.com>,\n Ani Sinha <anisinha@redhat.com>, qemu-devel@nongnu.org,\n Alistair Francis <alistair.francis@wdc.com>,\n Heinrich Schuchardt <heinrich.schuchardt@canonical.com>", "Subject": "[PATCH] hw/acpi: correct field sequence in SPCR table", "Date": "Thu, 26 Mar 2026 13:19:47 +0100", "Message-ID": "<20260326121947.51200-1-heinrich.schuchardt@canonical.com>", "X-Mailer": "git-send-email 2.53.0", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Received-SPF": "pass client-ip=185.125.188.122;\n envelope-from=heinrich.schuchardt@canonical.com;\n helo=smtp-relay-internal-0.canonical.com", "X-Spam_score_int": "-23", "X-Spam_score": "-2.4", "X-Spam_bar": "--", "X-Spam_report": "(-2.4 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001,\n DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001,\n RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001,\n URI_TRY_3LD=1.999 autolearn=ham autolearn_force=no", "X-Spam_action": "no action", "X-BeenThere": "qemu-devel@nongnu.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "qemu development <qemu-devel.nongnu.org>", "List-Unsubscribe": "<https://lists.nongnu.org/mailman/options/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>", "List-Archive": "<https://lists.nongnu.org/archive/html/qemu-devel>", "List-Post": "<mailto:qemu-devel@nongnu.org>", "List-Help": "<mailto:qemu-devel-request@nongnu.org?subject=help>", "List-Subscribe": "<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=subscribe>", "Errors-To": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org", "Sender": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org" }, "content": "On LoongArch and RISC-V invalid SPCR tables are created:\n\nTerrminal Type : 00\nLanguage : 03\n\nThe correct values are:\n\nTerrminal Type : 03\nLanguage : 00\n\nThis is due to commit 7dd0b070fa09 (\"hw/arm/virt-acpi-build.c: Migrate\nSPCR creation to common location\") that swapped the fields.\n\nSee the specification of the table in\nhttps://learn.microsoft.com/en-us/windows-hardware/drivers/bringup/serial-port-console-redirection-table\n\nFixes: 7dd0b070fa09 (\"hw/arm/virt-acpi-build.c: Migrate SPCR creation to common location\")\nSigned-off-by: Heinrich Schuchardt <heinrich.schuchardt@canonical.com>\n---\n hw/acpi/aml-build.c | 4 ++--\n 1 file changed, 2 insertions(+), 2 deletions(-)", "diff": "diff --git a/hw/acpi/aml-build.c b/hw/acpi/aml-build.c\nindex 4b37405088..a999320e61 100644\n--- a/hw/acpi/aml-build.c\n+++ b/hw/acpi/aml-build.c\n@@ -2115,10 +2115,10 @@ void build_spcr(GArray *table_data, BIOSLinker *linker,\n build_append_int_noprefix(table_data, f->stop_bits, 1);\n /* Flow Control */\n build_append_int_noprefix(table_data, f->flow_control, 1);\n- /* Language */\n- build_append_int_noprefix(table_data, f->language, 1);\n /* Terminal Type */\n build_append_int_noprefix(table_data, f->terminal_type, 1);\n+ /* Language */\n+ build_append_int_noprefix(table_data, f->language, 1);\n /* PCI Device ID */\n build_append_int_noprefix(table_data, f->pci_device_id, 2);\n /* PCI Vendor ID */\n", "prefixes": [] }