Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/2216421/?format=api
{ "id": 2216421, "url": "http://patchwork.ozlabs.org/api/patches/2216421/?format=api", "web_url": "http://patchwork.ozlabs.org/project/uboot/patch/20260326115500.955388-2-sjg@chromium.org/", "project": { "id": 18, "url": "http://patchwork.ozlabs.org/api/projects/18/?format=api", "name": "U-Boot", "link_name": "uboot", "list_id": "u-boot.lists.denx.de", "list_email": "u-boot@lists.denx.de", "web_url": null, "scm_url": null, "webscm_url": null, "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20260326115500.955388-2-sjg@chromium.org>", "list_archive_url": null, "date": "2026-03-26T11:54:57", "name": "[v2,2/2] kbuild: Use relative paths in generated .incbin directives", "commit_ref": null, "pull_url": null, "state": "changes-requested", "archived": false, "hash": "09c74f5c14b81d0ded3c305505336c67d7093bb8", "submitter": { "id": 6170, "url": "http://patchwork.ozlabs.org/api/people/6170/?format=api", "name": "Simon Glass", "email": "sjg@chromium.org" }, "delegate": { "id": 3651, "url": "http://patchwork.ozlabs.org/api/users/3651/?format=api", "username": "trini", "first_name": "Tom", "last_name": "Rini", "email": "trini@ti.com" }, "mbox": "http://patchwork.ozlabs.org/project/uboot/patch/20260326115500.955388-2-sjg@chromium.org/mbox/", "series": [ { "id": 497578, "url": "http://patchwork.ozlabs.org/api/series/497578/?format=api", "web_url": "http://patchwork.ozlabs.org/project/uboot/list/?series=497578", "date": "2026-03-26T11:54:56", "name": "[v2,1/2] kbuild: Move U-Boot .incbin rules to Makefile.lib-u-boot", "version": 2, "mbox": "http://patchwork.ozlabs.org/series/497578/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2216421/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2216421/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<u-boot-bounces@lists.denx.de>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=chromium.org header.i=@chromium.org header.a=rsa-sha256\n header.s=google header.b=f+b6rKLp;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de\n (client-ip=2a01:238:438b:c500:173d:9f52:ddab:ee01; helo=phobos.denx.de;\n envelope-from=u-boot-bounces@lists.denx.de; receiver=patchwork.ozlabs.org)", "phobos.denx.de;\n dmarc=pass (p=none dis=none) header.from=chromium.org", "phobos.denx.de;\n spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de", "phobos.denx.de;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=chromium.org header.i=@chromium.org\n header.b=\"f+b6rKLp\";\n\tdkim-atps=neutral", "phobos.denx.de;\n dmarc=pass (p=none dis=none) header.from=chromium.org", "phobos.denx.de;\n spf=pass smtp.mailfrom=sjg@chromium.org" ], "Received": [ "from phobos.denx.de (phobos.denx.de\n [IPv6:2a01:238:438b:c500:173d:9f52:ddab:ee01])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fhMfR3g8Pz1y1G\n\tfor <incoming@patchwork.ozlabs.org>; Thu, 26 Mar 2026 22:55:27 +1100 (AEDT)", "from h2850616.stratoserver.net (localhost [IPv6:::1])\n\tby phobos.denx.de (Postfix) with ESMTP id 4EFC183FD3;\n\tThu, 26 Mar 2026 12:55:21 +0100 (CET)", "by phobos.denx.de (Postfix, from userid 109)\n id 6751783FD9; Thu, 26 Mar 2026 12:55:20 +0100 (CET)", "from mail-oi1-x22b.google.com (mail-oi1-x22b.google.com\n [IPv6:2607:f8b0:4864:20::22b])\n (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits))\n (No client certificate requested)\n by phobos.denx.de (Postfix) with ESMTPS id 31CC183FA3\n for <u-boot@lists.denx.de>; Thu, 26 Mar 2026 12:55:18 +0100 (CET)", "by mail-oi1-x22b.google.com with SMTP id\n 5614622812f47-466ec4c6846so277646b6e.3\n for <u-boot@lists.denx.de>; Thu, 26 Mar 2026 04:55:18 -0700 (PDT)", "from chromium.org ([73.34.74.121]) by smtp.gmail.com with ESMTPSA id\n 586e51a60fabf-41cc7b6312csm2145860fac.15.2026.03.26.04.55.13\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Thu, 26 Mar 2026 04:55:14 -0700 (PDT)" ], "X-Spam-Checker-Version": "SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de", "X-Spam-Level": "", "X-Spam-Status": "No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,\n DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,\n RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_PASS autolearn=ham\n autolearn_force=no version=3.4.2", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=chromium.org; s=google; t=1774526116; x=1775130916; darn=lists.denx.de;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:from:to:cc:subject:date\n :message-id:reply-to;\n bh=yQ9u+pAhrAF7QXuAgzwslLohwNno4IFo+TFQM6izD54=;\n b=f+b6rKLp3SJm9GYCy/SDYlFkjfXvG/5SQ2f971Om0K9FIiGJVbp3VjF4OIQZ3Hn27P\n 9SamVoxMKrC3fXmRhVVS4bpCc8gsdjIcolzNy5kVRyTknXcu092TFqZ5S4MGtqONZl7N\n fMFPUig1uDd+KTb9EOVjtqHk7eb5bHrdkvtUQ=", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1774526116; x=1775130916;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from\n :to:cc:subject:date:message-id:reply-to;\n bh=yQ9u+pAhrAF7QXuAgzwslLohwNno4IFo+TFQM6izD54=;\n b=Ehz/5DSdvKlUECrs2cniyZQK+HZhxH51FMdBC3MyLnv6FY8S4GGt7SFJ1r6TWUOj8+\n JSQT7Jc50tE+m3PGkQrQdYosDh7Z8l62TIBTzQhBurFu9AJGkhS00uYllw7oAqoKP44h\n WGu2Le+EC1v5L7DiSxYO25LB5Lk6xNjUrPkSwr4gLJqvSsCkOCpamKGWeEoguWz52ZME\n B3tNoSAz6rO5AI7UNCc37tbcGttEl4qNJVUKpTePb/cmyNQxUNp92gKrPUu+G+e6w5lB\n QFnBqUUEi8TQXwMLToKVzb2vVwx+7Ol33hzKJNNvemqYZN8Vpt6YxtmhQIsLkavbp0zN\n FMDg==", "X-Gm-Message-State": "AOJu0YxcdQSEo8Wdhd6K0Nw2fT8BJwY21kdNzw2ljiMDXY8U0w0LekOp\n Y/Xjl7ofHZiE3HSXTDRWPnjqXzsS7q/AjNt5h9Yf0I1gWubjf0xbxfF9gVmiF2PGOwg+WaqC7lE\n T5Ps=", "X-Gm-Gg": "ATEYQzzYt1/Wu8OO2W+0LF7+jUWzVF9kfxHDMBu+9F/UpY3jw4LUrQ6buC+KU8Yqm6f\n j1CCB0s+LkK+OyF/ARNVblvNKsqyKndOyX//iCBZl/hDYV2bxd5LrOrGnsfAHcDmvFdM2dkSmOi\n vkQOzNNWgzv1fOIFL/NhVmjQRPxz7VHuhPd6+0VWKeyvE5r366ioBKLHR8cOLl23wMi0LULAtPz\n hOGZnKBUq4ccAFSOf7QWOFoQKR2f8rTUk+0W5Gxqy66GedTT4x6a2D+tAjM93B5dLm9zs/a6BnR\n GRm7lv7W7xh8wCwuc+PIgkMMIjAXSFBNEtCQQMKEphXFgAyZHhTjXriTs8d2qlF9N+1vMj4tjXO\n 6IDRFrrhKEBAWsuq0kuQS/vqWGTr75qRIPD0EqWfbzp9Rql1iqCbKTwpkYoJwLb+vJqMEMzItFF\n s4GT1weYMYDfjzVJNmjg==", "X-Received": "by 2002:a05:6870:1436:b0:41b:f7f5:e887 with SMTP id\n 586e51a60fabf-41ca6fc02a7mr4232975fac.24.1774526116288;\n Thu, 26 Mar 2026 04:55:16 -0700 (PDT)", "From": "Simon Glass <sjg@chromium.org>", "To": "u-boot@lists.denx.de", "Cc": "Simon Glass <sjg@chromium.org>,\n Anatolij Gustschin <ag.dev.uboot@gmail.com>,\n Dario Binacchi <dario.binacchi@amarulasolutions.com>,\n Heinrich Schuchardt <xypron.glpk@gmx.de>, Ion Agorria <ion@agorria.com>,\n Miquel Raynal <miquel.raynal@bootlin.com>,\n Patrice Chotard <patrice.chotard@foss.st.com>,\n Svyatoslav Ryhel <clamor95@gmail.com>, Tom Rini <trini@konsulko.com>", "Subject": "[PATCH v2 2/2] kbuild: Use relative paths in generated .incbin\n directives", "Date": "Thu, 26 Mar 2026 05:54:57 -0600", "Message-ID": "<20260326115500.955388-2-sjg@chromium.org>", "X-Mailer": "git-send-email 2.43.0", "In-Reply-To": "<20260326115500.955388-1-sjg@chromium.org>", "References": "<20260326115500.955388-1-sjg@chromium.org>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "u-boot@lists.denx.de", "X-Mailman-Version": "2.1.39", "Precedence": "list", "List-Id": "U-Boot discussion <u-boot.lists.denx.de>", "List-Unsubscribe": "<https://lists.denx.de/options/u-boot>,\n <mailto:u-boot-request@lists.denx.de?subject=unsubscribe>", "List-Archive": "<https://lists.denx.de/pipermail/u-boot/>", "List-Post": "<mailto:u-boot@lists.denx.de>", "List-Help": "<mailto:u-boot-request@lists.denx.de?subject=help>", "List-Subscribe": "<https://lists.denx.de/listinfo/u-boot>,\n <mailto:u-boot-request@lists.denx.de?subject=subscribe>", "Errors-To": "u-boot-bounces@lists.denx.de", "Sender": "\"U-Boot\" <u-boot-bounces@lists.denx.de>", "X-Virus-Scanned": "clamav-milter 0.103.8 at phobos.denx.de", "X-Virus-Status": "Clean" }, "content": "The generated .S files for fonts and splash screens use .incbin with the\nfull prerequisite path. When building with O= this bakes an absolute\npath into the .S file. If the build directory is later used on a\ndifferent machine (e.g. in a container), the assembler cannot find the\nsource file.\n\nUse $(src)/$(notdir $<) instead of $< so the .incbin directive contains\na source-relative path like drivers/video/fonts/nimbus_sans_l_regular.ttf\nrather than an absolute one. Add per-file AFLAGS with -Wa,-I$(srctree)\nin the subdirectory Makefiles so the assembler can resolve these paths,\nkeeping scripts/Makefile.lib free of U-Boot-specific changes.\n\nThe EFI rule is left unchanged since its prerequisite is a generated\nfile in the build directory, like the DTB and DTBO rules.\n\nSigned-off-by: Simon Glass <sjg@chromium.org>\n---\n\nChanges in v2:\n- Move U-Boot .incbin rules to Makefile.lib-u-boot first (previous patch)\n- Drop the EFI .incbin change since .efi files are generated, not source\n- Use per-file AFLAGS instead of modifying a_flags in Makefile.lib\n\n drivers/video/Makefile | 1 +\n drivers/video/fonts/Makefile | 8 ++++++++\n scripts/Makefile.lib-u-boot | 4 ++--\n 3 files changed, 11 insertions(+), 2 deletions(-)", "diff": "diff --git a/drivers/video/Makefile b/drivers/video/Makefile\nindex 984768ea156..020b6680345 100644\n--- a/drivers/video/Makefile\n+++ b/drivers/video/Makefile\n@@ -25,6 +25,7 @@ obj-$(CONFIG_PANEL_HX8238D) += hx8238d.o\n obj-$(CONFIG_$(PHASE_)SIMPLE_PANEL) += simple_panel.o\n \n obj-$(CONFIG_VIDEO_LOGO) += u_boot_logo.o\n+AFLAGS_u_boot_logo.o += -Wa,-I$(srctree)\n obj-$(CONFIG_$(PHASE_)BMP) += bmp.o\n \n endif\ndiff --git a/drivers/video/fonts/Makefile b/drivers/video/fonts/Makefile\nindex 1111f92a2c6..a2ac4bd40b3 100644\n--- a/drivers/video/fonts/Makefile\n+++ b/drivers/video/fonts/Makefile\n@@ -8,3 +8,11 @@ obj-$(CONFIG_CONSOLE_TRUETYPE_ANKACODER) += ankacoder_c75_r.o\n obj-$(CONFIG_CONSOLE_TRUETYPE_RUFSCRIPT) += rufscript010.o\n obj-$(CONFIG_CONSOLE_TRUETYPE_CANTORAONE) += cantoraone_regular.o\n obj-$(CONFIG_CONSOLE_TRUETYPE_DEJAVU) += dejavu_mono.o\n+\n+# The .S files generated from .ttf fonts use .incbin with a source-relative\n+# path, so tell the assembler where to find the source tree.\n+AFLAGS_nimbus_sans_l_regular.o += -Wa,-I$(srctree)\n+AFLAGS_ankacoder_c75_r.o += -Wa,-I$(srctree)\n+AFLAGS_rufscript010.o += -Wa,-I$(srctree)\n+AFLAGS_cantoraone_regular.o += -Wa,-I$(srctree)\n+AFLAGS_dejavu_mono.o += -Wa,-I$(srctree)\ndiff --git a/scripts/Makefile.lib-u-boot b/scripts/Makefile.lib-u-boot\nindex c55f8d8e0c3..4c4de359fe5 100644\n--- a/scripts/Makefile.lib-u-boot\n+++ b/scripts/Makefile.lib-u-boot\n@@ -14,7 +14,7 @@ cmd_S_ttf=\t\t\t\t\t\t\\\n \techo '.balign 16';\t\t\t\t\\\n \techo '.global __ttf_$(*F)_begin';\t\t\\\n \techo '__ttf_$(*F)_begin:';\t\t\t\\\n-\techo '.incbin \"$<\" ';\t\t\t\t\\\n+\techo '.incbin \"$(src)/$(notdir $<)\" ';\t\t\t\t\\\n \techo '__ttf_$(*F)_end:';\t\t\t\\\n \techo '.global __ttf_$(*F)_end';\t\t\t\\\n \techo '.balign 16';\t\t\t\t\\\n@@ -34,7 +34,7 @@ cmd_S_splash=\t\t\t\t\t\t\\\n \techo '.balign 16';\t\t\t\t\\\n \techo '.global __splash_$(*F)_begin';\t\t\\\n \techo '__splash_$(*F)_begin:';\t\t\t\\\n-\techo '.incbin \"$<\" ';\t\t\t\t\\\n+\techo '.incbin \"$(src)/$(notdir $<)\" ';\t\t\t\t\\\n \techo '__splash_$(*F)_end:';\t\t\t\\\n \techo '.global __splash_$(*F)_end';\t\t\\\n \techo '.balign 16';\t\t\t\t\\\n", "prefixes": [ "v2", "2/2" ] }