Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/2216416/?format=api
{ "id": 2216416, "url": "http://patchwork.ozlabs.org/api/patches/2216416/?format=api", "web_url": "http://patchwork.ozlabs.org/project/uboot/patch/20260326115111.1631261-2-ilias.apalodimas@linaro.org/", "project": { "id": 18, "url": "http://patchwork.ozlabs.org/api/projects/18/?format=api", "name": "U-Boot", "link_name": "uboot", "list_id": "u-boot.lists.denx.de", "list_email": "u-boot@lists.denx.de", "web_url": null, "scm_url": null, "webscm_url": null, "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20260326115111.1631261-2-ilias.apalodimas@linaro.org>", "list_archive_url": null, "date": "2026-03-26T11:51:07", "name": "[v1,1/3] fdtdec: Deduplicate iterator function", "commit_ref": null, "pull_url": null, "state": "changes-requested", "archived": false, "hash": "d1a40044450425c15601a235255fb5a8dd70bb5a", "submitter": { "id": 74147, "url": "http://patchwork.ozlabs.org/api/people/74147/?format=api", "name": "Ilias Apalodimas", "email": "ilias.apalodimas@linaro.org" }, "delegate": { "id": 3651, "url": "http://patchwork.ozlabs.org/api/users/3651/?format=api", "username": "trini", "first_name": "Tom", "last_name": "Rini", "email": "trini@ti.com" }, "mbox": "http://patchwork.ozlabs.org/project/uboot/patch/20260326115111.1631261-2-ilias.apalodimas@linaro.org/mbox/", "series": [ { "id": 497576, "url": "http://patchwork.ozlabs.org/api/series/497576/?format=api", "web_url": "http://patchwork.ozlabs.org/project/uboot/list/?series=497576", "date": "2026-03-26T11:51:06", "name": "Relocate U-Boot in the last bank", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/497576/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2216416/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2216416/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<u-boot-bounces@lists.denx.de>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256\n header.s=google header.b=UXEnQ9I0;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de\n (client-ip=85.214.62.61; helo=phobos.denx.de;\n envelope-from=u-boot-bounces@lists.denx.de; receiver=patchwork.ozlabs.org)", "phobos.denx.de;\n dmarc=pass (p=none dis=none) header.from=linaro.org", "phobos.denx.de;\n spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de", "phobos.denx.de;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=linaro.org header.i=@linaro.org header.b=\"UXEnQ9I0\";\n\tdkim-atps=neutral", "phobos.denx.de;\n dmarc=pass (p=none dis=none) header.from=linaro.org", "phobos.denx.de;\n spf=pass smtp.mailfrom=ilias.apalodimas@linaro.org" ], "Received": [ "from phobos.denx.de (phobos.denx.de [85.214.62.61])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fhMZ81yTkz1y1x\n\tfor <incoming@patchwork.ozlabs.org>; Thu, 26 Mar 2026 22:51:44 +1100 (AEDT)", "from h2850616.stratoserver.net (localhost [IPv6:::1])\n\tby phobos.denx.de (Postfix) with ESMTP id A033483F14;\n\tThu, 26 Mar 2026 12:51:34 +0100 (CET)", "by phobos.denx.de (Postfix, from userid 109)\n id 6A53380517; Thu, 26 Mar 2026 12:51:33 +0100 (CET)", "from mail-wm1-x334.google.com (mail-wm1-x334.google.com\n [IPv6:2a00:1450:4864:20::334])\n (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits))\n (No client certificate requested)\n by phobos.denx.de (Postfix) with ESMTPS id 29756838BB\n for <u-boot@lists.denx.de>; Thu, 26 Mar 2026 12:51:31 +0100 (CET)", "by mail-wm1-x334.google.com with SMTP id\n 5b1f17b1804b1-48538c5956bso7657945e9.0\n for <u-boot@lists.denx.de>; Thu, 26 Mar 2026 04:51:31 -0700 (PDT)", "from hera ([94.131.143.12]) by smtp.gmail.com with ESMTPSA id\n 5b1f17b1804b1-4871fb3d09dsm25968005e9.0.2026.03.26.04.51.29\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Thu, 26 Mar 2026 04:51:29 -0700 (PDT)" ], "X-Spam-Checker-Version": "SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de", "X-Spam-Level": "", "X-Spam-Status": "No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,\n DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_BLOCKED,\n SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.2", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=linaro.org; s=google; t=1774525890; x=1775130690; darn=lists.denx.de;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:from:to:cc:subject:date\n :message-id:reply-to;\n bh=P2Z1UmY5ZYlyL7HbF/75dN6hWTpGHa0x+q+pJO3Y3VU=;\n b=UXEnQ9I0Su2PNYmofwiVlFNd3Kst931NIZ42VfE2qn/UHgyaX9S2srYbTwKB4B5qU8\n xVxIvIugFV2CqgTdfe7F2fT3PCc3zRIoMhLskbG0AvwWMGm/yVaBv5PxjeplUth5EyGa\n JLyFHmvE1CV2zey2p2tWRwZts+YDIqE27F41K8HdoYPGdUybq6uixm/8OTEdhnYvyFXd\n ZTAQTcGnCjgBZ172vIdm4cBcvucSPmXNjRlix8+vVzWZLluCjS+aGgy524eOaKT33f4V\n QYOuKz8/+2sps5A2cV3lGIPuHbEC71QaRTbfeaoqU/yIFrfq4mryCAKOcI+rumnie7gx\n /weA==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1774525890; x=1775130690;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from\n :to:cc:subject:date:message-id:reply-to;\n bh=P2Z1UmY5ZYlyL7HbF/75dN6hWTpGHa0x+q+pJO3Y3VU=;\n b=scPHUvLwkT4QPNZ1ioAlbOWhoYWinyPCPwaypspVNy0/com94zLlK1zIhIXHdOSxrO\n fIyFzzG94anqLUjS01wz9FAHoKwZ7WYGkwI1wNwrpN48WPZil1N2/pCakDgONwRo1CC8\n b3KwvWw62Ynb4mmodJPhZNXGiaYJ4bCXGp+Pa1iMz/NmmMj4GHT966BxezYmvSqTitjg\n q4ntoTPufyNJ1maL3OaC1CmmDIq1TkuSHXmI6m+QgVSjW9z2DDWTuCbdBkH156YTXZT2\n PbS6VGoHvCt5eJdUtltbAxOho4Y5chvXNlq/Ur1syvDNPUyneznBpTwJkTJaA8Gbopt3\n Wl1A==", "X-Forwarded-Encrypted": "i=1;\n AJvYcCUJZLC1eXWvNAOFLM5ltZzCAcZBl1EcC5tfu6RaWvA2B70s2MfK+WWR1urjifRb6QWWa0aZjlo=@lists.denx.de", "X-Gm-Message-State": "AOJu0Yzp3vR1I1KM4XDQoiOLloy4F5bI1V94qrNLnPRsXg7I7xx30OXL\n KSmEK5ZZTMH0cqAy/iqD3RB2rdo0yUFrNyjJ8vME//DxbJbJ/trM+rrJnB80QAEWy7s=", "X-Gm-Gg": "ATEYQzy/4cqJYK5QzN3xmYOcLZwT5uix3RyyH9AwpBBBb5hB1MQlORcDCK1zQ2cjNqY\n RgdslYD/YabwugONIU1UCjCymD1gl2QkACwnCiUZYEMpeqSrtLsRNNbnOqWrUK2IsflS0Iav6Hz\n gl0/uagJYVsZ6G9HpzzODIoNG5PwMMf+mdI+NVPsT35IaSCeUvp4nhEl10VpqRfjjhp4TFo/iMX\n CVH7GWWce+C6Fk3Ozpdw0RP5fy2I2ipTZMks/5yAmu3kF2N1jhnCBuI00RbygradCrjJsDWLbQ9\n pf6S2kBLJTVTx/BwRBclW0ZcyFFSiHGyY7MEqPVAulFr6HdoDnJc+lO1ntjfVoZnw2OuNRSLZ7H\n C+o18Evgg1RboF/5i+P+9m+xk5hkE2cac8d6ZIyQI+YT3T6D6pxeaPMGMu5xp+UElE+7gmRDru5\n 17F3yiH9NOaGylVvFWbWsiRqum2jtrcHjKf037Zuk51IFtyviw7GjO6/TEs5dz2/UZHr4FaEDvd\n lkXTdX0QkvGuAAYuOgr3cyHsw9GNN96APCPkDltqFTzDb8frJy9GTvnrFtfzcb2sH4FZESjPaD7\n hWL08cRXfYAIRwTyYiAPa/OXGKMqBCaKqzuIaOH4IfCdCDr96882/fD84wbFyKXLVkt7DwJlP5d\n ZlzUsCFhz4T9U9/h83SUGFte9ZLO54tbuop5lsdNjO5aYDPiYTsDASBesV5mez2fGdRbQMfn/0q\n nG1yx5rVCTKp3pNriL8MWBr4Nt/NulA2GiBJalllS+2l42mbpgqJjHKFYXUQyK", "X-Received": "by 2002:a05:600d:16:b0:485:3428:774c with SMTP id\n 5b1f17b1804b1-48722ba90cbmr14842715e9.4.1774525890514;\n Thu, 26 Mar 2026 04:51:30 -0700 (PDT)", "From": "Ilias Apalodimas <ilias.apalodimas@linaro.org>", "To": "marek.vasut+renesas@mailbox.org,\n\ttrini@konsulko.com", "Cc": "Ilias Apalodimas <ilias.apalodimas@linaro.org>,\n\tu-boot@lists.denx.de", "Subject": "[PATCH v1 1/3] fdtdec: Deduplicate iterator function", "Date": "Thu, 26 Mar 2026 13:51:07 +0200", "Message-ID": "<20260326115111.1631261-2-ilias.apalodimas@linaro.org>", "X-Mailer": "git-send-email 2.51.0", "In-Reply-To": "<20260326115111.1631261-1-ilias.apalodimas@linaro.org>", "References": "<20260326115111.1631261-1-ilias.apalodimas@linaro.org>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "u-boot@lists.denx.de", "X-Mailman-Version": "2.1.39", "Precedence": "list", "List-Id": "U-Boot discussion <u-boot.lists.denx.de>", "List-Unsubscribe": "<https://lists.denx.de/options/u-boot>,\n <mailto:u-boot-request@lists.denx.de?subject=unsubscribe>", "List-Archive": "<https://lists.denx.de/pipermail/u-boot/>", "List-Post": "<mailto:u-boot@lists.denx.de>", "List-Help": "<mailto:u-boot-request@lists.denx.de?subject=help>", "List-Subscribe": "<https://lists.denx.de/listinfo/u-boot>,\n <mailto:u-boot-request@lists.denx.de?subject=subscribe>", "Errors-To": "u-boot-bounces@lists.denx.de", "Sender": "\"U-Boot\" <u-boot-bounces@lists.denx.de>", "X-Virus-Scanned": "clamav-milter 0.103.8 at phobos.denx.de", "X-Virus-Status": "Clean" }, "content": "From: Marek Vasut <marek.vasut+renesas@mailbox.org>\n\nBoth fdtdec_setup_memory_banksize() and fdtdec_setup_mem_size_base_lowest()\nimplement the exact same iterator over all memory banks, the only difference\nis the body that is executed for each bank. Deduplicate the functionality\ninto iterator function fdtdec_setup_mem_for_each_bank(), which takes a\nfunction pointer to a function which implements the body as a parameter.\nNo functional change.\n\nReviewed-by: Ilias Apalodimas <ilias.apalodimas@linaro.org>\nSigned-off-by: Ilias Apalodimas <ilias.apalodimas@linaro.org>\nSigned-off-by: Marek Vasut <marek.vasut+renesas@mailbox.org>\n---\nChanges since RFC:\n- None\n\n lib/fdtdec.c | 77 ++++++++++++++++++++--------------------------------\n 1 file changed, 30 insertions(+), 47 deletions(-)", "diff": "diff --git a/lib/fdtdec.c b/lib/fdtdec.c\nindex c38738b48c79..d820f75b031d 100644\n--- a/lib/fdtdec.c\n+++ b/lib/fdtdec.c\n@@ -1092,7 +1092,7 @@ ofnode get_next_memory_node(ofnode mem)\n \treturn mem;\n }\n \n-int fdtdec_setup_memory_banksize(void)\n+static int fdtdec_setup_mem_for_each_bank(void (*bankfn)(struct resource *res, int bank))\n {\n \tint bank, ret, reg = 0;\n \tstruct resource res;\n@@ -1120,63 +1120,46 @@ int fdtdec_setup_memory_banksize(void)\n \t\tif (ret != 0)\n \t\t\treturn -EINVAL;\n \n-\t\tgd->bd->bi_dram[bank].start = (phys_addr_t)res.start;\n-\t\tgd->bd->bi_dram[bank].size =\n-\t\t\t(phys_size_t)(res.end - res.start + 1);\n-\n-\t\tdebug(\"%s: DRAM Bank #%d: start = 0x%llx, size = 0x%llx\\n\",\n-\t\t __func__, bank,\n-\t\t (unsigned long long)gd->bd->bi_dram[bank].start,\n-\t\t (unsigned long long)gd->bd->bi_dram[bank].size);\n+\t\tbankfn(&res, bank);\n \t}\n \n \treturn 0;\n }\n \n-int fdtdec_setup_mem_size_base_lowest(void)\n+static void fdtdec_setup_memory_banksize_bankfn(struct resource *res, int bank)\n {\n-\tint bank, ret, reg = 0;\n-\tstruct resource res;\n-\tunsigned long base;\n-\tphys_size_t size;\n-\tofnode mem = ofnode_null();\n+\tgd->bd->bi_dram[bank].start = (phys_addr_t)res->start;\n+\tgd->bd->bi_dram[bank].size = (phys_size_t)(res->end - res->start + 1);\n \n-\tgd->ram_base = (unsigned long)~0;\n-\n-\tmem = get_next_memory_node(mem);\n-\tif (!ofnode_valid(mem)) {\n-\t\tdebug(\"%s: Missing /memory node\\n\", __func__);\n-\t\treturn -EINVAL;\n-\t}\n-\n-\tfor (bank = 0; bank < CONFIG_NR_DRAM_BANKS; bank++) {\n-\t\tret = ofnode_read_resource(mem, reg++, &res);\n-\t\tif (ret < 0) {\n-\t\t\treg = 0;\n-\t\t\tmem = get_next_memory_node(mem);\n-\t\t\tif (!ofnode_valid(mem))\n-\t\t\t\tbreak;\n-\n-\t\t\tret = ofnode_read_resource(mem, reg++, &res);\n-\t\t\tif (ret < 0)\n-\t\t\t\tbreak;\n-\t\t}\n-\n-\t\tif (ret != 0)\n-\t\t\treturn -EINVAL;\n+\tdebug(\"%s: DRAM Bank #%d: start = 0x%llx, size = 0x%llx\\n\",\n+\t __func__, bank,\n+\t (unsigned long long)gd->bd->bi_dram[bank].start,\n+\t (unsigned long long)gd->bd->bi_dram[bank].size);\n+}\n \n-\t\tbase = (unsigned long)res.start;\n-\t\tsize = (phys_size_t)(res.end - res.start + 1);\n+int fdtdec_setup_memory_banksize(void)\n+{\n+\treturn fdtdec_setup_mem_for_each_bank(fdtdec_setup_memory_banksize_bankfn);\n+}\n \n-\t\tif (gd->ram_base > base && size) {\n-\t\t\tgd->ram_base = base;\n-\t\t\tgd->ram_size = size;\n-\t\t\tdebug(\"%s: Initial DRAM base %lx size %lx\\n\",\n-\t\t\t __func__, base, (unsigned long)size);\n-\t\t}\n+static void fdtdec_setup_mem_size_base_lowest_bankfn(struct resource *res, int bank)\n+{\n+\tunsigned long base = (unsigned long)res->start;\n+\tphys_size_t size = (phys_size_t)(res->end - res->start + 1);\n+\n+\tif (gd->ram_base > base && size) {\n+\t\tgd->ram_base = base;\n+\t\tgd->ram_size = size;\n+\t\tdebug(\"%s: Initial DRAM base %lx size %lx\\n\",\n+\t\t __func__, base, (unsigned long)size);\n \t}\n+}\n \n-\treturn 0;\n+int fdtdec_setup_mem_size_base_lowest(void)\n+{\n+\tgd->ram_base = (unsigned long)~0;\n+\n+\treturn fdtdec_setup_mem_for_each_bank(fdtdec_setup_mem_size_base_lowest_bankfn);\n }\n \n static int uncompress_blob(const void *src, ulong sz_src, void **dstp)\n", "prefixes": [ "v1", "1/3" ] }