Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/2216376/?format=api
{ "id": 2216376, "url": "http://patchwork.ozlabs.org/api/patches/2216376/?format=api", "web_url": "http://patchwork.ozlabs.org/project/linux-cifs-client/patch/20260326104544.509518-20-dhowells@redhat.com/", "project": { "id": 12, "url": "http://patchwork.ozlabs.org/api/projects/12/?format=api", "name": "Linux CIFS Client", "link_name": "linux-cifs-client", "list_id": "linux-cifs.vger.kernel.org", "list_email": "linux-cifs@vger.kernel.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20260326104544.509518-20-dhowells@redhat.com>", "list_archive_url": null, "date": "2026-03-26T10:45:34", "name": "[19/26] cifs: Remove support for ITER_KVEC/BVEC/FOLIOQ from smb_extract_iter_to_rdma()", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "77bc80f9d303065e05a067dec69a0863ff1e986e", "submitter": { "id": 59, "url": "http://patchwork.ozlabs.org/api/people/59/?format=api", "name": "David Howells", "email": "dhowells@redhat.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/linux-cifs-client/patch/20260326104544.509518-20-dhowells@redhat.com/mbox/", "series": [ { "id": 497565, "url": "http://patchwork.ozlabs.org/api/series/497565/?format=api", "web_url": "http://patchwork.ozlabs.org/project/linux-cifs-client/list/?series=497565", "date": "2026-03-26T10:45:15", "name": "netfs: Keep track of folios in a segmented bio_vec[] chain", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/497565/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2216376/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2216376/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "\n <linux-cifs+bounces-10542-incoming=patchwork.ozlabs.org@vger.kernel.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "linux-cifs@vger.kernel.org" ], "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=mimecast20190719 header.b=KLgnR05x;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=2600:3c04:e001:36c::12fc:5321; helo=tor.lore.kernel.org;\n envelope-from=linux-cifs+bounces-10542-incoming=patchwork.ozlabs.org@vger.kernel.org;\n receiver=patchwork.ozlabs.org)", "smtp.subspace.kernel.org;\n\tdkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com\n header.b=\"KLgnR05x\"", "smtp.subspace.kernel.org;\n arc=none smtp.client-ip=170.10.133.124", "smtp.subspace.kernel.org;\n dmarc=pass (p=quarantine dis=none) header.from=redhat.com", "smtp.subspace.kernel.org;\n spf=pass smtp.mailfrom=redhat.com" ], "Received": [ "from tor.lore.kernel.org (tor.lore.kernel.org\n [IPv6:2600:3c04:e001:36c::12fc:5321])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fhLkN0ZM8z1y1G\n\tfor <incoming@patchwork.ozlabs.org>; Thu, 26 Mar 2026 22:13:48 +1100 (AEDT)", "from smtp.subspace.kernel.org (conduit.subspace.kernel.org\n [100.90.174.1])\n\tby tor.lore.kernel.org (Postfix) with ESMTP id 2B7C931BC18C\n\tfor <incoming@patchwork.ozlabs.org>; Thu, 26 Mar 2026 10:53:41 +0000 (UTC)", "from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id 35DD138B7BF;\n\tThu, 26 Mar 2026 10:49:04 +0000 (UTC)", "from us-smtp-delivery-124.mimecast.com\n (us-smtp-delivery-124.mimecast.com [170.10.133.124])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby smtp.subspace.kernel.org (Postfix) with ESMTPS id 3AE233E5EC5\n\tfor <linux-cifs@vger.kernel.org>; Thu, 26 Mar 2026 10:49:02 +0000 (UTC)", "from mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com\n (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by\n relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3,\n cipher=TLS_AES_256_GCM_SHA384) id us-mta-180-NVW6woi9PzuY_nXMvCratw-1; Thu,\n 26 Mar 2026 06:48:56 -0400", "from mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com\n (mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.4])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n\t(No client certificate requested)\n\tby mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS\n id 31466195608B;\n\tThu, 26 Mar 2026 10:48:53 +0000 (UTC)", "from warthog.procyon.org.com (unknown [10.44.33.121])\n\tby mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP\n id 4F81F3000223;\n\tThu, 26 Mar 2026 10:48:46 +0000 (UTC)" ], "ARC-Seal": "i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;\n\tt=1774522144; cv=none;\n b=gyPJ2g223LzUSEH+dwD532wU1rBRmYxs7A3XRufD7TURZbB6EB+AHACV6TD1yX2Mcratnt0TMZ69Q1K7awVxO584Q9mTLnV5sBEtzDhEVvO5OVuYEMJi7DFdGvHPziZGsXVOAAMlXEjACQwJC/V4Fq6gajXDLpodMgZOo12Bs6k=", "ARC-Message-Signature": "i=1; a=rsa-sha256; d=subspace.kernel.org;\n\ts=arc-20240116; t=1774522144; c=relaxed/simple;\n\tbh=NuHELTMH2SeFr1y9KlDYkuQWSEKgI3Zi4FFIE8rccO0=;\n\th=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References:\n\t MIME-Version;\n b=EW6BO2kEFUcg4EQ3GzeeW9bzflPwVKM6TJgFTESEzuz45waPd9APxGMycHAah9JiUuhY0t2wY0BBc6NvqKDmXI/L6wVNCSB4qPlh4PgHPxt+j50JAFAialTQGZ7fhFf5IY4Qpl6DcDY53zK+qOx25x5PIFjK+LqgEWmZQHB6bRY=", "ARC-Authentication-Results": "i=1; smtp.subspace.kernel.org;\n dmarc=pass (p=quarantine dis=none) header.from=redhat.com;\n spf=pass smtp.mailfrom=redhat.com;\n dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com\n header.b=KLgnR05x; arc=none smtp.client-ip=170.10.133.124", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n\ts=mimecast20190719; t=1774522141;\n\th=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n\t to:to:cc:cc:mime-version:mime-version:\n\t content-transfer-encoding:content-transfer-encoding:\n\t in-reply-to:in-reply-to:references:references;\n\tbh=An9ppvJd90yS+MIu3WT/4ujzY282508ExyNV62oMYCI=;\n\tb=KLgnR05xAZtdAC8uNggxh0s0nG5YknbIRt8jdA46r/xDBCEnBhzHL0Mp/AXTLqyT/yGeU0\n\tCNl9p1xPzafSNOtlxWsDCV26+cCwW4ibapEwjG1G07I38KJGkxQ18KUVaZZdK+pSYj2Wub\n\tMmEpkSb3P6/gyT1JZSRyH55/jAJ+kiM=", "X-MC-Unique": "NVW6woi9PzuY_nXMvCratw-1", "X-Mimecast-MFC-AGG-ID": "NVW6woi9PzuY_nXMvCratw_1774522133", "From": "David Howells <dhowells@redhat.com>", "To": "Christian Brauner <christian@brauner.io>,\n\tMatthew Wilcox <willy@infradead.org>,\n\tChristoph Hellwig <hch@infradead.org>", "Cc": "David Howells <dhowells@redhat.com>,\n\tPaulo Alcantara <pc@manguebit.com>,\n\tJens Axboe <axboe@kernel.dk>,\n\tLeon Romanovsky <leon@kernel.org>,\n\tSteve French <sfrench@samba.org>,\n\tChenXiaoSong <chenxiaosong@chenxiaosong.com>,\n\tMarc Dionne <marc.dionne@auristor.com>,\n\tEric Van Hensbergen <ericvh@kernel.org>,\n\tDominique Martinet <asmadeus@codewreck.org>,\n\tIlya Dryomov <idryomov@gmail.com>,\n\tTrond Myklebust <trondmy@kernel.org>,\n\tnetfs@lists.linux.dev,\n\tlinux-afs@lists.infradead.org,\n\tlinux-cifs@vger.kernel.org,\n\tlinux-nfs@vger.kernel.org,\n\tceph-devel@vger.kernel.org,\n\tv9fs@lists.linux.dev,\n\tlinux-erofs@lists.ozlabs.org,\n\tlinux-fsdevel@vger.kernel.org,\n\tlinux-kernel@vger.kernel.org,\n\tPaulo Alcantara <pc@manguebit.org>,\n\tShyam Prasad N <sprasad@microsoft.com>,\n\tTom Talpey <tom@talpey.com>", "Subject": "[PATCH 19/26] cifs: Remove support for ITER_KVEC/BVEC/FOLIOQ from\n smb_extract_iter_to_rdma()", "Date": "Thu, 26 Mar 2026 10:45:34 +0000", "Message-ID": "<20260326104544.509518-20-dhowells@redhat.com>", "In-Reply-To": "<20260326104544.509518-1-dhowells@redhat.com>", "References": "<20260326104544.509518-1-dhowells@redhat.com>", "Precedence": "bulk", "X-Mailing-List": "linux-cifs@vger.kernel.org", "List-Id": "<linux-cifs.vger.kernel.org>", "List-Subscribe": "<mailto:linux-cifs+subscribe@vger.kernel.org>", "List-Unsubscribe": "<mailto:linux-cifs+unsubscribe@vger.kernel.org>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-Scanned-By": "MIMEDefang 3.4.1 on 10.30.177.4" }, "content": "netfslib now only presents an bvecq queue and an associated ITER_BVECQ\niterator to the filesystem, so it isn't going to see ITER_KVEC, ITER_BVEC\nor ITER_FOLIOQ iterators. So remove that code.\n\nSigned-off-by: David Howells <dhowells@redhat.com>\ncc: Steve French <sfrench@samba.org>\ncc: Paulo Alcantara <pc@manguebit.org>\ncc: Shyam Prasad N <sprasad@microsoft.com>\ncc: Tom Talpey <tom@talpey.com>\ncc: linux-cifs@vger.kernel.org\ncc: netfs@lists.linux.dev\ncc: linux-fsdevel@vger.kernel.org\n---\n fs/smb/client/smbdirect.c | 165 --------------------------------------\n 1 file changed, 165 deletions(-)", "diff": "diff --git a/fs/smb/client/smbdirect.c b/fs/smb/client/smbdirect.c\nindex f8a6be83db98..d9e026d5e9f9 100644\n--- a/fs/smb/client/smbdirect.c\n+++ b/fs/smb/client/smbdirect.c\n@@ -3142,162 +3142,6 @@ static bool smb_set_sge(struct smb_extract_to_rdma *rdma,\n \treturn true;\n }\n \n-/*\n- * Extract page fragments from a BVEC-class iterator and add them to an RDMA\n- * element list. The pages are not pinned.\n- */\n-static ssize_t smb_extract_bvec_to_rdma(struct iov_iter *iter,\n-\t\t\t\t\tstruct smb_extract_to_rdma *rdma,\n-\t\t\t\t\tssize_t maxsize)\n-{\n-\tconst struct bio_vec *bv = iter->bvec;\n-\tunsigned long start = iter->iov_offset;\n-\tunsigned int i;\n-\tssize_t ret = 0;\n-\n-\tfor (i = 0; i < iter->nr_segs; i++) {\n-\t\tsize_t off, len;\n-\n-\t\tlen = bv[i].bv_len;\n-\t\tif (start >= len) {\n-\t\t\tstart -= len;\n-\t\t\tcontinue;\n-\t\t}\n-\n-\t\tlen = min_t(size_t, maxsize, len - start);\n-\t\toff = bv[i].bv_offset + start;\n-\n-\t\tif (!smb_set_sge(rdma, bv[i].bv_page, off, len))\n-\t\t\treturn -EIO;\n-\n-\t\tret += len;\n-\t\tmaxsize -= len;\n-\t\tif (rdma->nr_sge >= rdma->max_sge || maxsize <= 0)\n-\t\t\tbreak;\n-\t\tstart = 0;\n-\t}\n-\n-\tif (ret > 0)\n-\t\tiov_iter_advance(iter, ret);\n-\treturn ret;\n-}\n-\n-/*\n- * Extract fragments from a KVEC-class iterator and add them to an RDMA list.\n- * This can deal with vmalloc'd buffers as well as kmalloc'd or static buffers.\n- * The pages are not pinned.\n- */\n-static ssize_t smb_extract_kvec_to_rdma(struct iov_iter *iter,\n-\t\t\t\t\tstruct smb_extract_to_rdma *rdma,\n-\t\t\t\t\tssize_t maxsize)\n-{\n-\tconst struct kvec *kv = iter->kvec;\n-\tunsigned long start = iter->iov_offset;\n-\tunsigned int i;\n-\tssize_t ret = 0;\n-\n-\tfor (i = 0; i < iter->nr_segs; i++) {\n-\t\tstruct page *page;\n-\t\tunsigned long kaddr;\n-\t\tsize_t off, len, seg;\n-\n-\t\tlen = kv[i].iov_len;\n-\t\tif (start >= len) {\n-\t\t\tstart -= len;\n-\t\t\tcontinue;\n-\t\t}\n-\n-\t\tkaddr = (unsigned long)kv[i].iov_base + start;\n-\t\toff = kaddr & ~PAGE_MASK;\n-\t\tlen = min_t(size_t, maxsize, len - start);\n-\t\tkaddr &= PAGE_MASK;\n-\n-\t\tmaxsize -= len;\n-\t\tdo {\n-\t\t\tseg = min_t(size_t, len, PAGE_SIZE - off);\n-\n-\t\t\tif (is_vmalloc_or_module_addr((void *)kaddr))\n-\t\t\t\tpage = vmalloc_to_page((void *)kaddr);\n-\t\t\telse\n-\t\t\t\tpage = virt_to_page((void *)kaddr);\n-\n-\t\t\tif (!smb_set_sge(rdma, page, off, seg))\n-\t\t\t\treturn -EIO;\n-\n-\t\t\tret += seg;\n-\t\t\tlen -= seg;\n-\t\t\tkaddr += PAGE_SIZE;\n-\t\t\toff = 0;\n-\t\t} while (len > 0 && rdma->nr_sge < rdma->max_sge);\n-\n-\t\tif (rdma->nr_sge >= rdma->max_sge || maxsize <= 0)\n-\t\t\tbreak;\n-\t\tstart = 0;\n-\t}\n-\n-\tif (ret > 0)\n-\t\tiov_iter_advance(iter, ret);\n-\treturn ret;\n-}\n-\n-/*\n- * Extract folio fragments from a FOLIOQ-class iterator and add them to an RDMA\n- * list. The folios are not pinned.\n- */\n-static ssize_t smb_extract_folioq_to_rdma(struct iov_iter *iter,\n-\t\t\t\t\t struct smb_extract_to_rdma *rdma,\n-\t\t\t\t\t ssize_t maxsize)\n-{\n-\tconst struct folio_queue *folioq = iter->folioq;\n-\tunsigned int slot = iter->folioq_slot;\n-\tssize_t ret = 0;\n-\tsize_t offset = iter->iov_offset;\n-\n-\tBUG_ON(!folioq);\n-\n-\tif (slot >= folioq_nr_slots(folioq)) {\n-\t\tfolioq = folioq->next;\n-\t\tif (WARN_ON_ONCE(!folioq))\n-\t\t\treturn -EIO;\n-\t\tslot = 0;\n-\t}\n-\n-\tdo {\n-\t\tstruct folio *folio = folioq_folio(folioq, slot);\n-\t\tsize_t fsize = folioq_folio_size(folioq, slot);\n-\n-\t\tif (offset < fsize) {\n-\t\t\tsize_t part = umin(maxsize, fsize - offset);\n-\n-\t\t\tif (!smb_set_sge(rdma, folio_page(folio, 0), offset, part))\n-\t\t\t\treturn -EIO;\n-\n-\t\t\toffset += part;\n-\t\t\tret += part;\n-\t\t\tmaxsize -= part;\n-\t\t}\n-\n-\t\tif (offset >= fsize) {\n-\t\t\toffset = 0;\n-\t\t\tslot++;\n-\t\t\tif (slot >= folioq_nr_slots(folioq)) {\n-\t\t\t\tif (!folioq->next) {\n-\t\t\t\t\tWARN_ON_ONCE(ret < iter->count);\n-\t\t\t\t\tbreak;\n-\t\t\t\t}\n-\t\t\t\tfolioq = folioq->next;\n-\t\t\t\tslot = 0;\n-\t\t\t}\n-\t\t}\n-\t} while (rdma->nr_sge < rdma->max_sge && maxsize > 0);\n-\n-\titer->folioq = folioq;\n-\titer->folioq_slot = slot;\n-\titer->iov_offset = offset;\n-\titer->count -= ret;\n-\treturn ret;\n-}\n-\n /*\n * Extract memory fragments from a BVECQ-class iterator and add them to an RDMA\n * list. The folios are not pinned.\n@@ -3373,15 +3217,6 @@ static ssize_t smb_extract_iter_to_rdma(struct iov_iter *iter, size_t len,\n \tint before = rdma->nr_sge;\n \n \tswitch (iov_iter_type(iter)) {\n-\tcase ITER_BVEC:\n-\t\tret = smb_extract_bvec_to_rdma(iter, rdma, len);\n-\t\tbreak;\n-\tcase ITER_KVEC:\n-\t\tret = smb_extract_kvec_to_rdma(iter, rdma, len);\n-\t\tbreak;\n-\tcase ITER_FOLIOQ:\n-\t\tret = smb_extract_folioq_to_rdma(iter, rdma, len);\n-\t\tbreak;\n \tcase ITER_BVECQ:\n \t\tret = smb_extract_bvecq_to_rdma(iter, rdma, len);\n \t\tbreak;\n", "prefixes": [ "19/26" ] }