Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/2216365/?format=api
{ "id": 2216365, "url": "http://patchwork.ozlabs.org/api/patches/2216365/?format=api", "web_url": "http://patchwork.ozlabs.org/project/linux-cifs-client/patch/20260326104544.509518-21-dhowells@redhat.com/", "project": { "id": 12, "url": "http://patchwork.ozlabs.org/api/projects/12/?format=api", "name": "Linux CIFS Client", "link_name": "linux-cifs-client", "list_id": "linux-cifs.vger.kernel.org", "list_email": "linux-cifs@vger.kernel.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20260326104544.509518-21-dhowells@redhat.com>", "list_archive_url": null, "date": "2026-03-26T10:45:35", "name": "[20/26] netfs: Remove netfs_alloc/free_folioq_buffer()", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "298fd66cc3a8009c9fb42bc3d1be58e46707eae4", "submitter": { "id": 59, "url": "http://patchwork.ozlabs.org/api/people/59/?format=api", "name": "David Howells", "email": "dhowells@redhat.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/linux-cifs-client/patch/20260326104544.509518-21-dhowells@redhat.com/mbox/", "series": [ { "id": 497565, "url": "http://patchwork.ozlabs.org/api/series/497565/?format=api", "web_url": "http://patchwork.ozlabs.org/project/linux-cifs-client/list/?series=497565", "date": "2026-03-26T10:45:15", "name": "netfs: Keep track of folios in a segmented bio_vec[] chain", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/497565/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2216365/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2216365/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "\n <linux-cifs+bounces-10543-incoming=patchwork.ozlabs.org@vger.kernel.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "linux-cifs@vger.kernel.org" ], "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=mimecast20190719 header.b=AgVGGIRC;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=2600:3c15:e001:75::12fc:5321; helo=sin.lore.kernel.org;\n envelope-from=linux-cifs+bounces-10543-incoming=patchwork.ozlabs.org@vger.kernel.org;\n receiver=patchwork.ozlabs.org)", "smtp.subspace.kernel.org;\n\tdkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com\n header.b=\"AgVGGIRC\"", "smtp.subspace.kernel.org;\n arc=none smtp.client-ip=170.10.133.124", "smtp.subspace.kernel.org;\n dmarc=pass (p=quarantine dis=none) header.from=redhat.com", "smtp.subspace.kernel.org;\n spf=pass smtp.mailfrom=redhat.com" ], "Received": [ "from sin.lore.kernel.org (sin.lore.kernel.org\n [IPv6:2600:3c15:e001:75::12fc:5321])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fhLfK3c21z1y1G\n\tfor <incoming@patchwork.ozlabs.org>; Thu, 26 Mar 2026 22:10:17 +1100 (AEDT)", "from smtp.subspace.kernel.org (conduit.subspace.kernel.org\n [100.90.174.1])\n\tby sin.lore.kernel.org (Postfix) with ESMTP id 4D4A030F442F\n\tfor <incoming@patchwork.ozlabs.org>; Thu, 26 Mar 2026 10:54:03 +0000 (UTC)", "from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id B76393F661A;\n\tThu, 26 Mar 2026 10:49:09 +0000 (UTC)", "from us-smtp-delivery-124.mimecast.com\n (us-smtp-delivery-124.mimecast.com [170.10.133.124])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby smtp.subspace.kernel.org (Postfix) with ESMTPS id 37EDD3F6610\n\tfor <linux-cifs@vger.kernel.org>; Thu, 26 Mar 2026 10:49:08 +0000 (UTC)", "from mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com\n (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by\n relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3,\n cipher=TLS_AES_256_GCM_SHA384) id us-mta-310-0-W5qP_vNJW-BBJ5KPgU-Q-1; Thu,\n 26 Mar 2026 06:49:04 -0400", "from mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com\n (mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.17])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n\t(No client certificate requested)\n\tby mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS\n id 466FE195609E;\n\tThu, 26 Mar 2026 10:49:01 +0000 (UTC)", "from warthog.procyon.org.com (unknown [10.44.33.121])\n\tby mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP\n id E0E991955D84;\n\tThu, 26 Mar 2026 10:48:54 +0000 (UTC)" ], "ARC-Seal": "i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;\n\tt=1774522149; cv=none;\n b=YY9Pbp+Juwz2F2vAdlVtLbI0h7dw7dpuReStTJlGXJXoQwxGwg7qULFYFtqXvRsrsqiTkBgg+hxweu0VG9pgXKAwj6aNkeDpytu9xeJfr9e6QNAjzXAXU5Ejes8LYlsPhcdldPwTBhBIn+oDAiLVABxlXH8H0QPPrclH2mDNz64=", "ARC-Message-Signature": "i=1; a=rsa-sha256; d=subspace.kernel.org;\n\ts=arc-20240116; t=1774522149; c=relaxed/simple;\n\tbh=H3CavFbU8S5da8e2fjCDeHpXbehFxeTwgISDgTn9O2M=;\n\th=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References:\n\t MIME-Version;\n b=XfVhRsQp9dU8SJ0K9ZByDqHXuPCZ39cBhEnat7vgTpo+7Hkd6qbiXj2RyWPXKBSnld9MJj8sIJvQCVgo//omYaK3DgXSFzFeetEd5/6VUg7I9XycfPuIQvPJLg5xOpRBk7gUi8pqVPHtUxvmV+k3A3/E//cmGKYgej/cC5N8EwM=", "ARC-Authentication-Results": "i=1; smtp.subspace.kernel.org;\n dmarc=pass (p=quarantine dis=none) header.from=redhat.com;\n spf=pass smtp.mailfrom=redhat.com;\n dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com\n header.b=AgVGGIRC; arc=none smtp.client-ip=170.10.133.124", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n\ts=mimecast20190719; t=1774522147;\n\th=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n\t to:to:cc:cc:mime-version:mime-version:\n\t content-transfer-encoding:content-transfer-encoding:\n\t in-reply-to:in-reply-to:references:references;\n\tbh=k0QgTm96/panRDmu2v4v3cUuvffY71COarsUF9Amqek=;\n\tb=AgVGGIRCie4XiF+4/sVWKy9kkc+JJjQdaA/MZIGjgFpQLghSetDRpITPeRSU2dm1fIaqp/\n\tXflMLIvL7k9H68Uo4SBzxCc9ILorNTjHZ3tWxF5rcO4bYJvF1u05oFHb4i1cjAf+iddWiD\n\t8oX+7bwS2YDQ02a25w1BnuWAwY0R8Ms=", "X-MC-Unique": "0-W5qP_vNJW-BBJ5KPgU-Q-1", "X-Mimecast-MFC-AGG-ID": "0-W5qP_vNJW-BBJ5KPgU-Q_1774522141", "From": "David Howells <dhowells@redhat.com>", "To": "Christian Brauner <christian@brauner.io>,\n\tMatthew Wilcox <willy@infradead.org>,\n\tChristoph Hellwig <hch@infradead.org>", "Cc": "David Howells <dhowells@redhat.com>,\n\tPaulo Alcantara <pc@manguebit.com>,\n\tJens Axboe <axboe@kernel.dk>,\n\tLeon Romanovsky <leon@kernel.org>,\n\tSteve French <sfrench@samba.org>,\n\tChenXiaoSong <chenxiaosong@chenxiaosong.com>,\n\tMarc Dionne <marc.dionne@auristor.com>,\n\tEric Van Hensbergen <ericvh@kernel.org>,\n\tDominique Martinet <asmadeus@codewreck.org>,\n\tIlya Dryomov <idryomov@gmail.com>,\n\tTrond Myklebust <trondmy@kernel.org>,\n\tnetfs@lists.linux.dev,\n\tlinux-afs@lists.infradead.org,\n\tlinux-cifs@vger.kernel.org,\n\tlinux-nfs@vger.kernel.org,\n\tceph-devel@vger.kernel.org,\n\tv9fs@lists.linux.dev,\n\tlinux-erofs@lists.ozlabs.org,\n\tlinux-fsdevel@vger.kernel.org,\n\tlinux-kernel@vger.kernel.org,\n\tPaulo Alcantara <pc@manguebit.org>", "Subject": "[PATCH 20/26] netfs: Remove netfs_alloc/free_folioq_buffer()", "Date": "Thu, 26 Mar 2026 10:45:35 +0000", "Message-ID": "<20260326104544.509518-21-dhowells@redhat.com>", "In-Reply-To": "<20260326104544.509518-1-dhowells@redhat.com>", "References": "<20260326104544.509518-1-dhowells@redhat.com>", "Precedence": "bulk", "X-Mailing-List": "linux-cifs@vger.kernel.org", "List-Id": "<linux-cifs.vger.kernel.org>", "List-Subscribe": "<mailto:linux-cifs+subscribe@vger.kernel.org>", "List-Unsubscribe": "<mailto:linux-cifs+unsubscribe@vger.kernel.org>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-Scanned-By": "MIMEDefang 3.0 on 10.30.177.17" }, "content": "Remove netfs_alloc/free_folioq_buffer() as these have been replaced with\nnetfs_alloc/free_bvecq_buffer().\n\nSigned-off-by: David Howells <dhowells@redhat.com>\ncc: Paulo Alcantara <pc@manguebit.org>\ncc: Matthew Wilcox <willy@infradead.org>\ncc: Christoph Hellwig <hch@infradead.org>\ncc: Steve French <sfrench@samba.org>\ncc: linux-cifs@vger.kernel.org\ncc: netfs@lists.linux.dev\ncc: linux-fsdevel@vger.kernel.org\n---\n fs/afs/dir_edit.c | 1 -\n fs/netfs/misc.c | 98 ---------------------------------------\n fs/smb/client/smb2ops.c | 1 -\n fs/smb/client/smbdirect.c | 1 -\n include/linux/netfs.h | 6 ---\n 5 files changed, 107 deletions(-)", "diff": "diff --git a/fs/afs/dir_edit.c b/fs/afs/dir_edit.c\nindex 59d3decf7692..d6a9bb4e2039 100644\n--- a/fs/afs/dir_edit.c\n+++ b/fs/afs/dir_edit.c\n@@ -10,7 +10,6 @@\n #include <linux/namei.h>\n #include <linux/pagemap.h>\n #include <linux/iversion.h>\n-#include <linux/folio_queue.h>\n #include \"internal.h\"\n #include \"xdr_fs.h\"\n \ndiff --git a/fs/netfs/misc.c b/fs/netfs/misc.c\nindex ab142cbaad35..a19724389147 100644\n--- a/fs/netfs/misc.c\n+++ b/fs/netfs/misc.c\n@@ -8,104 +8,6 @@\n #include <linux/swap.h>\n #include \"internal.h\"\n \n-#if 0\n-/**\n- * netfs_alloc_folioq_buffer - Allocate buffer space into a folio queue\n- * @mapping: Address space to set on the folio (or NULL).\n- * @_buffer: Pointer to the folio queue to add to (may point to a NULL; updated).\n- * @_cur_size: Current size of the buffer (updated).\n- * @size: Target size of the buffer.\n- * @gfp: The allocation constraints.\n- */\n-int netfs_alloc_folioq_buffer(struct address_space *mapping,\n-\t\t\t struct folio_queue **_buffer,\n-\t\t\t size_t *_cur_size, ssize_t size, gfp_t gfp)\n-{\n-\tstruct folio_queue *tail = *_buffer, *p;\n-\n-\tsize = round_up(size, PAGE_SIZE);\n-\tif (*_cur_size >= size)\n-\t\treturn 0;\n-\n-\tif (tail)\n-\t\twhile (tail->next)\n-\t\t\ttail = tail->next;\n-\n-\tdo {\n-\t\tstruct folio *folio;\n-\t\tint order = 0, slot;\n-\n-\t\tif (!tail || folioq_full(tail)) {\n-\t\t\tp = netfs_folioq_alloc(0, GFP_NOFS, netfs_trace_folioq_alloc_buffer);\n-\t\t\tif (!p)\n-\t\t\t\treturn -ENOMEM;\n-\t\t\tif (tail) {\n-\t\t\t\ttail->next = p;\n-\t\t\t\tp->prev = tail;\n-\t\t\t} else {\n-\t\t\t\t*_buffer = p;\n-\t\t\t}\n-\t\t\ttail = p;\n-\t\t}\n-\n-\t\tif (size - *_cur_size > PAGE_SIZE)\n-\t\t\torder = umin(ilog2(size - *_cur_size) - PAGE_SHIFT,\n-\t\t\t\t MAX_PAGECACHE_ORDER);\n-\n-\t\tfolio = folio_alloc(gfp, order);\n-\t\tif (!folio && order > 0)\n-\t\t\tfolio = folio_alloc(gfp, 0);\n-\t\tif (!folio)\n-\t\t\treturn -ENOMEM;\n-\n-\t\tfolio->mapping = mapping;\n-\t\tfolio->index = *_cur_size / PAGE_SIZE;\n-\t\ttrace_netfs_folio(folio, netfs_folio_trace_alloc_buffer);\n-\t\tslot = folioq_append_mark(tail, folio);\n-\t\t*_cur_size += folioq_folio_size(tail, slot);\n-\t} while (*_cur_size < size);\n-\n-\treturn 0;\n-}\n-EXPORT_SYMBOL(netfs_alloc_folioq_buffer);\n-\n-/**\n- * netfs_free_folioq_buffer - Free a folio queue.\n- * @fq: The start of the folio queue to free\n- *\n- * Free up a chain of folio_queues and, if marked, the marked folios they point\n- * to.\n- */\n-void netfs_free_folioq_buffer(struct folio_queue *fq)\n-{\n-\tstruct folio_queue *next;\n-\tstruct folio_batch fbatch;\n-\n-\tfolio_batch_init(&fbatch);\n-\n-\tfor (; fq; fq = next) {\n-\t\tfor (int slot = 0; slot < folioq_count(fq); slot++) {\n-\t\t\tstruct folio *folio = folioq_folio(fq, slot);\n-\n-\t\t\tif (!folio ||\n-\t\t\t !folioq_is_marked(fq, slot))\n-\t\t\t\tcontinue;\n-\n-\t\t\ttrace_netfs_folio(folio, netfs_folio_trace_put);\n-\t\t\tif (folio_batch_add(&fbatch, folio))\n-\t\t\t\tfolio_batch_release(&fbatch);\n-\t\t}\n-\n-\t\tnetfs_stat_d(&netfs_n_folioq);\n-\t\tnext = fq->next;\n-\t\tkfree(fq);\n-\t}\n-\n-\tfolio_batch_release(&fbatch);\n-}\n-EXPORT_SYMBOL(netfs_free_folioq_buffer);\n-#endif\n-\n /**\n * netfs_dirty_folio - Mark folio dirty and pin a cache object for writeback\n * @mapping: The mapping the folio belongs to.\ndiff --git a/fs/smb/client/smb2ops.c b/fs/smb/client/smb2ops.c\nindex 173acca17af7..0d19c8fc4c3d 100644\n--- a/fs/smb/client/smb2ops.c\n+++ b/fs/smb/client/smb2ops.c\n@@ -13,7 +13,6 @@\n #include <linux/sort.h>\n #include <crypto/aead.h>\n #include <linux/fiemap.h>\n-#include <linux/folio_queue.h>\n #include <uapi/linux/magic.h>\n #include \"cifsfs.h\"\n #include \"cifsglob.h\"\ndiff --git a/fs/smb/client/smbdirect.c b/fs/smb/client/smbdirect.c\nindex d9e026d5e9f9..252e7757d21c 100644\n--- a/fs/smb/client/smbdirect.c\n+++ b/fs/smb/client/smbdirect.c\n@@ -6,7 +6,6 @@\n */\n #include <linux/module.h>\n #include <linux/highmem.h>\n-#include <linux/folio_queue.h>\n #define __SMBDIRECT_SOCKET_DISCONNECT(__sc) smbd_disconnect_rdma_connection(__sc)\n #include \"../common/smbdirect/smbdirect_pdu.h\"\n #include \"smbdirect.h\"\ndiff --git a/include/linux/netfs.h b/include/linux/netfs.h\nindex 3345c88bbd8e..9d8576a62868 100644\n--- a/include/linux/netfs.h\n+++ b/include/linux/netfs.h\n@@ -463,12 +463,6 @@ void netfs_end_io_write(struct inode *inode);\n int netfs_start_io_direct(struct inode *inode);\n void netfs_end_io_direct(struct inode *inode);\n \n-/* Buffer wrangling helpers API. */\n-int netfs_alloc_folioq_buffer(struct address_space *mapping,\n-\t\t\t struct folio_queue **_buffer,\n-\t\t\t size_t *_cur_size, ssize_t size, gfp_t gfp);\n-void netfs_free_folioq_buffer(struct folio_queue *fq);\n-\n /**\n * netfs_inode - Get the netfs inode context from the inode\n * @inode: The inode to query\n", "prefixes": [ "20/26" ] }