Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/2216290/?format=api
{ "id": 2216290, "url": "http://patchwork.ozlabs.org/api/patches/2216290/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20260326091948.194529-4-silvan@quobyte.com/", "project": { "id": 14, "url": "http://patchwork.ozlabs.org/api/projects/14/?format=api", "name": "QEMU Development", "link_name": "qemu-devel", "list_id": "qemu-devel.nongnu.org", "list_email": "qemu-devel@nongnu.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20260326091948.194529-4-silvan@quobyte.com>", "list_archive_url": null, "date": "2026-03-26T09:19:48", "name": "[3/3] tests/qemu-iotests: Add test 315 for locking=posix", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "38a1cde3f99e80b0cca45f4e96adfae175024634", "submitter": { "id": 92975, "url": "http://patchwork.ozlabs.org/api/people/92975/?format=api", "name": "Silvan Kaiser", "email": "silvan@quobyte.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20260326091948.194529-4-silvan@quobyte.com/mbox/", "series": [ { "id": 497558, "url": "http://patchwork.ozlabs.org/api/series/497558/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/list/?series=497558", "date": "2026-03-26T09:19:45", "name": "block: Add 'posix' option for file locking", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/497558/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2216290/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2216290/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=quobyte.com header.i=@quobyte.com header.a=rsa-sha256\n header.s=google header.b=2ocIbG3p;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)" ], "Received": [ "from lists.gnu.org (lists.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fhJDn70GGz1yGL\n\tfor <incoming@patchwork.ozlabs.org>; Thu, 26 Mar 2026 20:21:29 +1100 (AEDT)", "from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from <qemu-devel-bounces@nongnu.org>)\n\tid 1w5gtp-0000ps-DG; Thu, 26 Mar 2026 05:21:09 -0400", "from eggs.gnu.org ([2001:470:142:3::10])\n by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <silvan@quobyte.com>)\n id 1w5gtl-0000nx-S9\n for qemu-devel@nongnu.org; Thu, 26 Mar 2026 05:21:05 -0400", "from mail-wm1-x32d.google.com ([2a00:1450:4864:20::32d])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)\n (Exim 4.90_1) (envelope-from <silvan@quobyte.com>)\n id 1w5gtk-0000Ks-2P\n for qemu-devel@nongnu.org; Thu, 26 Mar 2026 05:21:05 -0400", "by mail-wm1-x32d.google.com with SMTP id\n 5b1f17b1804b1-486fd5360d4so9422615e9.1\n for <qemu-devel@nongnu.org>; Thu, 26 Mar 2026 02:21:03 -0700 (PDT)", "from kaisers.corp.quobyte.com ([24.134.167.61])\n by smtp.gmail.com with ESMTPSA id\n 5b1f17b1804b1-48722c9506dsm16474295e9.7.2026.03.26.02.21.01\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Thu, 26 Mar 2026 02:21:01 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=quobyte.com; s=google; t=1774516862; x=1775121662; darn=nongnu.org;\n h=mime-version:references:in-reply-to:message-id:date:subject:cc:to\n :from:from:to:cc:subject:date:message-id:reply-to;\n bh=HieXZL5piOqwNT+BgcNMrHvOisMf+bvhJjQFWY3kJhA=;\n b=2ocIbG3p9DB5wPk+GbbTmwRJUPNdYzafGEfDiN4oxmmv8qwiwueRhcX0gBKa2cSKOJ\n rigQD9J8YW4JZcYB5wi+4TYnib5K2TjgBlv2MLRr5p266Q9MODqHLbjgszqEbXVIZIX+\n VGwZywzN9icAxc0SqVhvEBsycKr2gxyIoAZOA=", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1774516862; x=1775121662;\n h=mime-version:references:in-reply-to:message-id:date:subject:cc:to\n :from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id\n :reply-to;\n bh=HieXZL5piOqwNT+BgcNMrHvOisMf+bvhJjQFWY3kJhA=;\n b=k/1q7mXh3HotCFv/ovHqBAZ8pt+l6bKiP7GNzQFm5Y0gvuksjrZY1PBUlKC91tH0px\n mVT4eSOxcJnoALJiaUklVtnP7UBZvH0TBfnJcdKJ0ctikl9xEW7/5QBX9xFUs8NQIgTW\n JnAC1jr81jG3EqKBY7wJVyl007c2bw3Zp26i59JIu9FuBEf9N/S5yZdkcDW0vyfBpeKR\n I3A81uLVGJuBQcFeiCQiFk5obsQuSFjQN1WeMCWtZqkgYnH7e+UiKkFMn5BMLcvRumkt\n tNeHm11CCTvnNj3ZZxVWJ+KR6BdkPrVPmwDWGIltfs6FOmUY9LAmXhR+GTEcb6NUXvdH\n jVYw==", "X-Gm-Message-State": "AOJu0Yyivw8zyhll+Lm/rOiKFXgqwHbT5bbkM9qZMSgN7c6QedMQUwWM\n xHulSbQKALwmTe9CMpzEiCumVvLuWTdKz6Hcks5SgazXabWcnXl89Qykc4mZoC6YtdQbuEf5UHN\n Q89YL+DxuZO1hl+MIeZnoBKw77BGhSf+/GRebv55HCT+2FGVdTOb3pK5IFriSGh6EpMQt", "X-Gm-Gg": "ATEYQzwYxuimMy83M59kpq3jUTp1MaMJoNxoHK2Gt/tv0EWOZPJv29EHpbMjsorTqWH\n qog0WgTt9S2fKToqyesrooCCYZxZSKvCoszjddDJQtfUvqnF3G6RID1vpAUqYrQp/C1JfTlWkQy\n W1yEN6VQj6wOzgKA3AF4HwKr0hOw1q/aDqbbm5FZa5oojzaPR5XW7mSiPOdiZbCTaPnqviVoqTu\n G5nKXfpkpUfWNTCztC8NpvswGnjfVzUXsVFzX8q4zivaFBR8JCQr1R6mK0DxxasNCC/2yFY7xXm\n h9k5l7TCbwzitJuctMxt1LI01t64ZMOJfDsZISLnpcdRy5EAqlpEDIuJbuc//OzzVGrd21d/q6Q\n Iit5cmPNmQMq5tv3H5aQT8GxkN+ZjaFG/nTVv4q8uYcpfH5F2X+zPkzvJWQpmjw8RuBP4sZNrE8\n Rui65fbaXTwk+AhIXgdTGN8WLnYc3vWSn2Qr/X1nke4XqIgELhgpJkLC+BZPPwk4gCEeekYcqHt\n h/9xsFOx3m+dFHTuEZ+ei5NjbUZ0fMzYAQwtBMLi40tZ/XMfkrmxw5zuds=", "X-Received": "by 2002:a05:600c:3484:b0:485:5ba3:37d8 with SMTP id\n 5b1f17b1804b1-48715fd4649mr92903385e9.5.1774516862308;\n Thu, 26 Mar 2026 02:21:02 -0700 (PDT)", "From": "Silvan Kaiser <silvan@quobyte.com>", "To": "qemu-devel@nongnu.org", "Cc": "qemu-block@nongnu.org, kwolf@redhat.com, hreitz@redhat.com,\n pierrick.bouvier@linaro.org, eblake@redhat.com, armbru@redhat.com,\n Silvan Kaiser <silvan@quobyte.com>", "Subject": "[PATCH 3/3] tests/qemu-iotests: Add test 315 for locking=posix", "Date": "Thu, 26 Mar 2026 10:19:48 +0100", "Message-ID": "<20260326091948.194529-4-silvan@quobyte.com>", "X-Mailer": "git-send-email 2.47.3", "In-Reply-To": "<20260326091948.194529-1-silvan@quobyte.com>", "References": "<20260326091948.194529-1-silvan@quobyte.com>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"US-ASCII\"", "Received-SPF": "pass client-ip=2a00:1450:4864:20::32d;\n envelope-from=silvan@quobyte.com; helo=mail-wm1-x32d.google.com", "X-Spam_score_int": "-20", "X-Spam_score": "-2.1", "X-Spam_bar": "--", "X-Spam_report": "(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=ham autolearn_force=no", "X-Spam_action": "no action", "X-BeenThere": "qemu-devel@nongnu.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "qemu development <qemu-devel.nongnu.org>", "List-Unsubscribe": "<https://lists.nongnu.org/mailman/options/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>", "List-Archive": "<https://lists.nongnu.org/archive/html/qemu-devel>", "List-Post": "<mailto:qemu-devel@nongnu.org>", "List-Help": "<mailto:qemu-devel-request@nongnu.org?subject=help>", "List-Subscribe": "<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=subscribe>", "Errors-To": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org", "Sender": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org" }, "content": "Signed-off-by: Silvan Kaiser <silvan@quobyte.com>\n---\n tests/qemu-iotests/315 | 88 ++++++++++++++++++++++++++++++++++++++\n tests/qemu-iotests/315.out | 7 +++\n 2 files changed, 95 insertions(+)\n create mode 100755 tests/qemu-iotests/315\n create mode 100644 tests/qemu-iotests/315.out", "diff": "diff --git a/tests/qemu-iotests/315 b/tests/qemu-iotests/315\nnew file mode 100755\nindex 0000000000..9ccc4b0439\n--- /dev/null\n+++ b/tests/qemu-iotests/315\n@@ -0,0 +1,88 @@\n+#!/usr/bin/env bash\n+# group: rw quick\n+#\n+# Test image locking with locking=posix\n+#\n+# Unlike 'locking=on', which prefers OFD locks and falls back to POSIX\n+# with a warning, 'locking=posix' explicitly forces the use of POSIX\n+# locks without any warning. This test verifies that:\n+# - locking=posix does not emit a fallback warning\n+# - locking=posix actually applies POSIX locks on the image\n+#\n+# The lock check uses qemu-storage-daemon opening the image via the\n+# 'file' protocol driver directly (no format layer on top), because\n+# POSIX locks are per-process and are silently released when any fd to\n+# the same inode is closed -- which happens during qcow2 initialisation\n+# inside a full QEMU instance.\n+#\n+# Copyright 2026 Quobyte Inc\n+# SPDX-License-Identifier: GPL-2.0-or-later\n+\n+# creator\n+owner=silvan@quobyte.com\n+\n+seq=\"$(basename $0)\"\n+echo \"QA output created by $seq\"\n+\n+tmp=/tmp/$$\n+status=1\t# failure is the default!\n+\n+_cleanup()\n+{\n+ _cleanup_test_img\n+ if [ -f \"$TEST_DIR/qsd.pid\" ]; then\n+ kill -SIGTERM \"$(cat \"$TEST_DIR/qsd.pid\")\" 2>/dev/null\n+ rm -f \"$TEST_DIR/qsd.pid\"\n+ fi\n+ rm -f \"$SOCK_DIR/qsd-315.sock\"\n+}\n+trap \"_cleanup; exit \\$status\" 0 1 2 3 15\n+\n+# get standard environment, filters and checks\n+. ./common.rc\n+. ./common.filter\n+\n+_supported_fmt qcow2\n+_supported_proto file\n+_supported_os Linux\n+\n+size=32M\n+\n+_make_test_img $size\n+\n+# locking=posix is an explicit choice, not a fallback, so the\n+# \"falling back to POSIX file locks\" warning must never appear,\n+# regardless of whether OFD locking is available on this host.\n+echo \"Checking that locking=posix does not warn about OFD fallback\"\n+if $QEMU_IMG info --image-opts \\\n+ \"driver=file,locking=posix,filename=$TEST_IMG\" 2>&1 |\n+ grep -q 'falling back'; then\n+ _fail \"FAIL: unexpected fallback warning with locking=posix\"\n+fi\n+echo \"OK: no fallback warning\"\n+\n+# Use qemu-storage-daemon with driver=file (no format layer) to hold the\n+# image open with locking=posix, then verify POSIX locks appear in\n+# /proc/locks. A format layer (e.g. qcow2) would trigger internal fd\n+# reopen operations that silently release POSIX locks, so we bypass it.\n+echo \"Checking that locking=posix applies POSIX locks on the image\"\n+$QSD \\\n+ --blockdev \"driver=file,node-name=file0,filename=$TEST_IMG,locking=posix\" \\\n+ --nbd-server \"addr.type=unix,addr.path=$SOCK_DIR/qsd-315.sock\" \\\n+ --export \"type=nbd,id=exp0,node-name=file0,writable=on\" \\\n+ --daemonize --pidfile \"$TEST_DIR/qsd.pid\"\n+\n+INODE=$(stat -c %i \"$TEST_IMG\")\n+if grep -q \"POSIX.*:${INODE} \" /proc/locks; then\n+ echo \"OK: POSIX locks present on image\"\n+else\n+ _fail \"FAIL: no POSIX locks found on image\"\n+fi\n+\n+kill -SIGTERM \"$(cat \"$TEST_DIR/qsd.pid\")\"\n+rm -f \"$TEST_DIR/qsd.pid\" \"$SOCK_DIR/qsd-315.sock\"\n+\n+# success, all done\n+echo \"*** done\"\n+rm -f $seq.full\n+status=0\ndiff --git a/tests/qemu-iotests/315.out b/tests/qemu-iotests/315.out\nnew file mode 100644\nindex 0000000000..e90082fc64\n--- /dev/null\n+++ b/tests/qemu-iotests/315.out\n@@ -0,0 +1,7 @@\n+QA output created by 315\n+Formatting 'TEST_DIR/t.IMGFMT', fmt=IMGFMT size=33554432\n+Checking that locking=posix does not warn about OFD fallback\n+OK: no fallback warning\n+Checking that locking=posix applies POSIX locks on the image\n+OK: POSIX locks present on image\n+*** done\n", "prefixes": [ "3/3" ] }