Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/2216258/?format=api
{ "id": 2216258, "url": "http://patchwork.ozlabs.org/api/patches/2216258/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20260326082350.17374-2-its@irrelevant.dk/", "project": { "id": 14, "url": "http://patchwork.ozlabs.org/api/projects/14/?format=api", "name": "QEMU Development", "link_name": "qemu-devel", "list_id": "qemu-devel.nongnu.org", "list_email": "qemu-devel@nongnu.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20260326082350.17374-2-its@irrelevant.dk>", "list_archive_url": null, "date": "2026-03-26T08:23:48", "name": "[PULL,1/2] hw/nvme: re-enable wzds bit in namespace dlfeat", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "6bf8190d217e5f97c9ac6614ac9ce1154292f40c", "submitter": { "id": 77636, "url": "http://patchwork.ozlabs.org/api/people/77636/?format=api", "name": "Klaus Jensen", "email": "its@irrelevant.dk" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20260326082350.17374-2-its@irrelevant.dk/mbox/", "series": [ { "id": 497549, "url": "http://patchwork.ozlabs.org/api/series/497549/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/list/?series=497549", "date": "2026-03-26T08:23:47", "name": "[PULL,1/2] hw/nvme: re-enable wzds bit in namespace dlfeat", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/497549/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2216258/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2216258/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=irrelevant.dk header.i=@irrelevant.dk\n header.a=rsa-sha256 header.s=fm3 header.b=iirc5U0H;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=messagingengine.com header.i=@messagingengine.com\n header.a=rsa-sha256 header.s=fm1 header.b=BU3Ej55G;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)" ], "Received": [ "from lists.gnu.org (lists.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fhH0h4V2Cz1y1G\n\tfor <incoming@patchwork.ozlabs.org>; Thu, 26 Mar 2026 19:25:56 +1100 (AEDT)", "from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from <qemu-devel-bounces@nongnu.org>)\n\tid 1w5g1K-00036P-BS; Thu, 26 Mar 2026 04:24:50 -0400", "from eggs.gnu.org ([2001:470:142:3::10])\n by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <its@irrelevant.dk>)\n id 1w5g1H-000352-0y; Thu, 26 Mar 2026 04:24:47 -0400", "from fhigh-b7-smtp.messagingengine.com ([202.12.124.158])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <its@irrelevant.dk>)\n id 1w5g1D-0006lA-G5; Thu, 26 Mar 2026 04:24:46 -0400", "from phl-compute-04.internal (phl-compute-04.internal [10.202.2.44])\n by mailfhigh.stl.internal (Postfix) with ESMTP id DFED07A0287;\n Thu, 26 Mar 2026 04:24:40 -0400 (EDT)", "from phl-frontend-03 ([10.202.2.162])\n by phl-compute-04.internal (MEProxy); Thu, 26 Mar 2026 04:24:41 -0400", "by mail.messagingengine.com (Postfix) with ESMTPA; Thu,\n 26 Mar 2026 04:24:38 -0400 (EDT)" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/relaxed; d=irrelevant.dk;\n h=cc:cc:content-transfer-encoding:content-type:date:date:from\n :from:in-reply-to:in-reply-to:message-id:mime-version:references\n :reply-to:subject:subject:to:to; s=fm3; t=1774513480; x=\n 1774599880; bh=gQH1ApkEVGpG7hoRi0wrrA6c5eVpDnsCS8lGdKrEb8s=; b=i\n irc5U0H6IRyYgOITuzRJmPTwpZUkasUCpQQuLkIuWcU/jX/YVoOmoRwWzedQLz35\n cq8jZwtoOBa9G/hU/vc+9ax1CPj9QBZqI8Orfra7KSIopysYTueOpSbGUe2A9qRV\n 6jWGTHDBRBl23hrBzzALz+QRbzolhXbPplqOy24SJWXvbB6u2p3q62IvgZNN/RL7\n ZHRdqKDbeMkkft+He+okZBwhDvwKqvfwwP1NCqnv1c9xnT/HbvU4NbZgWHqI9DBs\n vjazRrdbDt1OD10HC5XzOBpl6wiQ29MSVlU7bfETwaxxK4VbXNlm1yhahx/RQaEL\n Nripe63sM4vMRD44jNm6Q==", "v=1; a=rsa-sha256; c=relaxed/relaxed; d=\n messagingengine.com; h=cc:cc:content-transfer-encoding\n :content-type:date:date:feedback-id:feedback-id:from:from\n :in-reply-to:in-reply-to:message-id:mime-version:references\n :reply-to:subject:subject:to:to:x-me-proxy:x-me-sender\n :x-me-sender:x-sasl-enc; s=fm1; t=1774513480; x=1774599880; bh=g\n QH1ApkEVGpG7hoRi0wrrA6c5eVpDnsCS8lGdKrEb8s=; b=BU3Ej55G7b9E2Hwhv\n aH/6gHkXubFJWz3jRj/hy8hpezIcITnR0M80tAF5JPWJk+Jc5NjyCq6x/dBFBxLK\n xWJzLlHJe8UB2fHIfxLpW0/2rDtGPGVCSkc8+Gm+F0KZIRnCiXm/fxV8PTGn7gRW\n eIuXj2allczJ7jQ32SVM1OX21VK54EgYjxsBaZj7SuRaI6FQbBBKZsDMYnMR5Vml\n MEMJ5NReJDh9bta8ZGrEcjnCDMg9hUSF+6a3xCScQ3qNgngLgxGB8Z1eUDG72r70\n XihxxpTOee7usCn3CQW4iV7ppSAdVpYxASvgNARrwddjhHYWzb8PjbkWSlHCy3bb\n 2o8hg==" ], "X-ME-Sender": "<xms:R-3EaWR_AVucZBa6CAOTr1pPMKzrmCXw_p-dtzwCq4rac98Eyat9Kg>\n <xme:R-3EaV11lJKTDNxkmkLlAArgGRKkpa1M1Y76JZAY6PGmLet_WmA60mqiU1LmqKzSB\n rghV58_Fh9CaXknSHwJ-bRIV9cDDk-c8DMg_mVONFJtfG8ZBTtvWxs>", "X-ME-Received": "\n <xmr:R-3EaTviPRajmFTq3o0JDWMqVGVKb-R-x6bklLA03C5a5Q80tVMqJ3vw7ePsH0HqVenYJ48gi3qPl-BMZOdJzsSS_HCE_r6i2ODAvdKKlKYdDb2rHVgJ95VSJA>", "X-ME-Proxy-Cause": "\n gggruggvucftvghtrhhoucdtuddrgeefgedrtddtgdefvdeikeekucetufdoteggodetrf\n dotffvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfurfetoffkrfgpnffqhgenuceu\n rghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmnecujf\n gurhephffvvefufffkofgjfhgggfestdekredtredttdenucfhrhhomhepmfhlrghushcu\n lfgvnhhsvghnuceoihhtshesihhrrhgvlhgvvhgrnhhtrdgukheqnecuggftrfgrthhtvg\n hrnhepheefkefgjeejjeejuddtieeggeetfeevkedufeehveejkeeiueffueelieehueeg\n necuffhomhgrihhnpehkvghrnhgvlhdrohhrghenucevlhhushhtvghrufhiiigvpedtne\n curfgrrhgrmhepmhgrihhlfhhrohhmpehithhssehirhhrvghlvghvrghnthdrughkpdhn\n sggprhgtphhtthhopeekpdhmohguvgepshhmthhpohhuthdprhgtphhtthhopehqvghmuh\n dquggvvhgvlhesnhhonhhgnhhurdhorhhgpdhrtghpthhtohepphgvthgvrhdrmhgrhigu\n vghllheslhhinhgrrhhordhorhhgpdhrtghpthhtohepphdrrhgrghhhrghvsehsrghmsh\n hunhhgrdgtohhmpdhrtghpthhtohepkhdrjhgvnhhsvghnsehsrghmshhunhhgrdgtohhm\n pdhrtghpthhtohepkhgsuhhstghhsehkvghrnhgvlhdrohhrghdprhgtphhtthhopehith\n hssehirhhrvghlvghvrghnthdrughkpdhrtghpthhtohepfhhoshhsseguvghfmhgrtghr\n ohdrihhtpdhrtghpthhtohepqhgvmhhuqdgslhhotghksehnohhnghhnuhdrohhrgh", "X-ME-Proxy": "<xmx:R-3EaThQZ1jq2gHQPnuOc1MC1kW_2yi3XKv7BF0SdVt7wtiSBrPTFw>\n <xmx:R-3Eac81PI3vwYs2GFYHRJwaq2JIVZVJi-hDFZpC01vucSt3f1kKpg>\n <xmx:R-3EaesAuMwvEyxJ80wfcQlUglsQAkDWuoCWW9dyp96LDH1VoKtgGA>\n <xmx:R-3EaYoUDkaAINoDQmHmx-bGTW6Bim5qKCWempjo1V3S4HrLu7naqA>\n <xmx:SO3EabYuVkgaaFcPy0xDM_OSFSy1uuin0tf4_-yPJrLcZqwqdsZ_v3EL>", "Feedback-ID": "idc91472f:Fastmail", "From": "Klaus Jensen <its@irrelevant.dk>", "To": "qemu-devel@nongnu.org", "Cc": "Peter Maydell <peter.maydell@linaro.org>,\n Pankaj Raghav <p.raghav@samsung.com>, Klaus Jensen <k.jensen@samsung.com>,\n Keith Busch <kbusch@kernel.org>, Klaus Jensen <its@irrelevant.dk>,\n Jesper Devantier <foss@defmacro.it>, qemu-block@nongnu.org", "Subject": "[PULL 1/2] hw/nvme: re-enable wzds bit in namespace dlfeat", "Date": "Thu, 26 Mar 2026 09:23:48 +0100", "Message-ID": "<20260326082350.17374-2-its@irrelevant.dk>", "X-Mailer": "git-send-email 2.53.0", "In-Reply-To": "<20260326082350.17374-1-its@irrelevant.dk>", "References": "<20260326082350.17374-1-its@irrelevant.dk>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Received-SPF": "pass client-ip=202.12.124.158; envelope-from=its@irrelevant.dk;\n helo=fhigh-b7-smtp.messagingengine.com", "X-Spam_score_int": "-27", "X-Spam_score": "-2.8", "X-Spam_bar": "--", "X-Spam_report": "(-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001,\n RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_PASS=-0.001,\n SPF_PASS=-0.001 autolearn=ham autolearn_force=no", "X-Spam_action": "no action", "X-BeenThere": "qemu-devel@nongnu.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "qemu development <qemu-devel.nongnu.org>", "List-Unsubscribe": "<https://lists.nongnu.org/mailman/options/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>", "List-Archive": "<https://lists.nongnu.org/archive/html/qemu-devel>", "List-Post": "<mailto:qemu-devel@nongnu.org>", "List-Help": "<mailto:qemu-devel-request@nongnu.org?subject=help>", "List-Subscribe": "<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=subscribe>", "Errors-To": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org", "Sender": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org" }, "content": "From: Pankaj Raghav <p.raghav@samsung.com>\n\ndlfeat was changed from 0x9 to 0x1 when PI support was added.\nIt was removed because we can't rely on unmap and have to physically\nclear it to get the checksums right but that doesnt mean that we do not\nsupport the bit.\n\nThe spec says that if wzds is enabled, then the controller supports\ndeallocate (DEAC) on write zeroes. But DEAC bit in write zeroes command\nis only a hint, the controller might choose to physically write zeroes in\nthose areas.\n\nAs we are sending write zeroes command with BDRV_REQ_MAY_UNMAP to the\nunderlying block device anyway (if the unmap operation is supported),\nchange the dlfeat value back to 0x9.\n\nA new flag FALLOC_FL_WRITE_ZEROES has been introduced in linux for\nfallocate which will use the wzds bit in dlfeat to quickly zeroout extents\nusing unmap operation whenever possible[1].\n\n[1] https://lore.kernel.org/linux-fsdevel/20250619111806.3546162-1-yi.zhang@huaweicloud.com/\n\nFixes: 146f720c55 (\"hw/block/nvme: end-to-end data protection\")\nSuggested-by: Klaus Jensen <k.jensen@samsung.com>\nSigned-off-by: Pankaj Raghav <p.raghav@samsung.com>\nSigned-off-by: Klaus Jensen <k.jensen@samsung.com>\n---\n hw/nvme/ns.c | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)", "diff": "diff --git a/hw/nvme/ns.c b/hw/nvme/ns.c\nindex 38f86a17268f..b0106eaa5c8f 100644\n--- a/hw/nvme/ns.c\n+++ b/hw/nvme/ns.c\n@@ -75,7 +75,7 @@ static int nvme_ns_init(NvmeNamespace *ns, Error **errp)\n ns->csi = NVME_CSI_NVM;\n ns->status = 0x0;\n \n- ns->id_ns.dlfeat = 0x1;\n+ ns->id_ns.dlfeat = 0x9;\n \n /* support DULBE and I/O optimization fields */\n id_ns->nsfeat |= (NVME_ID_NS_NSFEAT_DAE | NVME_ID_NS_NSFEAT_OPTPERF_ALL);\n", "prefixes": [ "PULL", "1/2" ] }