Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/2216255/?format=api
{ "id": 2216255, "url": "http://patchwork.ozlabs.org/api/patches/2216255/?format=api", "web_url": "http://patchwork.ozlabs.org/project/glibc/patch/20260326082350.2470966-1-lucas.chollet@free.fr/", "project": { "id": 41, "url": "http://patchwork.ozlabs.org/api/projects/41/?format=api", "name": "GNU C Library", "link_name": "glibc", "list_id": "libc-alpha.sourceware.org", "list_email": "libc-alpha@sourceware.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20260326082350.2470966-1-lucas.chollet@free.fr>", "list_archive_url": null, "date": "2026-03-26T08:23:48", "name": "[v2] posix: Handle negative fds in spawn's addfchdir", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "d2aeecbefd07c7bd04358022679d60ca2b80ca86", "submitter": { "id": 86596, "url": "http://patchwork.ozlabs.org/api/people/86596/?format=api", "name": "Lucas Chollet", "email": "lucas.chollet@free.fr" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/glibc/patch/20260326082350.2470966-1-lucas.chollet@free.fr/mbox/", "series": [ { "id": 497548, "url": "http://patchwork.ozlabs.org/api/series/497548/?format=api", "web_url": "http://patchwork.ozlabs.org/project/glibc/list/?series=497548", "date": "2026-03-26T08:23:48", "name": "[v2] posix: Handle negative fds in spawn's addfchdir", "version": 2, "mbox": "http://patchwork.ozlabs.org/series/497548/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2216255/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2216255/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<libc-alpha-bounces~incoming=patchwork.ozlabs.org@sourceware.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "libc-alpha@sourceware.org" ], "Delivered-To": [ "patchwork-incoming@legolas.ozlabs.org", "libc-alpha@sourceware.org" ], "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=free.fr header.i=@free.fr header.a=rsa-sha256\n header.s=smtp-20201208 header.b=V6RqnP1z;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=sourceware.org\n (client-ip=2620:52:6:3111::32; helo=vm01.sourceware.org;\n envelope-from=libc-alpha-bounces~incoming=patchwork.ozlabs.org@sourceware.org;\n receiver=patchwork.ozlabs.org)", "sourceware.org;\n\tdkim=pass (2048-bit key,\n unprotected) header.d=free.fr header.i=@free.fr header.a=rsa-sha256\n header.s=smtp-20201208 header.b=V6RqnP1z", "sourceware.org;\n dmarc=pass (p=quarantine dis=none) header.from=free.fr", "sourceware.org; spf=pass smtp.mailfrom=free.fr", "server2.sourceware.org;\n arc=none smtp.remote-ip=2a01:e0c:1:1599::12" ], "Received": [ "from vm01.sourceware.org (vm01.sourceware.org\n [IPv6:2620:52:6:3111::32])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fhGzZ34zRz1y1x\n\tfor <incoming@patchwork.ozlabs.org>; Thu, 26 Mar 2026 19:24:57 +1100 (AEDT)", "from vm01.sourceware.org (localhost [127.0.0.1])\n\tby sourceware.org (Postfix) with ESMTP id 725BF4BA2E1E\n\tfor <incoming@patchwork.ozlabs.org>; Thu, 26 Mar 2026 08:24:53 +0000 (GMT)", "from smtp3-g21.free.fr (smtp3-g21.free.fr\n [IPv6:2a01:e0c:1:1599::12])\n by sourceware.org (Postfix) with ESMTPS id BF7E64BA2E12\n for <libc-alpha@sourceware.org>; Thu, 26 Mar 2026 08:24:30 +0000 (GMT)", "from itxub.fritz.box (unknown [84.254.90.136])\n (Authenticated sender: lucas.chollet@free.fr)\n by smtp3-g21.free.fr (Postfix) with ESMTPSA id 7466813F8A2;\n Thu, 26 Mar 2026 09:24:27 +0100 (CET)" ], "DKIM-Filter": [ "OpenDKIM Filter v2.11.0 sourceware.org 725BF4BA2E1E", "OpenDKIM Filter v2.11.0 sourceware.org BF7E64BA2E12" ], "DMARC-Filter": "OpenDMARC Filter v1.4.2 sourceware.org BF7E64BA2E12", "ARC-Filter": "OpenARC Filter v1.0.0 sourceware.org BF7E64BA2E12", "ARC-Seal": "i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1774513470; cv=none;\n b=NgyC1+nQA+uW9gAn89mEZvVMFX6I16k365NHcKwuUuGYUYkwMK/KGT80UJ5FU3lVcDlIj7TI9i9DxiHrWn4NADZQ+ArA0vIYCc9PIv28nsADBV7754O4l5ETQPcixs0sDXVItrdCTlC6fnfJzt515698L/R0wCrqkSk7VjfLGWg=", "ARC-Message-Signature": "i=1; a=rsa-sha256; d=sourceware.org; s=key;\n t=1774513470; c=relaxed/simple;\n bh=gKhOU+QJI+RACT8f3CZMruFctZAZM1jL/ZAbqv6YdIk=;\n h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version;\n b=J/9weGJaR+jZ2SyAu+uvViJNWbXp6NwzV0GZLkihRwZPddYuBSZypVPYCrCaqLy5ILKi4dEk85Bf+Ab8vLKhUMQoZHDe4t/xoUvLGyZkUuvXM5IiW6ns+beXDVpaUxi20N+lAX7F2FYtNuTtEqBotFyjUv2W37QUATiMovZPN68=", "ARC-Authentication-Results": "i=1; server2.sourceware.org", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=free.fr;\n s=smtp-20201208; t=1774513468;\n bh=gKhOU+QJI+RACT8f3CZMruFctZAZM1jL/ZAbqv6YdIk=;\n h=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n b=V6RqnP1zgKVE1clnc40JWjG757Cqjl4ljOisYUfNtuZJHvJMbuJKujcz0GXPII9YP\n bNP+9qp0NUf5Foyx8SENHZwjrTeX6baJyGxV3XvhJp4OnPQ8L09la7m85eNrlPMjt9\n VkwdSPNqVOWhfVgGEQr0ilsHzzvvWMKWDaUkArrXqq5hHU3TmNX6jOo1SdxABam5sF\n LAZnDFOqPR5+nYHEY3C4q6dCmqP2TfiFQh1/iw/Ty1Wfi4WZaF/a/ypj+eSHPufOpe\n GOmR0/UV2HcoB6doQb7j3VcTYKgmWQw3mZmepc1V27StV+3mV8GPEQrq0vOP6VWEcl\n 4wjozNOv4AmHg==", "From": "Lucas Chollet <lucas.chollet@free.fr>", "To": "libc-alpha@sourceware.org", "Cc": "Lucas Chollet <lucas.chollet@free.fr>", "Subject": "[PATCH v2] posix: Handle negative fds in spawn's addfchdir", "Date": "Thu, 26 Mar 2026 09:23:48 +0100", "Message-ID": "<20260326082350.2470966-1-lucas.chollet@free.fr>", "X-Mailer": "git-send-email 2.51.0", "In-Reply-To": "<20260325140452.1825551-2-lucas.chollet@free.fr>", "References": "<20260325140452.1825551-2-lucas.chollet@free.fr>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libc-alpha@sourceware.org", "X-Mailman-Version": "2.1.30", "Precedence": "list", "List-Id": "Libc-alpha mailing list <libc-alpha.sourceware.org>", "List-Unsubscribe": "<https://sourceware.org/mailman/options/libc-alpha>,\n <mailto:libc-alpha-request@sourceware.org?subject=unsubscribe>", "List-Archive": "<https://sourceware.org/pipermail/libc-alpha/>", "List-Post": "<mailto:libc-alpha@sourceware.org>", "List-Help": "<mailto:libc-alpha-request@sourceware.org?subject=help>", "List-Subscribe": "<https://sourceware.org/mailman/listinfo/libc-alpha>,\n <mailto:libc-alpha-request@sourceware.org?subject=subscribe>", "Errors-To": "libc-alpha-bounces~incoming=patchwork.ozlabs.org@sourceware.org" }, "content": "This patch makes `posix_spawn_file_actions_addfchdir` return EBADF on\nnegative file descriptors. This is mandated by POSIX.\n\nSigned-off-by: Lucas Chollet <lucas.chollet@free.fr>\n---\nv2:\n - I used fd < 0 in place of !__spawn_valid_fd (fd)\n\n posix/spawn_faction_addfchdir.c | 3 +++\n 1 file changed, 3 insertions(+)", "diff": "diff --git a/posix/spawn_faction_addfchdir.c b/posix/spawn_faction_addfchdir.c\nindex a3df6df489..e851af1722 100644\n--- a/posix/spawn_faction_addfchdir.c\n+++ b/posix/spawn_faction_addfchdir.c\n@@ -28,6 +28,9 @@ posix_spawn_file_actions_addfchdir_np (posix_spawn_file_actions_t *actions,\n {\n struct __spawn_action *rec;\n \n+ if (fd < 0)\n+ return EBADF;\n+\n /* Allocate more memory if needed. */\n if (actions->__used == actions->__allocated\n && __posix_spawn_file_actions_realloc (actions) != 0)\n", "prefixes": [ "v2" ] }