Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/2216241/?format=api
{ "id": 2216241, "url": "http://patchwork.ozlabs.org/api/patches/2216241/?format=api", "web_url": "http://patchwork.ozlabs.org/project/linuxppc-dev/patch/20260326080836.695207-6-surenb@google.com/", "project": { "id": 2, "url": "http://patchwork.ozlabs.org/api/projects/2/?format=api", "name": "Linux PPC development", "link_name": "linuxppc-dev", "list_id": "linuxppc-dev.lists.ozlabs.org", "list_email": "linuxppc-dev@lists.ozlabs.org", "web_url": "https://github.com/linuxppc/wiki/wiki", "scm_url": "https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git", "webscm_url": "https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git/", "list_archive_url": "https://lore.kernel.org/linuxppc-dev/", "list_archive_url_format": "https://lore.kernel.org/linuxppc-dev/{}/", "commit_url_format": "https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git/commit/?id={}" }, "msgid": "<20260326080836.695207-6-surenb@google.com>", "list_archive_url": "https://lore.kernel.org/linuxppc-dev/20260326080836.695207-6-surenb@google.com/", "date": "2026-03-26T08:08:35", "name": "[v5,5/6] mm: use vma_start_write_killable() in process_vma_walk_lock()", "commit_ref": null, "pull_url": null, "state": "handled-elsewhere", "archived": false, "hash": "fe984af41ad992688f0c01f1337652b6d5d31259", "submitter": { "id": 74729, "url": "http://patchwork.ozlabs.org/api/people/74729/?format=api", "name": "Suren Baghdasaryan", "email": "surenb@google.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/linuxppc-dev/patch/20260326080836.695207-6-surenb@google.com/mbox/", "series": [ { "id": 497545, "url": "http://patchwork.ozlabs.org/api/series/497545/?format=api", "web_url": "http://patchwork.ozlabs.org/project/linuxppc-dev/list/?series=497545", "date": "2026-03-26T08:08:30", "name": "[v5,1/6] mm/vma: cleanup error handling path in vma_expand()", "version": 5, "mbox": "http://patchwork.ozlabs.org/series/497545/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2216241/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2216241/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "\n <linuxppc-dev+bounces-18815-incoming=patchwork.ozlabs.org@lists.ozlabs.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "linuxppc-dev@lists.ozlabs.org" ], "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=google.com header.i=@google.com header.a=rsa-sha256\n header.s=20251104 header.b=weKux7oI;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.ozlabs.org\n (client-ip=112.213.38.117; helo=lists.ozlabs.org;\n envelope-from=linuxppc-dev+bounces-18815-incoming=patchwork.ozlabs.org@lists.ozlabs.org;\n receiver=patchwork.ozlabs.org)", "lists.ozlabs.org;\n arc=none smtp.remote-ip=\"2607:f8b0:4864:20::1349\"", "lists.ozlabs.org;\n dmarc=pass (p=reject dis=none) header.from=google.com", "lists.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=google.com header.i=@google.com header.a=rsa-sha256\n header.s=20251104 header.b=weKux7oI;\n\tdkim-atps=neutral", "lists.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=flex--surenb.bounces.google.com\n (client-ip=2607:f8b0:4864:20::1349; helo=mail-dy1-x1349.google.com;\n envelope-from=3k-neaqykdm4ceby7v08805y.w86527eh99w-xyf52cdc.8j5uvc.8b0@flex--surenb.bounces.google.com;\n receiver=lists.ozlabs.org)" ], "Received": [ "from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fhGdg1hgDz1y1x\n\tfor <incoming@patchwork.ozlabs.org>; Thu, 26 Mar 2026 19:09:27 +1100 (AEDT)", "from boromir.ozlabs.org (localhost [127.0.0.1])\n\tby lists.ozlabs.org (Postfix) with ESMTP id 4fhGd314QQz2yv2;\n\tThu, 26 Mar 2026 19:08:55 +1100 (AEDT)", "from mail-dy1-x1349.google.com (mail-dy1-x1349.google.com\n [IPv6:2607:f8b0:4864:20::1349])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n\t(No client certificate requested)\n\tby lists.ozlabs.org (Postfix) with ESMTPS id 4fhGd22yN3z2yrb\n\tfor <linuxppc-dev@lists.ozlabs.org>; Thu, 26 Mar 2026 19:08:54 +1100 (AEDT)", "by mail-dy1-x1349.google.com with SMTP id\n 5a478bee46e88-2c16233ee11so726346eec.1\n for <linuxppc-dev@lists.ozlabs.org>;\n Thu, 26 Mar 2026 01:08:54 -0700 (PDT)" ], "ARC-Seal": "i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707; t=1774512535;\n\tcv=none;\n b=kvd4++9OlI/vsPPk25kQK+KGSbzkXFrKxEltrdbEc/u+w6Ex4SH+k1TJqR/3fi3fty8wuQ16zJQ/xaUAQakW/YLgJz3a4ELVgOwE3/hjNXVYv5u9u+9B16zaCWnfF8RGw890P+tMMzcX2SFMW7ggxdjfTaKeCvJmsN2vkmajCKlyxxPWRQzau/OmMW2w9Yu43E6RNd9NFsAvpnb7jwfTYFpmSXSH/EV4Az7UbBg220YFukyAyw7JjyQYS83qILZp4MBLDndI3WQ3Rlm/6Mrfh9eMv0b4H7U9V8t6MNz8zY1CgwrJEHGIYpVemWl/UFgNc+HqU6RxZQ1GLTyK++MRjQ==", "ARC-Message-Signature": "i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707;\n\tt=1774512535; c=relaxed/relaxed;\n\tbh=A2FZ0j4JsuEtXH0QE0EGuqUW1/fY5oq45gPlzlHIXGA=;\n\th=Date:In-Reply-To:Mime-Version:References:Message-ID:Subject:From:\n\t To:Cc:Content-Type;\n b=EX02jgiFDn6SNljDdR49jvNgoOvws6GiE/XZ3GFIMMMIoQ4I+fRYV6kFpd8qYOG3sYfrbsUpt7xiLn5jb6kFuhXWT7EB/qEvstgHjxTt3pjzelHMmahRYfXphDdWTS1XkU4NzRT/RLO4WZTZyfHkvwOU5cpsLvTmVANcdpo8CBbkYYouERIncpSCQ+ABVFY1CnM+2fWmMnzKFGoafm4XNDGvBvh/tL1vkqP9XMEdUkUfapNN0c0DEejTbABUOM2VPhaKUAL7jtPBmjRuu1ExaZdZyOf4kxo8YvCv6WllNiTlwJwTw6ecTpId+8rV/WqiFxMJhqKnTXlvn8qBwX/tkQ==", "ARC-Authentication-Results": "i=1; lists.ozlabs.org;\n dmarc=pass (p=reject dis=none) header.from=google.com;\n dkim=pass (2048-bit key;\n unprotected) header.d=google.com header.i=@google.com header.a=rsa-sha256\n header.s=20251104 header.b=weKux7oI; dkim-atps=neutral;\n spf=pass (client-ip=2607:f8b0:4864:20::1349; helo=mail-dy1-x1349.google.com;\n envelope-from=3k-neaqykdm4ceby7v08805y.w86527eh99w-xyf52cdc.8j5uvc.8b0@flex--surenb.bounces.google.com;\n receiver=lists.ozlabs.org) smtp.mailfrom=flex--surenb.bounces.google.com", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=google.com; s=20251104; t=1774512533; x=1775117333;\n darn=lists.ozlabs.org;\n h=cc:to:from:subject:message-id:references:mime-version:in-reply-to\n :date:from:to:cc:subject:date:message-id:reply-to;\n bh=A2FZ0j4JsuEtXH0QE0EGuqUW1/fY5oq45gPlzlHIXGA=;\n b=weKux7oINzBukacM8eJOJkrkMbGtCAFuIwh8OOEwbvGxFMLKK4I2zwGxcQZn0oqXuU\n IuuRYK2uxWyY+B3kX7l578tnq4dJCNoVeU83gAIIxKKbuSZ6Ia4PRljvEk5cj3R2j9E6\n QarqxM294hFf+zioJzEAhPApqAo4oLeV6P2Uh/WbXes2LP6UelZF6YjrcCDdQJs8VhIV\n VgfvKQtHPs9crY1xFGx14Pi7UdxF1/iLX4Fnv3oeVX8tA4snNkR86IZ16lFOjLR2jGOL\n 6s36nBbjU21tO6dUlSm1wutGB7yXjNY9YbeyacM2ux36MGqKa6hm89ofwgj8z9+bEwUB\n aevQ==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1774512533; x=1775117333;\n h=cc:to:from:subject:message-id:references:mime-version:in-reply-to\n :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to;\n bh=A2FZ0j4JsuEtXH0QE0EGuqUW1/fY5oq45gPlzlHIXGA=;\n b=leZarYpSKIUDnxZYcfERz0lH0GXUw+ybKcoei/L/jjqAX8/u5BUl84WXMOqU7tBp2c\n eXIskmOe9ZInbhfGRfu8gcsZ2MpRMURL3w1UufclqVIh56nRgacf3HB7JZf81i/qQ3xc\n 7jpMEnXEWQCgL5NazvOBrkEd8PmlBvfQ3O0eD4Mb6OOqBmVcCTAe22QWUpdAcXHGVBAt\n t6JJJ5brJt5McKh92m3iSoGHEGoc30gYyXy6jICi+gKoOB6HCM8Rf+6LUoauqj+jPzao\n 2XHYV5Y4Xjp+KaPMfRMsTM/mnzhTuYOntvTf6FMJoB+1lIlLL6hskXESZnny4/6O/4x6\n 0few==", "X-Forwarded-Encrypted": "i=1;\n AJvYcCW5N91TkyhyIZPo4XNwVZJfpreb9TfmsIT0yvTUfmoF5xRAHmw+pmZDIqi4DELRyY91qrJRTXu4/j7uYew=@lists.ozlabs.org", "X-Gm-Message-State": "AOJu0YxMZq7fAO2F6v/R7bPZU91ftt+wg41gjZlNO2SidK/depAgodit\n\toDakBdMlgdjskjMAHDvG2s1PQJ8QaSj2DhXt78Dgr+kpvPjX+7dODW1EMSbSmJkXQZ0IGM0X7cO\n\tXeu9C3A==", "X-Received": "from dycrm24.prod.google.com\n ([2002:a05:693c:2a18:b0:2c1:4f1:c859])\n (user=surenb job=prod-delivery.src-stubby-dispatcher) by\n 2002:a05:7300:8b05:b0:2c1:161f:ac39\n with SMTP id 5a478bee46e88-2c15d3e3b8cmr3740873eec.26.1774512531898; Thu, 26\n Mar 2026 01:08:51 -0700 (PDT)", "Date": "Thu, 26 Mar 2026 01:08:35 -0700", "In-Reply-To": "<20260326080836.695207-1-surenb@google.com>", "X-Mailing-List": "linuxppc-dev@lists.ozlabs.org", "List-Id": "<linuxppc-dev.lists.ozlabs.org>", "List-Help": "<mailto:linuxppc-dev+help@lists.ozlabs.org>", "List-Owner": "<mailto:linuxppc-dev+owner@lists.ozlabs.org>", "List-Post": "<mailto:linuxppc-dev@lists.ozlabs.org>", "List-Archive": "<https://lore.kernel.org/linuxppc-dev/>,\n <https://lists.ozlabs.org/pipermail/linuxppc-dev/>", "List-Subscribe": "<mailto:linuxppc-dev+subscribe@lists.ozlabs.org>,\n <mailto:linuxppc-dev+subscribe-digest@lists.ozlabs.org>,\n <mailto:linuxppc-dev+subscribe-nomail@lists.ozlabs.org>", "List-Unsubscribe": "<mailto:linuxppc-dev+unsubscribe@lists.ozlabs.org>", "Precedence": "list", "Mime-Version": "1.0", "References": "<20260326080836.695207-1-surenb@google.com>", "X-Mailer": "git-send-email 2.53.0.1018.g2bb0e51243-goog", "Message-ID": "<20260326080836.695207-6-surenb@google.com>", "Subject": "[PATCH v5 5/6] mm: use vma_start_write_killable() in\n process_vma_walk_lock()", "From": "Suren Baghdasaryan <surenb@google.com>", "To": "akpm@linux-foundation.org", "Cc": "willy@infradead.org, david@kernel.org, ziy@nvidia.com,\n\tmatthew.brost@intel.com, joshua.hahnjy@gmail.com, rakie.kim@sk.com,\n\tbyungchul@sk.com, gourry@gourry.net, ying.huang@linux.alibaba.com,\n\tapopple@nvidia.com, lorenzo.stoakes@oracle.com,\n baolin.wang@linux.alibaba.com,\n\tLiam.Howlett@oracle.com, npache@redhat.com, ryan.roberts@arm.com,\n\tdev.jain@arm.com, baohua@kernel.org, lance.yang@linux.dev, vbabka@suse.cz,\n\tjannh@google.com, rppt@kernel.org, mhocko@suse.com, pfalcato@suse.de,\n\tkees@kernel.org, maddy@linux.ibm.com, npiggin@gmail.com, mpe@ellerman.id.au,\n\tchleroy@kernel.org, borntraeger@linux.ibm.com, frankja@linux.ibm.com,\n\timbrenda@linux.ibm.com, hca@linux.ibm.com, gor@linux.ibm.com,\n\tagordeev@linux.ibm.com, svens@linux.ibm.com, gerald.schaefer@linux.ibm.com,\n\tlinux-mm@kvack.org, linuxppc-dev@lists.ozlabs.org, kvm@vger.kernel.org,\n\tlinux-kernel@vger.kernel.org, linux-s390@vger.kernel.org, surenb@google.com", "Content-Type": "text/plain; charset=\"UTF-8\"", "X-Spam-Status": "No, score=-7.6 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED,\n\tDKIM_VALID,DKIM_VALID_AU,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,\n\tUSER_IN_DEF_DKIM_WL autolearn=disabled version=4.0.1 OzLabs 8", "X-Spam-Checker-Version": "SpamAssassin 4.0.1 (2024-03-25) on lists.ozlabs.org" }, "content": "Replace vma_start_write() with vma_start_write_killable() when\nprocess_vma_walk_lock() is used with PGWALK_WRLOCK option.\nAdjust its direct and indirect users to check for a possible error\nand handle it. Ensure users handle EINTR correctly and do not ignore\nit.\n\nSuggested-by: Matthew Wilcox <willy@infradead.org>\nSigned-off-by: Suren Baghdasaryan <surenb@google.com>\n---\n fs/proc/task_mmu.c | 12 ++++++------\n mm/mempolicy.c | 1 +\n mm/pagewalk.c | 22 +++++++++++++++-------\n 3 files changed, 22 insertions(+), 13 deletions(-)", "diff": "diff --git a/fs/proc/task_mmu.c b/fs/proc/task_mmu.c\nindex e091931d7ca1..33e5094a7842 100644\n--- a/fs/proc/task_mmu.c\n+++ b/fs/proc/task_mmu.c\n@@ -1774,15 +1774,15 @@ static ssize_t clear_refs_write(struct file *file, const char __user *buf,\n \tstruct vm_area_struct *vma;\n \tenum clear_refs_types type;\n \tint itype;\n-\tint rv;\n+\tint err;\n \n \tif (count > sizeof(buffer) - 1)\n \t\tcount = sizeof(buffer) - 1;\n \tif (copy_from_user(buffer, buf, count))\n \t\treturn -EFAULT;\n-\trv = kstrtoint(strstrip(buffer), 10, &itype);\n-\tif (rv < 0)\n-\t\treturn rv;\n+\terr = kstrtoint(strstrip(buffer), 10, &itype);\n+\tif (err)\n+\t\treturn err;\n \ttype = (enum clear_refs_types)itype;\n \tif (type < CLEAR_REFS_ALL || type >= CLEAR_REFS_LAST)\n \t\treturn -EINVAL;\n@@ -1824,7 +1824,7 @@ static ssize_t clear_refs_write(struct file *file, const char __user *buf,\n \t\t\t\t\t\t0, mm, 0, -1UL);\n \t\t\tmmu_notifier_invalidate_range_start(&range);\n \t\t}\n-\t\twalk_page_range(mm, 0, -1, &clear_refs_walk_ops, &cp);\n+\t\terr = walk_page_range(mm, 0, -1, &clear_refs_walk_ops, &cp);\n \t\tif (type == CLEAR_REFS_SOFT_DIRTY) {\n \t\t\tmmu_notifier_invalidate_range_end(&range);\n \t\t\tflush_tlb_mm(mm);\n@@ -1837,7 +1837,7 @@ static ssize_t clear_refs_write(struct file *file, const char __user *buf,\n \t}\n \tput_task_struct(task);\n \n-\treturn count;\n+\treturn err ? : count;\n }\n \n const struct file_operations proc_clear_refs_operations = {\ndiff --git a/mm/mempolicy.c b/mm/mempolicy.c\nindex c38a90487531..336753a4b2b2 100644\n--- a/mm/mempolicy.c\n+++ b/mm/mempolicy.c\n@@ -969,6 +969,7 @@ static const struct mm_walk_ops queue_pages_lock_vma_walk_ops = {\n * (a hugetlbfs page or a transparent huge page being counted as 1).\n * -EIO - a misplaced page found, when MPOL_MF_STRICT specified without MOVEs.\n * -EFAULT - a hole in the memory range, when MPOL_MF_DISCONTIG_OK unspecified.\n+ * -EINTR - walk got terminated due to pending fatal signal.\n */\n static long\n queue_pages_range(struct mm_struct *mm, unsigned long start, unsigned long end,\ndiff --git a/mm/pagewalk.c b/mm/pagewalk.c\nindex 3ae2586ff45b..eca7bc711617 100644\n--- a/mm/pagewalk.c\n+++ b/mm/pagewalk.c\n@@ -443,14 +443,13 @@ static inline void process_mm_walk_lock(struct mm_struct *mm,\n \t\tmmap_assert_write_locked(mm);\n }\n \n-static inline void process_vma_walk_lock(struct vm_area_struct *vma,\n-\t\t\t\t\t enum page_walk_lock walk_lock)\n+static int process_vma_walk_lock(struct vm_area_struct *vma,\n+\t\t\t\t enum page_walk_lock walk_lock)\n {\n #ifdef CONFIG_PER_VMA_LOCK\n \tswitch (walk_lock) {\n \tcase PGWALK_WRLOCK:\n-\t\tvma_start_write(vma);\n-\t\tbreak;\n+\t\treturn vma_start_write_killable(vma);\n \tcase PGWALK_WRLOCK_VERIFY:\n \t\tvma_assert_write_locked(vma);\n \t\tbreak;\n@@ -462,6 +461,7 @@ static inline void process_vma_walk_lock(struct vm_area_struct *vma,\n \t\tbreak;\n \t}\n #endif\n+\treturn 0;\n }\n \n /*\n@@ -505,7 +505,9 @@ int walk_page_range_mm_unsafe(struct mm_struct *mm, unsigned long start,\n \t\t\tif (ops->pte_hole)\n \t\t\t\terr = ops->pte_hole(start, next, -1, &walk);\n \t\t} else { /* inside vma */\n-\t\t\tprocess_vma_walk_lock(vma, ops->walk_lock);\n+\t\t\terr = process_vma_walk_lock(vma, ops->walk_lock);\n+\t\t\tif (err)\n+\t\t\t\tbreak;\n \t\t\twalk.vma = vma;\n \t\t\tnext = min(end, vma->vm_end);\n \t\t\tvma = find_vma(mm, vma->vm_end);\n@@ -722,6 +724,7 @@ int walk_page_range_vma_unsafe(struct vm_area_struct *vma, unsigned long start,\n \t\t.vma\t\t= vma,\n \t\t.private\t= private,\n \t};\n+\tint err;\n \n \tif (start >= end || !walk.mm)\n \t\treturn -EINVAL;\n@@ -729,7 +732,9 @@ int walk_page_range_vma_unsafe(struct vm_area_struct *vma, unsigned long start,\n \t\treturn -EINVAL;\n \n \tprocess_mm_walk_lock(walk.mm, ops->walk_lock);\n-\tprocess_vma_walk_lock(vma, ops->walk_lock);\n+\terr = process_vma_walk_lock(vma, ops->walk_lock);\n+\tif (err)\n+\t\treturn err;\n \treturn __walk_page_range(start, end, &walk);\n }\n \n@@ -752,6 +757,7 @@ int walk_page_vma(struct vm_area_struct *vma, const struct mm_walk_ops *ops,\n \t\t.vma\t\t= vma,\n \t\t.private\t= private,\n \t};\n+\tint err;\n \n \tif (!walk.mm)\n \t\treturn -EINVAL;\n@@ -759,7 +765,9 @@ int walk_page_vma(struct vm_area_struct *vma, const struct mm_walk_ops *ops,\n \t\treturn -EINVAL;\n \n \tprocess_mm_walk_lock(walk.mm, ops->walk_lock);\n-\tprocess_vma_walk_lock(vma, ops->walk_lock);\n+\terr = process_vma_walk_lock(vma, ops->walk_lock);\n+\tif (err)\n+\t\treturn err;\n \treturn __walk_page_range(vma->vm_start, vma->vm_end, &walk);\n }\n \n", "prefixes": [ "v5", "5/6" ] }