Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/2216236/?format=api
{ "id": 2216236, "url": "http://patchwork.ozlabs.org/api/patches/2216236/?format=api", "web_url": "http://patchwork.ozlabs.org/project/linuxppc-dev/patch/20260326080836.695207-2-surenb@google.com/", "project": { "id": 2, "url": "http://patchwork.ozlabs.org/api/projects/2/?format=api", "name": "Linux PPC development", "link_name": "linuxppc-dev", "list_id": "linuxppc-dev.lists.ozlabs.org", "list_email": "linuxppc-dev@lists.ozlabs.org", "web_url": "https://github.com/linuxppc/wiki/wiki", "scm_url": "https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git", "webscm_url": "https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git/", "list_archive_url": "https://lore.kernel.org/linuxppc-dev/", "list_archive_url_format": "https://lore.kernel.org/linuxppc-dev/{}/", "commit_url_format": "https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git/commit/?id={}" }, "msgid": "<20260326080836.695207-2-surenb@google.com>", "list_archive_url": "https://lore.kernel.org/linuxppc-dev/20260326080836.695207-2-surenb@google.com/", "date": "2026-03-26T08:08:31", "name": "[v5,1/6] mm/vma: cleanup error handling path in vma_expand()", "commit_ref": null, "pull_url": null, "state": "handled-elsewhere", "archived": false, "hash": "3e8fa2d1b8a68abbf10c36897afec10625ae6dd7", "submitter": { "id": 74729, "url": "http://patchwork.ozlabs.org/api/people/74729/?format=api", "name": "Suren Baghdasaryan", "email": "surenb@google.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/linuxppc-dev/patch/20260326080836.695207-2-surenb@google.com/mbox/", "series": [ { "id": 497545, "url": "http://patchwork.ozlabs.org/api/series/497545/?format=api", "web_url": "http://patchwork.ozlabs.org/project/linuxppc-dev/list/?series=497545", "date": "2026-03-26T08:08:30", "name": "[v5,1/6] mm/vma: cleanup error handling path in vma_expand()", "version": 5, "mbox": "http://patchwork.ozlabs.org/series/497545/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2216236/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2216236/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "\n <linuxppc-dev+bounces-18810-incoming=patchwork.ozlabs.org@lists.ozlabs.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "linuxppc-dev@lists.ozlabs.org" ], "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=google.com header.i=@google.com header.a=rsa-sha256\n header.s=20251104 header.b=cL8DD0xq;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.ozlabs.org\n (client-ip=112.213.38.117; helo=lists.ozlabs.org;\n envelope-from=linuxppc-dev+bounces-18810-incoming=patchwork.ozlabs.org@lists.ozlabs.org;\n receiver=patchwork.ozlabs.org)", "lists.ozlabs.org;\n arc=none smtp.remote-ip=\"2607:f8b0:4864:20::134a\"", "lists.ozlabs.org;\n dmarc=pass (p=reject dis=none) header.from=google.com", "lists.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=google.com header.i=@google.com header.a=rsa-sha256\n header.s=20251104 header.b=cL8DD0xq;\n\tdkim-atps=neutral", "lists.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=flex--surenb.bounces.google.com\n (client-ip=2607:f8b0:4864:20::134a; helo=mail-dy1-x134a.google.com;\n envelope-from=3i-neaqykdmy463qzns00sxq.o0yxuz6911o-pq7xu454.0bxmn4.03s@flex--surenb.bounces.google.com;\n receiver=lists.ozlabs.org)" ], "Received": [ "from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1 raw public key)\n server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fhGcz0Qtkz1y1x\n\tfor <incoming@patchwork.ozlabs.org>; Thu, 26 Mar 2026 19:08:50 +1100 (AEDT)", "from boromir.ozlabs.org (localhost [127.0.0.1])\n\tby lists.ozlabs.org (Postfix) with ESMTP id 4fhGcw28l9z2yVB;\n\tThu, 26 Mar 2026 19:08:48 +1100 (AEDT)", "from mail-dy1-x134a.google.com (mail-dy1-x134a.google.com\n [IPv6:2607:f8b0:4864:20::134a])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n\t(No client certificate requested)\n\tby lists.ozlabs.org (Postfix) with ESMTPS id 4fhGct1q3Gz2xlM\n\tfor <linuxppc-dev@lists.ozlabs.org>; Thu, 26 Mar 2026 19:08:45 +1100 (AEDT)", "by mail-dy1-x134a.google.com with SMTP id\n 5a478bee46e88-2bdf75bc88fso609693eec.0\n for <linuxppc-dev@lists.ozlabs.org>;\n Thu, 26 Mar 2026 01:08:45 -0700 (PDT)" ], "ARC-Seal": "i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707; t=1774512528;\n\tcv=none;\n b=hQ0GrFRgdIy6luwLCm+O/oqjSHImJugP5UXKkbrWzIO/EISQFPZJtnmutN1JQj337RYfE448EQwO+qHFY7Gk+wvjTZEZBaHGnX3KcBJsOcMY+57z6X94aB4zfB+FiYScQkO4/Y48yVqjJ8NN8kisxKH/ljeuxX4dM36SKgXEzOjB+skDE98M9m+MgMx1zUNmUknjAJ0aYgVDCCgGC7E3oAlkW56RZCMEfNXocXSnx4XM6bORscth9ZZkzZy50lMyLONzTJwrTPO/IbOlCmx64fpRVpUz41WS/KBDK+v9eMIp4zcBIaw9QKBOTBwq83qGZ1SxbKVn8Drege9gIUek/g==", "ARC-Message-Signature": "i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707;\n\tt=1774512528; c=relaxed/relaxed;\n\tbh=wGMSLi6pfWPDruUV3e3+0duVYRVGge54aYv+ZuYilb8=;\n\th=Date:In-Reply-To:Mime-Version:References:Message-ID:Subject:From:\n\t To:Cc:Content-Type;\n b=P8XbcG5Qp9gaaGxqOgezKoxRh9s4dFB9RpxNUl5Jvd9w2/fy8iD8ezVipefHbXCNtTIM7kJOmdFQWISJyxzbdJZXHVArMrEputD62Kv8DKUHqyB0/wlzPyxzvUfeUcd9IHT+p9K/WcXCbXqy3KuRyz38i/mS9tbx/AEK/CwQBPmi85N/iWD5pRVjW1hGvhqfGf6vfPOPUJzqwp14bt6GZ1yGf+4H6uPCtAs7Jvyk42ku/em2aAxbfevDhHpkcHOUZt7FAamPWaT5iN5plicFya5DBjaqHkFrfDU0nL5kAzuKN9Ya6F9m3so31JfgnBiO8bgUcsAolHMOizXtA6w6wQ==", "ARC-Authentication-Results": "i=1; lists.ozlabs.org;\n dmarc=pass (p=reject dis=none) header.from=google.com;\n dkim=pass (2048-bit key;\n unprotected) header.d=google.com header.i=@google.com header.a=rsa-sha256\n header.s=20251104 header.b=cL8DD0xq; dkim-atps=neutral;\n spf=pass (client-ip=2607:f8b0:4864:20::134a; helo=mail-dy1-x134a.google.com;\n envelope-from=3i-neaqykdmy463qzns00sxq.o0yxuz6911o-pq7xu454.0bxmn4.03s@flex--surenb.bounces.google.com;\n receiver=lists.ozlabs.org) smtp.mailfrom=flex--surenb.bounces.google.com", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=google.com; s=20251104; t=1774512524; x=1775117324;\n darn=lists.ozlabs.org;\n h=cc:to:from:subject:message-id:references:mime-version:in-reply-to\n :date:from:to:cc:subject:date:message-id:reply-to;\n bh=wGMSLi6pfWPDruUV3e3+0duVYRVGge54aYv+ZuYilb8=;\n b=cL8DD0xqjczRdEaOmlmDXtLPtnlBVdJO2+Z8hbwFD9Z+ZomCBjV8hvUsHM0fXhzif6\n K8C+Z9hJLg5+3SQXJ+l7IgDLyYWubfbDQnx1wquj/4Go7tsoZiTCT4EI8ZBb3C97M8q7\n 80vYZP7Zg+9dl64eKh4diAhBPBJ6wikhAK3AQfeevHEvunA9MMdKCxxrLuOChejbjDcL\n yb25pWSyEljYQgGqBNQTEysTmvOQ17PyX7r1pmNTPk2PmoB/6GhPwU4NNXz9axUWio07\n i/7nP4OhTew3vlP+9Jd+oPu1P555NfUkOf5su2fi4OdLnwE8DEN5jEXxAB2SqY4dy6Gb\n yuNg==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1774512524; x=1775117324;\n h=cc:to:from:subject:message-id:references:mime-version:in-reply-to\n :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to;\n bh=wGMSLi6pfWPDruUV3e3+0duVYRVGge54aYv+ZuYilb8=;\n b=qWyGCNMk+JvI0BeAkF/SF0hnK0QIm6yz+fhKfhZOiSqDw4AUmG3+dYXhofYl3nYQTe\n UqcTlYGa9Ik2G+Rp53i7EJ5bg28AceAKs0KOAdJUlBo6Pi31IOnB83wrAcuMWoj8WFeF\n IKnB60vInvjbZjnlsuC3+iXBaNThyEMTM/5gve1mljwyVNjVyaGLuGZP/mo3drX2tpaE\n 1E9GBtGnxd71JZ8LgmO6EJV4HcPyuW+z8Ma8Te3thwFOt7xFX5Hr5X9WPuk6VLo2N4VG\n 7FQne7K+IDzhR7lIoa13x25LvgdK0NeC8J2WYOF7iqU0CgEo4lUD9dLvg7L+SRmUDtU2\n VyZg==", "X-Forwarded-Encrypted": "i=1;\n AJvYcCWxrMv7dsTcIp1v5RqmkoHx68F6/nmYXAseTfXfpD8/MFzA5uXcuJ3RmrsnULwihMZO9NO5DlHQ/oHoJPg=@lists.ozlabs.org", "X-Gm-Message-State": "AOJu0YxT+bDV2qnapwphXn4ORFuSEHIKcfKYgr4Zbg44gGXR2zsTa+nP\n\tl0A/NK+0w1z29JYqRPeQMiAqaaj732CqkOTPMMh3qMG182jPvQo0mw2COg/rlyjyy1cJmlgm+PT\n\tWyuyRVw==", "X-Received": "from dykg12.prod.google.com\n ([2002:a05:7300:578c:b0:2c0:da3c:9f74])\n (user=surenb job=prod-delivery.src-stubby-dispatcher) by\n 2002:a05:7300:dc05:b0:2c0:f424:b545\n with SMTP id 5a478bee46e88-2c15d350374mr3760721eec.15.1774512523474; Thu, 26\n Mar 2026 01:08:43 -0700 (PDT)", "Date": "Thu, 26 Mar 2026 01:08:31 -0700", "In-Reply-To": "<20260326080836.695207-1-surenb@google.com>", "X-Mailing-List": "linuxppc-dev@lists.ozlabs.org", "List-Id": "<linuxppc-dev.lists.ozlabs.org>", "List-Help": "<mailto:linuxppc-dev+help@lists.ozlabs.org>", "List-Owner": "<mailto:linuxppc-dev+owner@lists.ozlabs.org>", "List-Post": "<mailto:linuxppc-dev@lists.ozlabs.org>", "List-Archive": "<https://lore.kernel.org/linuxppc-dev/>,\n <https://lists.ozlabs.org/pipermail/linuxppc-dev/>", "List-Subscribe": "<mailto:linuxppc-dev+subscribe@lists.ozlabs.org>,\n <mailto:linuxppc-dev+subscribe-digest@lists.ozlabs.org>,\n <mailto:linuxppc-dev+subscribe-nomail@lists.ozlabs.org>", "List-Unsubscribe": "<mailto:linuxppc-dev+unsubscribe@lists.ozlabs.org>", "Precedence": "list", "Mime-Version": "1.0", "References": "<20260326080836.695207-1-surenb@google.com>", "X-Mailer": "git-send-email 2.53.0.1018.g2bb0e51243-goog", "Message-ID": "<20260326080836.695207-2-surenb@google.com>", "Subject": "[PATCH v5 1/6] mm/vma: cleanup error handling path in vma_expand()", "From": "Suren Baghdasaryan <surenb@google.com>", "To": "akpm@linux-foundation.org", "Cc": "willy@infradead.org, david@kernel.org, ziy@nvidia.com,\n\tmatthew.brost@intel.com, joshua.hahnjy@gmail.com, rakie.kim@sk.com,\n\tbyungchul@sk.com, gourry@gourry.net, ying.huang@linux.alibaba.com,\n\tapopple@nvidia.com, lorenzo.stoakes@oracle.com,\n baolin.wang@linux.alibaba.com,\n\tLiam.Howlett@oracle.com, npache@redhat.com, ryan.roberts@arm.com,\n\tdev.jain@arm.com, baohua@kernel.org, lance.yang@linux.dev, vbabka@suse.cz,\n\tjannh@google.com, rppt@kernel.org, mhocko@suse.com, pfalcato@suse.de,\n\tkees@kernel.org, maddy@linux.ibm.com, npiggin@gmail.com, mpe@ellerman.id.au,\n\tchleroy@kernel.org, borntraeger@linux.ibm.com, frankja@linux.ibm.com,\n\timbrenda@linux.ibm.com, hca@linux.ibm.com, gor@linux.ibm.com,\n\tagordeev@linux.ibm.com, svens@linux.ibm.com, gerald.schaefer@linux.ibm.com,\n\tlinux-mm@kvack.org, linuxppc-dev@lists.ozlabs.org, kvm@vger.kernel.org,\n\tlinux-kernel@vger.kernel.org, linux-s390@vger.kernel.org, surenb@google.com", "Content-Type": "text/plain; charset=\"UTF-8\"", "X-Spam-Status": "No, score=-7.6 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED,\n\tDKIM_VALID,DKIM_VALID_AU,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,\n\tUSER_IN_DEF_DKIM_WL autolearn=disabled version=4.0.1 OzLabs 8", "X-Spam-Checker-Version": "SpamAssassin 4.0.1 (2024-03-25) on lists.ozlabs.org" }, "content": "vma_expand() error handling is a bit confusing with \"if (ret) return ret;\"\nmixed with \"if (!ret && ...) ret = ...;\". Simplify the code to check\nfor errors and return immediately after an operation that might fail.\nThis also makes later changes to this function more readable.\nChange variable name for storing the error code from \"ret\" to \"err\".\n\nNo functional change intended.\n\nSuggested-by: Jann Horn <jannh@google.com>\nSigned-off-by: Suren Baghdasaryan <surenb@google.com>\nReviewed-by: Liam R. Howlett <Liam.Howlett@oracle.com>\nReviewed-by: Lorenzo Stoakes <lorenzo.stoakes@oracle.com>\nReviewed-by: Barry Song <baohua@kernel.org>\n---\n mm/vma.c | 18 +++++++++++-------\n 1 file changed, 11 insertions(+), 7 deletions(-)", "diff": "diff --git a/mm/vma.c b/mm/vma.c\nindex a43f3c5d4b3d..ba78ab1f397a 100644\n--- a/mm/vma.c\n+++ b/mm/vma.c\n@@ -1170,7 +1170,7 @@ int vma_expand(struct vma_merge_struct *vmg)\n \tvma_flags_t sticky_flags =\n \t\tvma_flags_and_mask(&vmg->vma_flags, VMA_STICKY_FLAGS);\n \tvma_flags_t target_sticky;\n-\tint ret = 0;\n+\tint err = 0;\n \n \tmmap_assert_write_locked(vmg->mm);\n \tvma_start_write(target);\n@@ -1200,12 +1200,16 @@ int vma_expand(struct vma_merge_struct *vmg)\n \t * Note that, by convention, callers ignore OOM for this case, so\n \t * we don't need to account for vmg->give_up_on_mm here.\n \t */\n-\tif (remove_next)\n-\t\tret = dup_anon_vma(target, next, &anon_dup);\n-\tif (!ret && vmg->copied_from)\n-\t\tret = dup_anon_vma(target, vmg->copied_from, &anon_dup);\n-\tif (ret)\n-\t\treturn ret;\n+\tif (remove_next) {\n+\t\terr = dup_anon_vma(target, next, &anon_dup);\n+\t\tif (err)\n+\t\t\treturn err;\n+\t}\n+\tif (vmg->copied_from) {\n+\t\terr = dup_anon_vma(target, vmg->copied_from, &anon_dup);\n+\t\tif (err)\n+\t\t\treturn err;\n+\t}\n \n \tif (remove_next) {\n \t\tvma_flags_t next_sticky;\n", "prefixes": [ "v5", "1/6" ] }