Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/2216233/?format=api
{ "id": 2216233, "url": "http://patchwork.ozlabs.org/api/patches/2216233/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20260326074247.188674-3-armbru@redhat.com/", "project": { "id": 14, "url": "http://patchwork.ozlabs.org/api/projects/14/?format=api", "name": "QEMU Development", "link_name": "qemu-devel", "list_id": "qemu-devel.nongnu.org", "list_email": "qemu-devel@nongnu.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20260326074247.188674-3-armbru@redhat.com>", "list_archive_url": null, "date": "2026-03-26T07:42:46", "name": "[2/3] migration: Fix references to parameter names in error messages", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "70253b8ae5aa39182f12456a5888f7ae5ddf8f26", "submitter": { "id": 2645, "url": "http://patchwork.ozlabs.org/api/people/2645/?format=api", "name": "Markus Armbruster", "email": "armbru@redhat.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20260326074247.188674-3-armbru@redhat.com/mbox/", "series": [ { "id": 497542, "url": "http://patchwork.ozlabs.org/api/series/497542/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/list/?series=497542", "date": "2026-03-26T07:42:45", "name": "migration: Fix a few error messages and a bit of help", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/497542/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2216233/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2216233/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=mimecast20190719 header.b=dPoG9WHU;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)" ], "Received": [ "from lists.gnu.org (lists.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fhG4R1NnCz1y1G\n\tfor <incoming@patchwork.ozlabs.org>; Thu, 26 Mar 2026 18:44:07 +1100 (AEDT)", "from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from <qemu-devel-bounces@nongnu.org>)\n\tid 1w5fMp-0001LO-R6; Thu, 26 Mar 2026 03:42:59 -0400", "from eggs.gnu.org ([2001:470:142:3::10])\n by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <armbru@redhat.com>) id 1w5fMo-0001Kd-2O\n for qemu-devel@nongnu.org; Thu, 26 Mar 2026 03:42:58 -0400", "from us-smtp-delivery-124.mimecast.com ([170.10.133.124])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <armbru@redhat.com>) id 1w5fMm-0003OQ-Bd\n for qemu-devel@nongnu.org; Thu, 26 Mar 2026 03:42:57 -0400", "from mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com\n (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by\n relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3,\n cipher=TLS_AES_256_GCM_SHA384) id us-mta-668-sm1l_uuHNbuIS0CupWDpSw-1; Thu,\n 26 Mar 2026 03:42:51 -0400", "from mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com\n (mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.111])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n (No client certificate requested)\n by mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS\n id E90A919560A6; Thu, 26 Mar 2026 07:42:50 +0000 (UTC)", "from blackfin.pond.sub.org (unknown [10.45.242.6])\n by mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with\n ESMTPS\n id 68FE91800351; Thu, 26 Mar 2026 07:42:50 +0000 (UTC)", "by blackfin.pond.sub.org (Postfix, from userid 1000)\n id E052121E66C9; Thu, 26 Mar 2026 08:42:47 +0100 (CET)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n s=mimecast20190719; t=1774510975;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:cc:mime-version:mime-version:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=YJJl4g+pm93/aFX9CDaHwTcxxJ7X1MbqgcUNI7Fijsg=;\n b=dPoG9WHU+/AcfPh1QPZ8NLFgwpJqY3Eai1szDSXs9EPeOArUlwcI7wYhl8TSdQ1ki87XUe\n uBBAvKaur5xX89vUeMYqO1BgZPgu54Js6q3tXv/RRyuWn3ymU8YNTKC9paCyYLULqTb3TB\n 3m7sRMejhStjEbh8PmZYvoWZ9a78q+U=", "X-MC-Unique": "sm1l_uuHNbuIS0CupWDpSw-1", "X-Mimecast-MFC-AGG-ID": "sm1l_uuHNbuIS0CupWDpSw_1774510971", "From": "Markus Armbruster <armbru@redhat.com>", "To": "qemu-devel@nongnu.org", "Cc": "peterx@redhat.com,\n\tfarosas@suse.de", "Subject": "[PATCH 2/3] migration: Fix references to parameter names in error\n messages", "Date": "Thu, 26 Mar 2026 08:42:46 +0100", "Message-ID": "<20260326074247.188674-3-armbru@redhat.com>", "In-Reply-To": "<20260326074247.188674-1-armbru@redhat.com>", "References": "<20260326074247.188674-1-armbru@redhat.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-Scanned-By": "MIMEDefang 3.4.1 on 10.30.177.111", "Received-SPF": "pass client-ip=170.10.133.124; envelope-from=armbru@redhat.com;\n helo=us-smtp-delivery-124.mimecast.com", "X-Spam_score_int": "12", "X-Spam_score": "1.2", "X-Spam_bar": "+", "X-Spam_report": "(1.2 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001,\n DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001,\n RCVD_IN_SBL_CSS=3.335, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001,\n RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_PASS=-0.001,\n SPF_PASS=-0.001 autolearn=no autolearn_force=no", "X-Spam_action": "no action", "X-BeenThere": "qemu-devel@nongnu.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "qemu development <qemu-devel.nongnu.org>", "List-Unsubscribe": "<https://lists.nongnu.org/mailman/options/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>", "List-Archive": "<https://lists.nongnu.org/archive/html/qemu-devel>", "List-Post": "<mailto:qemu-devel@nongnu.org>", "List-Help": "<mailto:qemu-devel-request@nongnu.org?subject=help>", "List-Subscribe": "<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=subscribe>", "Errors-To": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org", "Sender": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org" }, "content": "Migration parameter names separate words with hyphens. A number of\nerror messages in migrate_params_check() use underscores instead.\nWrong since day one. Fix them.\n\nSigned-off-by: Markus Armbruster <armbru@redhat.com>\n---\n migration/options.c | 36 ++++++++++++++++++------------------\n 1 file changed, 18 insertions(+), 18 deletions(-)", "diff": "diff --git a/migration/options.c b/migration/options.c\nindex 3eb5b39186..7556fbc06b 100644\n--- a/migration/options.c\n+++ b/migration/options.c\n@@ -1133,103 +1133,103 @@ bool migrate_params_check(MigrationParameters *params, Error **errp)\n \n if (params->throttle_trigger_threshold < 1 ||\n params->throttle_trigger_threshold > 100) {\n- error_setg(errp, \"Option throttle_trigger_threshold expects \"\n+ error_setg(errp, \"Option throttle-trigger-threshold expects \"\n \"an integer in the range of 1 to 100\");\n return false;\n }\n \n if (params->cpu_throttle_initial < 1 ||\n params->cpu_throttle_initial > 99) {\n- error_setg(errp, \"Option cpu_throttle_initial expects \"\n+ error_setg(errp, \"Option cpu-throttle-initial expects \"\n \"an integer in the range of 1 to 99\");\n return false;\n }\n \n if (params->cpu_throttle_increment < 1 ||\n params->cpu_throttle_increment > 99) {\n- error_setg(errp, \"Option cpu_throttle_increment expects \"\n+ error_setg(errp, \"Option cpu-throttle-increment expects \"\n \"an integer in the range of 1 to 99\");\n return false;\n }\n \n if (params->max_bandwidth > SIZE_MAX) {\n- error_setg(errp, \"Option max_bandwidth expects \"\n+ error_setg(errp, \"Option max-bandwidth expects \"\n \"an integer in the range of 0 to \"stringify(SIZE_MAX)\n \" bytes/second\");\n return false;\n }\n \n if (params->avail_switchover_bandwidth > SIZE_MAX) {\n- error_setg(errp, \"Option avail_switchover_bandwidth expects \"\n+ error_setg(errp, \"Option avail-switchover-bandwidth expects \"\n \"an integer in the range of 0 to \"stringify(SIZE_MAX)\n \" bytes/second\");\n return false;\n }\n \n if (params->downtime_limit > MAX_MIGRATE_DOWNTIME) {\n- error_setg(errp, \"Option downtime_limit expects \"\n+ error_setg(errp, \"Option downtime-limit expects \"\n \"an integer in the range of 0 to \"\n stringify(MAX_MIGRATE_DOWNTIME)\" ms\");\n return false;\n }\n \n if (params->multifd_channels < 1) {\n- error_setg(errp, \"Option multifd_channels expects \"\n+ error_setg(errp, \"Option multifd-channels expects \"\n \"a value between 1 and 255\");\n return false;\n }\n \n if (params->multifd_zlib_level > 9) {\n- error_setg(errp, \"Option multifd_zlib_level expects \"\n+ error_setg(errp, \"Option multifd-zlib-level expects \"\n \"a value between 0 and 9\");\n return false;\n }\n \n if (params->multifd_qatzip_level > 9 ||\n params->multifd_qatzip_level < 1) {\n- error_setg(errp, \"Option multifd_qatzip_level expects \"\n+ error_setg(errp, \"Option multifd-qatzip-level expects \"\n \"a value between 1 and 9\");\n return false;\n }\n \n if (params->multifd_zstd_level > 20) {\n- error_setg(errp, \"Option multifd_zstd_level expects \"\n+ error_setg(errp, \"Option multifd-zstd-level expects \"\n \"a value between 0 and 20\");\n return false;\n }\n \n if (params->xbzrle_cache_size < qemu_target_page_size() ||\n !is_power_of_2(params->xbzrle_cache_size)) {\n- error_setg(errp, \"Option xbzrle_cache_size expects \"\n+ error_setg(errp, \"Option xbzrle-cache-size expects \"\n \"a power of two no less than the target page size\");\n return false;\n }\n \n if (params->max_cpu_throttle < params->cpu_throttle_initial ||\n params->max_cpu_throttle > 99) {\n- error_setg(errp, \"Option max_cpu_throttle expects \"\n- \"an integer in the range of cpu_throttle_initial to 99\");\n+ error_setg(errp, \"Option max-cpu-throttle expects \"\n+ \"an integer in the range of cpu-throttle-initial to 99\");\n return false;\n }\n \n if (params->announce_initial > 100000) {\n- error_setg(errp, \"Option announce_initial expects \"\n+ error_setg(errp, \"Option announce-initial expects \"\n \"a value between 0 and 100000\");\n return false;\n }\n if (params->announce_max > 100000) {\n- error_setg(errp, \"Option announce_max expects \"\n+ error_setg(errp, \"Option announce-max expects \"\n \"a value between 0 and 100000\");\n return false;\n }\n if (params->announce_rounds > 1000) {\n- error_setg(errp, \"Option announce_rounds expects \"\n+ error_setg(errp, \"Option announce-rounds expects \"\n \"a value between 0 and 1000\");\n return false;\n }\n if (params->announce_step < 1 ||\n params->announce_step > 10000) {\n- error_setg(errp, \"Option announce_step expects \"\n+ error_setg(errp, \"Option announce-step expects \"\n \"a value between 0 and 10000\");\n return false;\n }\n@@ -1264,7 +1264,7 @@ bool migrate_params_check(MigrationParameters *params, Error **errp)\n \n if (params->vcpu_dirty_limit < 1) {\n error_setg(errp,\n- \"Parameter 'vcpu_dirty_limit' must be greater than 1 MB/s\");\n+ \"Parameter 'vcpu-dirty-limit' must be greater than 1 MB/s\");\n return false;\n }\n \n", "prefixes": [ "2/3" ] }