Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/2216228/?format=api
{ "id": 2216228, "url": "http://patchwork.ozlabs.org/api/patches/2216228/?format=api", "web_url": "http://patchwork.ozlabs.org/project/gcc/patch/20260326065506.D65664A0A3@imap1.dmz-prg2.suse.org/", "project": { "id": 17, "url": "http://patchwork.ozlabs.org/api/projects/17/?format=api", "name": "GNU Compiler Collection", "link_name": "gcc", "list_id": "gcc-patches.gcc.gnu.org", "list_email": "gcc-patches@gcc.gnu.org", "web_url": null, "scm_url": null, "webscm_url": null, "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20260326065506.D65664A0A3@imap1.dmz-prg2.suse.org>", "list_archive_url": null, "date": "2026-03-26T06:54:51", "name": "middle-end/120839 - use unaligned incoming stack argument copy more", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "325e2a0242153d375c7f788a0582b68ae4af811d", "submitter": { "id": 4338, "url": "http://patchwork.ozlabs.org/api/people/4338/?format=api", "name": "Richard Biener", "email": "rguenther@suse.de" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/gcc/patch/20260326065506.D65664A0A3@imap1.dmz-prg2.suse.org/mbox/", "series": [ { "id": 497540, "url": "http://patchwork.ozlabs.org/api/series/497540/?format=api", "web_url": "http://patchwork.ozlabs.org/project/gcc/list/?series=497540", "date": "2026-03-26T06:54:51", "name": "middle-end/120839 - use unaligned incoming stack argument copy more", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/497540/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2216228/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2216228/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<gcc-patches-bounces~incoming=patchwork.ozlabs.org@gcc.gnu.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "gcc-patches@gcc.gnu.org" ], "Delivered-To": [ "patchwork-incoming@legolas.ozlabs.org", "gcc-patches@gcc.gnu.org" ], "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256\n header.s=susede2_rsa header.b=HPQHr/vg;\n\tdkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256\n header.s=susede2_ed25519 header.b=BUMGu3MZ;\n\tdkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de\n header.a=rsa-sha256 header.s=susede2_rsa header.b=HPQHr/vg;\n\tdkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256\n header.s=susede2_ed25519 header.b=BUMGu3MZ;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=gcc.gnu.org\n (client-ip=2620:52:6:3111::32; helo=vm01.sourceware.org;\n envelope-from=gcc-patches-bounces~incoming=patchwork.ozlabs.org@gcc.gnu.org;\n receiver=patchwork.ozlabs.org)", "sourceware.org;\n\tdkim=pass (1024-bit key,\n unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256\n header.s=susede2_rsa header.b=HPQHr/vg;\n\tdkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256\n header.s=susede2_ed25519 header.b=BUMGu3MZ;\n\tdkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de\n header.a=rsa-sha256 header.s=susede2_rsa header.b=HPQHr/vg;\n\tdkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256\n header.s=susede2_ed25519 header.b=BUMGu3MZ", "sourceware.org;\n dmarc=pass (p=none dis=none) header.from=suse.de", "sourceware.org; spf=pass smtp.mailfrom=suse.de", "server2.sourceware.org;\n arc=none smtp.remote-ip=195.135.223.131", "smtp-out2.suse.de;\n\tnone" ], "Received": [ "from vm01.sourceware.org (vm01.sourceware.org\n [IPv6:2620:52:6:3111::32])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fhF0Y3cRgz1y1G\n\tfor <incoming@patchwork.ozlabs.org>; Thu, 26 Mar 2026 17:55:41 +1100 (AEDT)", "from vm01.sourceware.org (localhost [127.0.0.1])\n\tby sourceware.org (Postfix) with ESMTP id 4C8454BA2E13\n\tfor <incoming@patchwork.ozlabs.org>; Thu, 26 Mar 2026 06:55:39 +0000 (GMT)", "from smtp-out2.suse.de (smtp-out2.suse.de [195.135.223.131])\n by sourceware.org (Postfix) with ESMTPS id 29E904BA2E13\n for <gcc-patches@gcc.gnu.org>; Thu, 26 Mar 2026 06:55:08 +0000 (GMT)", "from imap1.dmz-prg2.suse.org (unknown [10.150.64.97])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest\n SHA256)\n (No client certificate requested)\n by smtp-out2.suse.de (Postfix) with ESMTPS id 0E3CD5BD09;\n Thu, 26 Mar 2026 06:55:07 +0000 (UTC)", "from imap1.dmz-prg2.suse.org (localhost [127.0.0.1])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest\n SHA256)\n (No client certificate requested)\n by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id D65664A0A3;\n Thu, 26 Mar 2026 06:55:06 +0000 (UTC)", "from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167])\n by imap1.dmz-prg2.suse.org with ESMTPSA id BsvCMkrYxGnmGwAAD6G6ig\n (envelope-from <rguenther@suse.de>); Thu, 26 Mar 2026 06:55:06 +0000" ], "DKIM-Filter": [ "OpenDKIM Filter v2.11.0 sourceware.org 4C8454BA2E13", "OpenDKIM Filter v2.11.0 sourceware.org 29E904BA2E13" ], "DMARC-Filter": "OpenDMARC Filter v1.4.2 sourceware.org 29E904BA2E13", "ARC-Filter": "OpenARC Filter v1.0.0 sourceware.org 29E904BA2E13", "ARC-Seal": "i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1774508109; cv=none;\n b=Mg4qbTJa+9ffCYkLcttj+PTLLOAqfgBA4g7N0ixQ7thgRTshSURtxa9nxD+irRabj8PiIAFCPqJozerJq95eQMTKxkKu0iqyOSAbW5KRR5GKA5r+IkkdMm7IIFuEcCi9YPVAf/X59Rx0ceAxzXVLI9QZKMe1tXmrNWmCHTcE7DY=", "ARC-Message-Signature": "i=1; a=rsa-sha256; d=sourceware.org; s=key;\n t=1774508109; c=relaxed/simple;\n bh=uy/MImfUcQA76crnVhSJnEV7jFIR1/rrKNyufptWaoA=;\n h=DKIM-Signature:DKIM-Signature:DKIM-Signature:DKIM-Signature:Date:\n From:To:Subject:MIME-Version:Message-Id;\n b=Lt3j5PgnwVGTKiFHiFmYK6RiX6zHxiiXvzKWkaB88gpJSWZL9bH9vgtdJLeNZOt0Gd5kCA/YajFrY8XcUUNfrcTvziitrirxh37vYxVH03aGcn2oTgI8bA96reY9PLvXwGvM7+vJK+WlmODRINJeCSiRry4KWCNURlLGccX0+bk=", "ARC-Authentication-Results": "i=1; server2.sourceware.org", "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de;\n s=susede2_rsa;\n t=1774508107;\n h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:\n mime-version:mime-version:content-type:content-type;\n bh=H/qdEAdh40ANo5UzAM57L2bJ2+Nmo1QGlYCWcuPrQTg=;\n b=HPQHr/vg8asZjwUqoFJ/Xq++j3/XLskejWdDwAW51bf2Sjtpv5Z8TMU25bCiIBNw4icj0q\n R5jj7+0T075clHDXTddzFzYae2cnIw2v+AtMDnFfkEiyhkwocfN5pQ+JACwOpe5ARq24tm\n Akb01AJB1e1ngT4L8r+f/m7vng5VDl4=", "v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de;\n s=susede2_ed25519; t=1774508107;\n h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:\n mime-version:mime-version:content-type:content-type;\n bh=H/qdEAdh40ANo5UzAM57L2bJ2+Nmo1QGlYCWcuPrQTg=;\n b=BUMGu3MZ0r16O+VPapomZFmEX+hFVuvjFlQEt+VjZn6jr6yEHlZ10VbM+n4hHkH2dPwQxa\n aGk7vgKsVTopkUDw==", "v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de;\n s=susede2_rsa;\n t=1774508107;\n h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:\n mime-version:mime-version:content-type:content-type;\n bh=H/qdEAdh40ANo5UzAM57L2bJ2+Nmo1QGlYCWcuPrQTg=;\n b=HPQHr/vg8asZjwUqoFJ/Xq++j3/XLskejWdDwAW51bf2Sjtpv5Z8TMU25bCiIBNw4icj0q\n R5jj7+0T075clHDXTddzFzYae2cnIw2v+AtMDnFfkEiyhkwocfN5pQ+JACwOpe5ARq24tm\n Akb01AJB1e1ngT4L8r+f/m7vng5VDl4=", "v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de;\n s=susede2_ed25519; t=1774508107;\n h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:\n mime-version:mime-version:content-type:content-type;\n bh=H/qdEAdh40ANo5UzAM57L2bJ2+Nmo1QGlYCWcuPrQTg=;\n b=BUMGu3MZ0r16O+VPapomZFmEX+hFVuvjFlQEt+VjZn6jr6yEHlZ10VbM+n4hHkH2dPwQxa\n aGk7vgKsVTopkUDw==" ], "Date": "Thu, 26 Mar 2026 07:54:51 +0100 (CET)", "From": "Richard Biener <rguenther@suse.de>", "To": "gcc-patches@gcc.gnu.org", "cc": "amodra@gmail.com, rth@gcc.gnu.org, rdsandiford@googlemail.com", "Subject": "[PATCH] middle-end/120839 - use unaligned incoming stack argument\n copy more", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=US-ASCII", "Message-Id": "<20260326065506.D65664A0A3@imap1.dmz-prg2.suse.org>", "X-Spamd-Result": "default: False [-4.30 / 50.00]; BAYES_HAM(-3.00)[100.00%];\n NEURAL_HAM_LONG(-1.00)[-1.000];\n NEURAL_HAM_SHORT(-0.20)[-1.000]; MIME_GOOD(-0.10)[text/plain];\n FREEMAIL_CC(0.00)[gmail.com,gcc.gnu.org,googlemail.com];\n RCVD_TLS_ALL(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[];\n FUZZY_RATELIMITED(0.00)[rspamd.com];\n DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519];\n ARC_NA(0.00)[]; RCPT_COUNT_THREE(0.00)[4];\n FREEMAIL_ENVRCPT(0.00)[gmail.com,googlemail.com];\n MISSING_XM_UA(0.00)[]; FROM_EQ_ENVFROM(0.00)[];\n FROM_HAS_DN(0.00)[]; MIME_TRACE(0.00)[0:+];\n RCVD_COUNT_TWO(0.00)[2]; RCVD_VIA_SMTP_AUTH(0.00)[];\n TO_DN_NONE(0.00)[];\n DBL_BLOCKED_OPENRESOLVER(0.00)[imap1.dmz-prg2.suse.org:helo,\n imap1.dmz-prg2.suse.org:mid]", "X-BeenThere": "gcc-patches@gcc.gnu.org", "X-Mailman-Version": "2.1.30", "Precedence": "list", "List-Id": "Gcc-patches mailing list <gcc-patches.gcc.gnu.org>", "List-Unsubscribe": "<https://gcc.gnu.org/mailman/options/gcc-patches>,\n <mailto:gcc-patches-request@gcc.gnu.org?subject=unsubscribe>", "List-Archive": "<https://gcc.gnu.org/pipermail/gcc-patches/>", "List-Post": "<mailto:gcc-patches@gcc.gnu.org>", "List-Help": "<mailto:gcc-patches-request@gcc.gnu.org?subject=help>", "List-Subscribe": "<https://gcc.gnu.org/mailman/listinfo/gcc-patches>,\n <mailto:gcc-patches-request@gcc.gnu.org?subject=subscribe>", "Errors-To": "gcc-patches-bounces~incoming=patchwork.ozlabs.org@gcc.gnu.org" }, "content": "The following fixes a confusion seein in the x86 backend by\nassign_parm_adjust_stack_rtl failing to trigger a local stack copy\nfor an incoming stack parameter that is not aligned according to\nits type. The condition was introduced in r0-64961-gbfc45551d5ace4\nbut there is the MEM_ALIGN (stack_parm) < PREFERRED_STACK_BOUNDARY\ncondition not triggering for the case in question where both\nMEM_ALIGN and PREFERRED_STACK_BOUNDARY are 128. I cannot really\nmake sense of the condition - taking MEM_ALIGN (stack_parm)\nas the ABI mandated alignment of the argument stack slot means\nthat is a lower bound on the incoming stack boundary. But\nPREFERRED_STACK_BOUNDARY is not the actual boundary and relating\nit to a minimum known boundary to somehow infer known bigger\nalignment of the incoming parameter looks odd.\n\nAs minimal surgery at this point I'm not removing the condition\nbut make it include PREFERRED_STACK_BOUNDARY to make the copy\nfor the testcase in question. Correctness-wise I believe the\ncondition should be elided.\n\nAlan - you added this check, can you possibly guess what it was\nsupposed to guard against? Richard H., you approved the change in the\nend, what's the reason for the PREFERRED_STACK_BOUNDARY guard? Richard\nS., you became involved in the discussion at the end as well.\n\nBootstrapped and tested on x86_64-unknown-linux-gnu.\n\nOK for trunk?\n\nThanks,\nRichard.\n\n\tPR middle-end/120839\n\t* function.cc (assign_parm_adjust_stack_rtl): Adjust\n\talignment check forcing a local copy.\n\n\t* gcc.dg/torture/pr120839.c: New testcase.\n---\n gcc/function.cc | 2 +-\n gcc/testsuite/gcc.dg/torture/pr120839.c | 7 +++++++\n 2 files changed, 8 insertions(+), 1 deletion(-)\n create mode 100644 gcc/testsuite/gcc.dg/torture/pr120839.c", "diff": "diff --git a/gcc/function.cc b/gcc/function.cc\nindex bba05f3380d..e93d12785a5 100644\n--- a/gcc/function.cc\n+++ b/gcc/function.cc\n@@ -2840,7 +2840,7 @@ assign_parm_adjust_stack_rtl (struct assign_parm_data_one *data)\n \t\t\t\t\t\t MEM_ALIGN (stack_parm))))\n \t || (data->nominal_type\n \t && TYPE_ALIGN (data->nominal_type) > MEM_ALIGN (stack_parm)\n-\t && MEM_ALIGN (stack_parm) < PREFERRED_STACK_BOUNDARY)))\n+\t && MEM_ALIGN (stack_parm) <= PREFERRED_STACK_BOUNDARY)))\n stack_parm = NULL;\n \n /* If parm was passed in memory, and we need to convert it on entry,\ndiff --git a/gcc/testsuite/gcc.dg/torture/pr120839.c b/gcc/testsuite/gcc.dg/torture/pr120839.c\nnew file mode 100644\nindex 00000000000..158e800649f\n--- /dev/null\n+++ b/gcc/testsuite/gcc.dg/torture/pr120839.c\n@@ -0,0 +1,7 @@\n+/* { dg-do compile } */\n+\n+typedef struct {\n+ long double a, b;\n+} c __attribute__((aligned(32)));\n+double d;\n+void e(c f) { d = f.a; }\n", "prefixes": [] }