Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/2216194/?format=api
{ "id": 2216194, "url": "http://patchwork.ozlabs.org/api/patches/2216194/?format=api", "web_url": "http://patchwork.ozlabs.org/project/ltp/patch/20260326012908.6885-1-wegao@suse.com/", "project": { "id": 59, "url": "http://patchwork.ozlabs.org/api/projects/59/?format=api", "name": "Linux Test Project development", "link_name": "ltp", "list_id": "ltp.lists.linux.it", "list_email": "ltp@lists.linux.it", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20260326012908.6885-1-wegao@suse.com>", "list_archive_url": null, "date": "2026-03-26T01:28:58", "name": "[v5] fanotify22.c: handle multiple asynchronous error events", "commit_ref": null, "pull_url": null, "state": "changes-requested", "archived": false, "hash": "4e3a76bc1c7c1d119151dceaf0182102504f47ac", "submitter": { "id": 85577, "url": "http://patchwork.ozlabs.org/api/people/85577/?format=api", "name": "Wei Gao", "email": "wegao@suse.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/ltp/patch/20260326012908.6885-1-wegao@suse.com/mbox/", "series": [ { "id": 497526, "url": "http://patchwork.ozlabs.org/api/series/497526/?format=api", "web_url": "http://patchwork.ozlabs.org/project/ltp/list/?series=497526", "date": "2026-03-26T01:28:58", "name": "[v5] fanotify22.c: handle multiple asynchronous error events", "version": 5, "mbox": "http://patchwork.ozlabs.org/series/497526/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2216194/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2216194/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<ltp-bounces+incoming=patchwork.ozlabs.org@lists.linux.it>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "ltp@lists.linux.it" ], "Delivered-To": [ "patchwork-incoming@legolas.ozlabs.org", "ltp@picard.linux.it" ], "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=lists.linux.it header.i=@lists.linux.it\n header.a=rsa-sha256 header.s=picard header.b=PbZ4JfsT;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n unprotected) header.d=suse.com header.i=@suse.com header.a=rsa-sha256\n header.s=google header.b=HGp+0fPC;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.linux.it\n (client-ip=2001:1418:10:5::2; helo=picard.linux.it;\n envelope-from=ltp-bounces+incoming=patchwork.ozlabs.org@lists.linux.it;\n receiver=patchwork.ozlabs.org)" ], "Received": [ "from picard.linux.it (picard.linux.it [IPv6:2001:1418:10:5::2])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fh5m424ssz1y1x\n\tfor <incoming@patchwork.ozlabs.org>; Thu, 26 Mar 2026 12:29:21 +1100 (AEDT)", "from picard.linux.it (localhost [IPv6:::1])\n\tby picard.linux.it (Postfix) with ESMTP id 5602C3E5EE8\n\tfor <incoming@patchwork.ozlabs.org>; Thu, 26 Mar 2026 02:29:18 +0100 (CET)", "from in-6.smtp.seeweb.it (in-6.smtp.seeweb.it [217.194.8.6])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature ECDSA (secp384r1))\n (No client certificate requested)\n by picard.linux.it (Postfix) with ESMTPS id B33B43C21C4\n for <ltp@lists.linux.it>; Thu, 26 Mar 2026 02:29:13 +0100 (CET)", "from mail-wm1-x32f.google.com (mail-wm1-x32f.google.com\n [IPv6:2a00:1450:4864:20::32f])\n (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)\n key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n (No client certificate requested)\n by in-6.smtp.seeweb.it (Postfix) with ESMTPS id CB7FB140055C\n for <ltp@lists.linux.it>; Thu, 26 Mar 2026 02:29:12 +0100 (CET)", "by mail-wm1-x32f.google.com with SMTP id\n 5b1f17b1804b1-4853c1ca73aso4563545e9.2\n for <ltp@lists.linux.it>; Wed, 25 Mar 2026 18:29:12 -0700 (PDT)", "from localhost ([2a07:de40:b240:0:2ad6:ed42:2ad6:ed42])\n by smtp.gmail.com with UTF8SMTPSA id\n 5b1f17b1804b1-48711764625sm174991435e9.14.2026.03.25.18.29.11\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Wed, 25 Mar 2026 18:29:11 -0700 (PDT)" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/simple; d=lists.linux.it;\n i=@lists.linux.it; q=dns/txt; s=picard; t=1774488558; h=to : date :\n message-id : in-reply-to : references : mime-version : subject :\n list-id : list-unsubscribe : list-archive : list-post : list-help :\n list-subscribe : from : reply-to : cc : content-type :\n content-transfer-encoding : sender : from;\n bh=vWKCe2n4eunPBH/oeWLd2YJkCE9UYH+ACKeOOED6Lic=;\n b=PbZ4JfsTL1s+SqH40NReza8LjcYfK2xldKvXkmRu1T1XycDH5e1JHG3ybRLlJ9r8r5UnK\n NU9xIgQ3U1+d+Y/XjgkXJBTlJ2nelvTyOhGRRDPwXHmbVtI4DKGsn/wlWf/3EaqWrQ8yQM+\n Bl6F1pp9T7T4u6FkmTonYCzGrQ8kjDI=", "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=suse.com; s=google; t=1774488552; x=1775093352; darn=lists.linux.it;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:from:to:cc:subject:date\n :message-id:reply-to;\n bh=EXqXFMGYZvnzo0vFB1EERp3REShnP32eiMPmT5REn/I=;\n b=HGp+0fPCL7lV2hLnPW9ibnxvrxLj74yCb5xY2Ajuf3tO/MeEaBHGl8zIBN9HRG2o7n\n OI5TLMVy5VU7ynLbSh8cf39dreCDQ7Pdi24K+kBTJg8bxnQfNtefFOScfifLu2r8Yawq\n u18k55gqnrgsIwZXpyCsCXJkoj23hcGSAfydU933I8B+vZs/5uFWlEiXy09v1fgT2X60\n O6m3V3kKOsS53+n1/fjx7gPULSbZyiRTGyzbCeMlFN3Tky5XddatT9Ng7ulRuyfZHQnt\n nBS3S1IBOS7H+p9SBWzh3J75lOv1W5LXmMbK2o/LytYdv+n0tpzNQTM/GYBq9mlP1GcB\n +3oA==" ], "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1774488552; x=1775093352;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from\n :to:cc:subject:date:message-id:reply-to;\n bh=EXqXFMGYZvnzo0vFB1EERp3REShnP32eiMPmT5REn/I=;\n b=bBoEYkEBhR8XoeY4cxJgiM4PZJ3I0n40dCGCR6FjX3UFghFQibZwEIWww25JA+GyFd\n t1zL8SMFXSs1CEc19u5sJEeO/7k5PrMhEwbpncVjHUgvJLY5FIMLFr07O1ESiw4y4zZR\n A/HnjZwpGYxWUgNx115VF8v/tYhlI3xFe2rO0eRk4jEEvQNVZpvcUx7FhGnjqUzygJ0p\n iCy0gvs8djDeORFmksI4yEhZZxxUii+tFanEalNIYEIMskuD0WjTV/OrWmEchAlpd7XJ\n iEi9Q2Reece+KGuXgJ+Cqz51ZcDJAwkOqz19k9ySUE9eNbH5IE+5VOh3ofq8ICBM1HRv\n nKuA==", "X-Gm-Message-State": "AOJu0YyJl4k+ebFhtJ1ug1LQYXF3wgXo2HjxYIjUITz057DgxK2UImht\n cPSfuqCSVYgAJnllfg5X2W3+jG4YEMKWyc+qUdWYTlrbrX+j7ZdHjDkZOBnU7fvyh6W9yDqLjAQ\n Pp34d5w==", "X-Gm-Gg": "ATEYQzx8pSs4opjyKmRr++kLtMhxwAzgCyMLYH2p3TcjMVkzE43LrhlD4WKPHiE+qju\n F0DexGvlCB0zaQSmpz3qmgkAOth+qKB/yXiG/4AexMjZoVzx4w7EyCyieIrdRShhG8EcjVr+Fi2\n ChYad1abRQdC7Fhtv+i+AckRw1odex4uwE4+n2seUWj5klXXqCWYaDwjaVB6x3I5HmFv1aKtSGT\n NDVFT8+F6orTSgkkWeQN35BwYbUhidDWkf3zvQpXB6WeffZ9QWYanuunJ6JHzMvNHQGvkDKEI7d\n 4MNNttNvw3cDxeA6zr/l9TgUcnZATwxB8AF4S3WuGN/DW7O8KcxHoYEuzJtxljZy5GttTsUBkyI\n cvIH8pDI+76Mph4xAik6ZToz08lXOdHw/5cSi/OgxOTpBOPdWWXCDxBaqY/wiGlMQnI5MPp8W8z\n CH99XFDvJ7MWI=", "X-Received": "by 2002:a05:600c:c0db:b0:480:690e:f14a with SMTP id\n 5b1f17b1804b1-48715ff7b2fmr66966885e9.14.1774488551692;\n Wed, 25 Mar 2026 18:29:11 -0700 (PDT)", "To": "ltp@lists.linux.it", "Date": "Thu, 26 Mar 2026 01:28:58 +0000", "Message-ID": "<20260326012908.6885-1-wegao@suse.com>", "X-Mailer": "git-send-email 2.43.0", "In-Reply-To": "<20260325124428.6497-1-wegao@suse.com>", "References": "<20260325124428.6497-1-wegao@suse.com>", "MIME-Version": "1.0", "X-Spam-Status": "No, score=0.1 required=7.0 tests=DKIM_SIGNED,DKIM_VALID,\n DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_PASS shortcircuit=no\n autolearn=disabled version=4.0.1", "X-Spam-Checker-Version": "SpamAssassin 4.0.1 (2024-03-25) on in-6.smtp.seeweb.it", "X-Virus-Scanned": "clamav-milter 1.0.9 at in-6.smtp.seeweb.it", "X-Virus-Status": "Clean", "Subject": "[LTP] [PATCH v5] fanotify22.c: handle multiple asynchronous error\n events", "X-BeenThere": "ltp@lists.linux.it", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "Linux Test Project <ltp.lists.linux.it>", "List-Unsubscribe": "<https://lists.linux.it/options/ltp>,\n <mailto:ltp-request@lists.linux.it?subject=unsubscribe>", "List-Archive": "<http://lists.linux.it/pipermail/ltp/>", "List-Post": "<mailto:ltp@lists.linux.it>", "List-Help": "<mailto:ltp-request@lists.linux.it?subject=help>", "List-Subscribe": "<https://lists.linux.it/listinfo/ltp>,\n <mailto:ltp-request@lists.linux.it?subject=subscribe>", "From": "Wei Gao via ltp <ltp@lists.linux.it>", "Reply-To": "Wei Gao <wegao@suse.com>", "Cc": "Jan Kara <jack@suse.cz>, kernel test robot <oliver.sang@intel.com>", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "ltp-bounces+incoming=patchwork.ozlabs.org@lists.linux.it", "Sender": "\"ltp\" <ltp-bounces+incoming=patchwork.ozlabs.org@lists.linux.it>" }, "content": "Since the introduction of the asynchronous fserror reporting framework\n(kernel commit 81d2e13a57c9), fanotify22 has encountered sporadic failures\ndue to the non-deterministic nature of event delivery and merging:\n\n1) tcase3 failure: A race condition occurs when the test reads the\n notification fd between two events. uses a poll() and read() loop to wait\n until the expected.\n\n2) tcase4 failure: The kernel may deliver errors as independent events\n instead of a single merged event, since different worker kthread can\n end up generating each event so they won't be merged. As suggested by\n Jan Kara, this patch introduces a consolidate_events() helper. It iterates\n through the event buffer, accumulates the error_count from all independent\n events, and updates the first event's count in-place.\n\nReported-by: kernel test robot <oliver.sang@intel.com>\nCloses: https://lore.kernel.org/oe-lkp/202602042124.87bd00e3-lkp@intel.com\nSuggested-by: Jan Kara <jack@suse.cz>\nSigned-off-by: Wei Gao <wegao@suse.com>\n---\nv4->v5:\nAdded a continue after an unexpected errno2 is detected\n\n .../kernel/syscalls/fanotify/fanotify22.c | 87 ++++++++++++++++++-\n 1 file changed, 83 insertions(+), 4 deletions(-)", "diff": "diff --git a/testcases/kernel/syscalls/fanotify/fanotify22.c b/testcases/kernel/syscalls/fanotify/fanotify22.c\nindex e8002b160..2e5e6a3fa 100644\n--- a/testcases/kernel/syscalls/fanotify/fanotify22.c\n+++ b/testcases/kernel/syscalls/fanotify/fanotify22.c\n@@ -28,6 +28,7 @@\n #include \"tst_test.h\"\n #include <sys/fanotify.h>\n #include <sys/types.h>\n+#include <poll.h>\n \n #ifdef HAVE_SYS_FANOTIFY_H\n #include \"fanotify.h\"\n@@ -88,7 +89,6 @@ static void trigger_bad_link_lookup(void)\n \t\t\tret, BAD_LINK, errno, EUCLEAN);\n }\n \n-\n static void tcase3_trigger(void)\n {\n \ttrigger_bad_link_lookup();\n@@ -104,6 +104,7 @@ static void tcase4_trigger(void)\n static struct test_case {\n \tchar *name;\n \tint error;\n+\tint error2;\n \tunsigned int error_count;\n \tstruct fanotify_fid_t *fid;\n \tvoid (*trigger_error)(void);\n@@ -134,10 +135,53 @@ static struct test_case {\n \t\t.trigger_error = &tcase4_trigger,\n \t\t.error_count = 2,\n \t\t.error = EFSCORRUPTED,\n+\t\t.error2 = ESHUTDOWN,\n \t\t.fid = &bad_file_fid,\n \t}\n };\n \n+static size_t consolidate_events(char *buf, size_t len, const struct test_case *ex)\n+{\n+\tstruct fanotify_event_metadata *metadata, *first = NULL;\n+\tstruct fanotify_event_info_error *first_info = NULL;\n+\tunsigned int total_count = 0;\n+\tint event_num = 0;\n+\n+\tfor (metadata = (struct fanotify_event_metadata *)buf;\n+\t\t\tFAN_EVENT_OK(metadata, len);\n+\t\t\tmetadata = FAN_EVENT_NEXT(metadata, len)) {\n+\n+\t\tevent_num++;\n+\t\tstruct fanotify_event_info_error *info = get_event_info_error(metadata);\n+\n+\t\tif (!info) {\n+\t\t\ttst_res(TFAIL, \"%s: Event [%d] missing error info\",\n+\t\t\t\t\tex->name, event_num);\n+\t\t\tcontinue;\n+\t\t}\n+\n+\t\tif (info->error != ex->error && (ex->error2 == 0 || info->error != ex->error2)) {\n+\t\t\ttst_res(TFAIL, \"%s: Event [%d] unexpected errno (%d)\",\n+\t\t\t\t\tex->name, event_num, info->error);\n+\t\t\tcontinue;\n+\t\t}\n+\n+\t\tif (!first) {\n+\t\t\tfirst = metadata;\n+\t\t\tfirst_info = info;\n+\t\t}\n+\t\ttotal_count += info->error_count;\n+\n+\t\ttst_res(TINFO, \"Event [%d]: errno=%d, error_count=%d\",\n+\t\t\t\tevent_num, info->error, info->error_count);\n+\t}\n+\n+\tif (first_info)\n+\t\tfirst_info->error_count = total_count;\n+\n+\treturn (first) ? first->event_len : 0;\n+}\n+\n static int check_error_event_info_fid(struct fanotify_event_info_fid *fid,\n \t\t\t\t const struct test_case *ex)\n {\n@@ -248,19 +292,54 @@ static void check_event(char *buf, size_t len, const struct test_case *ex)\n static void do_test(unsigned int i)\n {\n \tconst struct test_case *tcase = &testcases[i];\n-\tsize_t read_len;\n+\tsize_t read_len = 0;\n+\tstruct pollfd pfd;\n+\tunsigned int accumulated_count = 0;\n \n \tSAFE_FANOTIFY_MARK(fd_notify, FAN_MARK_ADD|FAN_MARK_FILESYSTEM,\n \t\t\t FAN_FS_ERROR, AT_FDCWD, MOUNT_PATH);\n \n \ttcase->trigger_error();\n \n-\tread_len = SAFE_READ(0, fd_notify, event_buf, BUF_SIZE);\n+\tpfd.fd = fd_notify;\n+\tpfd.events = POLLIN;\n+\n+\twhile (accumulated_count < tcase->error_count) {\n+\t\tif (poll(&pfd, 1, 5000) <= 0) {\n+\t\t\ttst_res(TFAIL, \"%s: Timeout waiting for events\", tcase->name);\n+\t\t\tgoto out;\n+\t\t}\n+\n+\t\tchar *current_pos = event_buf + read_len;\n+\t\tint ret = read(fd_notify, current_pos, BUF_SIZE - read_len);\n+\n+\t\tif (ret < 0) {\n+\t\t\ttst_res(TFAIL, \"%s: read failed: %s\", tcase->name, strerror(errno));\n+\t\t\tgoto out;\n+\t\t}\n+\n+\t\tstruct fanotify_event_metadata *m =\n+\t\t\t(struct fanotify_event_metadata *)current_pos;\n+\t\twhile (FAN_EVENT_OK(m, ret)) {\n+\t\t\tstruct fanotify_event_info_error *e = get_event_info_error(m);\n+\n+\t\t\tif (e)\n+\t\t\t\taccumulated_count += e->error_count;\n+\n+\t\t\tread_len += m->event_len;\n+\t\t\tm = FAN_EVENT_NEXT(m, ret);\n+\t\t}\n+\t}\n+\n+\tread_len = consolidate_events(event_buf, read_len, tcase);\n+\n+\tcheck_event(event_buf, read_len, tcase);\n+\n+out:\n \n \tSAFE_FANOTIFY_MARK(fd_notify, FAN_MARK_REMOVE|FAN_MARK_FILESYSTEM,\n \t\t\t FAN_FS_ERROR, AT_FDCWD, MOUNT_PATH);\n \n-\tcheck_event(event_buf, read_len, tcase);\n \t/* Unmount and mount the filesystem to get it out of the error state */\n \tSAFE_UMOUNT(MOUNT_PATH);\n \tSAFE_MOUNT(tst_device->dev, MOUNT_PATH, tst_device->fs_type, 0, NULL);\n", "prefixes": [ "v5" ] }