Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/2216185/?format=api
{ "id": 2216185, "url": "http://patchwork.ozlabs.org/api/patches/2216185/?format=api", "web_url": "http://patchwork.ozlabs.org/project/ubuntu-kernel/patch/20260325232149.127814-4-ian.whitfield@canonical.com/", "project": { "id": 15, "url": "http://patchwork.ozlabs.org/api/projects/15/?format=api", "name": "Ubuntu Kernel", "link_name": "ubuntu-kernel", "list_id": "kernel-team.lists.ubuntu.com", "list_email": "kernel-team@lists.ubuntu.com", "web_url": null, "scm_url": null, "webscm_url": null, "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20260325232149.127814-4-ian.whitfield@canonical.com>", "list_archive_url": null, "date": "2026-03-25T23:21:46", "name": "[SRU,Q:linux-gcp,3/6] RDMA/irdma: Remove fixed 1 ms delay during AH wait loop", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "bfeed8bc643bd1be2dfad18a0c8097ace8511e61", "submitter": { "id": 89403, "url": "http://patchwork.ozlabs.org/api/people/89403/?format=api", "name": "Ian Whitfield", "email": "ian.whitfield@canonical.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/ubuntu-kernel/patch/20260325232149.127814-4-ian.whitfield@canonical.com/mbox/", "series": [ { "id": 497521, "url": "http://patchwork.ozlabs.org/api/series/497521/?format=api", "web_url": "http://patchwork.ozlabs.org/project/ubuntu-kernel/list/?series=497521", "date": "2026-03-25T23:21:43", "name": "Add irdma fixups since 6.19", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/497521/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2216185/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2216185/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<kernel-team-bounces@lists.ubuntu.com>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (4096-bit key;\n unprotected) header.d=canonical.com header.i=@canonical.com\n header.a=rsa-sha256 header.s=20251003 header.b=GkPXS6zn;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.ubuntu.com\n (client-ip=185.125.189.65; helo=lists.ubuntu.com;\n envelope-from=kernel-team-bounces@lists.ubuntu.com;\n receiver=patchwork.ozlabs.org)" ], "Received": [ "from lists.ubuntu.com (lists.ubuntu.com [185.125.189.65])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fh2x61y5hz1yGL\n\tfor <incoming@patchwork.ozlabs.org>; Thu, 26 Mar 2026 10:22:01 +1100 (AEDT)", "from localhost ([127.0.0.1] helo=lists.ubuntu.com)\n\tby lists.ubuntu.com with esmtp (Exim 4.86_2)\n\t(envelope-from <kernel-team-bounces@lists.ubuntu.com>)\n\tid 1w5XXv-0004jo-Qd; Wed, 25 Mar 2026 23:21:55 +0000", "from smtp-relay-internal-0.internal ([10.131.114.225]\n helo=smtp-relay-internal-0.canonical.com)\n by lists.ubuntu.com with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)\n (Exim 4.86_2) (envelope-from <ian.whitfield@canonical.com>)\n id 1w5XXu-0004fY-FJ\n for kernel-team@lists.ubuntu.com; Wed, 25 Mar 2026 23:21:54 +0000", "from mail-qt1-f198.google.com (mail-qt1-f198.google.com\n [209.85.160.198])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n (No client certificate requested)\n by smtp-relay-internal-0.canonical.com (Postfix) with ESMTPS id 49D113F29D\n for <kernel-team@lists.ubuntu.com>; Wed, 25 Mar 2026 23:21:54 +0000 (UTC)", "by mail-qt1-f198.google.com with SMTP id\n d75a77b69052e-50b4076dc16so15847851cf.2\n for <kernel-team@lists.ubuntu.com>; Wed, 25 Mar 2026 16:21:54 -0700 (PDT)", "from localhost ([2600:4041:dc:e800:448b:3cc:c137:e67a])\n by smtp.gmail.com with ESMTPSA id\n d75a77b69052e-50b9234f5dasm9710051cf.14.2026.03.25.16.21.52\n for <kernel-team@lists.ubuntu.com>\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Wed, 25 Mar 2026 16:21:52 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=canonical.com;\n s=20251003; t=1774480914;\n bh=m/R28Uwoxaq2ngJVt10OgGLoHqD5YNGLpiHr3V/ltm0=;\n h=From:To:Subject:Date:Message-ID:In-Reply-To:References:\n MIME-Version;\n b=GkPXS6znkF0EQvAGHvB8A2HUphXNToCTfwNy3b2jErfV2hwjdKkuzzBLf5xp43yTU\n vLtqiThg4cIJ9hJakPXCFLarj0+qa6+B1Qgzb7fzxtJIkxUmmvMKHS410rGIaJkqXn\n N9si8IW7FU2iDrklRdyfAMou7q13/Or1AJsZtpM/eHMbbuDzM6MrXzYgAiWNbMDWtA\n 0Uzu5tk8ZbKst9vk/vYZFb9pBXvdNVtxbxAQ6K45W571zhiDB0RvW5oLG9aYijSYxw\n 79O8esR4oxv8nBYqViN97JdYRj6RKewcU731GYZuw97Hv9mPPawe/d9g4W8moM8HII\n nx2F7GhWLUhtsbRaxKNy2+WIGXDUfZh3xj+9Afwpfd2VE5ToNjDkgs1mNGMDIcWd7R\n h5YevO8fLs4z8gkQ2ZA15KoSGS+ROqbbT8IpZeDE37zWEajkPX+E4IV+TcgRJCvqf0\n jqC8vHAylhRd8G7MLsrVJAqa0f5cKnRaqCOg1HcRLe9p7+a6UEtgZZg3L/yV+o/MeL\n LdU1KEj8kiz0zLdRU9aWeoC1GlMB4jwwWyBGH4dKigOb7NaKcXFnKpQg7drmdADh+e\n 717QvQPj43x3BM9AUV//XW68M06XejJf5lRj2nIZeOA8d2zD/tT+Azi65vtSab9jrx\n qGHZnn3Nb1LZyVtOe/Gc4bCQ=", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1774480913; x=1775085713;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:to:from:x-gm-gg:x-gm-message-state:from:to\n :cc:subject:date:message-id:reply-to;\n bh=m/R28Uwoxaq2ngJVt10OgGLoHqD5YNGLpiHr3V/ltm0=;\n b=C3MURbE43OYWmPOkWsZaYGmz7vUnwgdZhc9qOzKEYsVv//ZvWsiHVkmXikYzKkklzS\n oYhUM09QX8Z3yMVKaZdabZFr5EnJCExHcDSZAJq+v/uK7EcfztuCslexiBcSZibW4fDm\n /pT3lxSSnM+zOJ1F6PtoVTjtExROwpnZSCU+znMdLMcxAPARIR5C+HzAy5Q+7EG/I/ti\n rlhg5BrJazA5/ZU835N408FrjBOfKmkvPDpXnhi+96RiyOr2re9LhB5cdKQ+ZibFcBLj\n b1Omp/eZXTlJucY+xccIqzOBAKH/JS/EmEH0ChYzgKMfx/xWE8a4L43A4vP4YscVTcch\n DjCg==", "X-Gm-Message-State": "AOJu0YwZL8ipGGTaOpYgvIptyqiS7L5VK4lWLnd3aAgpLrSpEL0PE68L\n /K8CT1hoRHqURRA2+vLnk7HZLIlSZ0PYQ5rtStHbSe8pUPab//SUi+zD/3vNFlrWwYXHgavlRtN\n bqK65gp+ox8R0nif5zlr2yFVOdgtL11gFaRuZRqQJbJ5AkSnxruPzkmsE7EeLa34oI7eQ8A7ppt\n MIyVeru2TlCwqS4g==", "X-Gm-Gg": "ATEYQzzlZwESs8hVSikZZir7MMs1Me91TnOh52JddzUd1cemStz00sYIOivszCM/eMU\n Je/61hhYis23taayj9Yytg97+k837EGuIkFqKKRLOn8iRKHjd403mDTywUkGWT6CyP77V3k2Epq\n dz4gOqKd+zY2EgyZzFQXTLD2ld+IebQ95+LhWkFmgGww4nvXf22ESsdTgrBwjwooux7+CdyYoxP\n bhcjPDFM8RvZXJ191BK6NlRm77Z9A4ZktRJmhkYVGa0m6GJpzjnrTluLWdvaaelMsbBn6qo269o\n MbW9gLinMd1pplvjH3ub9siE3nwaCYgWNC07GRstVtCijnze3VfiGMqqAZ8KNekvM/R0AAIgDZK\n riRBWqXLJGXCD+uV+mZL/8t7wPB+wUg==", "X-Received": [ "by 2002:a05:622a:244b:b0:50b:4f56:f6f1 with SMTP id\n d75a77b69052e-50b80de2459mr72700531cf.35.1774480913145;\n Wed, 25 Mar 2026 16:21:53 -0700 (PDT)", "by 2002:a05:622a:244b:b0:50b:4f56:f6f1 with SMTP id\n d75a77b69052e-50b80de2459mr72700281cf.35.1774480912762;\n Wed, 25 Mar 2026 16:21:52 -0700 (PDT)" ], "From": "Ian Whitfield <ian.whitfield@canonical.com>", "To": "kernel-team@lists.ubuntu.com", "Subject": "[SRU][Q:linux-gcp][PATCH 3/6] RDMA/irdma: Remove fixed 1 ms delay\n during AH wait loop", "Date": "Wed, 25 Mar 2026 19:21:46 -0400", "Message-ID": "<20260325232149.127814-4-ian.whitfield@canonical.com>", "X-Mailer": "git-send-email 2.43.0", "In-Reply-To": "<20260325232149.127814-1-ian.whitfield@canonical.com>", "References": "<20260325232149.127814-1-ian.whitfield@canonical.com>", "MIME-Version": "1.0", "X-BeenThere": "kernel-team@lists.ubuntu.com", "X-Mailman-Version": "2.1.20", "Precedence": "list", "List-Id": "Kernel team discussions <kernel-team.lists.ubuntu.com>", "List-Unsubscribe": "<https://lists.ubuntu.com/mailman/options/kernel-team>,\n <mailto:kernel-team-request@lists.ubuntu.com?subject=unsubscribe>", "List-Archive": "<https://lists.ubuntu.com/archives/kernel-team>", "List-Post": "<mailto:kernel-team@lists.ubuntu.com>", "List-Help": "<mailto:kernel-team-request@lists.ubuntu.com?subject=help>", "List-Subscribe": "<https://lists.ubuntu.com/mailman/listinfo/kernel-team>,\n <mailto:kernel-team-request@lists.ubuntu.com?subject=subscribe>", "Content-Type": "text/plain; charset=\"utf-8\"", "Content-Transfer-Encoding": "base64", "Errors-To": "kernel-team-bounces@lists.ubuntu.com", "Sender": "\"kernel-team\" <kernel-team-bounces@lists.ubuntu.com>" }, "content": "From: Jacob Moroni <jmoroni@google.com>\n\nBugLink: https://bugs.launchpad.net/bugs/2146168\n\nThe AH CQP command wait loop executes in an atomic context and was\nusing a fixed 1 ms delay. Since many AH create commands can complete\nmuch faster than 1 ms, use poll_timeout_us_atomic with a 1 us delay.\n\nAlso, use the timeout value indicated during the capability exchange\nrather than a hard-coded value.\n\nSigned-off-by: Jacob Moroni <jmoroni@google.com>\nLink: https://patch.msgid.link/20260105180550.2907858-1-jmoroni@google.com\nSigned-off-by: Leon Romanovsky <leon@kernel.org>\n(cherry picked from commit 5c3f795d17dc57a58a1fc1c1b449812e26ad85a3)\nSigned-off-by: Ian Whitfield <ian.whitfield@canonical.com>\n---\n drivers/infiniband/hw/irdma/main.h | 2 ++\n drivers/infiniband/hw/irdma/utils.c | 2 +-\n drivers/infiniband/hw/irdma/verbs.c | 16 ++++++++--------\n 3 files changed, 11 insertions(+), 9 deletions(-)", "diff": "diff --git a/drivers/infiniband/hw/irdma/main.h b/drivers/infiniband/hw/irdma/main.h\nindex 65ce4924dbfa..c5336b26e730 100644\n--- a/drivers/infiniband/hw/irdma/main.h\n+++ b/drivers/infiniband/hw/irdma/main.h\n@@ -23,6 +23,7 @@\n #include <linux/workqueue.h>\n #include <linux/slab.h>\n #include <linux/io.h>\n+#include <linux/iopoll.h>\n #include <linux/crc32c.h>\n #include <linux/kthread.h>\n #ifndef CONFIG_64BIT\n@@ -528,6 +529,7 @@ void irdma_cq_wq_destroy(struct irdma_pci_f *rf, struct irdma_sc_cq *cq);\n void irdma_srq_event(struct irdma_sc_srq *srq);\n void irdma_srq_wq_destroy(struct irdma_pci_f *rf, struct irdma_sc_srq *srq);\n void irdma_cleanup_pending_cqp_op(struct irdma_pci_f *rf);\n+int irdma_get_timeout_threshold(struct irdma_sc_dev *dev);\n int irdma_hw_modify_qp(struct irdma_device *iwdev, struct irdma_qp *iwqp,\n \t\t struct irdma_modify_qp_info *info, bool wait);\n int irdma_qp_suspend_resume(struct irdma_sc_qp *qp, bool suspend);\ndiff --git a/drivers/infiniband/hw/irdma/utils.c b/drivers/infiniband/hw/irdma/utils.c\nindex b6c4ccf38eb7..a1d9ebe4f731 100644\n--- a/drivers/infiniband/hw/irdma/utils.c\n+++ b/drivers/infiniband/hw/irdma/utils.c\n@@ -572,7 +572,7 @@ void irdma_cleanup_pending_cqp_op(struct irdma_pci_f *rf)\n \t}\n }\n \n-static int irdma_get_timeout_threshold(struct irdma_sc_dev *dev)\n+int irdma_get_timeout_threshold(struct irdma_sc_dev *dev)\n {\n \tu16 time_s = dev->vc_caps.cqp_timeout_s;\n \ndiff --git a/drivers/infiniband/hw/irdma/verbs.c b/drivers/infiniband/hw/irdma/verbs.c\nindex 6c3e1e8cea94..5e098215d1c0 100644\n--- a/drivers/infiniband/hw/irdma/verbs.c\n+++ b/drivers/infiniband/hw/irdma/verbs.c\n@@ -5019,15 +5019,15 @@ static int irdma_create_hw_ah(struct irdma_device *iwdev, struct irdma_ah *ah, b\n \t}\n \n \tif (!sleep) {\n-\t\tint cnt = CQP_COMPL_WAIT_TIME_MS * CQP_TIMEOUT_THRESHOLD;\n+\t\tconst u64 tmout_ms = irdma_get_timeout_threshold(&rf->sc_dev) *\n+\t\t\tCQP_COMPL_WAIT_TIME_MS;\n \n-\t\tdo {\n-\t\t\tirdma_cqp_ce_handler(rf, &rf->ccq.sc_cq);\n-\t\t\tmdelay(1);\n-\t\t} while (!ah->sc_ah.ah_info.ah_valid && --cnt);\n-\n-\t\tif (!cnt) {\n-\t\t\tibdev_dbg(&iwdev->ibdev, \"VERBS: CQP create AH timed out\");\n+\t\tif (poll_timeout_us_atomic(irdma_cqp_ce_handler(rf,\n+\t\t\t\t\t\t\t\t&rf->ccq.sc_cq),\n+\t\t\t\t\t ah->sc_ah.ah_info.ah_valid, 1,\n+\t\t\t\t\t tmout_ms * USEC_PER_MSEC, false)) {\n+\t\t\tibdev_dbg(&iwdev->ibdev,\n+\t\t\t\t \"VERBS: CQP create AH timed out\");\n \t\t\terr = -ETIMEDOUT;\n \t\t\tgoto err_ah_create;\n \t\t}\n", "prefixes": [ "SRU", "Q:linux-gcp", "3/6" ] }