Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 2216144,
    "url": "http://patchwork.ozlabs.org/api/patches/2216144/?format=api",
    "web_url": "http://patchwork.ozlabs.org/project/netfilter-devel/patch/20260325222615.637793-5-pablo@netfilter.org/",
    "project": {
        "id": 26,
        "url": "http://patchwork.ozlabs.org/api/projects/26/?format=api",
        "name": "Netfilter Development",
        "link_name": "netfilter-devel",
        "list_id": "netfilter-devel.vger.kernel.org",
        "list_email": "netfilter-devel@vger.kernel.org",
        "web_url": null,
        "scm_url": null,
        "webscm_url": null,
        "list_archive_url": "",
        "list_archive_url_format": "",
        "commit_url_format": ""
    },
    "msgid": "<20260325222615.637793-5-pablo@netfilter.org>",
    "list_archive_url": null,
    "date": "2026-03-25T22:26:05",
    "name": "[net,04/14] netfilter: nfnetlink_log: fix uninitialized padding leak in NFULA_PAYLOAD",
    "commit_ref": null,
    "pull_url": null,
    "state": "handled-elsewhere",
    "archived": true,
    "hash": "b9403816ceba0891d91c16cf3fe592adcdec5341",
    "submitter": {
        "id": 1315,
        "url": "http://patchwork.ozlabs.org/api/people/1315/?format=api",
        "name": "Pablo Neira Ayuso",
        "email": "pablo@netfilter.org"
    },
    "delegate": null,
    "mbox": "http://patchwork.ozlabs.org/project/netfilter-devel/patch/20260325222615.637793-5-pablo@netfilter.org/mbox/",
    "series": [
        {
            "id": 497517,
            "url": "http://patchwork.ozlabs.org/api/series/497517/?format=api",
            "web_url": "http://patchwork.ozlabs.org/project/netfilter-devel/list/?series=497517",
            "date": "2026-03-25T22:26:01",
            "name": "[net,01/14] netfilter: nft_set_pipapo_avx2: don't return non-matching entry on expiry",
            "version": 2,
            "mbox": "http://patchwork.ozlabs.org/series/497517/mbox/"
        }
    ],
    "comments": "http://patchwork.ozlabs.org/api/patches/2216144/comments/",
    "check": "pending",
    "checks": "http://patchwork.ozlabs.org/api/patches/2216144/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "\n <netfilter-devel+bounces-11424-incoming=patchwork.ozlabs.org@vger.kernel.org>",
        "X-Original-To": [
            "incoming@patchwork.ozlabs.org",
            "netfilter-devel@vger.kernel.org"
        ],
        "Delivered-To": "patchwork-incoming@legolas.ozlabs.org",
        "Authentication-Results": [
            "legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=netfilter.org header.i=@netfilter.org\n header.a=rsa-sha256 header.s=2025 header.b=Is8pgJJv;\n\tdkim-atps=neutral",
            "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=172.105.105.114; helo=tor.lore.kernel.org;\n envelope-from=netfilter-devel+bounces-11424-incoming=patchwork.ozlabs.org@vger.kernel.org;\n receiver=patchwork.ozlabs.org)",
            "smtp.subspace.kernel.org;\n\tdkim=pass (2048-bit key) header.d=netfilter.org header.i=@netfilter.org\n header.b=\"Is8pgJJv\"",
            "smtp.subspace.kernel.org;\n arc=none smtp.client-ip=217.70.190.124",
            "smtp.subspace.kernel.org;\n dmarc=none (p=none dis=none) header.from=netfilter.org",
            "smtp.subspace.kernel.org;\n spf=pass smtp.mailfrom=netfilter.org"
        ],
        "Received": [
            "from tor.lore.kernel.org (tor.lore.kernel.org [172.105.105.114])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fh1jZ6RPJz1y1x\n\tfor <incoming@patchwork.ozlabs.org>; Thu, 26 Mar 2026 09:26:58 +1100 (AEDT)",
            "from smtp.subspace.kernel.org (conduit.subspace.kernel.org\n [100.90.174.1])\n\tby tor.lore.kernel.org (Postfix) with ESMTP id CDA07303A3D9\n\tfor <incoming@patchwork.ozlabs.org>; Wed, 25 Mar 2026 22:26:42 +0000 (UTC)",
            "from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id D3EC638F22E;\n\tWed, 25 Mar 2026 22:26:37 +0000 (UTC)",
            "from mail.netfilter.org (mail.netfilter.org [217.70.190.124])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby smtp.subspace.kernel.org (Postfix) with ESMTPS id EA851381B1D;\n\tWed, 25 Mar 2026 22:26:35 +0000 (UTC)",
            "from localhost.localdomain (mail-agni [217.70.190.124])\n\tby mail.netfilter.org (Postfix) with ESMTPSA id C893B60180;\n\tWed, 25 Mar 2026 23:26:28 +0100 (CET)"
        ],
        "ARC-Seal": "i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;\n\tt=1774477597; cv=none;\n b=PUgJb+5LMV4V6Q/n8T0Ok/THDd27VjEMfNhHkvYnoegyfDsJtOOA8IPE/KSYALu0k3lD8z74scvvpckcYvwidKiay7EM6xpjvNqIMnHFBpgfxKYJ+O4yfDWOGkB75581EXTNAP2enjCShpgb4803rjVJv6BLiVpnv2Jr3IWVm80=",
        "ARC-Message-Signature": "i=1; a=rsa-sha256; d=subspace.kernel.org;\n\ts=arc-20240116; t=1774477597; c=relaxed/simple;\n\tbh=K7RSrdEFZy6Z+RlJPtEraPlErH2kH671nvcT1Ug4334=;\n\th=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References:\n\t MIME-Version;\n b=gtOV3iW9f9OEk9qwByR/EU3b5i088bCtAESxDdojN4t1ulTjcoi+VFxFzLUqjwcYpEl7km6yzDeBCsJ5L3Q+IVcVgaABCUB0j8Y5bEySTMLfhV4pBP9kEBXV/S5V4IdoIEG0VAVGoSNmCeJBHKEBW4a+P11myozr7pl0JlOFsec=",
        "ARC-Authentication-Results": "i=1; smtp.subspace.kernel.org;\n dmarc=none (p=none dis=none) header.from=netfilter.org;\n spf=pass smtp.mailfrom=netfilter.org;\n dkim=pass (2048-bit key) header.d=netfilter.org header.i=@netfilter.org\n header.b=Is8pgJJv; arc=none smtp.client-ip=217.70.190.124",
        "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=netfilter.org;\n\ts=2025; t=1774477589;\n\tbh=PIh+oFx3ncJBBFZxKgZDh/cS8gnROLybKH/NG8EuEkg=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=Is8pgJJvbBEHBFukM7CRaU4lKTha55XlKQnijXNkRApB/2eCo5Tg8ittoZtX8r4l3\n\t hjW9iNWZOv2WXsmbNeskBgL8Sfkd9z422DpHON5SKp59RLVLYBfKgJ5aBAzsryq/ZT\n\t 89pw5Um4jsEeT8W17S4ZqRTB4ycrjm8baZBtJYu9D5IWREiaCgVvWqkkA84L0o4Dpe\n\t 575V+5daaRrHr/hcrj5C/SyKZCNAHNFFPajbOL2dkrXkD/GZo7vz9RF+T54DDwMm0t\n\t omecxgkbAUwHG4D6Fo2M/xlrFcQSKtgHgSs9CF3PqnlluSjwKVgh6REww4VeM/wTKk\n\t JJ1fXv1Z9EsXg==",
        "From": "Pablo Neira Ayuso <pablo@netfilter.org>",
        "To": "netfilter-devel@vger.kernel.org",
        "Cc": "davem@davemloft.net,\n\tnetdev@vger.kernel.org,\n\tkuba@kernel.org,\n\tpabeni@redhat.com,\n\tedumazet@google.com,\n\tfw@strlen.de,\n\thorms@kernel.org",
        "Subject": "[PATCH net 04/14] netfilter: nfnetlink_log: fix uninitialized padding\n leak in NFULA_PAYLOAD",
        "Date": "Wed, 25 Mar 2026 23:26:05 +0100",
        "Message-ID": "<20260325222615.637793-5-pablo@netfilter.org>",
        "X-Mailer": "git-send-email 2.47.3",
        "In-Reply-To": "<20260325222615.637793-1-pablo@netfilter.org>",
        "References": "<20260325222615.637793-1-pablo@netfilter.org>",
        "Precedence": "bulk",
        "X-Mailing-List": "netfilter-devel@vger.kernel.org",
        "List-Id": "<netfilter-devel.vger.kernel.org>",
        "List-Subscribe": "<mailto:netfilter-devel+subscribe@vger.kernel.org>",
        "List-Unsubscribe": "<mailto:netfilter-devel+unsubscribe@vger.kernel.org>",
        "MIME-Version": "1.0",
        "Content-Transfer-Encoding": "8bit"
    },
    "content": "From: Weiming Shi <bestswngs@gmail.com>\n\n__build_packet_message() manually constructs the NFULA_PAYLOAD netlink\nattribute using skb_put() and skb_copy_bits(), bypassing the standard\nnla_reserve()/nla_put() helpers. While nla_total_size(data_len) bytes\nare allocated (including NLA alignment padding), only data_len bytes\nof actual packet data are copied. The trailing nla_padlen(data_len)\nbytes (1-3 when data_len is not 4-byte aligned) are never initialized,\nleaking stale heap contents to userspace via the NFLOG netlink socket.\n\nReplace the manual attribute construction with nla_reserve(), which\nhandles the tailroom check, header setup, and padding zeroing via\n__nla_reserve(). The subsequent skb_copy_bits() fills in the payload\ndata on top of the properly initialized attribute.\n\nFixes: df6fb868d611 (\"[NETFILTER]: nfnetlink: convert to generic netlink attribute functions\")\nReported-by: Xiang Mei <xmei5@asu.edu>\nSigned-off-by: Weiming Shi <bestswngs@gmail.com>\nSigned-off-by: Florian Westphal <fw@strlen.de>\nSigned-off-by: Pablo Neira Ayuso <pablo@netfilter.org>\n---\n net/netfilter/nfnetlink_log.c | 8 ++------\n 1 file changed, 2 insertions(+), 6 deletions(-)",
    "diff": "diff --git a/net/netfilter/nfnetlink_log.c b/net/netfilter/nfnetlink_log.c\nindex b35a90955e2e..fcbe54940b2e 100644\n--- a/net/netfilter/nfnetlink_log.c\n+++ b/net/netfilter/nfnetlink_log.c\n@@ -647,15 +647,11 @@ __build_packet_message(struct nfnl_log_net *log,\n \n \tif (data_len) {\n \t\tstruct nlattr *nla;\n-\t\tint size = nla_attr_size(data_len);\n \n-\t\tif (skb_tailroom(inst->skb) < nla_total_size(data_len))\n+\t\tnla = nla_reserve(inst->skb, NFULA_PAYLOAD, data_len);\n+\t\tif (!nla)\n \t\t\tgoto nla_put_failure;\n \n-\t\tnla = skb_put(inst->skb, nla_total_size(data_len));\n-\t\tnla->nla_type = NFULA_PAYLOAD;\n-\t\tnla->nla_len = size;\n-\n \t\tif (skb_copy_bits(skb, 0, nla_data(nla), data_len))\n \t\t\tBUG();\n \t}\n",
    "prefixes": [
        "net",
        "04/14"
    ]
}