Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/2216105/?format=api
{ "id": 2216105, "url": "http://patchwork.ozlabs.org/api/patches/2216105/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20260325205054.109822-1-kohei@enjuk.jp/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20260325205054.109822-1-kohei@enjuk.jp>", "list_archive_url": null, "date": "2026-03-25T20:50:06", "name": "[iwl-net,v1] i40e: don't advertise IFF_SUPP_NOFCS", "commit_ref": null, "pull_url": null, "state": "under-review", "archived": false, "hash": "a90cad1ce94cff9a0c99b8a27611891c637654a0", "submitter": { "id": 92459, "url": "http://patchwork.ozlabs.org/api/people/92459/?format=api", "name": "Kohei Enju", "email": "kohei@enjuk.jp" }, "delegate": { "id": 109701, "url": "http://patchwork.ozlabs.org/api/users/109701/?format=api", "username": "anguy11", "first_name": "Anthony", "last_name": "Nguyen", "email": "anthony.l.nguyen@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20260325205054.109822-1-kohei@enjuk.jp/mbox/", "series": [ { "id": 497510, "url": "http://patchwork.ozlabs.org/api/series/497510/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/list/?series=497510", "date": "2026-03-25T20:50:06", "name": "[iwl-net,v1] i40e: don't advertise IFF_SUPP_NOFCS", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/497510/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2216105/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2216105/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@legolas.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=osuosl.org header.i=@osuosl.org header.a=rsa-sha256\n header.s=default header.b=ZfHha1Zl;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=osuosl.org\n (client-ip=140.211.166.138; helo=smtp1.osuosl.org;\n envelope-from=intel-wired-lan-bounces@osuosl.org;\n receiver=patchwork.ozlabs.org)" ], "Received": [ "from smtp1.osuosl.org (smtp1.osuosl.org [140.211.166.138])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fgzbW26lSz1xy1\n\tfor <incoming@patchwork.ozlabs.org>; Thu, 26 Mar 2026 07:51:34 +1100 (AEDT)", "from localhost (localhost [127.0.0.1])\n\tby smtp1.osuosl.org (Postfix) with ESMTP id 9EFFB8169F;\n\tWed, 25 Mar 2026 20:51:32 +0000 (UTC)", "from smtp1.osuosl.org ([127.0.0.1])\n by localhost (smtp1.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP\n id gu6EEk5S7kKI; Wed, 25 Mar 2026 20:51:32 +0000 (UTC)", "from lists1.osuosl.org (lists1.osuosl.org [140.211.166.142])\n\tby smtp1.osuosl.org (Postfix) with ESMTP id 18887816A4;\n\tWed, 25 Mar 2026 20:51:32 +0000 (UTC)", "from smtp2.osuosl.org (smtp2.osuosl.org [140.211.166.133])\n by lists1.osuosl.org (Postfix) with ESMTP id 05A46F5\n for <intel-wired-lan@lists.osuosl.org>; Wed, 25 Mar 2026 20:51:29 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n by smtp2.osuosl.org (Postfix) with ESMTP id D688C40216\n for <intel-wired-lan@lists.osuosl.org>; Wed, 25 Mar 2026 20:51:29 +0000 (UTC)", "from smtp2.osuosl.org ([127.0.0.1])\n by localhost (smtp2.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP\n id T_1BocXsCbqt for <intel-wired-lan@lists.osuosl.org>;\n Wed, 25 Mar 2026 20:51:29 +0000 (UTC)", "from www2881.sakura.ne.jp (www2881.sakura.ne.jp [49.212.198.91])\n by smtp2.osuosl.org (Postfix) with ESMTPS id C82794008C\n for <intel-wired-lan@lists.osuosl.org>; Wed, 25 Mar 2026 20:51:28 +0000 (UTC)", "from ms-a2 (39.25.31.150.dy.iij4u.or.jp [150.31.25.39])\n (authenticated bits=0)\n by www2881.sakura.ne.jp (8.16.1/8.16.1) with ESMTPSA id 62PKou8B020293\n (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO);\n Thu, 26 Mar 2026 05:50:56 +0900 (JST) (envelope-from kohei@enjuk.jp)" ], "X-Virus-Scanned": [ "amavis at osuosl.org", "amavis at osuosl.org" ], "X-Comment": "SPF check N/A for local connections - client-ip=140.211.166.142;\n helo=lists1.osuosl.org; envelope-from=intel-wired-lan-bounces@osuosl.org;\n receiver=<UNKNOWN> ", "DKIM-Filter": [ "OpenDKIM Filter v2.11.0 smtp1.osuosl.org 18887816A4", "OpenDKIM Filter v2.11.0 smtp2.osuosl.org C82794008C" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=osuosl.org;\n\ts=default; t=1774471892;\n\tbh=e+ypmhgEo15svmjeaPLlvAZjVEpBxo8jHbFD3xFAMjM=;\n\th=From:To:Cc:Date:Subject:List-Id:List-Unsubscribe:List-Archive:\n\t List-Post:List-Help:List-Subscribe:From;\n\tb=ZfHha1ZlnfjKUZ91ySJViMp6HT3DzF8AMHsgJkIF2Rzz/+BKzMKKD+RrRlyF1N08v\n\t QWbmWrdQ1ZshNHpvu2I1MYzpkqJ/51kOMou0Bc/qZsfd0bGF57MNp05AWIDnVuo7rV\n\t VCSXyU32a4ROgC6OtnLV54xwYisVbr87ljPX1nNSR0S/3imn7A1bkaJfR4kSvPjARq\n\t eDu8RLOnLI7RCwTwaZ/juyNENqSv+PcW4yEC1xlICypy2L4s+w8ODk6UlItT54UzJz\n\t zAxIW6WGLsePsRApB72G8k76UCLvRHlwi7mSCE6HYvbOnB1FP8H7UHcBe4Ydc2rm/m\n\t fcRIXvu3P5PJw==", "Received-SPF": "Pass (mailfrom) identity=mailfrom; client-ip=49.212.198.91;\n helo=www2881.sakura.ne.jp; envelope-from=kohei@enjuk.jp; receiver=<UNKNOWN>", "DMARC-Filter": "OpenDMARC Filter v1.4.2 smtp2.osuosl.org C82794008C", "From": "Kohei Enju <kohei@enjuk.jp>", "To": "intel-wired-lan@lists.osuosl.org, netdev@vger.kernel.org", "Cc": "Tony Nguyen <anthony.l.nguyen@intel.com>,\n Przemek Kitszel <przemyslaw.kitszel@intel.com>,\n Andrew Lunn <andrew+netdev@lunn.ch>,\n \"David S. Miller\" <davem@davemloft.net>,\n Eric Dumazet <edumazet@google.com>, Jakub Kicinski <kuba@kernel.org>,\n Paolo Abeni <pabeni@redhat.com>, Shannon Nelson <sln@onemain.com>,\n Jesse Brandeburg <jesse.brandeburg@intel.com>, kohei.enju@gmail.com,\n Kohei Enju <kohei@enjuk.jp>", "Date": "Wed, 25 Mar 2026 20:50:06 +0000", "Message-ID": "<20260325205054.109822-1-kohei@enjuk.jp>", "X-Mailer": "git-send-email 2.51.0", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-Mailman-Original-DKIM-Signature": "a=rsa-sha256;\n bh=e+ypmhgEo15svmjeaPLlvAZjVEpBxo8jHbFD3xFAMjM=;\n c=relaxed/relaxed; d=enjuk.jp;\n h=From:Message-ID:To:Subject:Date;\n s=rs20251215; t=1774471856; v=1;\n b=lSUT0jRI1tAoWK5D8wckc74+l+HU26AoMJa853f/ULNa73hsWYW6Sk3J3x9pcD5y\n RIeaobmuvBF+s+DVLQYilGkBPgXs0AWQr6B0foQjHbWjgDBCHGDQdFBhleAWmTs3\n VuFeLz3y0/XQWGxreyXY55v/9KcfkpCeztMIFzb83ej5bVH4q2uzoQrtbQ2ImzCT\n H69am2/zMVOqKbaTRqFd7/Tn305KcKzvtSPto3nDh+fCVEtXZIACnKOZQYEvsAlj\n CWPMUae4CVUrNIZP65nz0xQG8OXoDnc4VxMqoek9v9jiiQEvdiMD63LhV3Fn4/CQ\n DRVhYrpsEVyqMgod0NUvbQ==", "X-Mailman-Original-Authentication-Results": [ "smtp2.osuosl.org;\n dmarc=pass (p=none dis=none)\n header.from=enjuk.jp", "smtp2.osuosl.org;\n dkim=pass (2048-bit key,\n unprotected) header.d=enjuk.jp header.i=@enjuk.jp header.a=rsa-sha256\n header.s=rs20251215 header.b=lSUT0jRI" ], "Subject": "[Intel-wired-lan] [PATCH iwl-net v1] i40e: don't advertise\n IFF_SUPP_NOFCS", "X-BeenThere": "intel-wired-lan@osuosl.org", "X-Mailman-Version": "2.1.30", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n <intel-wired-lan.osuosl.org>", "List-Unsubscribe": "<https://lists.osuosl.org/mailman/options/intel-wired-lan>,\n <mailto:intel-wired-lan-request@osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@osuosl.org?subject=help>", "List-Subscribe": "<https://lists.osuosl.org/mailman/listinfo/intel-wired-lan>,\n <mailto:intel-wired-lan-request@osuosl.org?subject=subscribe>", "Errors-To": "intel-wired-lan-bounces@osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@osuosl.org>" }, "content": "i40e advertises IFF_SUPP_NOFCS, allowing users to use the SO_NOFCS\nsocket option. However, this option is silently ignored, as the driver\ndoes not check skb->no_fcs, and always enables FCS insertion offload.\n\nFix this by removing the advertisement of IFF_SUPP_NOFCS.\n\nThis behavior can be reproduced with a simple AF_PACKET socket:\n\n import socket\n s = socket.socket(socket.AF_PACKET, socket.SOCK_RAW)\n s.setsockopt(socket.SOL_SOCKET, 43, 1) # SO_NOFCS\n s.bind((\"eth0\", 0))\n s.send(b'\\xff' * 64)\n\nPreviously, send() succeeds but the driver ignores SO_NOFCS.\nWith this change, send() fails with -EPROTONOSUPPORT, as expected.\n\nFixes: 41c445ff0f48 (\"i40e: main driver core\")\nSigned-off-by: Kohei Enju <kohei@enjuk.jp>\n---\n drivers/net/ethernet/intel/i40e/i40e_main.c | 1 -\n 1 file changed, 1 deletion(-)", "diff": "diff --git a/drivers/net/ethernet/intel/i40e/i40e_main.c b/drivers/net/ethernet/intel/i40e/i40e_main.c\nindex 3749f32ef95a..a3c52aa6255b 100644\n--- a/drivers/net/ethernet/intel/i40e/i40e_main.c\n+++ b/drivers/net/ethernet/intel/i40e/i40e_main.c\n@@ -13831,7 +13831,6 @@ static int i40e_config_netdev(struct i40e_vsi *vsi)\n \tnetdev->neigh_priv_len = sizeof(u32) * 4;\n \n \tnetdev->priv_flags |= IFF_UNICAST_FLT;\n-\tnetdev->priv_flags |= IFF_SUPP_NOFCS;\n \t/* Setup netdev TC information */\n \ti40e_vsi_config_netdev_tc(vsi, vsi->tc_config.enabled_tc);\n \n", "prefixes": [ "iwl-net", "v1" ] }