Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/2216104/?format=api
{ "id": 2216104, "url": "http://patchwork.ozlabs.org/api/patches/2216104/?format=api", "web_url": "http://patchwork.ozlabs.org/project/linux-pci/patch/20260325202720.389400-1-brodyengland3@gmail.com/", "project": { "id": 28, "url": "http://patchwork.ozlabs.org/api/projects/28/?format=api", "name": "Linux PCI development", "link_name": "linux-pci", "list_id": "linux-pci.vger.kernel.org", "list_email": "linux-pci@vger.kernel.org", "web_url": null, "scm_url": null, "webscm_url": null, "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20260325202720.389400-1-brodyengland3@gmail.com>", "list_archive_url": null, "date": "2026-03-25T20:27:20", "name": "PCI: cpcihp: Check pci_hp_add_bridge() return value", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "0c9e07f42d9ded900a18c3c6aea397f401669e6f", "submitter": { "id": 92970, "url": "http://patchwork.ozlabs.org/api/people/92970/?format=api", "name": "Brody England", "email": "brodyengland3@gmail.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/linux-pci/patch/20260325202720.389400-1-brodyengland3@gmail.com/mbox/", "series": [ { "id": 497509, "url": "http://patchwork.ozlabs.org/api/series/497509/?format=api", "web_url": "http://patchwork.ozlabs.org/project/linux-pci/list/?series=497509", "date": "2026-03-25T20:27:20", "name": "PCI: cpcihp: Check pci_hp_add_bridge() return value", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/497509/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2216104/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2216104/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "\n <linux-pci+bounces-51131-incoming=patchwork.ozlabs.org@vger.kernel.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "linux-pci@vger.kernel.org" ], "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256\n header.s=20251104 header.b=FGD26ZYV;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=2600:3c09:e001:a7::12fc:5321; helo=sto.lore.kernel.org;\n envelope-from=linux-pci+bounces-51131-incoming=patchwork.ozlabs.org@vger.kernel.org;\n receiver=patchwork.ozlabs.org)", "smtp.subspace.kernel.org;\n\tdkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com\n header.b=\"FGD26ZYV\"", "smtp.subspace.kernel.org;\n arc=none smtp.client-ip=74.125.82.174", "smtp.subspace.kernel.org;\n dmarc=pass (p=none dis=none) header.from=gmail.com", "smtp.subspace.kernel.org;\n spf=pass smtp.mailfrom=gmail.com" ], "Received": [ "from sto.lore.kernel.org (sto.lore.kernel.org\n [IPv6:2600:3c09:e001:a7::12fc:5321])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fgz4g2mzbz1y1x\n\tfor <incoming@patchwork.ozlabs.org>; Thu, 26 Mar 2026 07:28:19 +1100 (AEDT)", "from smtp.subspace.kernel.org (conduit.subspace.kernel.org\n [100.90.174.1])\n\tby sto.lore.kernel.org (Postfix) with ESMTP id 196763008266\n\tfor <incoming@patchwork.ozlabs.org>; Wed, 25 Mar 2026 20:27:28 +0000 (UTC)", "from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id 78B3623AE87;\n\tWed, 25 Mar 2026 20:27:25 +0000 (UTC)", "from mail-dy1-f174.google.com (mail-dy1-f174.google.com\n [74.125.82.174])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))\n\t(No client certificate requested)\n\tby smtp.subspace.kernel.org (Postfix) with ESMTPS id 34F81371054\n\tfor <linux-pci@vger.kernel.org>; Wed, 25 Mar 2026 20:27:24 +0000 (UTC)", "by mail-dy1-f174.google.com with SMTP id\n 5a478bee46e88-2c1092cc08cso676954eec.1\n for <linux-pci@vger.kernel.org>; Wed, 25 Mar 2026 13:27:24 -0700 (PDT)", "from brody-server.tail733610.ts.net ([65.173.245.48])\n by smtp.gmail.com with ESMTPSA id\n 5a478bee46e88-2c16ec815cesm643827eec.13.2026.03.25.13.27.22\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Wed, 25 Mar 2026 13:27:22 -0700 (PDT)" ], "ARC-Seal": "i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;\n\tt=1774470445; cv=none;\n b=MHwlFu/YPNWX05WahC/4m8CNpxwSlIIk4cJrkUFwcrlRl2YKeH14QxvMbKwX4iYGrD3GDyL7iVb83uMpGGKZnJCRbksE8yDJPIgazXPc9SlBcV3aWz79JjUTERmQjD2xLRsSv5U0i1HoPUzOi3vQ/yKop5t8aRciS9ggLeY5Gwc=", "ARC-Message-Signature": "i=1; a=rsa-sha256; d=subspace.kernel.org;\n\ts=arc-20240116; t=1774470445; c=relaxed/simple;\n\tbh=0onwSdC4aAc8cDI7zylJ8q/ArIAL1vgMBP4pvRTtjWg=;\n\th=From:To:Cc:Subject:Date:Message-ID:MIME-Version;\n b=lN27ubSXdxAMqOslzJd3VSdq07AnAASuz102i+uv227+wDc2LpYdfJhWnGGzK/gs8n1Ik4SJjVGob2dTWd7M7hovw0VD9u2Rmv3lN9MjmG4/zs5Wb7H+uVpu7VSdJEjJ59dfKitGDVoPSnK1SK+c3TKQ+DMOqJvyk3N9AIm2Rro=", "ARC-Authentication-Results": "i=1; smtp.subspace.kernel.org;\n dmarc=pass (p=none dis=none) header.from=gmail.com;\n spf=pass smtp.mailfrom=gmail.com;\n dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com\n header.b=FGD26ZYV; arc=none smtp.client-ip=74.125.82.174", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=gmail.com; s=20251104; t=1774470443; x=1775075243;\n darn=vger.kernel.org;\n h=content-transfer-encoding:mime-version:message-id:date:subject:cc\n :to:from:from:to:cc:subject:date:message-id:reply-to;\n bh=0O/c1TvyMvLhySUBvQSZ4Jz6C1ecY6F0Rr8Y+sdjF50=;\n b=FGD26ZYVPQ4zpvVHC9qHDdxgTR/vbfCn+Jj+7cq+R/UZ7wwBkBq6BPj0LEdTlgKET2\n ywwQqxv0IJ024c/0jJucjiUqVoPFfnS2zfssQiVurThqX8ZEphTmrhSLq9OIT9Y7zdlU\n anCKHragPnUuBQBbWwyUuA/bOg7hULNIMuOrwtLmqf7GkDw8xhMsQ7prAspN1d82YnMh\n 9Q6ETHfJGjDDAwomHEXEePLseoF1Ntbmo8oyrilApJtFAxfsWBjvS/Zr6fh9XDAeWeRf\n bvs0iEI7ataOaVgyqOvt8nPlcA32rHIkeYyxvcJIlAbPrmvaX4MsQ/gK8LN4X+DJSRtH\n R58w==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1774470443; x=1775075243;\n h=content-transfer-encoding:mime-version:message-id:date:subject:cc\n :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date\n :message-id:reply-to;\n bh=0O/c1TvyMvLhySUBvQSZ4Jz6C1ecY6F0Rr8Y+sdjF50=;\n b=MDAHfy2CV/J/he4SK2dZfIRmIRZ7auagTArroiFSjtCaa+j0Kizl9VfhURExgmySXV\n yPKiRH4yDNM5JKFdAvwCnIF5nWWko+RPtOKQ4JUN0JkqtlO8AQvUotfwxaccZnqVBUH+\n NBpqYotWE/7/ntWlnEu8zypXYav/8a64cQbNb3rMUsWOUELm+9Cg+im+eMtWL0QuPkb1\n RbQO77wzSMHz6mf+jExZzSYYtq1lY0KXHRdBPGVUzCPRx0jWKO1auCkbRZUeDusWdIV/\n RBHMElCdaAHz+4+54wR27IWCVAxwq57Geu5eO6r/I2VfATMQpjNd34zeoFswpZ5ZVGwq\n fSrg==", "X-Forwarded-Encrypted": "i=1;\n AJvYcCX3BKYjPLBtqlYVkfuoWpnBd4mhZJtSJYtzjPZuH/YVeNJW9uLJZgrC8qxx/KPQ3etWtKTqzlGWqrE=@vger.kernel.org", "X-Gm-Message-State": "AOJu0YwLKhw/OD+Jvc0T+/v1lJmNTe2AHnQUgLVEGPg7Nq8NShz26B9u\n\tuWREFhLZbYTko66AtuQJ8AJhgSUKby2XEpCOnkb017rOHDfDYeqjFrEm", "X-Gm-Gg": "ATEYQzzl96E50Nle0GGQupwJryDJ2TU8iqQPxzNOpy7UVRNAFbTiBwuRt6LjDntJyig\n\tgl82HH8gtyHB39oJ12KnnUU+6y+oV8th0oOhEckZNqlRTkuMdXyouLjz9P0xlrJcXhtP3dwrb3b\n\tDjrSsoWrA/UrAXbk6kz6koQRpP6lfJcxh8e8vDJ5IwaWXllzEPtd5lv12rhBj438tz6O5UngsLO\n\t4uXyBGjv3+CfC7mCeg9MNiphCo4T8q7NgigPMpwoboCZ8idvGJfKUQD8hLkXO6VX7wZM5afNmAD\n\tn0gm86VpW9oAPBUQPHpRHdDEKo/EkwXO/DmK9gHtqc+ifY1Ffu7Ya2WeoggfoJRe6KFOmqjeG/F\n\tjdu5HmpgihuQe/i2wPDDMtSAEQxw6sNc9VPxDppHRqqF/ho8kfv9qkecKJjfut0KhR9ihHht/VU\n\ty3GSKVNDcRVY6gw3jjMTfCUos/aY5EIlbrxoggoXeQfXO6snEDZNc=", "X-Received": "by 2002:a05:7300:6a95:b0:2c1:6eda:476c with SMTP id\n 5a478bee46e88-2c16eda4baemr434739eec.28.1774470443233;\n Wed, 25 Mar 2026 13:27:23 -0700 (PDT)", "From": "Brody England <brodyengland3@gmail.com>", "To": "scott@spiteful.org", "Cc": "bhelgaas@google.com,\n\tlinux-pci@vger.kernel.org,\n\tlinux-kernel@vger.kernel.org", "Subject": "[PATCH] PCI: cpcihp: Check pci_hp_add_bridge() return value", "Date": "Wed, 25 Mar 2026 13:27:20 -0700", "Message-ID": "<20260325202720.389400-1-brodyengland3@gmail.com>", "X-Mailer": "git-send-email 2.47.3", "Precedence": "bulk", "X-Mailing-List": "linux-pci@vger.kernel.org", "List-Id": "<linux-pci.vger.kernel.org>", "List-Subscribe": "<mailto:linux-pci+subscribe@vger.kernel.org>", "List-Unsubscribe": "<mailto:linux-pci+unsubscribe@vger.kernel.org>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit" }, "content": "cpci_configure_slot() ignores the return value of pci_hp_add_bridge()\nand continues with resource assignment and device addition even if\nbridge setup fails.\n\nCheck the return value, report the error, and abort slot configuration\nif adding the bridge fails.\n\nCompile-tested only.\n\nSigned-off-by: Brody England <brodyengland3@gmail.com>\n---\n drivers/pci/hotplug/cpci_hotplug_pci.c | 10 ++++++++--\n 1 file changed, 8 insertions(+), 2 deletions(-)", "diff": "diff --git a/drivers/pci/hotplug/cpci_hotplug_pci.c b/drivers/pci/hotplug/cpci_hotplug_pci.c\nindex 6c48066acb44..7ae02071e796 100644\n--- a/drivers/pci/hotplug/cpci_hotplug_pci.c\n+++ b/drivers/pci/hotplug/cpci_hotplug_pci.c\n@@ -269,8 +269,14 @@ int cpci_configure_slot(struct slot *slot)\n \tparent = slot->dev->bus;\n \n \tfor_each_pci_bridge(dev, parent) {\n-\t\tif (PCI_SLOT(dev->devfn) == PCI_SLOT(slot->devfn))\n-\t\t\tpci_hp_add_bridge(dev);\n+\t\tif (PCI_SLOT(dev->devfn) == PCI_SLOT(slot->devfn)) {\n+\t\t\tret = pci_hp_add_bridge(dev);\n+\t\t\tif (ret) {\n+\t\t\t\terr(\"Could not add hotplug bridge for slot %02x\",\n+\t\t\t\t slot->number);\n+\t\t\t\tgoto out;\n+\t\t\t}\n+\t\t}\n \t}\n \n \tpci_assign_unassigned_bridge_resources(parent->self);\n", "prefixes": [] }