Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/2216042/?format=api
{ "id": 2216042, "url": "http://patchwork.ozlabs.org/api/patches/2216042/?format=api", "web_url": "http://patchwork.ozlabs.org/project/buildroot/patch/20260325-linux-werror-v1-1-2b98ff2a2cdd@cherry.de/", "project": { "id": 27, "url": "http://patchwork.ozlabs.org/api/projects/27/?format=api", "name": "Buildroot development", "link_name": "buildroot", "list_id": "buildroot.buildroot.org", "list_email": "buildroot@buildroot.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20260325-linux-werror-v1-1-2b98ff2a2cdd@cherry.de>", "list_archive_url": null, "date": "2026-03-25T17:51:25", "name": "linux: allow the user to respect Linux kernel defconfig's CONFIG_WERROR", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "6004bafdbeee8aa0f0649b00cae087b501082d60", "submitter": { "id": 83602, "url": "http://patchwork.ozlabs.org/api/people/83602/?format=api", "name": "Quentin Schulz", "email": "foss+buildroot@0leil.net" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/buildroot/patch/20260325-linux-werror-v1-1-2b98ff2a2cdd@cherry.de/mbox/", "series": [ { "id": 497480, "url": "http://patchwork.ozlabs.org/api/series/497480/?format=api", "web_url": "http://patchwork.ozlabs.org/project/buildroot/list/?series=497480", "date": "2026-03-25T17:51:25", "name": "linux: allow the user to respect Linux kernel defconfig's CONFIG_WERROR", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/497480/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2216042/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2216042/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<buildroot-bounces@buildroot.org>", "X-Original-To": [ "incoming-buildroot@patchwork.ozlabs.org", "buildroot@buildroot.org" ], "Delivered-To": [ "patchwork-incoming-buildroot@legolas.ozlabs.org", "buildroot@buildroot.org" ], "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=buildroot.org header.i=@buildroot.org\n header.a=rsa-sha256 header.s=default header.b=WkkeNDva;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=buildroot.org\n (client-ip=140.211.166.138; helo=smtp1.osuosl.org;\n envelope-from=buildroot-bounces@buildroot.org; receiver=patchwork.ozlabs.org)" ], "Received": [ "from smtp1.osuosl.org (smtp1.osuosl.org [140.211.166.138])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fgvc12grVz1xy1\n\tfor <incoming-buildroot@patchwork.ozlabs.org>;\n Thu, 26 Mar 2026 04:51:45 +1100 (AEDT)", "from localhost (localhost [127.0.0.1])\n\tby smtp1.osuosl.org (Postfix) with ESMTP id 61E2580821;\n\tWed, 25 Mar 2026 17:51:42 +0000 (UTC)", "from smtp1.osuosl.org ([127.0.0.1])\n by localhost (smtp1.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP\n id Dv89ACpibIV4; Wed, 25 Mar 2026 17:51:41 +0000 (UTC)", "from lists1.osuosl.org (lists1.osuosl.org [140.211.166.142])\n\tby smtp1.osuosl.org (Postfix) with ESMTP id 3B75580994;\n\tWed, 25 Mar 2026 17:51:41 +0000 (UTC)", "from smtp1.osuosl.org (smtp1.osuosl.org [140.211.166.138])\n by lists1.osuosl.org (Postfix) with ESMTP id 739FF353\n for <buildroot@buildroot.org>; Wed, 25 Mar 2026 17:51:39 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n by smtp1.osuosl.org (Postfix) with ESMTP id 657B1819F5\n for <buildroot@buildroot.org>; Wed, 25 Mar 2026 17:51:39 +0000 (UTC)", "from smtp1.osuosl.org ([127.0.0.1])\n by localhost (smtp1.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP\n id B-5_6tXty6XB for <buildroot@buildroot.org>;\n Wed, 25 Mar 2026 17:51:38 +0000 (UTC)", "from smtp-190e.mail.infomaniak.ch (smtp-190e.mail.infomaniak.ch\n [185.125.25.14])\n by smtp1.osuosl.org (Postfix) with ESMTPS id E7E4C819D5\n for <buildroot@buildroot.org>; Wed, 25 Mar 2026 17:51:37 +0000 (UTC)", "from smtp-3-0000.mail.infomaniak.ch (unknown\n [IPv6:2001:1600:4:17::246b])\n by smtp-3-3000.mail.infomaniak.ch (Postfix) with ESMTPS id 4fgvbp1lnxzKpm;\n Wed, 25 Mar 2026 18:51:34 +0100 (CET)", "from unknown by smtp-3-0000.mail.infomaniak.ch (Postfix) with ESMTPA\n id 4fgvbn5jSxzd6J; Wed, 25 Mar 2026 18:51:33 +0100 (CET)" ], "X-Virus-Scanned": [ "amavis at osuosl.org", "amavis at osuosl.org" ], "X-Comment": "SPF check N/A for local connections - client-ip=140.211.166.142;\n helo=lists1.osuosl.org; envelope-from=buildroot-bounces@buildroot.org;\n receiver=<UNKNOWN> ", "DKIM-Filter": [ "OpenDKIM Filter v2.11.0 smtp1.osuosl.org 3B75580994", "OpenDKIM Filter v2.11.0 smtp1.osuosl.org E7E4C819D5" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=buildroot.org;\n\ts=default; t=1774461101;\n\tbh=NUQauyh1XTCfYB2Ue9UM16UDm8+KSNcpxaVm5DI+HtY=;\n\th=Date:To:Cc:Subject:List-Id:List-Unsubscribe:List-Archive:\n\t List-Post:List-Help:List-Subscribe:From:Reply-To:From;\n\tb=WkkeNDvac/VHrVnL80Xyn8wW+e6izm7/GYpb87y4qvC6tX4p6J9uKcGTDH8gKKE3t\n\t bwhg7it43i78ahMjyxjxvL4cZeQpkfh6fPKfR29DuO7pXnD6jhtIpM+PQAGTJAdJWT\n\t 3+tfKRGD0oZXyfT+JAXUePe5yTWkALdcQadJkMe/X8QwSCYgH5aKE4YFizShOnRiof\n\t jEXwmE95BrH4ovMmdX8zWgPEFvngs5OtxIgyz2Zt5i71QrNxL+aX+IhamjH0bNuEZO\n\t MOz3Pm1uB3slGCulmvBIh+upbadx32JhiaxL7wIQymcyZ2nQKoNJ6TtlHQ1qvat0So\n\t 8wY0xGm5eKQvw==", "Received-SPF": "Pass (mailfrom) identity=mailfrom; client-ip=185.125.25.14;\n helo=smtp-190e.mail.infomaniak.ch; envelope-from=foss+buildroot@0leil.net;\n receiver=<UNKNOWN>", "DMARC-Filter": "OpenDMARC Filter v1.4.2 smtp1.osuosl.org E7E4C819D5", "Date": "Wed, 25 Mar 2026 18:51:25 +0100", "MIME-Version": "1.0", "Message-Id": "<20260325-linux-werror-v1-1-2b98ff2a2cdd@cherry.de>", "X-B4-Tracking": "v=1; b=H4sIAAAAAAAC/yXMTQ5AMBBA4avIrDWpKglXEQs/U0akZKpIxN0Vy\n 2/x3gUOmdBBGV3AuJOjxQYkcQTd2NgBBfXBoKTKZaoyMZP1pziQeWFRmBx102vdSgMhWRkNnd+\n uqn87307Ybe8D7vsBjN0z13AAAAA=", "X-Change-ID": "20260325-linux-werror-9f6e4ad44b0f", "To": "buildroot@buildroot.org", "Cc": "Quentin Schulz <quentin.schulz@cherry.de>", "X-Mailer": "b4 0.15-dev-47773", "X-Infomaniak-Routing": "alpha", "X-Mailman-Original-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=0leil.net; s=20231125; t=1774461094;\n bh=c5LTU6ee/k6bUjb3dO9Hlcb6kpPSnYcT0kghqEkpiXk=;\n h=From:Date:Subject:To:Cc:From;\n b=H2k99MnKf2ACxnfRQ87RR8jiMqQuEdyey7lZgmEEwNvogt3bvbCG2fDgPFQ2M10yn\n nEMHMZslhZ0/zKa+fFd1YD+51exSk2ynkwOQutIm3V1CooB2J2aPAFF+82/XdRRXbz\n 7SwHDD6lmfOlQ5PRD5sboI8kWZDS7V/AUZAVRXj8ok8ufxPQLdVHiMH7ZyiN3Hpn35\n 52pY7408ShWeIj5F/5ouvCXtP0FJcTQPQ9KK8aHDxhjmyHmlek8nzBJVLo6WLWRLvk\n loXX15TlMqJ0Lg288qqf7UfiTuH4bLkRBEXK/vmOtFh/PyR2l0qop0lAt0iEnNLztX\n Pk2u0lbqWmwIg==", "X-Mailman-Original-Authentication-Results": [ "smtp1.osuosl.org;\n dmarc=pass (p=reject dis=none)\n header.from=0leil.net", "smtp1.osuosl.org;\n dkim=pass (2048-bit key,\n unprotected) header.d=0leil.net header.i=@0leil.net header.a=rsa-sha256\n header.s=20231125 header.b=H2k99MnK" ], "Subject": "[Buildroot] [PATCH] linux: allow the user to respect Linux kernel\n defconfig's CONFIG_WERROR", "X-BeenThere": "buildroot@buildroot.org", "X-Mailman-Version": "2.1.30", "Precedence": "list", "List-Id": "Discussion and development of buildroot <buildroot.buildroot.org>", "List-Unsubscribe": "<https://lists.buildroot.org/mailman/options/buildroot>,\n <mailto:buildroot-request@buildroot.org?subject=unsubscribe>", "List-Archive": "<http://lists.buildroot.org/pipermail/buildroot/>", "List-Post": "<mailto:buildroot@buildroot.org>", "List-Help": "<mailto:buildroot-request@buildroot.org?subject=help>", "List-Subscribe": "<https://lists.buildroot.org/mailman/listinfo/buildroot>,\n <mailto:buildroot-request@buildroot.org?subject=subscribe>", "From": "Quentin Schulz via buildroot <buildroot@buildroot.org>", "Reply-To": "Quentin Schulz <foss+buildroot@0leil.net>", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "buildroot-bounces@buildroot.org", "Sender": "\"buildroot\" <buildroot-bounces@buildroot.org>" }, "content": "From: Quentin Schulz <quentin.schulz@cherry.de>\n\nBuildroot forcibly disables WERROR (and PPC_WERROR via\nPPC_DISABLE_WERROR for PowerPC) for all kernels since commit\n6b56e0b4f09b (\"linux: disable -Werror\") for the former and 1713c3c344be\n(\"linux: disable Werror for powerpc kernels\") for the latter.\n\nSome users (me :) ) may only build kernels within Buildroot and may be\nrequired by audit companies to ensure that no warnings are generated\nwhen building them. While we could look at the log manually and report\nthat indeed no warnings are seen, better not even build if there's a\nwarning and catch them as early as possible.\n\nThus, let's allow the user to not override the WERROR state gotten from\nthe defconfig. It is left as force-disabled by default as upstream\nBuildroot likely does not want to fail builds when bumping the\ntoolchains with newer warnings and no bandwidth to fix or backport fixes\nfor kernels for upstream Buildroot defconfigs.\n\nSigned-off-by: Quentin Schulz <quentin.schulz@cherry.de>\n---\nI believe that commit 6b56e0b4f09b (\"linux: disable -Werror\") should\nrather have disabled WERROR from ESP_HOSTED_LINUX_CONFIG_FIXUPS in\npackage/esp-hosted/esp-hosted.mk instead of disabling it for everybody.\n\nI understand Buildroot not wanting to respect WERROR if in the kernel\ndefconfig to avoid additional friction when bumping toolchains, hence\nwhy I made this into a Kconfig knob.\n\nI'm assuming we do not want upstream Buildroot defconfigs to have this\nset to N. I can add this info to the Kconfig help text. I can also make\nsure defconfigs aren't setting this to N by adding a check in\nutils/checkpackagelib/lib_defconfig.py. Let me know if this is something\nyou're interested in.\n---\n linux/Config.in | 14 ++++++++++++++\n linux/linux.mk | 12 +++++++++---\n 2 files changed, 23 insertions(+), 3 deletions(-)\n\n\n---\nbase-commit: c8dd9e9a011f1a5755df62baceb865efc09862fe\nchange-id: 20260325-linux-werror-9f6e4ad44b0f\n\nBest regards,\n-- \nQuentin Schulz <quentin.schulz@cherry.de>", "diff": "diff --git a/linux/Config.in b/linux/Config.in\nindex 44f8b08e71..43397d52af 100644\n--- a/linux/Config.in\n+++ b/linux/Config.in\n@@ -223,6 +223,20 @@ config BR2_LINUX_KERNEL_CONFIG_FRAGMENT_FILES\n \t A space-separated list of kernel configuration fragment files,\n \t that will be merged to the main kernel configuration file.\n \n+config BR2_LINUX_KERNEL_DISABLE_WERROR\n+\tbool \"Force-disable Werror\"\n+\tdefault y\n+\thelp\n+\t This allows to force disable CONFIG_WERROR (and force enable\n+\t CONFIG_PPC_DISABLE_WERROR for PPC) even if set by the kernel\n+\t defconfig. This is typically wanted for third party kernel\n+\t trees or old kernel releases when attempting to build with\n+\t newer toolchains. Since 2019.08 for PPC and since 2024.05 for\n+\t the other architectures, the default has been Y.\n+\n+\t You may want to set this to N if you want to make sure your\n+\t kernel builds without warning for your specific setup.\n+\n config BR2_LINUX_KERNEL_CUSTOM_LOGO_PATH\n \tstring \"Custom boot logo file path\"\n \thelp\ndiff --git a/linux/linux.mk b/linux/linux.mk\nindex c61089bfe0..f7f2dfe107 100644\n--- a/linux/linux.mk\n+++ b/linux/linux.mk\n@@ -419,6 +419,14 @@ define LINUX_KCONFIG_FIXUP_CMDS_ROOTFS_CPIO\n endef\n endif\n \n+ifeq ($(BR2_LINUX_KERNEL_DISABLE_WERROR),y)\n+define LINUX_FIXUP_CONFIG_DISABLE_WERROR\n+\t$(if $(BR2_powerpc)$(BR2_powerpc64)$(BR2_powerpc64le),\n+\t\t$(call KCONFIG_ENABLE_OPT,CONFIG_PPC_DISABLE_WERROR))\n+\t$(call KCONFIG_DISABLE_OPT,CONFIG_WERROR)\n+endef\n+endif\n+\n define LINUX_KCONFIG_FIXUP_CMDS\n \t@$(call MESSAGE,\"Updating kernel config with fixups\")\n \t$(if $(LINUX_NEEDS_MODULES),\n@@ -431,8 +439,6 @@ define LINUX_KCONFIG_FIXUP_CMDS\n \t$(LINUX_FIXUP_CONFIG_PAHOLE_CHECK)\n \t$(if $(BR2_arm)$(BR2_armeb),\n \t\t$(call KCONFIG_ENABLE_OPT,CONFIG_AEABI))\n-\t$(if $(BR2_powerpc)$(BR2_powerpc64)$(BR2_powerpc64le),\n-\t\t$(call KCONFIG_ENABLE_OPT,CONFIG_PPC_DISABLE_WERROR))\n \t$(if $(BR2_ARC_PAGE_SIZE_4K),\n \t\t$(call KCONFIG_ENABLE_OPT,CONFIG_ARC_PAGE_SIZE_4K)\n \t\t$(call KCONFIG_DISABLE_OPT,CONFIG_ARC_PAGE_SIZE_8K)\n@@ -474,7 +480,7 @@ define LINUX_KCONFIG_FIXUP_CMDS\n \t\t$(call KCONFIG_ENABLE_OPT,CONFIG_LOGO)\n \t\t$(call KCONFIG_ENABLE_OPT,CONFIG_LOGO_LINUX_CLUT224))\n \t$(call KCONFIG_DISABLE_OPT,CONFIG_GCC_PLUGINS)\n-\t$(call KCONFIG_DISABLE_OPT,CONFIG_WERROR)\n+\t$(LINUX_FIXUP_CONFIG_DISABLE_WERROR)\n \t$(PACKAGES_LINUX_CONFIG_FIXUPS)\n endef\n \n", "prefixes": [] }