Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/2216001/?format=api
{ "id": 2216001, "url": "http://patchwork.ozlabs.org/api/patches/2216001/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20260325160231.1431929-1-ade@amicon.ru/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20260325160231.1431929-1-ade@amicon.ru>", "list_archive_url": null, "date": "2026-03-25T16:00:07", "name": "[net,v3] e1000: check return value of e1000_read_eeprom", "commit_ref": null, "pull_url": null, "state": "changes-requested", "archived": false, "hash": "162166b92f214b3531eacd7e8e9f1c9f33222585", "submitter": { "id": 92902, "url": "http://patchwork.ozlabs.org/api/people/92902/?format=api", "name": "Agalakov Daniil", "email": "ade@amicon.ru" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20260325160231.1431929-1-ade@amicon.ru/mbox/", "series": [ { "id": 497471, "url": "http://patchwork.ozlabs.org/api/series/497471/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/list/?series=497471", "date": "2026-03-25T16:00:07", "name": "[net,v3] e1000: check return value of e1000_read_eeprom", "version": 3, "mbox": "http://patchwork.ozlabs.org/series/497471/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2216001/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2216001/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@legolas.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=osuosl.org header.i=@osuosl.org header.a=rsa-sha256\n header.s=default header.b=3fPTjVVi;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=osuosl.org\n (client-ip=2605:bc80:3010::137; helo=smtp4.osuosl.org;\n envelope-from=intel-wired-lan-bounces@osuosl.org;\n receiver=patchwork.ozlabs.org)" ], "Received": [ "from smtp4.osuosl.org (smtp4.osuosl.org [IPv6:2605:bc80:3010::137])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fgsBq4vm6z1xy3\n\tfor <incoming@patchwork.ozlabs.org>; Thu, 26 Mar 2026 03:03:15 +1100 (AEDT)", "from localhost (localhost [127.0.0.1])\n\tby smtp4.osuosl.org (Postfix) with ESMTP id AC79640F19;\n\tWed, 25 Mar 2026 16:03:13 +0000 (UTC)", "from smtp4.osuosl.org ([127.0.0.1])\n by localhost (smtp4.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP\n id 5XiHXOyFxY0R; Wed, 25 Mar 2026 16:03:10 +0000 (UTC)", "from lists1.osuosl.org (lists1.osuosl.org [140.211.166.142])\n\tby smtp4.osuosl.org (Postfix) with ESMTP id 8085440C4D;\n\tWed, 25 Mar 2026 16:03:10 +0000 (UTC)", "from smtp3.osuosl.org (smtp3.osuosl.org [IPv6:2605:bc80:3010::136])\n by lists1.osuosl.org (Postfix) with ESMTP id 15A18F5\n for <intel-wired-lan@lists.osuosl.org>; Wed, 25 Mar 2026 16:03:09 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n by smtp3.osuosl.org (Postfix) with ESMTP id EED6860B01\n for <intel-wired-lan@lists.osuosl.org>; Wed, 25 Mar 2026 16:03:08 +0000 (UTC)", "from smtp3.osuosl.org ([127.0.0.1])\n by localhost (smtp3.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP\n id AOW8ROHoxGDR for <intel-wired-lan@lists.osuosl.org>;\n Wed, 25 Mar 2026 16:03:08 +0000 (UTC)", "from mail.amicon.ru (mail.amicon.ru [77.108.111.100])\n by smtp3.osuosl.org (Postfix) with ESMTPS id 99CF660B00\n for <intel-wired-lan@lists.osuosl.org>; Wed, 25 Mar 2026 16:03:06 +0000 (UTC)", "from example.com (172.16.2.46) by mail.amicon.lan (192.168.0.59)\n with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.27; Wed, 25 Mar\n 2026 19:03:03 +0300" ], "X-Virus-Scanned": [ "amavis at osuosl.org", "amavis at osuosl.org" ], "X-Comment": "SPF check N/A for local connections - client-ip=140.211.166.142;\n helo=lists1.osuosl.org; envelope-from=intel-wired-lan-bounces@osuosl.org;\n receiver=<UNKNOWN> ", "DKIM-Filter": [ "OpenDKIM Filter v2.11.0 smtp4.osuosl.org 8085440C4D", "OpenDKIM Filter v2.11.0 smtp3.osuosl.org 99CF660B00" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=osuosl.org;\n\ts=default; t=1774454590;\n\tbh=Go70odyKKD28YCWkaSUMl5gKwGR180E/V3Yo6aGp9yQ=;\n\th=From:To:CC:Date:In-Reply-To:References:Subject:List-Id:\n\t List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe:\n\t From;\n\tb=3fPTjVViEZlbBTWaSVgYV1OUQqFprg7NRY6+mDYAZbGIFARyP3RtA8v4tL/IugTtC\n\t ovaA1TN77b5FKymV0rubp816MvG6dibGdwXmvm9H/ZkoAQinxMixzDurmQrgo253jL\n\t DrOK+LcWOT9HeqxwBe6YqyPJT4Y3bOGU5mWeFg1vC6EsEO9QTiQxGBDCZ3ZGCMBTEt\n\t MkcKTdm2mTko60waJ3ybdHnl9UaSE34uML8WzGi7JmWbIIzmxnKha1ABfuzf3g6BBK\n\t eCqtrA5eZIfOtJtJnScDsmsY6Okjwt5sVGr5cpNm9dnpl+9v2gbgPe1QOS4CQiVnCH\n\t q/iBuQbIZyVWQ==", "Received-SPF": "Pass (mailfrom) identity=mailfrom; client-ip=77.108.111.100;\n helo=mail.amicon.ru; envelope-from=ade@amicon.ru; receiver=<UNKNOWN>", "DMARC-Filter": "OpenDMARC Filter v1.4.2 smtp3.osuosl.org 99CF660B00", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain", "From": "Agalakov Daniil <ade@amicon.ru>", "To": "Tony Nguyen <anthony.l.nguyen@intel.com>", "CC": "Agalakov Daniil <ade@amicon.ru>, Przemek Kitszel\n <przemyslaw.kitszel@intel.com>, Andrew Lunn <andrew+netdev@lunn.ch>, \"David\n S. Miller\" <davem@davemloft.net>, Eric Dumazet <edumazet@google.com>, \"Jakub\n Kicinski\" <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,\n <intel-wired-lan@lists.osuosl.org>, <netdev@vger.kernel.org>,\n <linux-kernel@vger.kernel.org>, <lvc-project@linuxtesting.org>, \"Daniil\n Iskhakov\" <dish@amicon.ru>, Roman Razov <rrv@amicon.ru>", "Date": "Wed, 25 Mar 2026 19:00:07 +0300", "Message-ID": "<20260325160231.1431929-1-ade@amicon.ru>", "X-Mailer": "git-send-email 2.51.0", "In-Reply-To": "<a70a49a0-43f8-4908-993a-50999bf0dfa8@intel.com>", "References": "<a70a49a0-43f8-4908-993a-50999bf0dfa8@intel.com>", "MIME-Version": "1.0", "X-Originating-IP": "[172.16.2.46]", "X-ClientProxiedBy": "mail.amicon.lan (192.168.0.59) To mail.amicon.lan\n (192.168.0.59)", "X-Mailman-Original-DKIM-Signature": "v=1; a=rsa-sha256; d=amicon.ru; s=mail;\n c=simple/simple;\n t=1774454583; h=from:subject:to:date:message-id;\n bh=03sGA4YSqaJAWjqStwtwmW5eSsQBADrXP8DO+DVWTos=;\n b=CRqFM5VIiOq0iJUi83p4CGxLQlUp81t+J0Xgftt5yuMOqE0stZrLI3xLTyzvWZcHjw8UUK0+zgB\n Ejfk5n6ViRmWUdnbZy6lXejYT78QZzYWvsqPk6/BhnnR9KexbIEgwGlwJ7/rNMkLyVmp3wM6Q8sGh\n y3ziU5dk468JPnf1rqLgjz/s8Y3VoqlzKvMtzJtA7et497DzG1tGbaOf9X82oRiDmFn7kc7/pR3IJ\n kut5LGM+DIi45Gy1au/cJoH/WNE++Z4vjKhCRRghD57sSX8w+HJmWmC4zY44lXE1dn1s5s9SstBSV\n 8L1+8XBvlNqeJPuIpV/bwSoA6ZkLFHxyOTQQ==", "X-Mailman-Original-Authentication-Results": [ "smtp3.osuosl.org;\n dmarc=pass (p=quarantine dis=none)\n header.from=amicon.ru", "smtp3.osuosl.org;\n dkim=pass (2048-bit key,\n unprotected) header.d=amicon.ru header.i=@amicon.ru header.a=rsa-sha256\n header.s=mail header.b=CRqFM5VI" ], "Subject": "[Intel-wired-lan] [PATCH net v3] e1000: check return value of\n e1000_read_eeprom", "X-BeenThere": "intel-wired-lan@osuosl.org", "X-Mailman-Version": "2.1.30", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n <intel-wired-lan.osuosl.org>", "List-Unsubscribe": "<https://lists.osuosl.org/mailman/options/intel-wired-lan>,\n <mailto:intel-wired-lan-request@osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@osuosl.org?subject=help>", "List-Subscribe": "<https://lists.osuosl.org/mailman/listinfo/intel-wired-lan>,\n <mailto:intel-wired-lan-request@osuosl.org?subject=subscribe>", "Errors-To": "intel-wired-lan-bounces@osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@osuosl.org>" }, "content": "[Why]\ne1000_set_eeprom() performs a read-modify-write operation when the write\nrange is not word-aligned. This requires reading the first and last words\nof the range from the EEPROM to preserve the unmodified bytes.\n\nHowever, the code does not check the return value of e1000_read_eeprom().\nIf the read fails, the operation continues using uninitialized data from\neeprom_buff. This results in corrupted data being written back to the\nEEPROM for the boundary words.\n\nAdd the missing error checks and abort the operation if reading fails.\n\nFound by Linux Verification Center (linuxtesting.org) with SVACE.\n\nFixes: 1da177e4c3f4 (\"Linux-2.6.12-rc2\")\nCo-developed-by: Iskhakov Daniil <dish@amicon.ru>\nSigned-off-by: Iskhakov Daniil <dish@amicon.ru>\nSigned-off-by: Agalakov Daniil <ade@amicon.ru>\n---\nv3:\n - Remove extra blank line.\n\nv2:\n - Split from original series.\n - Updated the error checking logic to be consistent with the\n implementation in the e1000e driver.\n\n drivers/net/ethernet/intel/e1000/e1000_ethtool.c | 4 ++++\n 1 file changed, 5 insertions(+)", "diff": "diff --git a/drivers/net/ethernet/intel/e1000/e1000_ethtool.c b/drivers/net/ethernet/intel/e1000/e1000_ethtool.c\nindex ab232b3fbbd0..3c3c6de95af7 100644\n--- a/drivers/net/ethernet/intel/e1000/e1000_ethtool.c\n+++ b/drivers/net/ethernet/intel/e1000/e1000_ethtool.c\n@@ -506,6 +506,9 @@ static int e1000_set_eeprom(struct net_device *netdev,\n \t\t\t\t\t &eeprom_buff[last_word - first_word]);\n \t}\n \n+\tif (ret_val)\n+\t\tgoto out;\n+\n \t/* Device's eeprom is always little-endian, word addressable */\n \tfor (i = 0; i < last_word - first_word + 1; i++)\n \t\tle16_to_cpus(&eeprom_buff[i]);\n@@ -522,6 +525,7 @@ static int e1000_set_eeprom(struct net_device *netdev,\n \tif ((ret_val == 0) && (first_word <= EEPROM_CHECKSUM_REG))\n \t\te1000_update_eeprom_checksum(hw);\n \n+out:\n \tkfree(eeprom_buff);\n \treturn ret_val;\n }\n", "prefixes": [ "net", "v3" ] }