Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/2215960/?format=api
{ "id": 2215960, "url": "http://patchwork.ozlabs.org/api/patches/2215960/?format=api", "web_url": "http://patchwork.ozlabs.org/project/linux-i2c/patch/20260325143555.451852-6-herve.codina@bootlin.com/", "project": { "id": 35, "url": "http://patchwork.ozlabs.org/api/projects/35/?format=api", "name": "Linux I2C development", "link_name": "linux-i2c", "list_id": "linux-i2c.vger.kernel.org", "list_email": "linux-i2c@vger.kernel.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20260325143555.451852-6-herve.codina@bootlin.com>", "list_archive_url": null, "date": "2026-03-25T14:35:32", "name": "[v6,05/27] bus: simple-pm-bus: Populate child nodes at probe", "commit_ref": null, "pull_url": null, "state": "not-applicable", "archived": false, "hash": "5cb0e5d5ba528fa93860b22d47bcebe178b1173b", "submitter": { "id": 81983, "url": "http://patchwork.ozlabs.org/api/people/81983/?format=api", "name": "Herve Codina", "email": "herve.codina@bootlin.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/linux-i2c/patch/20260325143555.451852-6-herve.codina@bootlin.com/mbox/", "series": [ { "id": 497455, "url": "http://patchwork.ozlabs.org/api/series/497455/?format=api", "web_url": "http://patchwork.ozlabs.org/project/linux-i2c/list/?series=497455", "date": "2026-03-25T14:35:31", "name": "lan966x pci device: Add support for SFPs", "version": 6, "mbox": "http://patchwork.ozlabs.org/series/497455/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2215960/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2215960/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "\n <linux-i2c+bounces-16747-incoming=patchwork.ozlabs.org@vger.kernel.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "linux-i2c@vger.kernel.org" ], "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=bootlin.com header.i=@bootlin.com header.a=rsa-sha256\n header.s=dkim header.b=m62ahB0C;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=172.234.253.10; helo=sea.lore.kernel.org;\n envelope-from=linux-i2c+bounces-16747-incoming=patchwork.ozlabs.org@vger.kernel.org;\n receiver=patchwork.ozlabs.org)", "smtp.subspace.kernel.org;\n\tdkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com\n header.b=\"m62ahB0C\"", "smtp.subspace.kernel.org;\n arc=none smtp.client-ip=185.246.85.4", "smtp.subspace.kernel.org;\n dmarc=pass (p=reject dis=none) header.from=bootlin.com", "smtp.subspace.kernel.org;\n spf=pass smtp.mailfrom=bootlin.com" ], "Received": [ "from sea.lore.kernel.org (sea.lore.kernel.org [172.234.253.10])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fgrGX011bz1xy1\n\tfor <incoming@patchwork.ozlabs.org>; Thu, 26 Mar 2026 02:21:23 +1100 (AEDT)", "from smtp.subspace.kernel.org (conduit.subspace.kernel.org\n [100.90.174.1])\n\tby sea.lore.kernel.org (Postfix) with ESMTP id 41917318C86D\n\tfor <incoming@patchwork.ozlabs.org>; Wed, 25 Mar 2026 14:38:52 +0000 (UTC)", "from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id BEF113E6DCC;\n\tWed, 25 Mar 2026 14:37:55 +0000 (UTC)", "from smtpout-03.galae.net (smtpout-03.galae.net [185.246.85.4])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby smtp.subspace.kernel.org (Postfix) with ESMTPS id BFD8F3E4C9B;\n\tWed, 25 Mar 2026 14:37:50 +0000 (UTC)", "from smtpout-01.galae.net (smtpout-01.galae.net [212.83.139.233])\n\tby smtpout-03.galae.net (Postfix) with ESMTPS id 671344E427EF;\n\tWed, 25 Mar 2026 14:37:49 +0000 (UTC)", "from mail.galae.net (mail.galae.net [212.83.136.155])\n\tby smtpout-01.galae.net (Postfix) with ESMTPS id 36F74601FA;\n\tWed, 25 Mar 2026 14:37:49 +0000 (UTC)", "from [127.0.0.1] (localhost [127.0.0.1]) by localhost (Mailerdaemon)\n with ESMTPSA id AE6F210451416;\n\tWed, 25 Mar 2026 15:37:28 +0100 (CET)" ], "ARC-Seal": "i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;\n\tt=1774449475; cv=none;\n b=Cq0vZnK6FSFWJx0MUVZmZbI+R3x3ob9c38macHfPpeqlAg4Yutf013QxLXVYPaK1BfxKtSGQBK+pWPfaJxSvQ82VpePZzcWmb8mAMT0fnBOpP+SVcRa67Ml74rnFB9E+z3pQrLLJPzNRkvBZGh8MT2COp/tLmAwHn5zew8g/y/g=", "ARC-Message-Signature": "i=1; a=rsa-sha256; d=subspace.kernel.org;\n\ts=arc-20240116; t=1774449475; c=relaxed/simple;\n\tbh=9WU6CnPwYf69YjJfs3q6iXeTR9MJC3N/+SMlykGezC0=;\n\th=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References:\n\t MIME-Version;\n b=T5uJrxhLTiH0hgNLlQg43CkuOhyuJy05Kax2CPmqSlV/uBtaeDL4BppEAS3LR3CHH+BidUYZW5NFaliPinx6EinNZlt2dWfmQmaM3sNXH4/K18V5mQ+aIbkU8am7/I5Oz/nFSIPkrwVqqXEH90AmCEi5xR801fiTF5V9u5dY6us=", "ARC-Authentication-Results": "i=1; smtp.subspace.kernel.org;\n dmarc=pass (p=reject dis=none) header.from=bootlin.com;\n spf=pass smtp.mailfrom=bootlin.com;\n dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com\n header.b=m62ahB0C; arc=none smtp.client-ip=185.246.85.4", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=dkim;\n\tt=1774449465; h=from:subject:date:message-id:to:cc:mime-version:\n\t content-transfer-encoding:in-reply-to:references;\n\tbh=FQEG+gi+2Owsvm5H07y7paCS6UXV8c60jAbpve0hKl8=;\n\tb=m62ahB0CVbVSXyRzaj89A96TBTVUsl3QaPdwwSz4hjzQmkXkz5moBnHKLWQ3c5d9uBM2RC\n\ts1jU5vtd69pR9AV4zKvymEGToEMVnY1l9kYhR62DwZXGqqPwk06uwzNsCZK1kW3ypmbRCF\n\trmoQVBgfMVdgNyKFWE1Qa5aGIzLVae1Ik50Cf6ihtlYUbrFz+ls6RMH3R6FGoiaX/orx2V\n\twzLs7iRiMz9hudgG/Rw8kDC9/SyNC26JP9GiJakS1Yw+k2WWJvweJRTrpvT4vU85jLq0e8\n\tQPyqwd0wiYgVNPuMQcX36ASXO+BoHi97BRRZkQadmG0Fol8WK+sQ/gjYj6ksoQ==", "From": "Herve Codina <herve.codina@bootlin.com>", "To": "Andrew Lunn <andrew@lunn.ch>,\n\tRob Herring <robh@kernel.org>,\n\tKrzysztof Kozlowski <krzk+dt@kernel.org>,\n\tConor Dooley <conor+dt@kernel.org>,\n\tGeert Uytterhoeven <geert+renesas@glider.be>,\n\tKalle Niemi <kaleposti@gmail.com>,\n\tMatti Vaittinen <mazziesaccount@gmail.com>,\n\tGreg Kroah-Hartman <gregkh@linuxfoundation.org>,\n\t\"Rafael J. Wysocki\" <rafael@kernel.org>,\n\tDanilo Krummrich <dakr@kernel.org>,\n\tFrank Li <Frank.Li@nxp.com>,\n\tSascha Hauer <s.hauer@pengutronix.de>,\n\tPengutronix Kernel Team <kernel@pengutronix.de>,\n\tFabio Estevam <festevam@gmail.com>,\n\tMichael Turquette <mturquette@baylibre.com>,\n\tStephen Boyd <sboyd@kernel.org>,\n\tAndi Shyti <andi.shyti@kernel.org>,\n\tWolfram Sang <wsa+renesas@sang-engineering.com>,\n\tPeter Rosin <peda@axentia.se>,\n\tArnd Bergmann <arnd@arndb.de>,\n\tHerve Codina <herve.codina@bootlin.com>,\n\tSaravana Kannan <saravanak@kernel.org>,\n\tBjorn Helgaas <bhelgaas@google.com>,\n\tCharles Keepax <ckeepax@opensource.cirrus.com>,\n\tRichard Fitzgerald <rf@opensource.cirrus.com>,\n\tDavid Rhodes <david.rhodes@cirrus.com>,\n\tLinus Walleij <linusw@kernel.org>,\n\tUlf Hansson <ulf.hansson@linaro.org>,\n\tMark Brown <broonie@kernel.org>,\n\tLen Brown <lenb@kernel.org>,\n\tAndy Shevchenko <andriy.shevchenko@linux.intel.com>,\n\tDaniel Scally <djrscally@gmail.com>,\n\tHeikki Krogerus <heikki.krogerus@linux.intel.com>,\n\tSakari Ailus <sakari.ailus@linux.intel.com>,\n\tDavidlohr Bueso <dave@stgolabs.net>,\n\tJonathan Cameron <jonathan.cameron@huawei.com>,\n\tDave Jiang <dave.jiang@intel.com>,\n\tAlison Schofield <alison.schofield@intel.com>,\n\tVishal Verma <vishal.l.verma@intel.com>,\n\tIra Weiny <ira.weiny@intel.com>,\n\tDan Williams <dan.j.williams@intel.com>,\n\tShawn Guo <shawnguo@kernel.org>", "Cc": "Wolfram Sang <wsa@kernel.org>,\n\tlinux-kernel@vger.kernel.org,\n\tdriver-core@lists.linux.dev,\n\timx@lists.linux.dev,\n\tlinux-arm-kernel@lists.infradead.org,\n\tlinux-clk@vger.kernel.org,\n\tlinux-i2c@vger.kernel.org,\n\tdevicetree@vger.kernel.org,\n\tlinux-pci@vger.kernel.org,\n\tlinux-sound@vger.kernel.org,\n\tpatches@opensource.cirrus.com,\n\tlinux-gpio@vger.kernel.org,\n\tlinux-pm@vger.kernel.org,\n\tlinux-spi@vger.kernel.org,\n\tlinux-acpi@vger.kernel.org,\n\tlinux-cxl@vger.kernel.org,\n\tAllan Nielsen <allan.nielsen@microchip.com>,\n\tHoratiu Vultur <horatiu.vultur@microchip.com>,\n\tSteen Hegelund <steen.hegelund@microchip.com>,\n\tLuca Ceresoli <luca.ceresoli@bootlin.com>,\n\tThomas Petazzoni <thomas.petazzoni@bootlin.com>", "Subject": "[PATCH v6 05/27] bus: simple-pm-bus: Populate child nodes at probe", "Date": "Wed, 25 Mar 2026 15:35:32 +0100", "Message-ID": "<20260325143555.451852-6-herve.codina@bootlin.com>", "X-Mailer": "git-send-email 2.53.0", "In-Reply-To": "<20260325143555.451852-1-herve.codina@bootlin.com>", "References": "<20260325143555.451852-1-herve.codina@bootlin.com>", "Precedence": "bulk", "X-Mailing-List": "linux-i2c@vger.kernel.org", "List-Id": "<linux-i2c.vger.kernel.org>", "List-Subscribe": "<mailto:linux-i2c+subscribe@vger.kernel.org>", "List-Unsubscribe": "<mailto:linux-i2c+unsubscribe@vger.kernel.org>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-Last-TLS-Session-Version": "TLSv1.3" }, "content": "The simple-pm-bus driver handles several simple busses. When it is used\nwith busses other than a compatible \"simple-pm-bus\", it doesn't populate\nits child devices during its probe.\n\nThis confuses fw_devlink and results in wrong or missing devlinks.\n\nOnce a driver is bound to a device and the probe() has been called,\ndevice_links_driver_bound() is called.\n\nThis function performs operation based on the following assumption:\n If a child firmware node of the bound device is not added as a\n device, it will never be added.\n\nAmong operations done on fw_devlinks of those \"never be added\" devices,\ndevice_links_driver_bound() changes their supplier.\n\nWith devices attached to a simple-bus compatible device, this change\nleads to wrong devlinks where supplier of devices points to the device\nparent (i.e. simple-bus compatible device) instead of the device itself\n(i.e. simple-bus child).\n\nWhen the device attached to the simple-bus is removed, because devlinks\nare not correct, its consumers are not removed first.\n\nIn order to have correct devlinks created, make the simple-pm-bus driver\ncompliant with the devlink assumption and create its child devices\nduring its probe.\n\nSigned-off-by: Herve Codina <herve.codina@bootlin.com>\n---\n drivers/bus/simple-pm-bus.c | 21 ++++++++++++---------\n 1 file changed, 12 insertions(+), 9 deletions(-)", "diff": "diff --git a/drivers/bus/simple-pm-bus.c b/drivers/bus/simple-pm-bus.c\nindex 9ebd588ea24f..30628958c923 100644\n--- a/drivers/bus/simple-pm-bus.c\n+++ b/drivers/bus/simple-pm-bus.c\n@@ -42,14 +42,15 @@ static int simple_pm_bus_probe(struct platform_device *pdev)\n \tmatch = of_match_device(dev->driver->of_match_table, dev);\n \t/*\n \t * These are transparent bus devices (not simple-pm-bus matches) that\n-\t * have their child nodes populated automatically. So, don't need to\n-\t * do anything more. We only match with the device if this driver is\n-\t * the most specific match because we don't want to incorrectly bind to\n-\t * a device that has a more specific driver.\n+\t * need to have their child nodes populated. So, don't need to do\n+\t * anything more except populate child nodes during this probe(). We\n+\t * only match with the device if this driver is the most specific match\n+\t * because we don't want to incorrectly bind to a device that has a more\n+\t * specific driver.\n \t */\n \tif (match && match->data) {\n \t\tif (of_property_match_string(np, \"compatible\", match->compatible) == 0)\n-\t\t\treturn 0;\n+\t\t\tgoto populate;\n \t\telse\n \t\t\treturn -ENODEV;\n \t}\n@@ -64,13 +65,14 @@ static int simple_pm_bus_probe(struct platform_device *pdev)\n \n \tdev_set_drvdata(&pdev->dev, bus);\n \n-\tdev_dbg(&pdev->dev, \"%s\\n\", __func__);\n-\n \tpm_runtime_enable(&pdev->dev);\n \n+populate:\n \tif (np)\n \t\tof_platform_populate(np, NULL, lookup, &pdev->dev);\n \n+\tdev_dbg(&pdev->dev, \"%s\\n\", __func__);\n+\n \treturn 0;\n }\n \n@@ -78,7 +80,7 @@ static void simple_pm_bus_remove(struct platform_device *pdev)\n {\n \tconst void *data = of_device_get_match_data(&pdev->dev);\n \n-\tif (pdev->driver_override || data)\n+\tif (pdev->driver_override)\n \t\treturn;\n \n \tdev_dbg(&pdev->dev, \"%s\\n\", __func__);\n@@ -86,7 +88,8 @@ static void simple_pm_bus_remove(struct platform_device *pdev)\n \tif (pdev->dev.of_node)\n \t\tof_platform_depopulate(&pdev->dev);\n \n-\tpm_runtime_disable(&pdev->dev);\n+\tif (!data)\n+\t\tpm_runtime_disable(&pdev->dev);\n }\n \n static int simple_pm_bus_runtime_suspend(struct device *dev)\n", "prefixes": [ "v6", "05/27" ] }