Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/2215958/?format=api
{ "id": 2215958, "url": "http://patchwork.ozlabs.org/api/patches/2215958/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20260325151728.45378-4-philmd@linaro.org/", "project": { "id": 14, "url": "http://patchwork.ozlabs.org/api/projects/14/?format=api", "name": "QEMU Development", "link_name": "qemu-devel", "list_id": "qemu-devel.nongnu.org", "list_email": "qemu-devel@nongnu.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20260325151728.45378-4-philmd@linaro.org>", "list_archive_url": null, "date": "2026-03-25T15:17:25", "name": "[PATCH-for-11.0?,3/6] qom: Declare GlobalProperty structure in 'qom/compat-properties.h'", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "88cf32ec9af99095729bc1347d2dc515ff16d18e", "submitter": { "id": 85046, "url": "http://patchwork.ozlabs.org/api/people/85046/?format=api", "name": "Philippe Mathieu-Daudé", "email": "philmd@linaro.org" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20260325151728.45378-4-philmd@linaro.org/mbox/", "series": [ { "id": 497463, "url": "http://patchwork.ozlabs.org/api/series/497463/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/list/?series=497463", "date": "2026-03-25T15:17:22", "name": "qom: Restrict compat properties API to system emulation", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/497463/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2215958/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2215958/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256\n header.s=google header.b=gDlBNZry;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)" ], "Received": [ "from lists.gnu.org (lists.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fgrCc03ycz1xy3\n\tfor <incoming@patchwork.ozlabs.org>; Thu, 26 Mar 2026 02:18:52 +1100 (AEDT)", "from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from <qemu-devel-bounces@nongnu.org>)\n\tid 1w5Pzm-0004mt-DC; Wed, 25 Mar 2026 11:18:10 -0400", "from eggs.gnu.org ([2001:470:142:3::10])\n by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <philmd@linaro.org>) id 1w5PzZ-0004ed-QP\n for qemu-devel@nongnu.org; Wed, 25 Mar 2026 11:18:00 -0400", "from mail-wm1-x332.google.com ([2a00:1450:4864:20::332])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)\n (Exim 4.90_1) (envelope-from <philmd@linaro.org>) id 1w5PzX-0008F3-Li\n for qemu-devel@nongnu.org; Wed, 25 Mar 2026 11:17:57 -0400", "by mail-wm1-x332.google.com with SMTP id\n 5b1f17b1804b1-486fe2024a9so39613595e9.0\n for <qemu-devel@nongnu.org>; Wed, 25 Mar 2026 08:17:55 -0700 (PDT)", "from localhost.localdomain (88-187-86-199.subs.proxad.net.\n [88.187.86.199]) by smtp.gmail.com with ESMTPSA id\n 5b1f17b1804b1-4871174f2cesm139322565e9.10.2026.03.25.08.17.52\n (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256);\n Wed, 25 Mar 2026 08:17:52 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=linaro.org; s=google; t=1774451874; x=1775056674; darn=nongnu.org;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:from:to:cc:subject:date\n :message-id:reply-to;\n bh=XA8bPid9+EKsdhouBQu4lXqcrGO4SDDhjT8ZDU7r9Ac=;\n b=gDlBNZryujxUPYMA8/BnVCijWZf0qp420J55G+vf7tKSN3x8Pqv3FIwmQo7jm5P000\n ELP//bkrzYHGVzV6jQXa39QuJffo/c43gXnhHDNRqLc2jfUv469WTQERcU7nVVfwu4xe\n 5Cq8GvnUqSNQ5NGjFSGs6BQBU1SAujyKmBGunygDutb6V9cnE43VFN2hGpluHS0UmvhP\n ry1wnnUtJYodjUlHqnT5jtKlH44HIPMCwBbppcPbGYqHx5213fvgJEjkTiClB19wBNgz\n mQ43h7ly8wDlkG7bZZUPB5Wp7VyFOU250iaM2EUr+KOokPkICGfMNrCb8909mzsovwzw\n Y60g==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1774451874; x=1775056674;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from\n :to:cc:subject:date:message-id:reply-to;\n bh=XA8bPid9+EKsdhouBQu4lXqcrGO4SDDhjT8ZDU7r9Ac=;\n b=hbUVswK3ZG+NdngZsY8SwE2rzKkRenpYR5MTh4AUWuhq7/cGBs8uXGbwOwHFZ2WEOU\n Gjao1BEu0swe0V9obe9LaqnZVejFOiJ4mBZiSeZdc9LWVd6TxDJ68LMoYubrQookr5mP\n FC2MIpLL50Q3l4SgfOeSLKJKdwLS+k9e4FXNh00hpVqDrUqQbSBmUJb56TZkftXFmdOM\n uvxqBjruNh97RRMUKblNCdBX+XpEGeNsR61eO+ABLGXi+YWSTSe3XU7AIqCCJ0uoq+Dz\n dU5WCIltWza3rLqQZU2gbQKV33L4ZWHjWEZVSmnlwI0OX1gnkWiu0XF2UL5uBbr5AgY1\n 6I/g==", "X-Forwarded-Encrypted": "i=1;\n AJvYcCXKt97bDfeJ82/palTKjoDD98agVgTUiQkaiLVR08vMu9CWg5/0iEgRnYazlImMcc+NxqCP89bkzSmg@nongnu.org", "X-Gm-Message-State": "AOJu0YxhjKc0tF2+z6kb0nERehdYYx4BE0NYqkUDIaw7v+JEgOWm0wDm\n /FgGoO4na0tlrLA4Z6OONspBpywKR66mdee+lw4Olb5E/2u/yIrPWXYc6ICgJWs5+PfzScKK4YV\n X2z/7iQE=", "X-Gm-Gg": "ATEYQzyUq+dU++tjwtcDzWnW2lVM+jci0jcNs1lU6U5EXUv8KYoFU741YGb4Gdc/eyd\n lqYORdX3cogQJitVb/e1B4bKTNk+wO/fZ29OyHfTMi1ga4Q7TrHXQE6qhEne5KlmW07I9TaV1OP\n Ux4oYoEWYBk88aOE1nBTge7cYVCnADFJ8J+kadYKNhYH9rwbV+hg5SsGqmTSsCZaoyLt20p5C5M\n e48jEhVlHgO6msEnd72DaQVfTy6edskdF5BAzGF6W9/fy4XFdqVI14h6NCk8O5VfYaqCWbuqEtm\n hgPIuiVrNjmoctaGqvyW4ImLABB/21yvMkzgRNkUmeddgrplnB9xThK+FSU/09lPYmMSTt0Rv+x\n SCOYQWSWtKjV93AUSsi5IkypdYaOMCZ5a1SabBF/VyWHOJv/b3gPKy0IQbQhEP13lgY6LxMmQxI\n xlBQP0QPFV0nxOk8pIFDrbWPNo/IZwHMKopmLRRIh8coyWUs1rETfjLs0auMjmo+DJPuIvnNp3", "X-Received": "by 2002:a05:600c:1f12:b0:486:fdca:ea8d with SMTP id\n 5b1f17b1804b1-48716050758mr55535255e9.25.1774451873986;\n Wed, 25 Mar 2026 08:17:53 -0700 (PDT)", "From": "=?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= <philmd@linaro.org>", "To": "Michael Tokarev <mjt@tls.msk.ru>,\n\tqemu-devel@nongnu.org", "Cc": "=?utf-8?q?Marc-Andr=C3=A9_Lureau?= <marcandre.lureau@redhat.com>,\n Richard Henderson <richard.henderson@linaro.org>, =?utf-8?q?Philippe_Mathie?=\n\t=?utf-8?q?u-Daud=C3=A9?= <philmd@linaro.org>, =?utf-8?q?Daniel_P=2E_Berrang?=\n\t=?utf-8?q?=C3=A9?= <berrange@redhat.com>,\n Paolo Bonzini <pbonzini@redhat.com>,\n =?utf-8?q?Alex_Benn=C3=A9e?= <alex.bennee@linaro.org>, kvm@vger.kernel.org,\n Marcel Apfelbaum <marcel.apfelbaum@gmail.com>,\n Yanan Wang <wangyanan55@huawei.com>, Zhao Liu <zhao1.liu@intel.com>", "Subject": "[PATCH-for-11.0? 3/6] qom: Declare GlobalProperty structure in\n 'qom/compat-properties.h'", "Date": "Wed, 25 Mar 2026 16:17:25 +0100", "Message-ID": "<20260325151728.45378-4-philmd@linaro.org>", "X-Mailer": "git-send-email 2.53.0", "In-Reply-To": "<20260325151728.45378-1-philmd@linaro.org>", "References": "<20260325151728.45378-1-philmd@linaro.org>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=UTF-8", "Content-Transfer-Encoding": "8bit", "Received-SPF": "pass client-ip=2a00:1450:4864:20::332;\n envelope-from=philmd@linaro.org; helo=mail-wm1-x332.google.com", "X-Spam_score_int": "-20", "X-Spam_score": "-2.1", "X-Spam_bar": "--", "X-Spam_report": "(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=ham autolearn_force=no", "X-Spam_action": "no action", "X-BeenThere": "qemu-devel@nongnu.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "qemu development <qemu-devel.nongnu.org>", "List-Unsubscribe": "<https://lists.nongnu.org/mailman/options/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>", "List-Archive": "<https://lists.nongnu.org/archive/html/qemu-devel>", "List-Post": "<mailto:qemu-devel@nongnu.org>", "List-Help": "<mailto:qemu-devel-request@nongnu.org?subject=help>", "List-Subscribe": "<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=subscribe>", "Errors-To": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org", "Sender": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org" }, "content": "While GlobalProperty is expected to only be used by QDev board\nlayer, it is used by the lower QOM API, so define it in the\nqom/ namespace. This helps to build binary which use QOM but\ndon't need the QDev layer.\n\nSigned-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>\n---\n include/hw/core/boards.h | 1 +\n include/hw/core/qdev-properties.h | 1 +\n include/hw/core/qdev.h | 17 ----------------\n include/qom/compat-properties.h | 32 +++++++++++++++++++++++++++++++\n qom/object.c | 2 +-\n 5 files changed, 35 insertions(+), 18 deletions(-)\n create mode 100644 include/qom/compat-properties.h", "diff": "diff --git a/include/hw/core/boards.h b/include/hw/core/boards.h\nindex b7138f2715e..ec8999c0e14 100644\n--- a/include/hw/core/boards.h\n+++ b/include/hw/core/boards.h\n@@ -8,6 +8,7 @@\n #include \"system/blockdev.h\"\n #include \"qapi/qapi-types-machine.h\"\n #include \"qemu/module.h\"\n+#include \"qom/compat-properties.h\"\n #include \"qom/object.h\"\n #include \"hw/core/cpu.h\"\n #include \"hw/core/resettable.h\"\ndiff --git a/include/hw/core/qdev-properties.h b/include/hw/core/qdev-properties.h\nindex d8745d4c65f..17543957a6c 100644\n--- a/include/hw/core/qdev-properties.h\n+++ b/include/hw/core/qdev-properties.h\n@@ -1,6 +1,7 @@\n #ifndef QEMU_QDEV_PROPERTIES_H\n #define QEMU_QDEV_PROPERTIES_H\n \n+#include \"qom/compat-properties.h\"\n #include \"hw/core/qdev.h\"\n \n /**\ndiff --git a/include/hw/core/qdev.h b/include/hw/core/qdev.h\nindex 778617787c7..337d69ea2c3 100644\n--- a/include/hw/core/qdev.h\n+++ b/include/hw/core/qdev.h\n@@ -404,23 +404,6 @@ struct BusState {\n ResettableState reset;\n };\n \n-/**\n- * typedef GlobalProperty - a global property type\n- *\n- * @used: Set to true if property was used when initializing a device.\n- * @optional: If set to true, GlobalProperty will be skipped without errors\n- * if the property doesn't exist.\n- *\n- * An error is fatal for non-hotplugged devices, when the global is applied.\n- */\n-typedef struct GlobalProperty {\n- const char *driver;\n- const char *property;\n- const char *value;\n- bool used;\n- bool optional;\n-} GlobalProperty;\n-\n /*** Board API. This should go away once we have a machine config file. ***/\n \n /**\ndiff --git a/include/qom/compat-properties.h b/include/qom/compat-properties.h\nnew file mode 100644\nindex 00000000000..6e44aabc26b\n--- /dev/null\n+++ b/include/qom/compat-properties.h\n@@ -0,0 +1,32 @@\n+/*\n+ * QEMU Object Model\n+ *\n+ * Copyright IBM, Corp. 2011\n+ *\n+ * Authors:\n+ * Anthony Liguori <aliguori@us.ibm.com>\n+ *\n+ * SPDX-License-Identifier: GPL-2.0-or-later\n+ */\n+\n+#ifndef QEMU_COMPAT_PROPERTIES_H\n+#define QEMU_COMPAT_PROPERTIES_H\n+\n+/**\n+ * typedef GlobalProperty - a global property type\n+ *\n+ * @used: Set to true if property was used when initializing a device.\n+ * @optional: If set to true, GlobalProperty will be skipped without errors\n+ * if the property doesn't exist.\n+ *\n+ * An error is fatal for non-hotplugged devices, when the global is applied.\n+ */\n+typedef struct GlobalProperty {\n+ const char *driver;\n+ const char *property;\n+ const char *value;\n+ bool used;\n+ bool optional;\n+} GlobalProperty;\n+\n+#endif\ndiff --git a/qom/object.c b/qom/object.c\nindex ff8ede8a328..838b1d2b225 100644\n--- a/qom/object.c\n+++ b/qom/object.c\n@@ -11,8 +11,8 @@\n */\n \n #include \"qemu/osdep.h\"\n-#include \"hw/core/qdev.h\"\n #include \"qapi/error.h\"\n+#include \"qom/compat-properties.h\"\n #include \"qom/object.h\"\n #include \"qom/object_interfaces.h\"\n #include \"qemu/cutils.h\"\n", "prefixes": [ "PATCH-for-11.0?", "3/6" ] }