Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/2215956/?format=api
{ "id": 2215956, "url": "http://patchwork.ozlabs.org/api/patches/2215956/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20260325151728.45378-5-philmd@linaro.org/", "project": { "id": 14, "url": "http://patchwork.ozlabs.org/api/projects/14/?format=api", "name": "QEMU Development", "link_name": "qemu-devel", "list_id": "qemu-devel.nongnu.org", "list_email": "qemu-devel@nongnu.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20260325151728.45378-5-philmd@linaro.org>", "list_archive_url": null, "date": "2026-03-25T15:17:26", "name": "[PATCH-for-11.0?,4/6] qom: Declare compat properties API in 'qom/compat-properties.h'", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "6cc45263408ee6e9883ef39ade2c08475dd2b1fc", "submitter": { "id": 85046, "url": "http://patchwork.ozlabs.org/api/people/85046/?format=api", "name": "Philippe Mathieu-Daudé", "email": "philmd@linaro.org" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20260325151728.45378-5-philmd@linaro.org/mbox/", "series": [ { "id": 497463, "url": "http://patchwork.ozlabs.org/api/series/497463/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/list/?series=497463", "date": "2026-03-25T15:17:22", "name": "qom: Restrict compat properties API to system emulation", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/497463/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2215956/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2215956/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256\n header.s=google header.b=dgc7cLLR;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)" ], "Received": [ "from lists.gnu.org (lists.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fgrCL3SBXz1yG1\n\tfor <incoming@patchwork.ozlabs.org>; Thu, 26 Mar 2026 02:18:38 +1100 (AEDT)", "from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from <qemu-devel-bounces@nongnu.org>)\n\tid 1w5Pzn-0004qj-Fs; Wed, 25 Mar 2026 11:18:11 -0400", "from eggs.gnu.org ([2001:470:142:3::10])\n by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <philmd@linaro.org>) id 1w5Pzi-0004kv-PH\n for qemu-devel@nongnu.org; Wed, 25 Mar 2026 11:18:08 -0400", "from mail-wm1-x336.google.com ([2a00:1450:4864:20::336])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)\n (Exim 4.90_1) (envelope-from <philmd@linaro.org>) id 1w5Pzg-0008Q4-7S\n for qemu-devel@nongnu.org; Wed, 25 Mar 2026 11:18:05 -0400", "by mail-wm1-x336.google.com with SMTP id\n 5b1f17b1804b1-486fd5360d4so30229295e9.1\n for <qemu-devel@nongnu.org>; Wed, 25 Mar 2026 08:18:02 -0700 (PDT)", "from localhost.localdomain (88-187-86-199.subs.proxad.net.\n [88.187.86.199]) by smtp.gmail.com with ESMTPSA id\n ffacd0b85a97d-43b919e265csm466393f8f.32.2026.03.25.08.17.59\n (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256);\n Wed, 25 Mar 2026 08:18:00 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=linaro.org; s=google; t=1774451882; x=1775056682; darn=nongnu.org;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:from:to:cc:subject:date\n :message-id:reply-to;\n bh=QxrAV8rmf30CF98liKz5B3rdomtAez5skkM9aGRME4I=;\n b=dgc7cLLR8UVmC8uoFDu+LeCwu1elh5cmVYIGeJgzF6Tq1+zSmFPD0O6ygCB7j9q3uH\n fBakTQojCGgCXRAqeJVulBp2cPbx7VwD2N4T3nvYarZkr86GyDKgopgZvH4IkPOYDdiO\n R5ZabHcAxRU3v+EF0IBwKVPGsQKrGJzf6637DgL5e8B5/hqFKtocdaBWdftZXZOuonfO\n GJQoxkviSqjqGiaVR2homItntotRoG8mX3RXr3tYEZ5j1boUhc5B1KnXnpxcmMPTVJrL\n KkB+mKVZDbvGCshwuo4OA48ojP6yDRNzaYgxykQgdyngTpqqoayyUNvJdypoTWOChYAh\n 2Yww==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1774451882; x=1775056682;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from\n :to:cc:subject:date:message-id:reply-to;\n bh=QxrAV8rmf30CF98liKz5B3rdomtAez5skkM9aGRME4I=;\n b=AU5AhuaFSpqjAtwE7UglxfiMR2nfOWrtA2wAR8rok6aq3YHGrIwg6JPpFkyJKzaequ\n 0SW6JLCxnokHSRe5k86/n8elc+CfibsbLdwxecSpRy8tAC3JtUi5agcyNgzHuDs1/E4X\n lpxIWFfMwRh2PojkPCX0R0Wp+kNTDyan4d1rOYjSuh5EJZbkUx73eUSVY7jAbA7/IwKG\n GUrOGMhtO5npT5ugvsOoqkYPpgdNiEH3kMAr+lAim3GvQt4GH53+mk5qw2mUDSkDtBdY\n JtOUHWUJhZFR3wZXefL75sRioWSwrRfu1l3AbVHuoOEQ33fuCU5yRQrfI6CrLzb9hZj+\n ITsA==", "X-Forwarded-Encrypted": "i=1;\n AJvYcCUgV6CqN6hPtRsWGTV40m+ZucHcs1h7yLsz6px4kDw8pUJm61kkznV3DleGD7QoMa41AWToKcW4Gwtx@nongnu.org", "X-Gm-Message-State": "AOJu0YwurXOccodE2SlxyPQeFv9vITIopKCFbkUcG0mVZvpU7lsUtUsP\n oFet//Xm38pJT8Shl9wLSv5A8zUJLL+6mXiGfJSmLI7wRFMY/cdJKN7HFLoaG7Aj0u0=", "X-Gm-Gg": "ATEYQzzMRwqaXs64hoIvO/EBoTwHY/p4FmGjh9C9Go3pxxPdz+A2L24YymakUqKuGgC\n 176rUAHq03xQ9VGkZzl5cd9bzev3V6nC8xw4GiMKaHRuJ4euEAA+claYXaU+iIaneWM8csJrf4T\n HUcAeueteO3HO7UDjmRU9petxUmRsVBQiLIicJtrWLFKLiO/4S/Kxju80jY3W+Pl4buy03O4n4E\n cK9saNUzXoVohzqAwHqDLgeRxF+KpiAaiO7l3mKl9Wht3YwsvwOVB/IRkPz4YtXE7Wjbe83I5eJ\n GI3Sddm9rQMkXW+9OvR7n1rAXhenJktpcSQ2MAGUnrRH7NOa/3C5Ut3cHepi3bRZbC3SgSM+eNC\n AU+LUjgHzhzWzGClb+1aOgeFPPCNGlDF7ZgQRlyslxaW5xEYh487GK/cKsY8xo0ZA7BZjNpRoxA\n Vws3sqEhmgw0FTsV1uJJXXiN6nzCB8Akdl3/xsZaOn3vmwzsl1OB6Yc7FpMh6WKCOTiGapqy4I", "X-Received": "by 2002:a05:600c:1e2a:b0:487:18c:7acf with SMTP id\n 5b1f17b1804b1-4871606d963mr61278415e9.25.1774451881686;\n Wed, 25 Mar 2026 08:18:01 -0700 (PDT)", "From": "=?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= <philmd@linaro.org>", "To": "Michael Tokarev <mjt@tls.msk.ru>,\n\tqemu-devel@nongnu.org", "Cc": "=?utf-8?q?Marc-Andr=C3=A9_Lureau?= <marcandre.lureau@redhat.com>,\n Richard Henderson <richard.henderson@linaro.org>, =?utf-8?q?Philippe_Mathie?=\n\t=?utf-8?q?u-Daud=C3=A9?= <philmd@linaro.org>, =?utf-8?q?Daniel_P=2E_Berrang?=\n\t=?utf-8?q?=C3=A9?= <berrange@redhat.com>,\n Paolo Bonzini <pbonzini@redhat.com>,\n =?utf-8?q?Alex_Benn=C3=A9e?= <alex.bennee@linaro.org>, kvm@vger.kernel.org,\n David Hildenbrand <david@kernel.org>, Igor Mammedov <imammedo@redhat.com>,\n Marcel Apfelbaum <marcel.apfelbaum@gmail.com>,\n Yanan Wang <wangyanan55@huawei.com>, Zhao Liu <zhao1.liu@intel.com>,\n \"Michael S. Tsirkin\" <mst@redhat.com>, Marcelo Tosatti <mtosatti@redhat.com>", "Subject": "[PATCH-for-11.0? 4/6] qom: Declare compat properties API in\n 'qom/compat-properties.h'", "Date": "Wed, 25 Mar 2026 16:17:26 +0100", "Message-ID": "<20260325151728.45378-5-philmd@linaro.org>", "X-Mailer": "git-send-email 2.53.0", "In-Reply-To": "<20260325151728.45378-1-philmd@linaro.org>", "References": "<20260325151728.45378-1-philmd@linaro.org>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=UTF-8", "Content-Transfer-Encoding": "8bit", "Received-SPF": "pass client-ip=2a00:1450:4864:20::336;\n envelope-from=philmd@linaro.org; helo=mail-wm1-x336.google.com", "X-Spam_score_int": "-20", "X-Spam_score": "-2.1", "X-Spam_bar": "--", "X-Spam_report": "(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=ham autolearn_force=no", "X-Spam_action": "no action", "X-BeenThere": "qemu-devel@nongnu.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "qemu development <qemu-devel.nongnu.org>", "List-Unsubscribe": "<https://lists.nongnu.org/mailman/options/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>", "List-Archive": "<https://lists.nongnu.org/archive/html/qemu-devel>", "List-Post": "<mailto:qemu-devel@nongnu.org>", "List-Help": "<mailto:qemu-devel-request@nongnu.org?subject=help>", "List-Subscribe": "<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=subscribe>", "Errors-To": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org", "Sender": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org" }, "content": "While most of QEMU files use the QOM concept, few of them\nuse the compatibility properties API (mostly use in system\nemulation). Move its prototype to a new \"qom/compat-properties.h\"\nheader, keeping \"qom/object.h\" for generic QOM.\n\nSigned-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>\n---\n include/qom/compat-properties.h | 8 ++++++++\n include/qom/object.h | 8 --------\n accel/accel-system.c | 1 +\n backends/hostmem.c | 1 +\n hw/core/machine.c | 1 +\n hw/core/qdev-properties.c | 1 +\n hw/core/qdev.c | 1 +\n hw/i386/pc_q35.c | 1 +\n system/rtc.c | 1 +\n system/vl.c | 1 +\n target/i386/sev.c | 1 +\n ui/vdagent.c | 1 +\n 12 files changed, 18 insertions(+), 8 deletions(-)", "diff": "diff --git a/include/qom/compat-properties.h b/include/qom/compat-properties.h\nindex 6e44aabc26b..90f8320adfd 100644\n--- a/include/qom/compat-properties.h\n+++ b/include/qom/compat-properties.h\n@@ -29,4 +29,12 @@ typedef struct GlobalProperty {\n bool optional;\n } GlobalProperty;\n \n+void object_set_machine_compat_props(GPtrArray *compat_props);\n+void object_set_accelerator_compat_props(GPtrArray *compat_props);\n+void object_register_sugar_prop(const char *driver, const char *prop,\n+ const char *value, bool optional);\n+void object_apply_compat_props(Object *obj);\n+bool object_apply_global_props(Object *obj, const GPtrArray *props,\n+ Error **errp);\n+\n #endif\ndiff --git a/include/qom/object.h b/include/qom/object.h\nindex 26df6137b91..510885218ba 100644\n--- a/include/qom/object.h\n+++ b/include/qom/object.h\n@@ -700,14 +700,6 @@ Object *object_new_with_propv(const char *typename,\n Error **errp,\n va_list vargs);\n \n-bool object_apply_global_props(Object *obj, const GPtrArray *props,\n- Error **errp);\n-void object_set_machine_compat_props(GPtrArray *compat_props);\n-void object_set_accelerator_compat_props(GPtrArray *compat_props);\n-void object_register_sugar_prop(const char *driver, const char *prop,\n- const char *value, bool optional);\n-void object_apply_compat_props(Object *obj);\n-\n /**\n * object_set_props:\n * @obj: the object instance to set properties on\ndiff --git a/accel/accel-system.c b/accel/accel-system.c\nindex 150af05bf5b..9176665202d 100644\n--- a/accel/accel-system.c\n+++ b/accel/accel-system.c\n@@ -25,6 +25,7 @@\n \n #include \"qemu/osdep.h\"\n #include \"qemu/accel.h\"\n+#include \"qom/compat-properties.h\"\n #include \"qapi/qapi-commands-accelerator.h\"\n #include \"monitor/monitor.h\"\n #include \"hw/core/boards.h\"\ndiff --git a/backends/hostmem.c b/backends/hostmem.c\nindex 15d4365b697..cd2085fb3cd 100644\n--- a/backends/hostmem.c\n+++ b/backends/hostmem.c\n@@ -18,6 +18,7 @@\n #include \"qapi/qapi-builtin-visit.h\"\n #include \"qapi/visitor.h\"\n #include \"qemu/config-file.h\"\n+#include \"qom/compat-properties.h\"\n #include \"qom/object_interfaces.h\"\n #include \"qemu/mmap-alloc.h\"\n #include \"qemu/madvise.h\"\ndiff --git a/hw/core/machine.c b/hw/core/machine.c\nindex 6cf0e2f404e..6290b3556ee 100644\n--- a/hw/core/machine.c\n+++ b/hw/core/machine.c\n@@ -21,6 +21,7 @@\n #include \"qapi/qapi-visit-machine.h\"\n #include \"qapi/qapi-commands-machine.h\"\n #include \"qemu/madvise.h\"\n+#include \"qom/compat-properties.h\"\n #include \"qom/object_interfaces.h\"\n #include \"system/cpus.h\"\n #include \"system/system.h\"\ndiff --git a/hw/core/qdev-properties.c b/hw/core/qdev-properties.c\nindex ba8461e9a42..73539c727b3 100644\n--- a/hw/core/qdev-properties.c\n+++ b/hw/core/qdev-properties.c\n@@ -10,6 +10,7 @@\n #include \"qemu/units.h\"\n #include \"qemu/cutils.h\"\n #include \"qdev-prop-internal.h\"\n+#include \"qom/compat-properties.h\"\n #include \"qom/qom-qobject.h\"\n \n void qdev_prop_set_after_realize(DeviceState *dev, const char *name,\ndiff --git a/hw/core/qdev.c b/hw/core/qdev.c\nindex e48616b2c6f..b36101f3a75 100644\n--- a/hw/core/qdev.c\n+++ b/hw/core/qdev.c\n@@ -32,6 +32,7 @@\n #include \"qapi/visitor.h\"\n #include \"qemu/error-report.h\"\n #include \"qemu/option.h\"\n+#include \"qom/compat-properties.h\"\n #include \"hw/core/irq.h\"\n #include \"hw/core/qdev-properties.h\"\n #include \"hw/core/boards.h\"\ndiff --git a/hw/i386/pc_q35.c b/hw/i386/pc_q35.c\nindex cb23322f5a4..6a0967ecd18 100644\n--- a/hw/i386/pc_q35.c\n+++ b/hw/i386/pc_q35.c\n@@ -56,6 +56,7 @@\n #include \"hw/usb/hcd-uhci.h\"\n #include \"qapi/error.h\"\n #include \"qemu/error-report.h\"\n+#include \"qom/compat-properties.h\"\n #include \"system/numa.h\"\n #include \"hw/hyperv/vmbus-bridge.h\"\n #include \"hw/mem/nvdimm.h\"\ndiff --git a/system/rtc.c b/system/rtc.c\nindex 56951288c40..f13dd392a76 100644\n--- a/system/rtc.c\n+++ b/system/rtc.c\n@@ -28,6 +28,7 @@\n #include \"qemu/error-report.h\"\n #include \"qemu/option.h\"\n #include \"qemu/timer.h\"\n+#include \"qom/compat-properties.h\"\n #include \"qom/object.h\"\n #include \"system/replay.h\"\n #include \"system/system.h\"\ndiff --git a/system/vl.c b/system/vl.c\nindex 38d7b849e0a..ec31fd76c0d 100644\n--- a/system/vl.c\n+++ b/system/vl.c\n@@ -119,6 +119,7 @@\n #include \"qapi/string-input-visitor.h\"\n #include \"qapi/opts-visitor.h\"\n #include \"qapi/clone-visitor.h\"\n+#include \"qom/compat-properties.h\"\n #include \"qom/object_interfaces.h\"\n #include \"semihosting/semihost.h\"\n #include \"crypto/init.h\"\ndiff --git a/target/i386/sev.c b/target/i386/sev.c\nindex 9dde972c118..261b6aaa37b 100644\n--- a/target/i386/sev.c\n+++ b/target/i386/sev.c\n@@ -36,6 +36,7 @@\n #include \"system/reset.h\"\n #include \"trace.h\"\n #include \"migration/blocker.h\"\n+#include \"qom/compat-properties.h\"\n #include \"qom/object.h\"\n #include \"monitor/monitor.h\"\n #include \"monitor/hmp.h\"\ndiff --git a/ui/vdagent.c b/ui/vdagent.c\nindex bb0c4aa14ca..bb55cbefc9c 100644\n--- a/ui/vdagent.c\n+++ b/ui/vdagent.c\n@@ -5,6 +5,7 @@\n #include \"qemu/error-report.h\"\n #include \"qemu/option.h\"\n #include \"qemu/units.h\"\n+#include \"qom/compat-properties.h\"\n #include \"hw/core/qdev.h\"\n #include \"hw/core/qdev-properties.h\"\n #include \"migration/blocker.h\"\n", "prefixes": [ "PATCH-for-11.0?", "4/6" ] }