Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/2215952/?format=api
{ "id": 2215952, "url": "http://patchwork.ozlabs.org/api/patches/2215952/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20260325151615.1407182-3-ade@amicon.ru/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20260325151615.1407182-3-ade@amicon.ru>", "list_archive_url": null, "date": "2026-03-25T15:16:04", "name": "[net-next,v2,2/2] e1000e: limit endianness conversion to boundary words", "commit_ref": null, "pull_url": null, "state": "changes-requested", "archived": false, "hash": "2d93917af0abc400f64fd196018ee3c048ecf48c", "submitter": { "id": 92902, "url": "http://patchwork.ozlabs.org/api/people/92902/?format=api", "name": "Agalakov Daniil", "email": "ade@amicon.ru" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20260325151615.1407182-3-ade@amicon.ru/mbox/", "series": [ { "id": 497462, "url": "http://patchwork.ozlabs.org/api/series/497462/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/list/?series=497462", "date": "2026-03-25T15:16:02", "name": "e1000/e1000e: limit endianness conversion to boundary words", "version": 2, "mbox": "http://patchwork.ozlabs.org/series/497462/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2215952/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2215952/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@legolas.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=osuosl.org header.i=@osuosl.org header.a=rsa-sha256\n header.s=default header.b=rreZt4GR;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=osuosl.org\n (client-ip=2605:bc80:3010::138; helo=smtp1.osuosl.org;\n envelope-from=intel-wired-lan-bounces@osuosl.org;\n receiver=patchwork.ozlabs.org)" ], "Received": [ "from smtp1.osuosl.org (smtp1.osuosl.org [IPv6:2605:bc80:3010::138])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fgr9K2WCJz1xy3\n\tfor <incoming@patchwork.ozlabs.org>; Thu, 26 Mar 2026 02:16:53 +1100 (AEDT)", "from localhost (localhost [127.0.0.1])\n\tby smtp1.osuosl.org (Postfix) with ESMTP id 3106D80DCF;\n\tWed, 25 Mar 2026 15:16:50 +0000 (UTC)", "from smtp1.osuosl.org ([127.0.0.1])\n by localhost (smtp1.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP\n id yo528GPFpvz8; Wed, 25 Mar 2026 15:16:49 +0000 (UTC)", "from lists1.osuosl.org (lists1.osuosl.org [140.211.166.142])\n\tby smtp1.osuosl.org (Postfix) with ESMTP id 9E46E80DF1;\n\tWed, 25 Mar 2026 15:16:49 +0000 (UTC)", "from smtp2.osuosl.org (smtp2.osuosl.org [IPv6:2605:bc80:3010::133])\n by lists1.osuosl.org (Postfix) with ESMTP id 3358F353\n for <intel-wired-lan@lists.osuosl.org>; Wed, 25 Mar 2026 15:16:48 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n by smtp2.osuosl.org (Postfix) with ESMTP id 520AF4014E\n for <intel-wired-lan@lists.osuosl.org>; Wed, 25 Mar 2026 15:16:47 +0000 (UTC)", "from smtp2.osuosl.org ([127.0.0.1])\n by localhost (smtp2.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP\n id SwWAGaFpArG1 for <intel-wired-lan@lists.osuosl.org>;\n Wed, 25 Mar 2026 15:16:46 +0000 (UTC)", "from mail.amicon.ru (mail.amicon.ru [77.108.111.100])\n by smtp2.osuosl.org (Postfix) with ESMTPS id 39C5D4009E\n for <intel-wired-lan@lists.osuosl.org>; Wed, 25 Mar 2026 15:16:46 +0000 (UTC)", "from example.com (172.16.2.46) by mail.amicon.lan (192.168.0.59)\n with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.27; Wed, 25 Mar\n 2026 18:16:40 +0300" ], "X-Virus-Scanned": [ "amavis at osuosl.org", "amavis at osuosl.org" ], "X-Comment": "SPF check N/A for local connections - client-ip=140.211.166.142;\n helo=lists1.osuosl.org; envelope-from=intel-wired-lan-bounces@osuosl.org;\n receiver=<UNKNOWN> ", "DKIM-Filter": [ "OpenDKIM Filter v2.11.0 smtp1.osuosl.org 9E46E80DF1", "OpenDKIM Filter v2.11.0 smtp2.osuosl.org 39C5D4009E" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=osuosl.org;\n\ts=default; t=1774451809;\n\tbh=AykiBgWTGZCmEG1OUiyg3JJRUJKAqcw2wf1No+Ajw+Q=;\n\th=From:To:CC:Date:In-Reply-To:References:Subject:List-Id:\n\t List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe:\n\t From;\n\tb=rreZt4GR2/vbKlzi8rXe565QKuqdAanHaPJbp4ualW/E37WTIMg55sYfOfclaJuVJ\n\t pXUXt2yBGXoU6lVnnCnOD6A21ll5QAXmUg8W5FVNkh6lL9i3uRyYVYQY+i4EKxdCQ5\n\t C3jItB3UtzlqWurObYiigr6F/iphhuZJep7XuNXUYXO5QVw8+/EfStiTU2iCXWqkBc\n\t JGz4/LodhdO5JEhsjtGGBOZt66FaCr5iR4XDkMCS+6DCwOPj5LciVPxdG6Kknr8dR2\n\t 6IBqFx2WjcC5X0N7hf25T088pP5Sz2FUGJN1sjWNJmJzlbHoTPnqzkR7l9vJv1Z4ic\n\t PdlIhAHUyj7rg==", "Received-SPF": "Pass (mailfrom) identity=mailfrom; client-ip=77.108.111.100;\n helo=mail.amicon.ru; envelope-from=ade@amicon.ru; receiver=<UNKNOWN>", "DMARC-Filter": "OpenDMARC Filter v1.4.2 smtp2.osuosl.org 39C5D4009E", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain", "From": "Agalakov Daniil <ade@amicon.ru>", "To": "Tony Nguyen <anthony.l.nguyen@intel.com>", "CC": "Agalakov Daniil <ade@amicon.ru>, Przemek Kitszel\n <przemyslaw.kitszel@intel.com>, Andrew Lunn <andrew+netdev@lunn.ch>, \"David\n S. Miller\" <davem@davemloft.net>, Eric Dumazet <edumazet@google.com>, \"Jakub\n Kicinski\" <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,\n <intel-wired-lan@lists.osuosl.org>, <netdev@vger.kernel.org>,\n <linux-kernel@vger.kernel.org>, <lvc-project@linuxtesting.org>, \"Daniil\n Iskhakov\" <dish@amicon.ru>, Roman Razov <rrv@amicon.ru>", "Date": "Wed, 25 Mar 2026 18:16:04 +0300", "Message-ID": "<20260325151615.1407182-3-ade@amicon.ru>", "X-Mailer": "git-send-email 2.51.0", "In-Reply-To": "<20260325151615.1407182-1-ade@amicon.ru>", "References": "<a70a49a0-43f8-4908-993a-50999bf0dfa8@intel.com>\n <20260325151615.1407182-1-ade@amicon.ru>", "MIME-Version": "1.0", "X-Originating-IP": "[172.16.2.46]", "X-ClientProxiedBy": "mail.amicon.lan (192.168.0.59) To mail.amicon.lan\n (192.168.0.59)", "X-Mailman-Original-DKIM-Signature": "v=1; a=rsa-sha256; d=amicon.ru; s=mail;\n c=simple/simple;\n t=1774451801; h=from:subject:to:date:message-id;\n bh=CCk76vE/xjR+yNkkzEFs2kbv/+OqHzHF8wQdMwc3Q+c=;\n b=A5C0Y/LVSQQHJPx1q2vu01IU5HhZXytE2wVXMcKZ5SboKny2Zh5XMXxtNd4VeJY+PcGWZ+/HCyw\n LyqXCQyorG5fKzj3ZeH0SZaGqC4DLNQ1fz1FexS0ybo5G5ngCgVi2PY6IIsxtafI0BNs+8Ris+QhW\n d4ngJs3tCGvD8KufBFpqyt/MNgaGvrRHdCzrmdxQDlcZVWDYjDoNd4QUJigt/Ddq+UqL3di1GMOGa\n aex9kbDq6Pv5LRy9yYI7fo6h6x2IEfZzMSDoOJTmFv3TxT+NmeY9KkXjB0ZwoAOuw5J6/TiOuOYaC\n fW1DocDPYclpEIU0273DX8lLLJiDwTZ3ftUQ==", "X-Mailman-Original-Authentication-Results": [ "smtp2.osuosl.org;\n dmarc=pass (p=quarantine dis=none)\n header.from=amicon.ru", "smtp2.osuosl.org;\n dkim=pass (2048-bit key) header.d=amicon.ru header.i=@amicon.ru\n header.a=rsa-sha256 header.s=mail header.b=A5C0Y/LV" ], "Subject": "[Intel-wired-lan] [PATCH net-next v2 2/2] e1000e: limit endianness\n conversion to boundary words", "X-BeenThere": "intel-wired-lan@osuosl.org", "X-Mailman-Version": "2.1.30", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n <intel-wired-lan.osuosl.org>", "List-Unsubscribe": "<https://lists.osuosl.org/mailman/options/intel-wired-lan>,\n <mailto:intel-wired-lan-request@osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@osuosl.org?subject=help>", "List-Subscribe": "<https://lists.osuosl.org/mailman/listinfo/intel-wired-lan>,\n <mailto:intel-wired-lan-request@osuosl.org?subject=subscribe>", "Errors-To": "intel-wired-lan-bounces@osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@osuosl.org>" }, "content": "[Why]\nIn e1000_set_eeprom(), the eeprom_buff is allocated to hold a range of\nwords. However, only the boundary words (the first and the last) are\npopulated from the EEPROM if the write request is not word-aligned.\nThe words in the middle of the buffer remain uninitialized because they\nare intended to be completely overwritten by the new data via memcpy().\n\nThe previous implementation had a loop that performed le16_to_cpus()\non the entire buffer. This resulted in endianness conversion being\nperformed on uninitialized memory for all interior words.\n\nFix this by converting the endianness only for the boundary words\nimmediately after they are successfully read from the EEPROM.\n\nFound by Linux Verification Center (linuxtesting.org) with SVACE.\n\nCo-developed-by: Iskhakov Daniil <dish@amicon.ru>\nSigned-off-by: Iskhakov Daniil <dish@amicon.ru>\nSigned-off-by: Agalakov Daniil <ade@amicon.ru>\n---\nv2:\n - Split from the original bugfix series and targeted at 'net-text'.\n - Removed the Fixes: tag; limiting the conversion scope is an\n improvement to avoid unnecessary processing of uninitialized memory.\n - Improved commit description for clarity.\n - Note on e1000e: this driver already contains the necessary return\n value checks for EEPROM reads, so only the endianness conversion\n cleanup is included for e1000e.\n\n drivers/net/ethernet/intel/e1000e/ethtool.c | 10 +++++++++-\n 1 file changed, 9 insertions(+), 1 deletion(-)", "diff": "diff --git a/drivers/net/ethernet/intel/e1000e/ethtool.c b/drivers/net/ethernet/intel/e1000e/ethtool.c\nindex dbed30943ef4..785d89477c43 100644\n--- a/drivers/net/ethernet/intel/e1000e/ethtool.c\n+++ b/drivers/net/ethernet/intel/e1000e/ethtool.c\n@@ -583,13 +583,21 @@ static int e1000_set_eeprom(struct net_device *netdev,\n \t\t/* need read/modify/write of first changed EEPROM word */\n \t\t/* only the second byte of the word is being modified */\n \t\tret_val = e1000_read_nvm(hw, first_word, 1, &eeprom_buff[0]);\n+\n+\t\t/* Device's eeprom is always little-endian, word addressable */\n+\t\tle16_to_cpus(&eeprom_buff[0]);\n+\n \t\tptr++;\n \t}\n-\tif (((eeprom->offset + eeprom->len) & 1) && (!ret_val))\n+\tif (((eeprom->offset + eeprom->len) & 1) && (!ret_val)) {\n \t\t/* need read/modify/write of last changed EEPROM word */\n \t\t/* only the first byte of the word is being modified */\n \t\tret_val = e1000_read_nvm(hw, last_word, 1,\n \t\t\t\t\t &eeprom_buff[last_word - first_word]);\n+\t\n+\t\t/* Device's eeprom is always little-endian, word addressable */\n+\t\tle16_to_cpus(&eeprom_buff[last_word - first_word]);\n+\t}\n \n \tif (ret_val)\n \t\tgoto out;\n", "prefixes": [ "net-next", "v2", "2/2" ] }