Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/2215949/?format=api
{ "id": 2215949, "url": "http://patchwork.ozlabs.org/api/patches/2215949/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20260325151132.1399812-1-ade@amicon.ru/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20260325151132.1399812-1-ade@amicon.ru>", "list_archive_url": null, "date": "2026-03-25T15:02:20", "name": "[net,v2] e1000: check return value of e1000_read_eeprom", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "4eaac46566abab878e530bf2c3f0b20db9008b30", "submitter": { "id": 92902, "url": "http://patchwork.ozlabs.org/api/people/92902/?format=api", "name": "Agalakov Daniil", "email": "ade@amicon.ru" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20260325151132.1399812-1-ade@amicon.ru/mbox/", "series": [ { "id": 497461, "url": "http://patchwork.ozlabs.org/api/series/497461/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/list/?series=497461", "date": "2026-03-25T15:02:20", "name": "[net,v2] e1000: check return value of e1000_read_eeprom", "version": 2, "mbox": "http://patchwork.ozlabs.org/series/497461/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2215949/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2215949/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@legolas.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=osuosl.org header.i=@osuosl.org header.a=rsa-sha256\n header.s=default header.b=3xGzWrHf;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=osuosl.org\n (client-ip=2605:bc80:3010::138; helo=smtp1.osuosl.org;\n envelope-from=intel-wired-lan-bounces@osuosl.org;\n receiver=patchwork.ozlabs.org)" ], "Received": [ "from smtp1.osuosl.org (smtp1.osuosl.org [IPv6:2605:bc80:3010::138])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fgr3l6n9pz1yG1\n\tfor <incoming@patchwork.ozlabs.org>; Thu, 26 Mar 2026 02:12:03 +1100 (AEDT)", "from localhost (localhost [127.0.0.1])\n\tby smtp1.osuosl.org (Postfix) with ESMTP id 877DE812AF;\n\tWed, 25 Mar 2026 15:12:02 +0000 (UTC)", "from smtp1.osuosl.org ([127.0.0.1])\n by localhost (smtp1.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP\n id SiKdrb0wXxS7; Wed, 25 Mar 2026 15:12:00 +0000 (UTC)", "from lists1.osuosl.org (lists1.osuosl.org [140.211.166.142])\n\tby smtp1.osuosl.org (Postfix) with ESMTP id 52CAA812AB;\n\tWed, 25 Mar 2026 15:12:00 +0000 (UTC)", "from smtp4.osuosl.org (smtp4.osuosl.org [IPv6:2605:bc80:3010::137])\n by lists1.osuosl.org (Postfix) with ESMTP id 977A2353\n for <intel-wired-lan@lists.osuosl.org>; Wed, 25 Mar 2026 15:11:58 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n by smtp4.osuosl.org (Postfix) with ESMTP id 7DAF94094A\n for <intel-wired-lan@lists.osuosl.org>; Wed, 25 Mar 2026 15:11:58 +0000 (UTC)", "from smtp4.osuosl.org ([127.0.0.1])\n by localhost (smtp4.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP\n id yZtox_Pyy9VP for <intel-wired-lan@lists.osuosl.org>;\n Wed, 25 Mar 2026 15:11:58 +0000 (UTC)", "from mail.amicon.ru (mail.amicon.ru [77.108.111.100])\n by smtp4.osuosl.org (Postfix) with ESMTPS id 84991408AD\n for <intel-wired-lan@lists.osuosl.org>; Wed, 25 Mar 2026 15:11:57 +0000 (UTC)", "from example.com (172.16.2.46) by mail.amicon.lan (192.168.0.59)\n with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.27; Wed, 25 Mar\n 2026 18:11:54 +0300" ], "X-Virus-Scanned": [ "amavis at osuosl.org", "amavis at osuosl.org" ], "X-Comment": "SPF check N/A for local connections - client-ip=140.211.166.142;\n helo=lists1.osuosl.org; envelope-from=intel-wired-lan-bounces@osuosl.org;\n receiver=<UNKNOWN> ", "DKIM-Filter": [ "OpenDKIM Filter v2.11.0 smtp1.osuosl.org 52CAA812AB", "OpenDKIM Filter v2.11.0 smtp4.osuosl.org 84991408AD" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=osuosl.org;\n\ts=default; t=1774451520;\n\tbh=sNiO1tOOzZPAzSYMCv/dEDIMcjY8ft8tB93nY+0ZPsg=;\n\th=From:To:CC:Date:In-Reply-To:References:Subject:List-Id:\n\t List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe:\n\t From;\n\tb=3xGzWrHfNwsR6ZoILcRd9R3ttgzoNZPBBn/IKWUihUoq4RDVB2DnSuv4PLOIRueTa\n\t zONopfEIIKYuQNiBGisFXN44LVXNuihDaoNWsDt21IR+ljilDopt2i2M8Bxf6znPoq\n\t 0jpey8+BuLouehcgejf6kzd0wlVJed/sSuQYsHioqtYeiL5Yob0JDMvPPcgUcr+fzq\n\t GhoXcA7K5B2A/uHoayqxWxsLRNx1RDwiwrcDyoCSn7jZUFlG5UQ0e65RQofEHNfznm\n\t Poz51zUWYQmluH3VcFAdOojncv0DYoLPtKHr6zXRKXy3uMsuMcd5JVYTsySuaEmake\n\t eFLKA/OOIjpMw==", "Received-SPF": "Pass (mailfrom) identity=mailfrom; client-ip=77.108.111.100;\n helo=mail.amicon.ru; envelope-from=ade@amicon.ru; receiver=<UNKNOWN>", "DMARC-Filter": "OpenDMARC Filter v1.4.2 smtp4.osuosl.org 84991408AD", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain", "From": "Agalakov Daniil <ade@amicon.ru>", "To": "Tony Nguyen <anthony.l.nguyen@intel.com>", "CC": "Agalakov Daniil <ade@amicon.ru>, Przemek Kitszel\n <przemyslaw.kitszel@intel.com>, Andrew Lunn <andrew+netdev@lunn.ch>, \"David\n S. Miller\" <davem@davemloft.net>, Eric Dumazet <edumazet@google.com>, \"Jakub\n Kicinski\" <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,\n <intel-wired-lan@lists.osuosl.org>, <netdev@vger.kernel.org>,\n <linux-kernel@vger.kernel.org>, <lvc-project@linuxtesting.org>, \"Daniil\n Iskhakov\" <dish@amicon.ru>, Roman Razov <rrv@amicon.ru>", "Date": "Wed, 25 Mar 2026 18:02:20 +0300", "Message-ID": "<20260325151132.1399812-1-ade@amicon.ru>", "X-Mailer": "git-send-email 2.51.0", "In-Reply-To": "<a70a49a0-43f8-4908-993a-50999bf0dfa8@intel.com>", "References": "<a70a49a0-43f8-4908-993a-50999bf0dfa8@intel.com>", "MIME-Version": "1.0", "X-Originating-IP": "[172.16.2.46]", "X-ClientProxiedBy": "mail.amicon.lan (192.168.0.59) To mail.amicon.lan\n (192.168.0.59)", "X-Mailman-Original-DKIM-Signature": "v=1; a=rsa-sha256; d=amicon.ru; s=mail;\n c=simple/simple;\n t=1774451514; h=from:subject:to:date:message-id;\n bh=AE2guXMBp5DQPNbyJ1WdoFUb172juDOs9bZKDoSilTQ=;\n b=EXaqtQB8KUspwu79iQIwBlh7uPDjwVNXL27lIYm1NdEKxdsJNzPjIToBnw9JESsy7HSIAO5HumS\n FpYEIVrVHHuRKJ2dp5c6JHN0Zi4YzCo7XqfK8FbkN2JKx98VqId1tKgbV8WXNhuf9+U3EG4+LI1+i\n yNsfeym+UQYduB57J7lksJltmgV86fSXZ3ek8PLtZQ1LL8I2Z0Rs+pSq8FABwl09FMPoKy0RWUMOL\n n7ziIINxNWFSSHXGnCsqjG0iWnPzIqiUwpwds3EIf/vePzmlQwn4Rhoau0C5u9Bjh8goNdgLQjE8L\n 3HN0Cyzm0aAwbKPuqHzG3eBNGJmJgwt5ZYPw==", "X-Mailman-Original-Authentication-Results": [ "smtp4.osuosl.org;\n dmarc=pass (p=quarantine dis=none)\n header.from=amicon.ru", "smtp4.osuosl.org;\n dkim=pass (2048-bit key,\n unprotected) header.d=amicon.ru header.i=@amicon.ru header.a=rsa-sha256\n header.s=mail header.b=EXaqtQB8" ], "Subject": "[Intel-wired-lan] [PATCH net v2] e1000: check return value of\n e1000_read_eeprom", "X-BeenThere": "intel-wired-lan@osuosl.org", "X-Mailman-Version": "2.1.30", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n <intel-wired-lan.osuosl.org>", "List-Unsubscribe": "<https://lists.osuosl.org/mailman/options/intel-wired-lan>,\n <mailto:intel-wired-lan-request@osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@osuosl.org?subject=help>", "List-Subscribe": "<https://lists.osuosl.org/mailman/listinfo/intel-wired-lan>,\n <mailto:intel-wired-lan-request@osuosl.org?subject=subscribe>", "Errors-To": "intel-wired-lan-bounces@osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@osuosl.org>" }, "content": "[Why]\ne1000_set_eeprom() performs a read-modify-write operation when the write\nrange is not word-aligned. This requires reading the first and last words\nof the range from the EEPROM to preserve the unmodified bytes.\n\nHowever, the code does not check the return value of e1000_read_eeprom().\nIf the read fails, the operation continues using uninitialized data from\neeprom_buff. This results in corrupted data being written back to the\nEEPROM for the boundary words.\n\nAdd the missing error checks and abort the operation if reading fails.\n\nFound by Linux Verification Center (linuxtesting.org) with SVACE.\n\nFixes: 1da177e4c3f4 (\"Linux-2.6.12-rc2\")\nCo-developed-by: Iskhakov Daniil <dish@amicon.ru>\nSigned-off-by: Iskhakov Daniil <dish@amicon.ru>\nSigned-off-by: Agalakov Daniil <ade@amicon.ru>\n---\nv2:\n - Split from original series.\n - Updated the error checking logic to be consistent with the\n implementation in the e1000e driver.\n\n drivers/net/ethernet/intel/e1000/e1000_ethtool.c | 5 +++++\n 1 file changed, 5 insertions(+)", "diff": "diff --git a/drivers/net/ethernet/intel/e1000/e1000_ethtool.c b/drivers/net/ethernet/intel/e1000/e1000_ethtool.c\nindex ab232b3fbbd0..a9c56505adcb 100644\n--- a/drivers/net/ethernet/intel/e1000/e1000_ethtool.c\n+++ b/drivers/net/ethernet/intel/e1000/e1000_ethtool.c\n@@ -506,6 +506,10 @@ static int e1000_set_eeprom(struct net_device *netdev,\n \t\t\t\t\t &eeprom_buff[last_word - first_word]);\n \t}\n \n+\tif (ret_val)\n+\t\tgoto out;\n+\n+\n \t/* Device's eeprom is always little-endian, word addressable */\n \tfor (i = 0; i < last_word - first_word + 1; i++)\n \t\tle16_to_cpus(&eeprom_buff[i]);\n@@ -522,6 +526,7 @@ static int e1000_set_eeprom(struct net_device *netdev,\n \tif ((ret_val == 0) && (first_word <= EEPROM_CHECKSUM_REG))\n \t\te1000_update_eeprom_checksum(hw);\n \n+out:\n \tkfree(eeprom_buff);\n \treturn ret_val;\n }\n", "prefixes": [ "net", "v2" ] }