Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/2215948/?format=api
{ "id": 2215948, "url": "http://patchwork.ozlabs.org/api/patches/2215948/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20260325151050.2081977-1-poros@redhat.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20260325151050.2081977-1-poros@redhat.com>", "list_archive_url": null, "date": "2026-03-25T15:10:50", "name": "[iwl-net] ice: fix U.FL pin state set affecting paired SMA pin", "commit_ref": null, "pull_url": null, "state": "under-review", "archived": false, "hash": "fd03a056c4c34e7db3dbab17a5eadb03ed9c46d8", "submitter": { "id": 74657, "url": "http://patchwork.ozlabs.org/api/people/74657/?format=api", "name": "Petr Oros", "email": "poros@redhat.com" }, "delegate": { "id": 109701, "url": "http://patchwork.ozlabs.org/api/users/109701/?format=api", "username": "anguy11", "first_name": "Anthony", "last_name": "Nguyen", "email": "anthony.l.nguyen@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20260325151050.2081977-1-poros@redhat.com/mbox/", "series": [ { "id": 497460, "url": "http://patchwork.ozlabs.org/api/series/497460/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/list/?series=497460", "date": "2026-03-25T15:10:50", "name": "[iwl-net] ice: fix U.FL pin state set affecting paired SMA pin", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/497460/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2215948/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2215948/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@legolas.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=osuosl.org header.i=@osuosl.org header.a=rsa-sha256\n header.s=default header.b=uPqtUsqA;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=osuosl.org\n (client-ip=2605:bc80:3010::138; helo=smtp1.osuosl.org;\n envelope-from=intel-wired-lan-bounces@osuosl.org;\n receiver=patchwork.ozlabs.org)" ], "Received": [ "from smtp1.osuosl.org (smtp1.osuosl.org [IPv6:2605:bc80:3010::138])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fgr374X7hz1y1K\n\tfor <incoming@patchwork.ozlabs.org>; Thu, 26 Mar 2026 02:11:31 +1100 (AEDT)", "from localhost (localhost [127.0.0.1])\n\tby smtp1.osuosl.org (Postfix) with ESMTP id 1C0E28221D;\n\tWed, 25 Mar 2026 15:11:30 +0000 (UTC)", "from smtp1.osuosl.org ([127.0.0.1])\n by localhost (smtp1.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP\n id DDsAvjNFjGfq; Wed, 25 Mar 2026 15:11:28 +0000 (UTC)", "from lists1.osuosl.org (lists1.osuosl.org [140.211.166.142])\n\tby smtp1.osuosl.org (Postfix) with ESMTP id B4862821F7;\n\tWed, 25 Mar 2026 15:11:28 +0000 (UTC)", "from smtp4.osuosl.org (smtp4.osuosl.org [IPv6:2605:bc80:3010::137])\n by lists1.osuosl.org (Postfix) with ESMTP id 3F97D1D3\n for <intel-wired-lan@lists.osuosl.org>; Wed, 25 Mar 2026 15:11:27 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n by smtp4.osuosl.org (Postfix) with ESMTP id 2E79D4094A\n for <intel-wired-lan@lists.osuosl.org>; Wed, 25 Mar 2026 15:11:27 +0000 (UTC)", "from smtp4.osuosl.org ([127.0.0.1])\n by localhost (smtp4.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP\n id k6uVGSQ91AUH for <intel-wired-lan@lists.osuosl.org>;\n Wed, 25 Mar 2026 15:11:26 +0000 (UTC)", "from us-smtp-delivery-124.mimecast.com\n (us-smtp-delivery-124.mimecast.com [170.10.129.124])\n by smtp4.osuosl.org (Postfix) with ESMTPS id 229D2407EA\n for <intel-wired-lan@lists.osuosl.org>; Wed, 25 Mar 2026 15:11:25 +0000 (UTC)", "from mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com\n (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by\n relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3,\n cipher=TLS_AES_256_GCM_SHA384) id us-mta-101-xN6BkXvYN_6RTTSwpmcFdA-1; Wed,\n 25 Mar 2026 11:11:19 -0400", "from mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com\n (mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.4])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n (No client certificate requested)\n by mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS\n id 5C04B180894D; Wed, 25 Mar 2026 15:11:11 +0000 (UTC)", "from ShadowPeak.redhat.com (unknown [10.45.224.50])\n by mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP\n id C72C43000223; Wed, 25 Mar 2026 15:11:06 +0000 (UTC)" ], "X-Virus-Scanned": [ "amavis at osuosl.org", "amavis at osuosl.org" ], "X-Comment": "SPF check N/A for local connections - client-ip=140.211.166.142;\n helo=lists1.osuosl.org; envelope-from=intel-wired-lan-bounces@osuosl.org;\n receiver=<UNKNOWN> ", "DKIM-Filter": [ "OpenDKIM Filter v2.11.0 smtp1.osuosl.org B4862821F7", "OpenDKIM Filter v2.11.0 smtp4.osuosl.org 229D2407EA" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=osuosl.org;\n\ts=default; t=1774451488;\n\tbh=jbo0Ad/kP5wlt8QZq7dLLcRaxS2hXarbNY4mrADEEb4=;\n\th=From:To:Date:Subject:List-Id:List-Unsubscribe:List-Archive:\n\t List-Post:List-Help:List-Subscribe:Cc:From;\n\tb=uPqtUsqA3p+6uTgAdKJFeVUlLbHeNjFb54yowXVknKCfwq7e2fDECNUd7JHiYkpnM\n\t ayd5DKqKXNEx7bWwyYHrqME20CAgXCbRn6gsxI7kms7VMyOdJmXwRCBxvUI6T05UCr\n\t N8C/3YWhsVhnLajSMrbONZmAKLVIBLUj5634JZB0KPuPd/A4I0Far2rDtx0jD+Lg1+\n\t Ym4sOZVv4uGIL/f/n8HQkF9VhKyuX3/YAWnb6JjCwEg7ulfxaKpw7txFeyAX7jwB0M\n\t PG1SPSgmh70SUtwX99sUC9baDOOOX/DQGwKxG2DMoipGUm2Fv/02US9W5+81NNMoRV\n\t Bo6wNwjGXhvSQ==", "Received-SPF": "Pass (mailfrom) identity=mailfrom; client-ip=170.10.129.124;\n helo=us-smtp-delivery-124.mimecast.com; envelope-from=poros@redhat.com;\n receiver=<UNKNOWN>", "DMARC-Filter": "OpenDMARC Filter v1.4.2 smtp4.osuosl.org 229D2407EA", "X-MC-Unique": "xN6BkXvYN_6RTTSwpmcFdA-1", "X-Mimecast-MFC-AGG-ID": "xN6BkXvYN_6RTTSwpmcFdA_1774451475", "From": "Petr Oros <poros@redhat.com>", "To": "netdev@vger.kernel.org", "Date": "Wed, 25 Mar 2026 16:10:50 +0100", "Message-ID": "<20260325151050.2081977-1-poros@redhat.com>", "MIME-Version": "1.0", "X-Scanned-By": "MIMEDefang 3.4.1 on 10.30.177.4", "X-Mimecast-MFC-PROC-ID": "HgaG6XmigYSJYfXCw4E_wJj4imKrrHp9jG7hyylGsRM_1774451475", "X-Mimecast-Originator": "redhat.com", "Content-Transfer-Encoding": "8bit", "content-type": "text/plain; charset=\"US-ASCII\"; x-default=true", "X-Mailman-Original-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=redhat.com;\n s=mimecast20190719; t=1774451484;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:cc:mime-version:mime-version:content-type:content-type:\n content-transfer-encoding:content-transfer-encoding;\n bh=jbo0Ad/kP5wlt8QZq7dLLcRaxS2hXarbNY4mrADEEb4=;\n b=GYMQwIi8oObxlivsekOGftb+0cxyPlhZdl2xCaOPvwA8oH1krIkrrKZqWKTahPYTuW9lq+\n 6jLtRArWwk5lxO2rUkii2fugjRO1vMvTu12Ht+5OKby6LWvTceQP6vouG3Ehpibe8Wcvam\n Z3ND+W+WwRtHD55L4KnTeaQmCASx6mo=", "X-Mailman-Original-Authentication-Results": [ "smtp4.osuosl.org;\n dmarc=pass (p=quarantine dis=none)\n header.from=redhat.com", "smtp4.osuosl.org;\n dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com\n header.a=rsa-sha256 header.s=mimecast20190719 header.b=GYMQwIi8" ], "Subject": "[Intel-wired-lan] [PATCH iwl-net] ice: fix U.FL pin state set\n affecting paired SMA pin", "X-BeenThere": "intel-wired-lan@osuosl.org", "X-Mailman-Version": "2.1.30", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n <intel-wired-lan.osuosl.org>", "List-Unsubscribe": "<https://lists.osuosl.org/mailman/options/intel-wired-lan>,\n <mailto:intel-wired-lan-request@osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@osuosl.org?subject=help>", "List-Subscribe": "<https://lists.osuosl.org/mailman/listinfo/intel-wired-lan>,\n <mailto:intel-wired-lan-request@osuosl.org?subject=subscribe>", "Cc": "Vadim Fedorenko <vadim.fedorenko@linux.dev>,\n Michal Michalik <michal.michalik@intel.com>,\n Przemek Kitszel <przemyslaw.kitszel@intel.com>, linux-kernel@vger.kernel.org,\n Eric Dumazet <edumazet@google.com>,\n Arkadiusz Kubalewski <arkadiusz.kubalewski@intel.com>,\n Andrew Lunn <andrew+netdev@lunn.ch>,\n Tony Nguyen <anthony.l.nguyen@intel.com>,\n intel-wired-lan@lists.osuosl.org, Jakub Kicinski <kuba@kernel.org>,\n Paolo Abeni <pabeni@redhat.com>, \"David S. Miller\" <davem@davemloft.net>,\n Milena Olech <milena.olech@intel.com>", "Errors-To": "intel-wired-lan-bounces@osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@osuosl.org>" }, "content": "When setting a U.FL pin to disconnected state, ice_dpll_ufl_pin_state_set()\nblindly modifies SMA control register bits and disables the shared\nunderlying output/input pin without checking whether the U.FL pin is\ncurrently active.\n\nSMA1 and U.FL1 share the same physical output pin, controlled by\nICE_SMA1_DIR_EN and ICE_SMA1_TX_EN bits. When SMA1 is in output mode\n(DIR_EN=1, TX_EN=0), U.FL1 is already inactive. Disconnecting U.FL1\nsets TX_EN=1, which combined with DIR_EN=1 causes\nice_dpll_sw_pins_update() to mark SMA1 as inactive too. The subsequent\nice_dpll_pin_disable() then disables the shared output pin entirely,\nbreaking SMA1's connection.\n\nFix by checking whether U.FL1/U.FL2 is already inactive before\nproceeding with the disconnect. If the pin is not currently controlling\nthe shared output/input, return success immediately without modifying\nthe SMA control register or disabling the underlying pin.\n\nFixes: d7999f5ea64b (\"ice: implement dpll interface to control cgu\")\nSigned-off-by: Petr Oros <poros@redhat.com>\n---\n drivers/net/ethernet/intel/ice/ice_dpll.c | 17 +++++++++++++++++\n 1 file changed, 17 insertions(+)", "diff": "diff --git a/drivers/net/ethernet/intel/ice/ice_dpll.c b/drivers/net/ethernet/intel/ice/ice_dpll.c\nindex 5cfa19da099bfc..76c68f54a1cc97 100644\n--- a/drivers/net/ethernet/intel/ice/ice_dpll.c\n+++ b/drivers/net/ethernet/intel/ice/ice_dpll.c\n@@ -1253,6 +1253,14 @@ ice_dpll_ufl_pin_state_set(const struct dpll_pin *pin, void *pin_priv,\n \t\t\tdata &= ~ICE_SMA1_MASK;\n \t\t\tenable = true;\n \t\t} else if (state == DPLL_PIN_STATE_DISCONNECTED) {\n+\t\t\t/* Skip if U.FL1 is not active, setting TX_EN\n+\t\t\t * while DIR_EN is set would also deactivate\n+\t\t\t * the paired SMA1 output.\n+\t\t\t */\n+\t\t\tif (data & (ICE_SMA1_DIR_EN | ICE_SMA1_TX_EN)) {\n+\t\t\t\tret = 0;\n+\t\t\t\tgoto unlock;\n+\t\t\t}\n \t\t\tdata |= ICE_SMA1_TX_EN;\n \t\t\tenable = false;\n \t\t} else {\n@@ -1267,6 +1275,15 @@ ice_dpll_ufl_pin_state_set(const struct dpll_pin *pin, void *pin_priv,\n \t\t\tdata &= ~ICE_SMA2_UFL2_RX_DIS;\n \t\t\tenable = true;\n \t\t} else if (state == DPLL_PIN_STATE_DISCONNECTED) {\n+\t\t\t/* Skip if U.FL2 is not active, setting\n+\t\t\t * UFL2_RX_DIS could also disable the paired\n+\t\t\t * SMA2 input.\n+\t\t\t */\n+\t\t\tif (!(data & ICE_SMA2_DIR_EN) ||\n+\t\t\t (data & ICE_SMA2_UFL2_RX_DIS)) {\n+\t\t\t\tret = 0;\n+\t\t\t\tgoto unlock;\n+\t\t\t}\n \t\t\tdata |= ICE_SMA2_UFL2_RX_DIS;\n \t\t\tenable = false;\n \t\t} else {\n", "prefixes": [ "iwl-net" ] }