Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/2215843/?format=api
{ "id": 2215843, "url": "http://patchwork.ozlabs.org/api/patches/2215843/?format=api", "web_url": "http://patchwork.ozlabs.org/project/uboot/patch/5b39b321-e318-4112-9edd-78ae6562301b@ew.tq-group.com/", "project": { "id": 18, "url": "http://patchwork.ozlabs.org/api/projects/18/?format=api", "name": "U-Boot", "link_name": "uboot", "list_id": "u-boot.lists.denx.de", "list_email": "u-boot@lists.denx.de", "web_url": null, "scm_url": null, "webscm_url": null, "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<5b39b321-e318-4112-9edd-78ae6562301b@ew.tq-group.com>", "list_archive_url": null, "date": "2026-03-25T13:20:34", "name": "[v2,2/8] board/tq: Add common SoM API", "commit_ref": null, "pull_url": null, "state": "not-applicable", "archived": false, "hash": "c372f01ac6baac578cd6cf73629f1fa9e5a01966", "submitter": { "id": 92142, "url": "http://patchwork.ozlabs.org/api/people/92142/?format=api", "name": "Alexander Feilke", "email": "Alexander.Feilke@ew.tq-group.com" }, "delegate": { "id": 151988, "url": "http://patchwork.ozlabs.org/api/users/151988/?format=api", "username": "festevam", "first_name": "Fabio", "last_name": "Estevam", "email": "festevam@gmail.com" }, "mbox": "http://patchwork.ozlabs.org/project/uboot/patch/5b39b321-e318-4112-9edd-78ae6562301b@ew.tq-group.com/mbox/", "series": [ { "id": 497440, "url": "http://patchwork.ozlabs.org/api/series/497440/?format=api", "web_url": "http://patchwork.ozlabs.org/project/uboot/list/?series=497440", "date": "2026-03-25T13:20:34", "name": null, "version": 2, "mbox": "http://patchwork.ozlabs.org/series/497440/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2215843/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2215843/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<u-boot-bounces@lists.denx.de>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n unprotected) header.d=ew.tq-group.com header.i=@ew.tq-group.com\n header.a=rsa-sha256 header.s=default2602 header.b=n0N8XTVM;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de\n (client-ip=2a01:238:438b:c500:173d:9f52:ddab:ee01; helo=phobos.denx.de;\n envelope-from=u-boot-bounces@lists.denx.de; receiver=patchwork.ozlabs.org)", "phobos.denx.de;\n dmarc=fail (p=quarantine dis=none) header.from=ew.tq-group.com", "phobos.denx.de;\n spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de", "phobos.denx.de;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n unprotected) header.d=ew.tq-group.com header.i=@ew.tq-group.com\n header.b=\"n0N8XTVM\";\n\tdkim-atps=neutral", "phobos.denx.de; dmarc=pass (p=quarantine dis=none)\n header.from=ew.tq-group.com", "phobos.denx.de; spf=pass\n smtp.mailfrom=alexander.feilke@ew.tq-group.com" ], "Received": [ "from phobos.denx.de (phobos.denx.de\n [IPv6:2a01:238:438b:c500:173d:9f52:ddab:ee01])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fgnbM4z2Bz1xy1\n\tfor <incoming@patchwork.ozlabs.org>; Thu, 26 Mar 2026 00:20:47 +1100 (AEDT)", "from h2850616.stratoserver.net (localhost [IPv6:::1])\n\tby phobos.denx.de (Postfix) with ESMTP id C4BF883AAB;\n\tWed, 25 Mar 2026 14:20:44 +0100 (CET)", "by phobos.denx.de (Postfix, from userid 109)\n id E217E83CD3; Wed, 25 Mar 2026 14:20:43 +0100 (CET)", "from www537.your-server.de (www537.your-server.de [188.40.3.216])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits))\n (No client certificate requested)\n by phobos.denx.de (Postfix) with ESMTPS id 05A1B81E18\n for <u-boot@lists.denx.de>; Wed, 25 Mar 2026 14:20:42 +0100 (CET)", "from sslproxy06.your-server.de ([78.46.172.3])\n by www537.your-server.de with esmtpsa (TLS1.3) tls TLS_AES_256_GCM_SHA384\n (Exim 4.96.2) (envelope-from <alexander.feilke@ew.tq-group.com>)\n id 1w5OA0-000HEX-01; Wed, 25 Mar 2026 14:20:36 +0100", "from localhost ([127.0.0.1])\n by sslproxy06.your-server.de with esmtpsa (TLS1.3) tls TLS_AES_256_GCM_SHA384\n (Exim 4.96) (envelope-from <alexander.feilke@ew.tq-group.com>)\n id 1w5O9S-000BxT-15; Wed, 25 Mar 2026 14:20:35 +0100" ], "X-Spam-Checker-Version": "SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de", "X-Spam-Level": "", "X-Spam-Status": "No, score=-2.0 required=5.0 tests=BAYES_00,DKIM_SIGNED,\n DKIM_VALID,DKIM_VALID_AU,RCVD_IN_DNSWL_BLOCKED,\n RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED,\n SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.2", "DKIM-Signature": "v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;\n d=ew.tq-group.com; s=default2602; h=Content-Transfer-Encoding:Content-Type:\n In-Reply-To:From:References:Cc:To:Subject:MIME-Version:Date:Message-ID:Sender\n :Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From:\n Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID;\n bh=DD424kgKA7DPfyHp8B2ld30/Mq3EbqFBdjqU01+avJU=; b=n0N8XTVMiFvmX/W5IFJmjuzIBz\n tihklz2wLSudHxq7pCXpLrbsNL2WELuDJn6p30M745v6DT1WGCEbAxcX1cS1SU1p1XLzaqf1hqQM3\n au5/yzCCoSwrN1LVyXjZytTzQgKO3X+2G3AsYsT8LoSjo1460Cm/hDZ7bvALrkmO/BySrB0VyLcD1\n hegnKULOfOLIcJgJ0LKuxmKE+D/FuQa16YyU9m4AQrZibKwd8ZOhbRXVQEMtb/SmAcvNZeNt3ET+S\n ckQ6zpIDSVJ5k2pZ+QuTXVJQKHa/REoI+rSdsxTqewQIroJVXVEoAvvduXLn/wkQVhwOrXydFvmJ3\n wFEhWByQ==;", "Message-ID": "<5b39b321-e318-4112-9edd-78ae6562301b@ew.tq-group.com>", "Date": "Wed, 25 Mar 2026 14:20:34 +0100", "MIME-Version": "1.0", "User-Agent": "Mozilla Thunderbird", "Subject": "[PATCH v2 2/8] board/tq: Add common SoM API", "To": "Peng Fan <peng.fan@oss.nxp.com>", "Cc": "\"NXP i.MX U-Boot Team\" <uboot-imx@nxp.com>, u-boot@lists.denx.de,\n u-boot@ew.tq-group.com, Tom Rini <trini@konsulko.com>,\n Stefano Babic <sbabic@nabladev.com>, Fabio Estevam <festevam@gmail.com>,\n Peng Fan <peng.fan@nxp.com>, Jaehoon Chung <jh80.chung@samsung.com>,\n Max Merchel <Max.Merchel@ew.tq-group.com>", "References": "<20260325095801.47706-1-Alexander.Feilke@ew.tq-group.com>\n <20260325095801.47706-3-Alexander.Feilke@ew.tq-group.com>\n <acPGEGc16f3xwasm@shlinux89>", "From": "\"Feilke, Alexander\" <alexander.feilke@ew.tq-group.com>", "In-Reply-To": "<acPGEGc16f3xwasm@shlinux89>", "Content-Type": "text/plain; charset=UTF-8; format=flowed", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "u-boot@lists.denx.de", "X-Mailman-Version": "2.1.39", "Precedence": "list", "List-Id": "U-Boot discussion <u-boot.lists.denx.de>", "List-Unsubscribe": "<https://lists.denx.de/options/u-boot>,\n <mailto:u-boot-request@lists.denx.de?subject=unsubscribe>", "List-Archive": "<https://lists.denx.de/pipermail/u-boot/>", "List-Post": "<mailto:u-boot@lists.denx.de>", "List-Help": "<mailto:u-boot-request@lists.denx.de?subject=help>", "List-Subscribe": "<https://lists.denx.de/listinfo/u-boot>,\n <mailto:u-boot-request@lists.denx.de?subject=subscribe>", "Errors-To": "u-boot-bounces@lists.denx.de", "Sender": "\"U-Boot\" <u-boot-bounces@lists.denx.de>", "X-Virus-Scanned": "clamav-milter 0.103.8 at phobos.denx.de", "X-Virus-Status": "Clean" }, "content": "On 25.03.2026 at 12:25 Peng Fan wrote:\n> On Wed, Mar 25, 2026 at 10:57:55AM +0100, Alexander Feilke wrote:\n>> From: Alexander Feilke <alexander.feilke@ew.tq-group.com>\n>>\n>> Reduce code duplication by adding a default implementation.\n>>\n>> Signed-off-by: Alexander Feilke <alexander.feilke@ew.tq-group.com>\n>> Signed-off-by: Max Merchel <Max.Merchel@ew.tq-group.com>\n>> ---\n>> +static inline void tq_som_check_bits_set(u32 address, u32 mask)\n>> +{\n>> +\twhile ((readl(address) & mask) != mask)\n>> +\t\t;\n> You may need to use readl_poll_timeout API.\n>\n> Regards\n> Peng\n\nThanks for the suggestion. I successfully tested the patch below with \nall our RAM variants.\nYou may apply it directly or I can send a v3 if you prefer that.\n\n---", "diff": "diff --git a/board/tq/common/tq_som.h b/board/tq/common/tq_som.h\nindex d7168eb7e46..0ab01d51f99 100644\n--- a/board/tq/common/tq_som.h\n+++ b/board/tq/common/tq_som.h\n@@ -10,6 +10,7 @@\n\n #include <init.h>\n #include <asm/io.h>\n+#include <linux/iopoll.h>\n\n void tq_som_ram_init(void);\n\n@@ -27,8 +28,8 @@ bool tq_som_ram_check_size(long ram_size);\n\n static inline void tq_som_check_bits_set(u32 address, u32 mask)\n {\n- while ((readl(address) & mask) != mask)\n- ;\n+ u32 val;\n+ readl_poll_timeout(address, val, (val & mask) == mask, 1000);\n }\n\n #endif /* __TQ_SOM_H */\n", "prefixes": [ "v2", "2/8" ] }